4362 2005-08-09 13:13:04 -0700 Add mac-cyrillic to the list of encodings 2005-12-14 11:02:14 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 VERIFIED FIXED http://www.sbrf.ru/ P2 Normal --- 1 ap adele oldest_to_newest 16302 0 ap 2005-08-09 13:13:04 -0700 This site (one of the largest banks in Russia) sends charset=mac-cyrillic instead of x-mac-cyrillic. Safari doesn't support such an alias. I have tried adding an alias to WebCore/kwq/mac-encodings.txt, but for whatever reason, this makes the build fail: MacCyrillic: x-mac-cyrillic, mac-cyrillic, xmacukrainian /bin/sh -c /Users/ap/WebKit/WebKitBuild/WebCore.build/Deployment/WebCore.build/Script-932FC0D20824A2C4005B3C75.sh mac-cyrillic, in mac-encodings.txt, has illegal characters in it (must be all lowercase alphanumeric) Also, xmacukrainian (and x-mac-ukrainian) look like aliases to MacUkrainian, not MacCyrillic. 21091 1 ap 2005-10-01 13:39:14 -0700 The make-charset-table issue may have been obsoleted by switching to ICU (I'm not really sure, though). I have filed a request to add mac-cyrillic as an ICU Jitterbug 4859 (<http://dev.icu-project.org/cgi-bin/ icu-bugs>). 25926 2 darin 2005-12-13 19:33:32 -0800 All you have to do is add "maccyrillic" without the hyphen. Non-alphanumeric characters are ignored when doing the table match and only the first item in each table is allowed to contain them (because it's used in reverse-mapping an encoding to its name). So fixing this bug is as simple as adding that element to the table. 25934 3 5072 ap 2005-12-13 22:14:55 -0800 Created attachment 5072 proposed patch Thank you, I didn't grasp the difference between the first and subsequent elements :) I'm left wondering about rdar://3327157 (x-mac-ukrainian should be mapped to MacCyrillic) - could it be a workaround for some problem that no longer exists? 25935 4 ap 2005-12-13 22:28:23 -0800 A layout test is probably not necessary here (there are no tests for the presence of charset aliases) - correct me if I'm wrong. 25957 5 5072 darin 2005-12-14 09:41:30 -0800 Comment on attachment 5072 proposed patch r=me 25964 6 adele 2005-12-14 10:18:03 -0800 I've committed this. 5072 2005-12-13 22:14:55 -0800 2005-12-14 09:41:30 -0800 proposed patch MacEncodingsPatch.txt text/plain 616 ap SW5kZXg6IG1hYy1lbmNvZGluZ3MudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJDb3JlL2t3cS9tYWMtZW5jb2RpbmdzLnR4dCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNApk aWZmIC1wIC11IC1yMS4yNCBtYWMtZW5jb2RpbmdzLnR4dAotLS0gbWFjLWVuY29kaW5ncy50eHQJ MjMgU2VwIDIwMDMgMDQ6MDM6MTYgLTAwMDAJMS4yNAorKysgbWFjLWVuY29kaW5ncy50eHQJMTQg RGVjIDIwMDUgMDY6MTc6MjkgLTAwMDAKQEAgLTIwLDcgKzIwLDcgQEAgTWFjS29yZWFuOiB4LW1h Yy1rb3JlYW4KIE1hY0FyYWJpYzogeC1tYWMtYXJhYmljCiBNYWNIZWJyZXc6IHgtbWFjLWhlYnJl dwogTWFjR3JlZWs6IHgtbWFjLWdyZWVrCi1NYWNDeXJpbGxpYzogeC1tYWMtY3lyaWxsaWMsIHht YWN1a3JhaW5pYW4KK01hY0N5cmlsbGljOiB4LW1hYy1jeXJpbGxpYywgbWFjY3lyaWxsaWMsIHht YWN1a3JhaW5pYW4KIE1hY0RldmFuYWdhcmk6IHgtbWFjLWRldmFuYWdhcmkKIE1hY0d1cm11a2hp OiB4LW1hYy1ndXJtdWtoaQogTWFjR3VqYXJhdGk6IHgtbWFjLWd1amFyYXRpCg==