43619 2010-08-06 05:57:15 -0700 Bitmap.h has no default constructor 2010-12-02 12:47:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 41177 1 zherczeg webkit-unassigned abecsi ademar ossy yael oldest_to_newest 261209 0 zherczeg 2010-08-06 05:57:15 -0700 The bitmap array is not cleared, and contains a memory garbage after init. 261235 1 63718 zherczeg 2010-08-06 07:11:43 -0700 Created attachment 63718 patch 261347 2 63718 ggaren 2010-08-06 10:45:37 -0700 Comment on attachment 63718 patch Nice catch. JavaScriptCore/wtf/Bitmap.h:35 + Bitmap(bool initializationNeeded = true); WebKit is moving toward a policy of considering boolean arguments to functions to be a bad design pattern. I think we may eventually discourage or forbid them in our coding style guidelines. The problem with this kind of argument is that it's very hard to tell, at the callsite, exactly what "true" or "false" might mean. I think you should just remove the boolean argument here. If we do want to take advantage of an optimized "no initialization" bitmap in the future, let's add an extra constructor akin to the AdoptCFTag constructor for RetainPtr, or the VPtrStealingHackType constructor for JSString. Otherwise, this patch is great! 261384 3 63748 zherczeg 2010-08-06 12:04:47 -0700 Created attachment 63748 patch v2 261419 4 63748 eric 2010-08-06 13:31:05 -0700 Comment on attachment 63748 patch v2 LGTM. 261731 5 zherczeg 2010-08-07 10:37:35 -0700 Landed in http://trac.webkit.org/changeset/64912 Closing bug. 316332 6 yael 2010-12-02 12:21:45 -0800 This is the fix I was about to suggest for https://qtrequirements.europe.nokia.com/browse/BR-4872, just to find that it was already fixed. :-( 316358 7 ademar 2010-12-02 12:47:18 -0800 Revision r64912 cherry-picked into qtwebkit-2.1 with commit 67daffa <http://gitorious.org/webkit/qtwebkit/commit/67daffa> 63718 2010-08-06 07:11:43 -0700 2010-08-06 12:04:47 -0700 patch 0001-bitmap.patch text/plain 1992 zherczeg RnJvbSAzNGIyOWJiOTRlYTk4ZTE2MzdhYmNkOTZlMWRiYTMyOGE5MDU3ZTA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDYgQXVnIDIwMTAgMTY6MDk6NTkgKzAyMDAKU3ViamVjdDogW1BBVENI XSBiaXRtYXAKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3plZ0BpbmYudS1z emVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgIHwgICAxNiArKysrKysr KysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS93dGYvQml0bWFwLmggfCAgIDEyICsrKysrKysrKysr KwogMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwppbmRleCAyZGZmMGFkLi4yM2JkMjgzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAK IDIwMTAtMDgtMDYgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCaXRtYXAuaCBoYXMg bm8gZGVmYXVsdCBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDM2MTkKKworICAgICAgICBXaXRob3V0IGEgY29uc3RydWN0b3IsIHRo ZSBpbml0aWFsIGJpdHMgb2YgdGhlIEJpdG1hcCBjbGFzcworICAgICAgICBhcmUgdW5kZWZpbmll ZC4gSWYgb25seSBhIGZldywgb3IgemVybyBiaXRzIGFyZSAwLCB0aGUgbWVtb3J5CisgICAgICAg IGFyZWEgcHJvdmlkZWQgYnkgQWxpZ25lZE1lbW9yeUFsbG9jYXRvciBjYW4gYmUgZWFzbHkgZXho YXVzdGVkLgorCisgICAgICAgIENzYWJhIE9zenRyb2dvbsOhYyBoZWxwZWQgdG8gZmluZCB0aGlz IGJ1Zy4KKworICAgICAgICAqIHd0Zi9CaXRtYXAuaDoKKyAgICAgICAgKFdURjo6OjpCaXRtYXAp OgorCisyMDEwLTA4LTA2ICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCiAKICAgICAgICAgUmVmYWN0b3IgaWRl bnRpZmllciBwYXJzaW5nIGluIGxleGVyCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYv Qml0bWFwLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvQml0bWFwLmgKaW5kZXggYjlhNWNkNi4uMzBi N2UzYiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL0JpdG1hcC5oCisrKyBiL0phdmFT Y3JpcHRDb3JlL3d0Zi9CaXRtYXAuaApAQCAtMzIsNiArMzIsOCBAQCBwcml2YXRlOgogICAgIHR5 cGVkZWYgdWludDMyX3QgV29yZFR5cGU7CiAKIHB1YmxpYzoKKyAgICBCaXRtYXAoYm9vbCBpbml0 aWFsaXphdGlvbk5lZWRlZCA9IHRydWUpOworCiAgICAgYm9vbCBnZXQoc2l6ZV90KSBjb25zdDsK ICAgICB2b2lkIHNldChzaXplX3QpOwogICAgIHZvaWQgY2xlYXIoc2l6ZV90KTsKQEAgLTU1LDYg KzU3LDE2IEBAIHByaXZhdGU6CiAgICAgRml4ZWRBcnJheTxXb3JkVHlwZSwgd29yZHM+IGJpdHM7 CiB9OwogCisKK3RlbXBsYXRlPHNpemVfdCBzaXplPgoraW5saW5lIEJpdG1hcDxzaXplPjo6Qml0 bWFwKGJvb2wgaW5pdGlhbGl6YXRpb25OZWVkZWQpCit7CisgICAgLy8gQ2FsbHMgY2xlYXJBbGwo KSBieSBkZWZhdWx0LCBidXQgaXQgY2FuIGJlIGRpc2FibGVkCisgICAgLy8gaWYgaXQgZ2l2ZXMg YSBwZXJmb3JtYW5jZSBhZHZhbnRhZ2UuCisgICAgaWYgKGluaXRpYWxpemF0aW9uTmVlZGVkKQor ICAgICAgICBjbGVhckFsbCgpOworfQorCiB0ZW1wbGF0ZTxzaXplX3Qgc2l6ZT4KIGlubGluZSBi b29sIEJpdG1hcDxzaXplPjo6Z2V0KHNpemVfdCBuKSBjb25zdAogewotLSAKMS42LjAuNAoK 63748 2010-08-06 12:04:47 -0700 2010-08-06 13:31:05 -0700 patch v2 0001-bitmap.patch text/plain 1792 zherczeg RnJvbSA5MTJiNzcxMTUxNjE0ZGExYWMwNzliZmM5N2E4MGEyNDIzYjc3ZDA5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDYgQXVnIDIwMTAgMjE6MDE6NDUgKzAyMDAKU3ViamVjdDogW1BBVENI XSBiaXRtYXAKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3plZ0BpbmYudS1z emVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgIHwgICAxNiArKysrKysr KysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS93dGYvQml0bWFwLmggfCAgICA5ICsrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwppbmRleCAyZGZmMGFkLi4yM2JkMjgzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIw MTAtMDgtMDYgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KIAorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCaXRtYXAuaCBoYXMgbm8g ZGVmYXVsdCBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDM2MTkKKworICAgICAgICBXaXRob3V0IGEgY29uc3RydWN0b3IsIHRoZSBp bml0aWFsIGJpdHMgb2YgdGhlIEJpdG1hcCBjbGFzcworICAgICAgICBhcmUgdW5kZWZpbmllZC4g SWYgb25seSBhIGZldywgb3IgemVybyBiaXRzIGFyZSAwLCB0aGUgbWVtb3J5CisgICAgICAgIGFy ZWEgcHJvdmlkZWQgYnkgQWxpZ25lZE1lbW9yeUFsbG9jYXRvciBjYW4gYmUgZWFzbHkgZXhoYXVz dGVkLgorCisgICAgICAgIENzYWJhIE9zenRyb2dvbsOhYyBoZWxwZWQgdG8gZmluZCB0aGlzIGJ1 Zy4KKworICAgICAgICAqIHd0Zi9CaXRtYXAuaDoKKyAgICAgICAgKFdURjo6OjpCaXRtYXApOgor CisyMDEwLTA4LTA2ICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCiAKICAgICAgICAgUmVmYWN0b3IgaWRlbnRp ZmllciBwYXJzaW5nIGluIGxleGVyCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvQml0 bWFwLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvQml0bWFwLmgKaW5kZXggYjlhNWNkNi4uYjMzYzRl NSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL0JpdG1hcC5oCisrKyBiL0phdmFTY3Jp cHRDb3JlL3d0Zi9CaXRtYXAuaApAQCAtMzIsNiArMzIsOCBAQCBwcml2YXRlOgogICAgIHR5cGVk ZWYgdWludDMyX3QgV29yZFR5cGU7CiAKIHB1YmxpYzoKKyAgICBCaXRtYXAoKTsKKwogICAgIGJv b2wgZ2V0KHNpemVfdCkgY29uc3Q7CiAgICAgdm9pZCBzZXQoc2l6ZV90KTsKICAgICB2b2lkIGNs ZWFyKHNpemVfdCk7CkBAIC01NSw2ICs1NywxMyBAQCBwcml2YXRlOgogICAgIEZpeGVkQXJyYXk8 V29yZFR5cGUsIHdvcmRzPiBiaXRzOwogfTsKIAorCit0ZW1wbGF0ZTxzaXplX3Qgc2l6ZT4KK2lu bGluZSBCaXRtYXA8c2l6ZT46OkJpdG1hcCgpCit7CisgICAgY2xlYXJBbGwoKTsKK30KKwogdGVt cGxhdGU8c2l6ZV90IHNpemU+CiBpbmxpbmUgYm9vbCBCaXRtYXA8c2l6ZT46OmdldChzaXplX3Qg bikgY29uc3QKIHsKLS0gCjEuNi4wLjQKCg==