43611 2010-08-06 00:10:40 -0700 noembed should respect whether plugins are enabled 2010-08-06 11:01:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 261132 0 abarth 2010-08-06 00:10:40 -0700 noembed should respect whether plugins are enabled 261134 1 63702 abarth 2010-08-06 00:12:43 -0700 Created attachment 63702 Patch 261339 2 63702 eric 2010-08-06 10:36:20 -0700 Comment on attachment 63702 Patch WebCore/html/HTMLTreeBuilder.h:195 + static bool scriptEnabled(Frame* frame); No need for the argument name. Please file a bug with the HTML5 spec. 261342 3 eric 2010-08-06 10:36:45 -0700 Oh, it's possible to test this via DRT. With layoutTestController.overridePreference() 261343 4 63702 eric 2010-08-06 10:37:04 -0700 Comment on attachment 63702 Patch This should have a layout test. :) 261352 5 63702 commit-queue 2010-08-06 10:58:34 -0700 Comment on attachment 63702 Patch Clearing flags on attachment: 63702 Committed r64858: <http://trac.webkit.org/changeset/64858> 261353 6 commit-queue 2010-08-06 10:58:39 -0700 All reviewed patches have been landed. Closing bug. 261356 7 eric 2010-08-06 11:01:51 -0700 Sigh. This is an age-old bug: https://bugs.webkit.org/show_bug.cgi?id=32679 63702 2010-08-06 00:12:43 -0700 2010-08-06 10:58:34 -0700 Patch bug-43611-20100806001242.patch text/plain 4097 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2I5ZWY2ZmY2YzE4YTc4NzU5ZjA3NzRjOTcyYmJmZDYxYTJkYjRkZC4uMDVlM2E2NmM4YTE2MTVj ZmMwOTc3YmI0ZDIyODEzYmM4MzkyYjI4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wOC0wNiAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIG5vZW1iZWQgc2hvdWxkIHJlc3BlY3Qgd2hldGhlciBwbHVn aW5zIGFyZSBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MzYxMQorCisgICAgICAgIFRoaXMgaW5zdHJ1Y3Rpb24gaXNuJ3QgaW4gdGhlIEhU TUw1IHNwZWMsIGJ1dCBpdCBzZWVtcyBsaWtlIHRoZSByaWdodAorICAgICAgICB0aGluZyB0byBk by4gIEkgc3VzcGVjdCB0aGlzIGlzIGJlY2F1c2UgdGhlIHNwZWMgZG9lc24ndCB1bmRlcnN0YW5k CisgICAgICAgIHRoYXQgcGx1Z2lucyBjYW4gYmUgZGlzYWJsZWQuCisKKyAgICAgICAgSSdtIG5v dCBzdXJlIGhvdyB3ZSBjYW4gdGVzdCB0aGlzIGluIER1bXBSZW5kZXJUcmVlLCBidXQgSSdtIG9w ZW4gdG8KKyAgICAgICAgc3VnZ2VzdGlvbnMuCisKKyAgICAgICAgKiBodG1sL0hUTUxUcmVlQnVp bGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OmFkanVzdGVkTGV4 ZXJTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFy dFRhZ0ZvckluQm9keSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nl c3NTdGFydFRhZ0ZvckluSGVhZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6 OnNjcmlwdEVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpwbHVn aW5zRW5hYmxlZCk6CisgICAgICAgICogaHRtbC9IVE1MVHJlZUJ1aWxkZXIuaDoKKwogMjAxMC0w OC0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVp bGRlci5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcAppbmRleCA2MjM1Yzg4 YTdmMzVhNjkwM2U4Yzc2ZmU1ZjU4OGZiZWUwMjZiZWZiLi44M2Y0OWZlMTgyOTc2MzgxYmRkOWE3 OTMwMTI1ZmEyNDNkMjQ1OGE4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWls ZGVyLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcApAQCAtNDI4LDkg KzQyOCw5IEBAIEhUTUxUb2tlbml6ZXI6OlN0YXRlIEhUTUxUcmVlQnVpbGRlcjo6YWRqdXN0ZWRM ZXhlclN0YXRlKEhUTUxUb2tlbml6ZXI6OlN0YXRlIHN0CiAgICAgaWYgKHRhZ05hbWUgPT0gc3R5 bGVUYWcKICAgICAgICAgfHwgdGFnTmFtZSA9PSBpZnJhbWVUYWcKICAgICAgICAgfHwgdGFnTmFt ZSA9PSB4bXBUYWcKLSAgICAgICAgfHwgdGFnTmFtZSA9PSBub2VtYmVkVGFnCisgICAgICAgIHx8 ICh0YWdOYW1lID09IG5vZW1iZWRUYWcgJiYgcGx1Z2luc0VuYWJsZWQoZnJhbWUpKQogICAgICAg ICB8fCB0YWdOYW1lID09IG5vZnJhbWVzVGFnCi0gICAgICAgIHx8ICh0YWdOYW1lID09IG5vc2Ny aXB0VGFnICYmIGlzU2NyaXB0aW5nRmxhZ0VuYWJsZWQoZnJhbWUpKSkKKyAgICAgICAgfHwgKHRh Z05hbWUgPT0gbm9zY3JpcHRUYWcgJiYgc2NyaXB0RW5hYmxlZChmcmFtZSkpKQogICAgICAgICBy ZXR1cm4gSFRNTFRva2VuaXplcjo6UkFXVEVYVFN0YXRlOwogCiAgICAgaWYgKHRhZ05hbWUgPT0g cGxhaW50ZXh0VGFnKQpAQCAtOTkyLDExICs5OTIsMTEgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6 OnByb2Nlc3NTdGFydFRhZ0ZvckluQm9keShBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogICAgICAg ICBwcm9jZXNzR2VuZXJpY1Jhd1RleHRTdGFydFRhZyh0b2tlbik7CiAgICAgICAgIHJldHVybjsK ICAgICB9Ci0gICAgaWYgKHRva2VuLm5hbWUoKSA9PSBub2VtYmVkVGFnKSB7CisgICAgaWYgKHRv a2VuLm5hbWUoKSA9PSBub2VtYmVkVGFnICYmIHBsdWdpbnNFbmFibGVkKG1fZG9jdW1lbnQtPmZy YW1lKCkpKSB7CiAgICAgICAgIHByb2Nlc3NHZW5lcmljUmF3VGV4dFN0YXJ0VGFnKHRva2VuKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICBpZiAodG9rZW4ubmFtZSgpID09IG5vc2NyaXB0 VGFnICYmIGlzU2NyaXB0aW5nRmxhZ0VuYWJsZWQobV9kb2N1bWVudC0+ZnJhbWUoKSkpIHsKKyAg ICBpZiAodG9rZW4ubmFtZSgpID09IG5vc2NyaXB0VGFnICYmIHNjcmlwdEVuYWJsZWQobV9kb2N1 bWVudC0+ZnJhbWUoKSkpIHsKICAgICAgICAgcHJvY2Vzc0dlbmVyaWNSYXdUZXh0U3RhcnRUYWco dG9rZW4pOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtMjc3Miw3ICsyNzcyLDcgQEAgYm9v bCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZ0ZvckluSGVhZChBdG9taWNIVE1MVG9r ZW4mIHRva2VuKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAgICAgaWYgKHRva2VuLm5h bWUoKSA9PSBub3NjcmlwdFRhZykgewotICAgICAgICBpZiAoaXNTY3JpcHRpbmdGbGFnRW5hYmxl ZChtX2RvY3VtZW50LT5mcmFtZSgpKSkgeworICAgICAgICBpZiAoc2NyaXB0RW5hYmxlZChtX2Rv Y3VtZW50LT5mcmFtZSgpKSkgewogICAgICAgICAgICAgcHJvY2Vzc0dlbmVyaWNSYXdUZXh0U3Rh cnRUYWcodG9rZW4pOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0KQEAgLTI4 MzcsNyArMjgzNyw3IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpmaW5pc2hlZCgpCiAgICAgICAg IG1fZG9jdW1lbnQtPmZpbmlzaGVkUGFyc2luZygpOwogfQogCi1ib29sIEhUTUxUcmVlQnVpbGRl cjo6aXNTY3JpcHRpbmdGbGFnRW5hYmxlZChGcmFtZSogZnJhbWUpCitib29sIEhUTUxUcmVlQnVp bGRlcjo6c2NyaXB0RW5hYmxlZChGcmFtZSogZnJhbWUpCiB7CiAgICAgaWYgKCFmcmFtZSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMjg0Niw0ICsyODQ2LDExIEBAIGJvb2wgSFRNTFRyZWVC dWlsZGVyOjppc1NjcmlwdGluZ0ZsYWdFbmFibGVkKEZyYW1lKiBmcmFtZSkKICAgICByZXR1cm4g ZmFsc2U7CiB9CiAKK2Jvb2wgSFRNTFRyZWVCdWlsZGVyOjpwbHVnaW5zRW5hYmxlZChGcmFtZSog ZnJhbWUpCit7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJl dHVybiBmcmFtZS0+bG9hZGVyKCktPnN1YmZyYW1lTG9hZGVyKCktPmFsbG93UGx1Z2lucyhOb3RB Ym91dFRvSW5zdGFudGlhdGVQbHVnaW4pOworfQorCiB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0 bWwvSFRNTFRyZWVCdWlsZGVyLmggYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmgKaW5k ZXggZDcyMzM4NDQ2OWEwNmQyMzA3MzcwZmM0NWRjNjNkODJkNGFlN2I1OS4uZTMxZDA5YjY2ZWYz YjdjMTVlN2MwM2YwZWY4OWE0YjRiMWYzMDc2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hU TUxUcmVlQnVpbGRlci5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuaApAQCAt MTkyLDcgKzE5Miw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCBzZXRJbnNlcnRpb25Nb2RlQW5kRW5k KEluc2VydGlvbk1vZGUsIGJvb2wgZm9yZWlnbik7IC8vIEhlbHBlciBmb3IgcmVzZXRJbnNlcnRp b25Nb2RlQXBwcm9wcmlhdGVseQogICAgIHZvaWQgcmVzZXRJbnNlcnRpb25Nb2RlQXBwcm9wcmlh dGVseSgpOwogCi0gICAgc3RhdGljIGJvb2wgaXNTY3JpcHRpbmdGbGFnRW5hYmxlZChGcmFtZSog ZnJhbWUpOworICAgIHN0YXRpYyBib29sIHNjcmlwdEVuYWJsZWQoRnJhbWUqIGZyYW1lKTsKKyAg ICBzdGF0aWMgYm9vbCBwbHVnaW5zRW5hYmxlZChGcmFtZSogZnJhbWUpOwogCiAgICAgRG9jdW1l bnQqIG1fZG9jdW1lbnQ7CiAgICAgSFRNTENvbnN0cnVjdGlvblNpdGUgbV90cmVlOwo=