43606 2010-08-05 21:00:45 -0700 dump-as-markup should work in Firefox 2010-08-06 20:30:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric ojan oldest_to_newest 261069 0 abarth 2010-08-05 21:00:45 -0700 dump-as-markup should work in Firefox 261070 1 63687 abarth 2010-08-05 21:01:41 -0700 Created attachment 63687 Patch 261412 2 eric 2010-08-06 13:17:43 -0700 Seems ojan is your man here. 261417 3 63687 ojan 2010-08-06 13:22:17 -0700 Comment on attachment 63687 Patch > +++ b/LayoutTests/ChangeLog > + Apparently Firefox lacks this API. I think something else is going wrong here. document.body.ownerDocument.defaultView.getSelection() returns a selection object in Firefox. Does this fail for all dump-as-markup tests? Does it throw an exception? 261471 4 abarth 2010-08-06 14:34:32 -0700 I ran into the problem trying to run runner.html in Firefox. That dumps all kinds of crazy DOMs. 261586 5 63687 ojan 2010-08-06 17:18:08 -0700 Comment on attachment 63687 Patch You learn something new everyday. :) Filed https://bugs.webkit.org/show_bug.cgi?id=43655 for the difference in behavior. Mind just adding a comment to _getSelectionFromNode about the case where it returns null? i.e. when the selection is inside a display:none iframe in Firefox. 261642 6 abarth 2010-08-06 20:30:39 -0700 Committed r64892: <http://trac.webkit.org/changeset/64892> 63687 2010-08-05 21:01:41 -0700 2010-08-06 17:18:08 -0700 Patch bug-43606-20100805210139.patch text/plain 3507 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlM2I1Zjc4NTk5ZTZjNDYyYjU5OGJiYWM2ZjY3Nzk4ZDJkNTg2NDBiLi5mMzA3YTcz MjUzMDEzZjc0ZWFhZjg2ZjA1NzZhYzY5ZTJkMmY2ZGY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBkdW1wLWFz LW1hcmt1cCBzaG91bGQgd29yayBpbiBGaXJlZm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzYwNgorCisgICAgICAgIEFwcGFyZW50bHkgRmlyZWZv eCBsYWNrcyB0aGlzIEFQSS4KKworICAgICAgICAqIHJlc291cmNlcy9kdW1wLWFzLW1hcmt1cC5q czoKKyAgICAgICAgKE1hcmt1cC5fZ2V0TWFya3VwRm9yVGV4dE5vZGUpOgorICAgICAgICAoTWFy a3VwLl9nZXRTZWxlY3Rpb25NYXJrZXIpOgorCisyMDEwLTA4LTA1ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK ICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIE1hdGhNTCBlbnRpdGllcwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM1OTUKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcmVzb3VyY2VzL2R1bXAtYXMtbWFya3VwLmpzIGIvTGF5b3V0VGVzdHMvcmVzb3Vy Y2VzL2R1bXAtYXMtbWFya3VwLmpzCmluZGV4IDU2NzZmM2E1OWEwZjcxZjdjOWQwYjQ0MWU0YjM5 NDVkOTBkZjE0ODcuLjdiOWY5NWY4Yjg0NGFiMzM5MjhlMzc4YzBjMzI2MGM3YjM2ZmFlYmEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Jlc291cmNlcy9kdW1wLWFzLW1hcmt1cC5qcworKysgYi9M YXlvdXRUZXN0cy9yZXNvdXJjZXMvZHVtcC1hcy1tYXJrdXAuanMKQEAgLTI2MCwyOSArMjYwLDMx IEBAIE1hcmt1cC5fZ2V0TWFya3VwRm9yVGV4dE5vZGUgPSBmdW5jdGlvbihub2RlKQogICAgIHZh ciBzdGFydE9mZnNldCwgZW5kT2Zmc2V0LCBzdGFydFRleHQsIGVuZFRleHQ7CiAKICAgICB2YXIg c2VsID0gTWFya3VwLl9nZXRTZWxlY3Rpb25Gcm9tTm9kZShub2RlKTsKLSAgICBpZiAobm9kZSA9 PSBzZWwuYW5jaG9yTm9kZSAmJiBub2RlID09IHNlbC5mb2N1c05vZGUpIHsKLSAgICAgICAgaWYg KHNlbC5pc0NvbGxhcHNlZCkgewotICAgICAgICAgICAgc3RhcnRPZmZzZXQgPSBzZWwuYW5jaG9y T2Zmc2V0OwotICAgICAgICAgICAgc3RhcnRUZXh0ID0gTWFya3VwLl9TRUxFQ1RJT05fQ0FSRVQ7 Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBpZiAoc2VsLmZvY3VzT2Zmc2V0ID4gc2Vs LmFuY2hvck9mZnNldCkgeworICAgIGlmIChzZWwpIHsKKyAgICAgICAgaWYgKG5vZGUgPT0gc2Vs LmFuY2hvck5vZGUgJiYgbm9kZSA9PSBzZWwuZm9jdXNOb2RlKSB7CisgICAgICAgICAgICBpZiAo c2VsLmlzQ29sbGFwc2VkKSB7CiAgICAgICAgICAgICAgICAgc3RhcnRPZmZzZXQgPSBzZWwuYW5j aG9yT2Zmc2V0OwotICAgICAgICAgICAgICAgIGVuZE9mZnNldCA9IHNlbC5mb2N1c09mZnNldDsK LSAgICAgICAgICAgICAgICBzdGFydFRleHQgPSBNYXJrdXAuX1NFTEVDVElPTl9BTkNIT1I7Ci0g ICAgICAgICAgICAgICAgZW5kVGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0ZPQ1VTOworICAgICAg ICAgICAgICAgIHN0YXJ0VGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0NBUkVUOwogICAgICAgICAg ICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBzdGFydE9mZnNldCA9IHNlbC5mb2N1c09mZnNl dDsKLSAgICAgICAgICAgICAgICBlbmRPZmZzZXQgPSBzZWwuYW5jaG9yT2Zmc2V0OwotICAgICAg ICAgICAgICAgIHN0YXJ0VGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0ZPQ1VTOwotICAgICAgICAg ICAgICAgIGVuZFRleHQgPSBNYXJrdXAuX1NFTEVDVElPTl9BTkNIT1I7CisgICAgICAgICAgICAg ICAgaWYgKHNlbC5mb2N1c09mZnNldCA+IHNlbC5hbmNob3JPZmZzZXQpIHsKKyAgICAgICAgICAg ICAgICAgICAgc3RhcnRPZmZzZXQgPSBzZWwuYW5jaG9yT2Zmc2V0OworICAgICAgICAgICAgICAg ICAgICBlbmRPZmZzZXQgPSBzZWwuZm9jdXNPZmZzZXQ7CisgICAgICAgICAgICAgICAgICAgIHN0 YXJ0VGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0FOQ0hPUjsKKyAgICAgICAgICAgICAgICAgICAg ZW5kVGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0ZPQ1VTOworICAgICAgICAgICAgICAgIH0gZWxz ZSB7CisgICAgICAgICAgICAgICAgICAgIHN0YXJ0T2Zmc2V0ID0gc2VsLmZvY3VzT2Zmc2V0Owor ICAgICAgICAgICAgICAgICAgICBlbmRPZmZzZXQgPSBzZWwuYW5jaG9yT2Zmc2V0OworICAgICAg ICAgICAgICAgICAgICBzdGFydFRleHQgPSBNYXJrdXAuX1NFTEVDVElPTl9GT0NVUzsKKyAgICAg ICAgICAgICAgICAgICAgZW5kVGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0FOQ0hPUjsKKyAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSBpZiAobm9kZSA9PSBz ZWwuZm9jdXNOb2RlKSB7CisgICAgICAgICAgICBzdGFydE9mZnNldCA9IHNlbC5mb2N1c09mZnNl dDsKKyAgICAgICAgICAgIHN0YXJ0VGV4dCA9IE1hcmt1cC5fU0VMRUNUSU9OX0ZPQ1VTOworICAg ICAgICB9IGVsc2UgaWYgKG5vZGUgPT0gc2VsLmFuY2hvck5vZGUpIHsKKyAgICAgICAgICAgIHN0 YXJ0T2Zmc2V0ID0gc2VsLmFuY2hvck9mZnNldDsKKyAgICAgICAgICAgIHN0YXJ0VGV4dCA9IE1h cmt1cC5fU0VMRUNUSU9OX0FOQ0hPUjsKICAgICAgICAgfQotICAgIH0gZWxzZSBpZiAobm9kZSA9 PSBzZWwuZm9jdXNOb2RlKSB7Ci0gICAgICAgIHN0YXJ0T2Zmc2V0ID0gc2VsLmZvY3VzT2Zmc2V0 OwotICAgICAgICBzdGFydFRleHQgPSBNYXJrdXAuX1NFTEVDVElPTl9GT0NVUzsKLSAgICB9IGVs c2UgaWYgKG5vZGUgPT0gc2VsLmFuY2hvck5vZGUpIHsKLSAgICAgICAgc3RhcnRPZmZzZXQgPSBz ZWwuYW5jaG9yT2Zmc2V0OwotICAgICAgICBzdGFydFRleHQgPSBNYXJrdXAuX1NFTEVDVElPTl9B TkNIT1I7CiAgICAgfQogICAgIAogICAgIGlmIChzdGFydFRleHQgJiYgZW5kVGV4dCkKQEAgLTI5 OSw2ICszMDEsOSBAQCBNYXJrdXAuX2dldFNlbGVjdGlvbk1hcmtlciA9IGZ1bmN0aW9uKG5vZGUs IGluZGV4KQogICAgICAgICByZXR1cm4gJyc7CiAKICAgICB2YXIgc2VsID0gTWFya3VwLl9nZXRT ZWxlY3Rpb25Gcm9tTm9kZShub2RlKTs7CisgICAgaWYgKCFzZWwpCisgICAgICAgIHJldHVybiAn JzsKKwogICAgIGlmIChpbmRleCA9PSBzZWwuYW5jaG9yT2Zmc2V0ICYmIG5vZGUgPT0gc2VsLmFu Y2hvck5vZGUpIHsKICAgICAgICAgaWYgKHNlbC5pc0NvbGxhcHNlZCkKICAgICAgICAgICAgIHJl dHVybiBNYXJrdXAuX1NFTEVDVElPTl9DQVJFVDsK