43602 2010-08-05 19:23:08 -0700 [gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus 2010-08-09 08:50:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac (Intel) Linux RESOLVED FIXED P2 Normal --- 0 bjt23 webkit-unassigned mrobinson oldest_to_newest 261038 0 bjt23 2010-08-05 19:23:08 -0700 We have an on-screen keyboard that is implemented as a Gtk IM module. The change in Martin's commit 14a3dc3801b495632521c557be1091e79b996b03 that adds a call to gtk_im_context_focus_in() in webkitwebview.cpp:webkit_web_view_focus_in_event() causes the keyboard to pop up all the time, whenever the web view is focused, even if there are no actual editable/input-able elements on the page. Not sure what the best fix is; commenting out those lines makes the situation better, but there are still some problems. I'm thinking it should be checking the type of the focused DOM node, and only enable it if it's something that can accept keyboard input. But not sure how to do that just yet. 261042 1 bjt23 2010-08-05 19:31:41 -0700 Oh, that's svn rev r56072 for the git-impaired ^_^ 261316 2 63735 mrobinson 2010-08-06 09:59:08 -0700 Created attachment 63735 Patch for this issue 261318 3 mrobinson 2010-08-06 10:00:10 -0700 Thanks for reporting this Brian! I've uploaded a patch for this issue, but I do not think I can test it locally. Do you mind testing it for yourself? If it works, I'll mark it r?. 261449 4 bjt23 2010-08-06 14:05:58 -0700 Works perfectly, thanks Martin! 262141 5 63735 xan.lopez 2010-08-09 08:19:56 -0700 Comment on attachment 63735 Patch for this issue r=me 262154 6 63735 mrobinson 2010-08-09 08:50:23 -0700 Comment on attachment 63735 Patch for this issue Clearing flags on attachment: 63735 Committed r64983: <http://trac.webkit.org/changeset/64983> 262155 7 mrobinson 2010-08-09 08:50:27 -0700 All reviewed patches have been landed. Closing bug. 63735 2010-08-06 09:59:08 -0700 2010-08-09 08:50:23 -0700 Patch for this issue bug-43602-20100806095906.patch text/plain 1573 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYTQ5M2MwZGRmYmI2NWJjMWZmMzZhN2U0NzdjM2QzOWE2MDcxNWI4NC4uMjExY2YwYWU5 ZWQyZWQyNDBlMDA4NDViMGE4MTJhYzdiMTAyMjk0NSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MC0wOC0wNiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2d0a10gZ3RrX2ltX2Nv bnRleHRfZm9jdXNfaW4oKSBzaG91bGQgb25seSBiZSBjYWxsZWQgd2hlbiBhbiBpbnB1dC1hYmxl IGVsZW1lbnQgaGFzIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MzYwMgorCisgICAgICAgIE9ubHkgY2FsbCBndGtfaW1fY29udGV4dF9mb2N1 c19pbigpIHdoZW4gd2UgZm9jdXMgYSBmcmFtZSB3aGljaCBpcyBjdXJyZW50bHkgaW4KKyAgICAg ICAgYW4gZWRpdGFibGUgbm9kZS4gCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5j cHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZm9jdXNfaW5fZXZlbnQpOiBDb25kaXRpb25h bGl6ZSBjYWxsIHRvIGd0a19pbV9jb250ZXh0X2ZvY3VzX2luKCkuCisKIDIwMTAtMDgtMDUgIEdh dmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJl ciBzdGFtcGVkIGJ5IFNhbSBXZWluaWcKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5k ZXggMWQyYWYwZTUzMTA5MDFlZTEzMzMyMjdmYzBlMjczMjcxYzcwMTM0OS4uNThkOTFlYWRiYWM2 MGRiYzUyODU5NGQzMzc5MmQxNTAxNGYzODJlOCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmll dy5jcHAKQEAgLTc5Nyw3ICs3OTcsOCBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3 X2ZvY3VzX2luX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEZvY3VzKgogICAgICAg ICBlbHNlCiAgICAgICAgICAgICBmb2N1c0NvbnRyb2xsZXItPnNldEZvY3VzZWRGcmFtZShjb3Jl KHdlYlZpZXcpLT5tYWluRnJhbWUoKSk7CiAKLSAgICAgICAgZ3RrX2ltX2NvbnRleHRfZm9jdXNf aW4od2ViVmlldy0+cHJpdi0+aW1Db250ZXh0KTsKKyAgICAgICAgaWYgKGZvY3VzQ29udHJvbGxl ci0+Zm9jdXNlZEZyYW1lKCktPmVkaXRvcigpLT5jYW5FZGl0KCkpCisgICAgICAgICAgICBndGtf aW1fY29udGV4dF9mb2N1c19pbih3ZWJWaWV3LT5wcml2LT5pbUNvbnRleHQpOwogICAgIH0KICAg ICByZXR1cm4gR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50X2NsYXNzKS0+ Zm9jdXNfaW5fZXZlbnQod2lkZ2V0LCBldmVudCk7CiB9Cg==