43598 2010-08-05 17:35:01 -0700 AX: Placeholder value for text fields not exposed like it should be 2010-08-09 16:46:05 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin ddkilzer oldest_to_newest 260984 0 cfleizach 2010-08-05 17:35:01 -0700 When a textfield has placeholder text, it should be exposed through kAXPlaceholderValue 260985 1 63669 cfleizach 2010-08-05 17:39:31 -0700 Created attachment 63669 Patch 262186 2 cfleizach 2010-08-09 09:32:00 -0700 kAXPlaceholderValue is only defined on 10.6 however, so we need to also define it 262401 3 63669 ddkilzer 2010-08-09 16:38:01 -0700 Comment on attachment 63669 Patch LayoutTests/accessibility/placeholder.html:19 + description("This test makes sure that the placeholder is returned as the right attribute"); I would prefer "correct" instead of "right" here to make it clear it's a correct/incorrect issue and not a left/right issue. :) r=me 262402 4 cfleizach 2010-08-09 16:46:05 -0700 thanks! http://trac.webkit.org/changeset/65016 63669 2010-08-05 17:39:31 -0700 2010-08-09 16:38:01 -0700 Patch bug-43598-20100805173930.patch text/plain 6685 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDgwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMDUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogUGxhY2Vob2xkZXIgdmFsdWUgZm9yIHRleHQgZmllbGRzIG5vdCBleHBvc2VkIGxpa2Ug aXQgc2hvdWxkIGJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MzU5OAorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OnBsYWNlaG9sZGVy VmFsdWUpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oOgor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp0aXRsZSk6CisgICAg ICAgICogYWNjZXNzaWJpbGl0eS9tYWMvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW06Cisg ICAgICAgICgtW0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlBdHRyaWJ1 dGVOYW1lc10pOgorICAgICAgICAoLVtBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nlc3Np YmlsaXR5QXR0cmlidXRlVmFsdWU6XSk6CisKIDIwMTAtMDgtMDUgIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4 OiBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCShyZXZp c2lvbiA2NDc5MCkKKysrIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTY5LDYgKzk2OSwxNSBAQCBBY2Nlc3NpYmlsaXR5Um9s ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0OjphCiAgICAgcmV0dXJuIHJvbGVNYXAtPmdldCh2YWx1ZSk7 CiB9CiAKK2NvbnN0IEF0b21pY1N0cmluZyYgQWNjZXNzaWJpbGl0eU9iamVjdDo6cGxhY2Vob2xk ZXJWYWx1ZSgpIGNvbnN0Cit7CisgICAgY29uc3QgQXRvbWljU3RyaW5nJiBwbGFjZWhvbGRlciA9 IGdldEF0dHJpYnV0ZShwbGFjZWhvbGRlckF0dHIpOworICAgIGlmICghcGxhY2Vob2xkZXIuaXNF bXB0eSgpKQorICAgICAgICByZXR1cm4gcGxhY2Vob2xkZXI7CisgICAgCisgICAgcmV0dXJuIG51 bGxBdG9tOworfQorICAgIAogYm9vbCBBY2Nlc3NpYmlsaXR5T2JqZWN0Ojppc0luc2lkZUFSSUFM aXZlUmVnaW9uKCkgY29uc3QKIHsKICAgICBpZiAoc3VwcG9ydHNBUklBTGl2ZVJlZ2lvbigpKQpJ bmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCShyZXZp c2lvbiA2NDc5MCkKKysrIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0 LmgJKHdvcmtpbmcgY29weSkKQEAgLTQyOCw2ICs0MjgsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCBGcmFtZVZpZXcqIGRvY3VtZW50RnJhbWVWaWV3KCkgY29uc3Q7CiAgICAgU3RyaW5nIGxhbmd1 YWdlKCkgY29uc3Q7CiAgICAgdmlydHVhbCB1bnNpZ25lZCBoaWVyYXJjaGljYWxMZXZlbCgpIGNv bnN0IHsgcmV0dXJuIDA7IH0KKyAgICBjb25zdCBBdG9taWNTdHJpbmcmIHBsYWNlaG9sZGVyVmFs dWUoKSBjb25zdDsKICAgICAKICAgICB2aXJ0dWFsIHZvaWQgc2V0Rm9jdXNlZChib29sKSB7IH0K ICAgICB2aXJ0dWFsIHZvaWQgc2V0U2VsZWN0ZWRUZXh0KGNvbnN0IFN0cmluZyYpIHsgfQpJbmRl eDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcAkocmV2aXNpb24gNjQ3OTApCisrKyBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNTYsMTAgKzEyNTYs NiBAQCBTdHJpbmcgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGl0bGUoCiAgICAgICAgIEhU TUxMYWJlbEVsZW1lbnQqIGxhYmVsID0gbGFiZWxGb3JFbGVtZW50KHN0YXRpY19jYXN0PEVsZW1l bnQqPihub2RlKSk7CiAgICAgICAgIGlmIChsYWJlbCAmJiAhdGl0bGVVSUVsZW1lbnQoKSkKICAg ICAgICAgICAgIHJldHVybiBsYWJlbC0+aW5uZXJUZXh0KCk7Ci0gICAgICAgIAotICAgICAgICBj b25zdCBBdG9taWNTdHJpbmcmIHBsYWNlaG9sZGVyID0gZ2V0QXR0cmlidXRlKHBsYWNlaG9sZGVy QXR0cik7Ci0gICAgICAgIGlmICghcGxhY2Vob2xkZXIuaXNFbXB0eSgpKQotICAgICAgICAgICAg cmV0dXJuIHBsYWNlaG9sZGVyOwogICAgIH0KICAgICAKICAgICBpZiAocm9sZVZhbHVlKCkgPT0g QnV0dG9uUm9sZQpJbmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFj L0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCShyZXZpc2lvbiA2NDc5MCkKKysrIFdlYkNv cmUvYWNjZXNzaWJpbGl0eS9tYWMvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW0JKHdvcmtp bmcgY29weSkKQEAgLTE1Nyw2ICsxNTcsMTAgQEAgdXNpbmcgbmFtZXNwYWNlIHN0ZDsKICNkZWZp bmUgTlNBY2Nlc3NpYmlsaXR5SGFzUG9wdXBBdHRyaWJ1dGUgQCJBWEhhc1BvcHVwIgogI2VuZGlm CiAKKyNpZm5kZWYgTlNBY2Nlc3NpYmlsaXR5UGxhY2Vob2xkZXJWYWx1ZUF0dHJpYnV0ZQorI2Rl ZmluZSBOU0FjY2Vzc2liaWxpdHlQbGFjZWhvbGRlclZhbHVlQXR0cmlidXRlIEAiQVhQbGFjZWhv bGRlclZhbHVlIgorI2VuZGlmCisKICNpZmRlZiBCVUlMRElOR19PTl9USUdFUgogdHlwZWRlZiB1 bnNpZ25lZCBOU1VJbnRlZ2VyOwogI2RlZmluZSBOU0FjY2Vzc2liaWxpdHlWYWx1ZURlc2NyaXB0 aW9uQXR0cmlidXRlIEAiQVhWYWx1ZURlc2NyaXB0aW9uIgpAQCAtNzMxLDYgKzczNSw3IEBAIC0g KE5TQXJyYXkqKWFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVOYW1lcwogICAgICAgICBbdGVtcEFycmF5 IGFkZE9iamVjdDpOU0FjY2Vzc2liaWxpdHlUaXRsZVVJRWxlbWVudEF0dHJpYnV0ZV07CiAgICAg ICAgIFt0ZW1wQXJyYXkgYWRkT2JqZWN0Ok5TQWNjZXNzaWJpbGl0eUFjY2Vzc0tleUF0dHJpYnV0 ZV07CiAgICAgICAgIFt0ZW1wQXJyYXkgYWRkT2JqZWN0Ok5TQWNjZXNzaWJpbGl0eVJlcXVpcmVk QXR0cmlidXRlXTsKKyAgICAgICAgW3RlbXBBcnJheSBhZGRPYmplY3Q6TlNBY2Nlc3NpYmlsaXR5 UGxhY2Vob2xkZXJWYWx1ZUF0dHJpYnV0ZV07CiAgICAgICAgIHRleHRBdHRycyA9IFtbTlNBcnJh eSBhbGxvY10gaW5pdFdpdGhBcnJheTp0ZW1wQXJyYXldOwogICAgICAgICBbdGVtcEFycmF5IHJl bGVhc2VdOwogICAgIH0KQEAgLTE4NTksNiArMTg2NCw5IEBAIC0gKGlkKWFjY2Vzc2liaWxpdHlB dHRyaWJ1dGVWYWx1ZTooTlNTdHIKICAgICAgICAgcmV0dXJuIGRyb3BFZmZlY3RzQXJyYXk7CiAg ICAgfQogICAgIAorICAgIGlmIChbYXR0cmlidXRlTmFtZSBpc0VxdWFsVG9TdHJpbmc6TlNBY2Nl c3NpYmlsaXR5UGxhY2Vob2xkZXJWYWx1ZUF0dHJpYnV0ZV0pCisgICAgICAgIHJldHVybiBtX29i amVjdC0+cGxhY2Vob2xkZXJWYWx1ZSgpOworICAgIAogICAgIGlmIChbYXR0cmlidXRlTmFtZSBp c0VxdWFsVG9TdHJpbmc6TlNBY2Nlc3NpYmlsaXR5SGFzUG9wdXBBdHRyaWJ1dGVdKQogICAgICAg ICByZXR1cm4gW05TTnVtYmVyIG51bWJlcldpdGhCb29sOm1fb2JqZWN0LT5hcmlhSGFzUG9wdXAo KV07CiAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2NDgwMykKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA4LTA1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQVg6IFBsYWNlaG9sZGVyIHZhbHVlIGZvciB0ZXh0IGZp ZWxkcyBub3QgZXhwb3NlZCBsaWtlIGl0IHNob3VsZCBiZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM1OTgKKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvcGxhY2Vob2xkZXItZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvcGxh Y2Vob2xkZXIuaHRtbDoKKwogMjAxMC0wOC0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci1leHBlY3RlZC50eHQJKHJldmlz aW9uIDY0NzkwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci1leHBl Y3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMTAgKzEsMTAgQEAKIAotVGhpcyB0ZXN0IG1h a2VzIHN1cmUgdGhhdCB0aGUgQVhUaXRsZSB3aWxsIGZhbGwgYmFjayB0byBwbGFjZWhvbGRlciB0 ZXh0IGlmIG5vdGhpbmcgZWxzZSBpcyBhdmFpbGFibGUKK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRo YXQgdGhlIHBsYWNlaG9sZGVyIGlzIHJldHVybmVkIGFzIHRoZSByaWdodCBhdHRyaWJ1dGUKIAog T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgZmllbGRFbGVtZW50LnRpdGxlIGlz ICdBWFRpdGxlOiBzZWFyY2gnCitQQVNTIGZpZWxkRWxlbWVudC5zdHJpbmdBdHRyaWJ1dGVWYWx1 ZSgnQVhQbGFjZWhvbGRlclZhbHVlJykgaXMgJ3NlYXJjaCcKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9wbGFjZWhvbGRlci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvcGxhY2Vob2xkZXIuaHRtbAkocmV2aXNpb24gNjQ3OTApCisrKyBMYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE2LDExICsx NiwxMSBAQCB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gZmFsc2U7CiAgICAgIAogICAgIDxzY3Jp cHQ+CiAgICAgICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKLSAgICAg ICAgICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IHRoZSBBWFRpdGxl IHdpbGwgZmFsbCBiYWNrIHRvIHBsYWNlaG9sZGVyIHRleHQgaWYgbm90aGluZyBlbHNlIGlzIGF2 YWlsYWJsZSIpOworICAgICAgICAgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBtYWtlcyBzdXJl IHRoYXQgdGhlIHBsYWNlaG9sZGVyIGlzIHJldHVybmVkIGFzIHRoZSByaWdodCBhdHRyaWJ1dGUi KTsKIAogICAgICAgICAgICAgdmFyIGZpZWxkID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNl YXJjaHRlcm0iKS5mb2N1cygpOwogICAgICAgICAgICAgdmFyIGZpZWxkRWxlbWVudCA9IGFjY2Vz c2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OwotICAgICAgICAgICAgc2hvdWxkQmUo ImZpZWxkRWxlbWVudC50aXRsZSIsICInQVhUaXRsZTogc2VhcmNoJyIpOworICAgICAgICAgICAg c2hvdWxkQmUoImZpZWxkRWxlbWVudC5zdHJpbmdBdHRyaWJ1dGVWYWx1ZSgnQVhQbGFjZWhvbGRl clZhbHVlJykiLCAiJ3NlYXJjaCciKTsKIAogICAgICAgICB9CiAgICAgICAgIHN1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7Cg==