43593 2010-08-05 17:01:24 -0700 WebView::backingStore should check if m_backingStoreBitmap is NULL 2010-08-05 19:19:43 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jberlin jberlin jberlin oldest_to_newest 260959 0 jberlin 2010-08-05 17:01:24 -0700 There are cases when WebView::backingStore is called while m_backingStoreBitmap is NULL, such as after deleteBackingStore has been called in response to a WM_NCACTIVATE message (indicating a change in the the active/inactive state). Instead of attempting to dereference a null pointer, we should return early with E_FAIL if m_backingStoreBitmap is NULL. 261028 1 63677 jberlin 2010-08-05 18:49:12 -0700 Created attachment 63677 Add a null check to WebView::backingStore 261031 2 63677 jhoneycutt 2010-08-05 19:05:05 -0700 Comment on attachment 63677 Add a null check to WebView::backingStore r=me 261037 3 63677 jberlin 2010-08-05 19:19:33 -0700 Comment on attachment 63677 Add a null check to WebView::backingStore Committed in r64811 http://trac.webkit.org/changeset/64811 63677 2010-08-05 18:49:12 -0700 2010-08-05 19:19:33 -0700 Add a null check to WebView::backingStore addNullCheckToWebViewBackingStore.patch text/plain 1094 jberlin SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2NDgwOSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMDUgIEplc3NpZSBCZXJsaW4gIDxqYmVy bGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBCdWcgNDM1OTMgLSBXZWJWaWV3OjpiYWNraW5nU3RvcmUgc2hvdWxkIGNoZWNrIGlm IG1fYmFja2luZ1N0b3JlQml0bWFwIGlzIE5VTEwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzU5MworCisgICAgICAgICogV2ViVmlldy5jcHA6Cisg ICAgICAgIChXZWJWaWV3OjpiYWNraW5nU3RvcmUpOgorICAgICAgICBJZiBtX2JhY2tpbmdTdG9y ZUJpdG1hcCBpcyBOVUxMLCByZXR1cm4gRV9GQUlMLgorCiAyMDEwLTA4LTA1ICBHYXZpbiBCYXJy YWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXIgc3RhbXBl ZCBieSBTYW0gV2VpbmlnCkluZGV4OiBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDY0NzQ2KQorKysgV2ViS2l0L3dp bi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTcyNSw2ICs1NzI1LDggQEAgSFJFU1VM VCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpiYWNraQogewogICAgIGlmICghaEJpdG1hcCkK ICAgICAgICAgcmV0dXJuIEVfUE9JTlRFUjsKKyAgICBpZiAoIW1fYmFja2luZ1N0b3JlQml0bWFw KQorICAgICAgICByZXR1cm4gRV9GQUlMOwogICAgICpoQml0bWFwID0gcmVpbnRlcnByZXRfY2Fz dDxPTEVfSEFORExFPihtX2JhY2tpbmdTdG9yZUJpdG1hcC0+aGFuZGxlKCkpOwogICAgIHJldHVy biBTX09LOwogfQo=