43585 2010-08-05 16:06:39 -0700 Remove Invalid Asserts for Application Cache Quotas 2010-08-05 17:27:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned ddkilzer joepeck oldest_to_newest 260925 0 joepeck 2010-08-05 16:06:39 -0700 These ASSERTs were added in: <http://webkit.org/b/40627> Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) They will always fail the first time with a client that uses a non-unlimited quota because: - ApplicationCacheStorage's singleton is initialized with noQuota defaults - WebApplicationCache uses the above singleton - When initializing the WebView _preferencesChanged will call setter, which runs this ASSERT before the default quota is being set for the first time! [WebApplicationCache setDefaultOriginQuota:[preferences applicationCacheDefaultOriginQuota]]; 260935 1 63658 joepeck 2010-08-05 16:15:01 -0700 Created attachment 63658 Patch 260964 2 63658 ddkilzer 2010-08-05 17:05:09 -0700 Comment on attachment 63658 Patch r=me 260978 3 joepeck 2010-08-05 17:26:19 -0700 Committed r64802 M WebKit/mac/ChangeLog M WebKit/mac/WebView/WebPreferences.mm r64802 = 71974a4e5fadb1b52f47ea1ab3fcfa7604e2dc86 http://trac.webkit.org/changeset/64802 63658 2010-08-05 16:15:01 -0700 2010-08-05 17:05:08 -0700 Patch bug-43585-20100805161500.patch text/plain 1705 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggMzFiOGEwYWU0M2JmNGNhNGExODIwMGU2ZjA5YWUzMTBiNTcxM2JjOC4uNDQ5Y2UyNDU0 NmJjZjc1M2IzNzRiN2M3MGU0ZDY1MjcyZjcwOWQwOSAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wOC0wNSAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBJbnZhbGlkIEFz c2VydHMgZm9yIEFwcGxpY2F0aW9uIENhY2hlIFF1b3RhcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM1ODUKKworICAgICAgICBSZW1vdmVkIEludmFs aWQgQVNTRVJUcyB0aGF0IHdvdWxkIGFsd2F5cyBoYXBwZW4gZm9yIHF1b3RhcworICAgICAgICB0 aGF0IHdlcmUgbm90IG5vUXVvdGEoKS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5j ZXMubW06CisgICAgICAgICgtW1dlYlByZWZlcmVuY2VzIGFwcGxpY2F0aW9uQ2FjaGVUb3RhbFF1 b3RhXSk6CisgICAgICAgICgtW1dlYlByZWZlcmVuY2VzIGFwcGxpY2F0aW9uQ2FjaGVEZWZhdWx0 T3JpZ2luUXVvdGFdKToKKwogMjAxMC0wOC0wMyAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEtpbHplci4KZGlmZiAtLWdp dCBhL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbSBiL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJQcmVmZXJlbmNlcy5tbQppbmRleCA3ZWMyNDM5ZWFiZWNjMTU2ZTY1NGYwMzk4OGQw M2EzODM2OTY1ZjExLi5jNDZkY2E3ODJjZTkyYzUyNWQ3OWJjMTAxZTMxMzJmMTVjNjNhYTg2IDEw MDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0KKysrIGIvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tCkBAIC05OTgsNyArOTk4LDYgQEAgc3Rh dGljIFdlYkNhY2hlTW9kZWwgY2FjaGVNb2RlbEZvck1haW5CdW5kbGUodm9pZCkKIAogLSAoaW50 NjRfdClhcHBsaWNhdGlvbkNhY2hlVG90YWxRdW90YQogewotICAgIEFTU0VSVChbc2VsZiBfbG9u Z0xvbmdWYWx1ZUZvcktleTpXZWJLaXRBcHBsaWNhdGlvbkNhY2hlVG90YWxRdW90YV0gPT0gW1dl YkFwcGxpY2F0aW9uQ2FjaGUgbWF4aW11bVNpemVdKTsKICAgICByZXR1cm4gW3NlbGYgX2xvbmdM b25nVmFsdWVGb3JLZXk6V2ViS2l0QXBwbGljYXRpb25DYWNoZVRvdGFsUXVvdGFdOwogfQogCkBA IC0xMDEyLDcgKzEwMTEsNiBAQCBzdGF0aWMgV2ViQ2FjaGVNb2RlbCBjYWNoZU1vZGVsRm9yTWFp bkJ1bmRsZSh2b2lkKQogCiAtIChpbnQ2NF90KWFwcGxpY2F0aW9uQ2FjaGVEZWZhdWx0T3JpZ2lu UXVvdGEKIHsKLSAgICBBU1NFUlQoW3NlbGYgX2xvbmdMb25nVmFsdWVGb3JLZXk6V2ViS2l0QXBw bGljYXRpb25DYWNoZURlZmF1bHRPcmlnaW5RdW90YV0gPT0gW1dlYkFwcGxpY2F0aW9uQ2FjaGUg ZGVmYXVsdE9yaWdpblF1b3RhXSk7CiAgICAgcmV0dXJuIFtzZWxmIF9sb25nTG9uZ1ZhbHVlRm9y S2V5OldlYktpdEFwcGxpY2F0aW9uQ2FjaGVEZWZhdWx0T3JpZ2luUXVvdGFdOwogfQogCg==