43569 2010-08-05 12:05:45 -0700 [EFL] Add setting for enabling spatial navigation. 2010-08-11 11:50:16 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 antognolli+webkit webkit-unassigned barbieri commit-queue kenneth tonikitoo oldest_to_newest 260752 0 antognolli+webkit 2010-08-05 12:05:45 -0700 [EFL] Add setting for enabling spatial navigation. 260753 1 63613 antognolli+webkit 2010-08-05 12:07:27 -0700 Created attachment 63613 Patch 260783 2 63613 kenneth 2010-08-05 12:45:35 -0700 Comment on attachment 63613 Patch WebKit/efl/ewk/ewk_view.cpp:2619 + why so many newlines here? 263052 3 64075 abarth 2010-08-10 23:03:47 -0700 Created attachment 64075 Patch for landing 263369 4 64075 commit-queue 2010-08-11 11:50:11 -0700 Comment on attachment 64075 Patch for landing Clearing flags on attachment: 64075 Committed r65169: <http://trac.webkit.org/changeset/65169> 263370 5 commit-queue 2010-08-11 11:50:16 -0700 All reviewed patches have been landed. Closing bug. 63613 2010-08-05 12:07:27 -0700 2010-08-10 23:03:41 -0700 Patch bug-43569-20100805160726.patch text/plain 3004 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZTdlMjA5ZmUzMjUzZTg1OTNmNTljYWFlYTRjYzhjNmUwNmM4NTE4MC4uNDY2ZjZjMjUz YWJmNWNkNzMyNzU0YzM0NWY1NGRiOTY4NDYyMDdjZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wOC0wNSAgUmFmYWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFk ZCBzZXR0aW5nIGZvciBlbmFibGluZyBzcGF0aWFsIG5hdmlnYXRpb24uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzU2OQorCisgICAgICAgIEFkZGlu ZyBhcGkgZm9yIGVuYWJsaW5nL2Rpc2FibGluZyBzcGF0aWFsIG5hdmlnYXRpb24uCisKKyAgICAg ICAgKiBld2svZXdrX3ZpZXcuY3BwOiBCb3RoIGZ1bmN0aW9ucyBiZWxvdyBhZGRlZC4KKyAgICAg ICAgKGV3a192aWV3X3NldHRpbmdfc3BhdGlhbF9uYXZpZ2F0aW9uX2dldCk6CisgICAgICAgIChl d2tfdmlld19zZXR0aW5nX3NwYXRpYWxfbmF2aWdhdGlvbl9zZXQpOgorICAgICAgICAqIGV3ay9l d2tfdmlldy5oOiBzYW1lIGFzIGV3a192aWV3LmNwcC4KKwogMjAxMC0wOC0wMyAgTGVhbmRybyBQ ZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBieSBL ZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcCBiL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBlZDZmYjRkZDNj OTE4ZjBiMTcyODg0NjQzZmZhYjNkOTc0MWVlODdhLi4xY2U5NWVmNGMzNjI0ZTJhYzQ1Y2Y3YjM4 MGUxOTYwYzdjMWJkNjNkIDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAK KysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0xMDYsNiArMTA2LDcgQEAgc3Ry dWN0IF9Fd2tfVmlld19Qcml2YXRlX0RhdGEgewogICAgICAgICBFaW5hX0Jvb2wgcmVzaXphYmxl X3RleHRhcmVhczoxOwogICAgICAgICBFaW5hX0Jvb2wgcHJpdmF0ZV9icm93c2luZzoxOwogICAg ICAgICBFaW5hX0Jvb2wgY2FyZXRfYnJvd3Npbmc6MTsKKyAgICAgICAgRWluYV9Cb29sIHNwYXRp YWxfbmF2aWdhdGlvbjoxOwogICAgICAgICBzdHJ1Y3QgewogICAgICAgICAgICAgZmxvYXQgdzsK ICAgICAgICAgICAgIGZsb2F0IGg7CkBAIC0yNjA2LDYgKzI2MDcsMjggQEAgRWluYV9Cb29sIGV3 a192aWV3X3NldHRpbmdfZm9udF9zYW5zX3NlcmlmX3NldChFdmFzX09iamVjdCogbywgY29uc3Qg Y2hhciogZmFtaWwKICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQogCisKK0VpbmFfQm9vbCBld2tf dmlld19zZXR0aW5nX3NwYXRpYWxfbmF2aWdhdGlvbl9nZXQoRXZhc19PYmplY3QqIG8pCit7Cisg ICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7CisgICAgRVdL X1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCBFSU5BX0ZBTFNFKTsKKyAgICByZXR1 cm4gcHJpdi0+c2V0dGluZ3Muc3BhdGlhbF9uYXZpZ2F0aW9uOworfQorCisKKworRWluYV9Cb29s IGV3a192aWV3X3NldHRpbmdfc3BhdGlhbF9uYXZpZ2F0aW9uX3NldChFdmFzX09iamVjdCogbywg RWluYV9Cb29sIGVuYWJsZSkKK3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNk LCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYs IEVJTkFfRkFMU0UpOworICAgIGVuYWJsZSA9ICEhZW5hYmxlOworICAgIGlmIChwcml2LT5zZXR0 aW5ncy5zcGF0aWFsX25hdmlnYXRpb24gIT0gZW5hYmxlKSB7CisgICAgICAgIHByaXYtPnBhZ2Vf c2V0dGluZ3MtPnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChlbmFibGUpOworICAgICAgICBw cml2LT5zZXR0aW5ncy5zcGF0aWFsX25hdmlnYXRpb24gPSBlbmFibGU7CisgICAgfQorICAgIHJl dHVybiBFSU5BX1RSVUU7Cit9CisKIC8qKgogICogU2ltaWxhciB0byBldmFzX29iamVjdF9zbWFy dF9kYXRhX2dldCgpLCBidXQgZG9lcyB0eXBlIGNoZWNraW5nLgogICoKZGlmZiAtLWdpdCBhL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4 IDE5YTM1ODgzM2IyNmRmZGI5YjI5ODc5NDAzMjU2ZTBhOWRjZGU0YTAuLjNiZGQ0MmQ2Y2UyZGUx ZTAyZmM0NTRmNjA0NGFiMjJkODA5MWEwNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmgKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApAQCAtNDMzLDYgKzQzMyw5 IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NldHRpbmdfZm9udF9zZXJpZl9zZXQoRXZh c19PYmplY3QgKm8sIGNvbnN0IGNoYXIgKmZhCiBFQVBJIGNvbnN0IGNoYXIgICpld2tfdmlld19z ZXR0aW5nX2ZvbnRfc2Fuc19zZXJpZl9nZXQoY29uc3QgRXZhc19PYmplY3QgKm8pOwogRUFQSSBF aW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2V0dGluZ19mb250X3NhbnNfc2VyaWZfc2V0KEV2YXNfT2Jq ZWN0ICpvLCBjb25zdCBjaGFyICpmYW1pbHkpOwogCitFQVBJIEVpbmFfQm9vbCAgICBld2tfdmll d19zZXR0aW5nX3NwYXRpYWxfbmF2aWdhdGlvbl9nZXQoRXZhc19PYmplY3QqIG8pOworRUFQSSBF aW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2V0dGluZ19zcGF0aWFsX25hdmlnYXRpb25fc2V0KEV2YXNf T2JqZWN0KiBvLCBFaW5hX0Jvb2wgZW5hYmxlKTsKKwogLyogdG8gYmUgdXNlZCBieSBzdWJjbGFz cyBpbXBsZW1lbnRhdGlvbnMgKi8KIEVBUEkgRXdrX1ZpZXdfU21hcnRfRGF0YSAqZXdrX3ZpZXdf c21hcnRfZGF0YV9nZXQoY29uc3QgRXZhc19PYmplY3QgKm8pOwogCg== 64075 2010-08-10 23:03:47 -0700 2010-08-11 11:50:11 -0700 Patch for landing bug-43569-20100810230346.patch text/plain 2987 abarth ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggMDJjOTZlZTliMGVhZGU3ZDU1MzA3YjZmYmRmNWMzNWE3MTQzZjBiNS4uNjdjOGY2ZTI3 YzExZTI2MWMwYTEyNDAzOWY1OGE1YjFjNjhjYzBhZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wOC0xMCAgUmFmYWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAg ICAgIFtFRkxdIEFkZCBzZXR0aW5nIGZvciBlbmFibGluZyBzcGF0aWFsIG5hdmlnYXRpb24uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzU2OQorCisg ICAgICAgIEFkZGluZyBhcGkgZm9yIGVuYWJsaW5nL2Rpc2FibGluZyBzcGF0aWFsIG5hdmlnYXRp b24uCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOiBCb3RoIGZ1bmN0aW9ucyBiZWxvdyBh ZGRlZC4KKyAgICAgICAgKGV3a192aWV3X3NldHRpbmdfc3BhdGlhbF9uYXZpZ2F0aW9uX2dldCk6 CisgICAgICAgIChld2tfdmlld19zZXR0aW5nX3NwYXRpYWxfbmF2aWdhdGlvbl9zZXQpOgorICAg ICAgICAqIGV3ay9ld2tfdmlldy5oOiBzYW1lIGFzIGV3a192aWV3LmNwcC4KKwogMjAxMC0wOC0x MCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAg Yi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggZjYzMTBkNTYwZGEzYzZiMzg0MzU0 MjY2YzYwNDQ1YTgwMzBkNTUwOC4uYjlkOWYxODlkMjIzMTFlYzk1NjAxY2NhOGMzNWNjOGEwYjJk N2QzZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMTA2LDYgKzEwNiw3IEBAIHN0cnVjdCBfRXdrX1Zp ZXdfUHJpdmF0ZV9EYXRhIHsKICAgICAgICAgRWluYV9Cb29sIHJlc2l6YWJsZV90ZXh0YXJlYXM6 MTsKICAgICAgICAgRWluYV9Cb29sIHByaXZhdGVfYnJvd3Npbmc6MTsKICAgICAgICAgRWluYV9C b29sIGNhcmV0X2Jyb3dzaW5nOjE7CisgICAgICAgIEVpbmFfQm9vbCBzcGF0aWFsX25hdmlnYXRp b246MTsKICAgICAgICAgc3RydWN0IHsKICAgICAgICAgICAgIGZsb2F0IHc7CiAgICAgICAgICAg ICBmbG9hdCBoOwpAQCAtMjYwNiw2ICsyNjA3LDI1IEBAIEVpbmFfQm9vbCBld2tfdmlld19zZXR0 aW5nX2ZvbnRfc2Fuc19zZXJpZl9zZXQoRXZhc19PYmplY3QqIG8sIGNvbnN0IGNoYXIqIGZhbWls CiAgICAgcmV0dXJuIEVJTkFfVFJVRTsKIH0KIAorRWluYV9Cb29sIGV3a192aWV3X3NldHRpbmdf c3BhdGlhbF9uYXZpZ2F0aW9uX2dldChFdmFzX09iamVjdCogbykKK3sKKyAgICBFV0tfVklFV19T RF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dF VF9PUl9SRVRVUk4oc2QsIHByaXYsIEVJTkFfRkFMU0UpOworICAgIHJldHVybiBwcml2LT5zZXR0 aW5ncy5zcGF0aWFsX25hdmlnYXRpb247Cit9CisKK0VpbmFfQm9vbCBld2tfdmlld19zZXR0aW5n X3NwYXRpYWxfbmF2aWdhdGlvbl9zZXQoRXZhc19PYmplY3QqIG8sIEVpbmFfQm9vbCBlbmFibGUp Cit7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7Cisg ICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCBFSU5BX0ZBTFNFKTsKKyAg ICBlbmFibGUgPSAhIWVuYWJsZTsKKyAgICBpZiAocHJpdi0+c2V0dGluZ3Muc3BhdGlhbF9uYXZp Z2F0aW9uICE9IGVuYWJsZSkgeworICAgICAgICBwcml2LT5wYWdlX3NldHRpbmdzLT5zZXRTcGF0 aWFsTmF2aWdhdGlvbkVuYWJsZWQoZW5hYmxlKTsKKyAgICAgICAgcHJpdi0+c2V0dGluZ3Muc3Bh dGlhbF9uYXZpZ2F0aW9uID0gZW5hYmxlOworICAgIH0KKyAgICByZXR1cm4gRUlOQV9UUlVFOwor fQorCiAvKioKICAqIFNpbWlsYXIgdG8gZXZhc19vYmplY3Rfc21hcnRfZGF0YV9nZXQoKSwgYnV0 IGRvZXMgdHlwZSBjaGVja2luZy4KICAqCmRpZmYgLS1naXQgYS9XZWJLaXQvZWZsL2V3ay9ld2tf dmlldy5oIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAppbmRleCAxOWEzNTg4MzNiMjZkZmRi OWIyOTg3OTQwMzI1NmUwYTlkY2RlNGEwLi4zYmRkNDJkNmNlMmRlMWUwMmZjNDU0ZjYwNDRhYjIy ZDgwOTFhMDVhIDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCisrKyBiL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAgLTQzMyw2ICs0MzMsOSBAQCBFQVBJIEVpbmFfQm9v bCAgICBld2tfdmlld19zZXR0aW5nX2ZvbnRfc2VyaWZfc2V0KEV2YXNfT2JqZWN0ICpvLCBjb25z dCBjaGFyICpmYQogRUFQSSBjb25zdCBjaGFyICAqZXdrX3ZpZXdfc2V0dGluZ19mb250X3NhbnNf c2VyaWZfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKIEVBUEkgRWluYV9Cb29sICAgIGV3a192 aWV3X3NldHRpbmdfZm9udF9zYW5zX3NlcmlmX3NldChFdmFzX09iamVjdCAqbywgY29uc3QgY2hh ciAqZmFtaWx5KTsKIAorRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2V0dGluZ19zcGF0aWFs X25hdmlnYXRpb25fZ2V0KEV2YXNfT2JqZWN0KiBvKTsKK0VBUEkgRWluYV9Cb29sICAgIGV3a192 aWV3X3NldHRpbmdfc3BhdGlhbF9uYXZpZ2F0aW9uX3NldChFdmFzX09iamVjdCogbywgRWluYV9C b29sIGVuYWJsZSk7CisKIC8qIHRvIGJlIHVzZWQgYnkgc3ViY2xhc3MgaW1wbGVtZW50YXRpb25z ICovCiBFQVBJIEV3a19WaWV3X1NtYXJ0X0RhdGEgKmV3a192aWV3X3NtYXJ0X2RhdGFfZ2V0KGNv bnN0IEV2YXNfT2JqZWN0ICpvKTsKIAo=