43562 2010-08-05 08:31:53 -0700 [Qt] Temporary files should not be created in the current directory 2010-08-24 06:32:20 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 hausmann hausmann commit-queue hui_huang laszlo.gombos oldest_to_newest 260623 0 hausmann 2010-08-05 08:31:53 -0700 Currently the way FileSystemQt.cpp creates temporary files makes them end up in the current directory. We should be using the dedicated temporary directory on the system instead. 260626 1 hausmann 2010-08-05 08:36:23 -0700 The use of the current directory creates problems on Symbian (with different drives, etc.) and in general the system temporary directory is the better place, as it may be subject to cleanup (gc on system startup) and it has better permissions in place. 260627 2 63596 hausmann 2010-08-05 08:37:13 -0700 Created attachment 63596 Patch 260635 3 63596 laszlo.gombos 2010-08-05 08:50:26 -0700 Comment on attachment 63596 Patch looks good to me, r+. 261088 4 63596 commit-queue 2010-08-05 22:09:00 -0700 Comment on attachment 63596 Patch Clearing flags on attachment: 63596 Committed r64816: <http://trac.webkit.org/changeset/64816> 261089 5 commit-queue 2010-08-05 22:09:05 -0700 All reviewed patches have been landed. Closing bug. 262656 6 hausmann 2010-08-10 06:39:45 -0700 Revision r64816 cherry-picked into qtwebkit-2.1 with commit 195b286c999effb1c2e675ce35c3936c5cea946d 63596 2010-08-05 08:37:13 -0700 2010-08-05 22:09:00 -0700 Patch bug-43562-20100805173711.patch text/plain 1596 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTE0MzJmMGE3NjAxYmE2MGY1YTBmOWY4YWQ5ODRjMWI5NjQ2YmQ5OC4uNWJjOWRiNjcxMzE0YWY2 MjBlYWRjYmJkOWFmMTRhMTUyZmU4MGNjNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0wOC0wNSAgU2lt b24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBUZW1wb3JhcnkgZmlsZXMgc2hv dWxkIG5vdCBiZSBjcmVhdGVkIGluIHRoZSBjdXJyZW50IGRpcmVjdG9yeQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM1NjIKKworICAgICAgICBEb24n dCBjcmVhdGUgdGVtcG9yYXJ5IGZpbGVzIGluIHRoZSBjdXJyZW50IGRpcmVjdG9yeSwgdXNlIFFE aXI6OnRlbXBQYXRoKCkKKyAgICAgICAgaW5zdGVhZCwgYXMgc3VnZ2VzdGVkIGJ5IHRoZSBRVGVt cG9yYXJ5RmlsZSBkb2N1bWVudGF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvRmlsZVN5 c3RlbVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9wZW5UZW1wb3JhcnlGaWxlKToKKworMjAx MC0wOC0wNSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4KIAogICAgICAgICBbUXRdIENsZWFu IHVwIHRoZSBpbnB1dCBtZXRob2QgaGFuZGxpbmcKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vcXQvRmlsZVN5c3RlbVF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvRmlsZVN5c3RlbVF0 LmNwcAppbmRleCAwM2RmYzhmYmU1YWRkYjZhMWU5Njc0MzAzMzVjMjM2NGIyZDMyM2JjLi45NmMy MDkzYTQ1NzEwMjEwZTRhMTQzMjVmYThmMmJlOGU2MGRlYTA2IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1RdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9G aWxlU3lzdGVtUXQuY3BwCkBAIC0xMTYsNyArMTE2LDcgQEAgVmVjdG9yPFN0cmluZz4gbGlzdERp cmVjdG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIGNvbnN0IFN0cmluZyYgZmlsdGVyKQogQ1N0cmlu ZyBvcGVuVGVtcG9yYXJ5RmlsZShjb25zdCBjaGFyKiBwcmVmaXgsIFBsYXRmb3JtRmlsZUhhbmRs ZSYgaGFuZGxlKQogewogI2lmbmRlZiBRVF9OT19URU1QT1JBUllGSUxFCi0gICAgUVRlbXBvcmFy eUZpbGUqIHRlbXBGaWxlID0gbmV3IFFUZW1wb3JhcnlGaWxlKFFMYXRpbjFTdHJpbmcocHJlZml4 KSk7CisgICAgUVRlbXBvcmFyeUZpbGUqIHRlbXBGaWxlID0gbmV3IFFUZW1wb3JhcnlGaWxlKFFE aXI6OnRlbXBQYXRoKCkgKyBRTGF0aW4xQ2hhcignLycpICsgUUxhdGluMVN0cmluZyhwcmVmaXgp KTsKICAgICB0ZW1wRmlsZS0+c2V0QXV0b1JlbW92ZShmYWxzZSk7CiAgICAgUUZpbGUqIHRlbXAg PSB0ZW1wRmlsZTsKICAgICBpZiAodGVtcC0+b3BlbihRSU9EZXZpY2U6OlJlYWRXcml0ZSkpIHsK