43555 2010-08-05 05:54:36 -0700 Can't scroll on Bugzilla patch review pages on Mac with WebKit2 2010-09-13 19:03:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED https://bugs.webkit.org/attachment.cgi?id=63527&action=review InRadar, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned andersca eric mrowe sam oldest_to_newest 260550 0 aroben 2010-08-05 05:54:36 -0700 To reproduce: 1. Using a WebKit2 browser (like MiniBrowser), go to https://bugs.webkit.org/attachment.cgi?id=63527&action=review 2. Try to scroll either of the scrollable areas No scrolling happens! It doesn't matter if you use the mouse wheel/trackpad or use the scrollbar manually. 260551 1 aroben 2010-08-05 05:57:49 -0700 Scrolling works fine with WebKit2 on Windows. 260552 2 aroben 2010-08-05 05:58:20 -0700 <rdar://problem/8276298> 278640 3 67506 sam 2010-09-13 18:48:25 -0700 Created attachment 67506 Patch 278645 4 eric 2010-09-13 18:59:32 -0700 Attachment 67506 did not build on mac: Build output: http://queues.webkit.org/results/4042002 278647 5 sam 2010-09-13 19:03:46 -0700 Fixed in r67430. 67506 2010-09-13 18:48:25 -0700 2010-09-13 19:02:43 -0700 Patch patch.diff text/plain 4145 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzQyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMTMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW4ndCBz Y3JvbGwgb24gQnVnemlsbGEgcGF0Y2ggcmV2aWV3IHBhZ2VzIG9uIE1hYyB3aXRoIFdlYktpdDIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNTU1CisK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0MjEzODY+IFdlYktpdDI6IGdtYWlsLmNvbSBpcyBj b21wbGV0ZWx5IHVucmVzcG9uc2l2ZSB0byBjbGlja3MKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzgyNzYyOTg+IENhbid0IHNjcm9sbCBvbiBCdWd6aWxsYSBwYXRjaCByZXZpZXcgcGFnZXMgb24g TWFjIHdpdGggV2ViS2l0MiAoNDM1NTUpCisKKyAgICAgICAgKiBwYWdlL21hYy9FdmVudEhhbmRs ZXJNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnBhc3NXaGVlbEV2ZW50 VG9XaWRnZXQpOgorICAgICAgICAoV2ViQ29yZTo6ZnJhbWVIYXNQbGF0Zm9ybVdpZGdldCk6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnBhc3NNb3VzZVByZXNzRXZlbnRUb1N1YmZy YW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6cGFzc01vdXNlTW92ZUV2ZW50 VG9TdWJmcmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnBhc3NNb3VzZVJl bGVhc2VFdmVudFRvU3ViZnJhbWUpOgorICAgICAgICBBZGQgV2ViS2l0MiBtb2RlIGZvciB0aGVz ZSBmdW5jdGlvbnMgYmFzZWQgb24gdGhlIHByZXNlbmNlIG9mIGEgcGxhdGZvcm0gd2lkZ2V0IGZv ciBhCisgICAgICAgIEZyYW1lVmlldy4KKwogMjAxMC0wOS0xMyAgUGF0cmljayBHYW5zdGVyZXIg IDxwYXJvZ2FAcGFyb2dhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRl IENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tCShyZXZp c2lvbiA2NzQyOSkKKysrIFdlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC00NDcsMTQgKzQ0NywyNSBAQCBzdGF0aWMgdm9pZCBzZWxmUmV0YWluaW5n TlNTY3JvbGxWaWV3U2NyCiAgICAgICAgIFtzZWxmIHJlbGVhc2VdOwogfQogCi1ib29sIEV2ZW50 SGFuZGxlcjo6cGFzc1doZWVsRXZlbnRUb1dpZGdldChQbGF0Zm9ybVdoZWVsRXZlbnQmLCBXaWRn ZXQqIHdpZGdldCkKK2Jvb2wgRXZlbnRIYW5kbGVyOjpwYXNzV2hlZWxFdmVudFRvV2lkZ2V0KFBs YXRmb3JtV2hlZWxFdmVudCYgd2hlZWxFdmVudCwgV2lkZ2V0KiB3aWRnZXQpCiB7CiAgICAgQkVH SU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwotICAgICAgICAKLSAgICBpZiAoW2N1cnJlbnROU0V2 ZW50KCkgdHlwZV0gIT0gTlNTY3JvbGxXaGVlbCB8fCBtX3NlbmRpbmdFdmVudFRvU3VidmlldyB8 fCAhd2lkZ2V0KSAKKworICAgIGlmICghd2lkZ2V0KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICBOU1ZpZXcqIG5vZGVWaWV3ID0gd2lkZ2V0LT5wbGF0Zm9ybVdpZGdldCgpOworICAgIGlm ICghbm9kZVZpZXcpIHsKKyAgICAgICAgLy8gV2ViS2l0MiBjb2RlIHBhdGguCisgICAgICAgIGlm ICghd2lkZ2V0LT5pc0ZyYW1lVmlldygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisg ICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxGcmFtZVZpZXcqPih3aWRnZXQpLT5mcmFtZSgpLT5l dmVudEhhbmRsZXIoKS0+aGFuZGxlV2hlZWxFdmVudCh3aGVlbEV2ZW50KTsKKyAgICB9CisKKyAg ICBpZiAoW2N1cnJlbnROU0V2ZW50KCkgdHlwZV0gIT0gTlNTY3JvbGxXaGVlbCB8fCBtX3NlbmRp bmdFdmVudFRvU3VidmlldykgCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIEFTU0VSVChu b2RlVmlldyk7CiAgICAgQVNTRVJUKFtub2RlVmlldyBzdXBlcnZpZXddKTsKICAgICBOU1ZpZXcg KnZpZXcgPSBbbm9kZVZpZXcgaGl0VGVzdDpbW25vZGVWaWV3IHN1cGVydmlld10gY29udmVydFBv aW50OltjdXJyZW50TlNFdmVudCgpIGxvY2F0aW9uSW5XaW5kb3ddIGZyb21WaWV3Om5pbF1dOwpA QCAtNjE1LDE5ICs2MjYsNDkgQEAgdm9pZCBFdmVudEhhbmRsZXI6Om1vdXNlTW92ZWQoTlNFdmVu dCAqZQogICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiB9CiAKK3N0YXRpYyBib29sIGZy YW1lSGFzUGxhdGZvcm1XaWRnZXQoRnJhbWUqIGZyYW1lKQoreworICAgIGlmIChGcmFtZVZpZXcq IGZyYW1lVmlldyA9IGZyYW1lLT52aWV3KCkpIHsKKyAgICAgICAgaWYgKGZyYW1lVmlldy0+cGxh dGZvcm1XaWRnZXQoKSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgIHJl dHVybiBmYWxzZTsKK30KKwogYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NNb3VzZVByZXNzRXZlbnRU b1N1YmZyYW1lKE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmIG1ldiwgRnJhbWUqIHN1YmZy YW1lKQogewotICAgIHJldHVybiBwYXNzU3ViZnJhbWVFdmVudFRvU3ViZnJhbWUobWV2LCBzdWJm cmFtZSk7CisgICAgLy8gV2ViS2l0MSBjb2RlIHBhdGguCisgICAgaWYgKGZyYW1lSGFzUGxhdGZv cm1XaWRnZXQobV9mcmFtZSkpCisgICAgICAgIHJldHVybiBwYXNzU3ViZnJhbWVFdmVudFRvU3Vi ZnJhbWUobWV2LCBzdWJmcmFtZSkKKworICAgIC8vIFdlYktpdDIgY29kZSBwYXRoLgorICAgIHN1 YmZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VQcmVzc0V2ZW50KG1ldi5ldmVudCgp KTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NNb3VzZU1v dmVFdmVudFRvU3ViZnJhbWUoTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgbWV2LCBGcmFt ZSogc3ViZnJhbWUsIEhpdFRlc3RSZXN1bHQqIGhvdmVyZWROb2RlKQogewotICAgIHJldHVybiBw YXNzU3ViZnJhbWVFdmVudFRvU3ViZnJhbWUobWV2LCBzdWJmcmFtZSwgaG92ZXJlZE5vZGUpOwor ICAgIC8vIFdlYktpdDEgY29kZSBwYXRoLgorICAgIGlmIChmcmFtZUhhc1BsYXRmb3JtV2lkZ2V0 KG1fZnJhbWUpKQorICAgICAgICByZXR1cm4gcGFzc1N1YmZyYW1lRXZlbnRUb1N1YmZyYW1lKG1l diwgc3ViZnJhbWUsIGhvdmVyZWROb2RlKTsKKworICAgIC8vIFdlYktpdDIgY29kZSBwYXRoLgor ICAgIGlmIChtX21vdXNlRG93bk1heVN0YXJ0RHJhZyAmJiAhbV9tb3VzZURvd25XYXNJblN1YmZy YW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgc3ViZnJhbWUtPmV2ZW50SGFuZGxlcigp LT5oYW5kbGVNb3VzZU1vdmVFdmVudChtZXYuZXZlbnQoKSwgaG92ZXJlZE5vZGUpOworICAgIHJl dHVybiB0cnVlOwogfQogCiBib29sIEV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUmVsZWFzZUV2ZW50 VG9TdWJmcmFtZShNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBtZXYsIEZyYW1lKiBzdWJm cmFtZSkKIHsKLSAgICByZXR1cm4gcGFzc1N1YmZyYW1lRXZlbnRUb1N1YmZyYW1lKG1ldiwgc3Vi ZnJhbWUpOworICAgIC8vIFdlYktpdDEgY29kZSBwYXRoLgorICAgIGlmIChmcmFtZUhhc1BsYXRm b3JtV2lkZ2V0KG1fZnJhbWUpKQorICAgICAgICByZXR1cm4gcGFzc1N1YmZyYW1lRXZlbnRUb1N1 YmZyYW1lKG1ldiwgc3ViZnJhbWUpOworCisgICAgLy8gV2ViS2l0MiBjb2RlIHBhdGguCisgICAg c3ViZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVNb3VzZVJlbGVhc2VFdmVudChtZXYuZXZl bnQoKSk7CisgICAgcmV0dXJuIHRydWU7CiB9CiAKIFBsYXRmb3JtTW91c2VFdmVudCBFdmVudEhh bmRsZXI6OmN1cnJlbnRQbGF0Zm9ybU1vdXNlRXZlbnQoKSBjb25zdAo=