43548 2010-08-05 02:52:17 -0700 Allow custom memory allocation control for EventHandlingState struct 2010-08-07 22:01:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned eric oldest_to_newest 260489 0 zoltan 2010-08-05 02:52:17 -0700 Inherits the following class from FastAllocBase because it is instantiated by 'new': struct name: EventHandlingState; instantiated at: WebCore/html/HTMLInputElement.cpp:2051 260492 1 63568 zoltan 2010-08-05 02:55:12 -0700 Created attachment 63568 proposed patch 261420 2 63568 eric 2010-08-06 13:32:01 -0700 Comment on attachment 63568 proposed patch Are you using a script to find these? Could we add a script to the build system to catch these before checkin? 261424 3 zoltan 2010-08-06 13:37:27 -0700 Unfortunately, not. I'm using our static code analyzer tool called Columbus to catch these. It's a continuous work, I make analyses once a week and usually I need a little hand-check on the results before posting bugs. 261830 4 63568 eric 2010-08-07 22:01:14 -0700 Comment on attachment 63568 proposed patch Clearing flags on attachment: 63568 Committed r64936: <http://trac.webkit.org/changeset/64936> 261831 5 eric 2010-08-07 22:01:18 -0700 All reviewed patches have been landed. Closing bug. 63568 2010-08-05 02:55:12 -0700 2010-08-07 22:01:13 -0700 proposed patch eventhandling.patch text/plain 1266 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDcyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMjAgQEAKIDIwMTAtMDgtMDUgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEV2ZW50SGFuZGxpbmdT dGF0ZSBzdHJ1Y3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQzNTQ4CisKKyAgICAgICAgSW5oZXJpdHMgdGhlIGZvbGxvd2luZyBjbGFzcyBmcm9tIEZh c3RBbGxvY0Jhc2UgYmVjYXVzZSBpdCBpcworICAgICAgICBpbnN0YW50aWF0ZWQgYnkgJ25ldyc6 CisKKyAgICAgICAgc3RydWN0IG5hbWUgICAgICAgICAtIGluc3RhbnRpYXRlZCBhdDogV2ViQ29y ZS8KKyAgICAgICAgRXZlbnRIYW5kbGluZ1N0YXRlICAtIGh0bWwvSFRNTElucHV0RWxlbWVudC5j cHA6MjA1MQorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKworMjAxMC0w OC0wNSAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KIAogICAgICAgICBBbGxvdyBjdXN0b20gbWVtb3J5IGFs bG9jYXRpb24gY29udHJvbCBmb3IgQ2xpcHBlckRhdGEgc3RydWN0CkluZGV4OiBXZWJDb3JlL2h0 bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiA2NDcyMikKKysrIFdlYkNvcmUvaHRtbC9IVE1MSW5w dXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAzMCw3ICsyMDMwLDcgQEAKICAgICBy ZXR1cm4gZmFsc2U7CiB9CiAKLXN0cnVjdCBFdmVudEhhbmRsaW5nU3RhdGUgeworc3RydWN0IEV2 ZW50SGFuZGxpbmdTdGF0ZSA6IEZhc3RBbGxvY0Jhc2UgewogICAgIFJlZlB0cjxIVE1MSW5wdXRF bGVtZW50PiBtX2N1cnJSYWRpbzsKICAgICBib29sIG1faW5kZXRlcm1pbmF0ZTsKICAgICBib29s IG1fY2hlY2tlZDsK