43547 2010-08-05 02:51:56 -0700 Rebaselined a bunch of layout tests after the parser switch. 2010-08-05 10:12:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pfeldman webkit-unassigned abarth eric oldest_to_newest 260488 0 pfeldman 2010-08-05 02:51:56 -0700 Please check that this is fine. Some image diffs I don't really like... 260493 1 pfeldman 2010-08-05 02:57:03 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.txt M LayoutTests/platform/chromium-linux/fast/forms/form-element-geometry-expected.txt M LayoutTests/platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.checksum M LayoutTests/platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png M LayoutTests/platform/chromium-linux/fast/forms/text-style-color-expected.checksum M LayoutTests/platform/chromium-linux/fast/forms/text-style-color-expected.png M LayoutTests/platform/chromium-linux/fast/invalid/019-expected.checksum M LayoutTests/platform/chromium-linux/fast/invalid/019-expected.png M LayoutTests/platform/chromium-linux/fast/invalid/missing-address-end-tag-expected.checksum M LayoutTests/platform/chromium-linux/fast/invalid/missing-address-end-tag-expected.png M LayoutTests/platform/chromium-linux/fast/invalid/residual-style-expected.checksum M LayoutTests/platform/chromium-linux/fast/invalid/residual-style-expected.png M LayoutTests/platform/chromium-linux/fast/invalid/residual-style-expected.txt M LayoutTests/platform/chromium-linux/fast/invalid/table-inside-stray-table-content-expected.checksum M LayoutTests/platform/chromium-linux/fast/invalid/table-inside-stray-table-content-expected.png M LayoutTests/platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.checksum M LayoutTests/platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.png M LayoutTests/platform/chromium-linux/fonts/fantasy-expected.txt A LayoutTests/platform/chromium-linux/tables/mozilla/bugs/adforce_imgis_com-expected.txt M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.txt M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug278385-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug278385-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug48028-1-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug48028-1-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum A LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum M LayoutTests/platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt A LayoutTests/platform/chromium-mac/fast/dom/isindex-001-expected.checksum A LayoutTests/platform/chromium-mac/fast/dom/isindex-001-expected.png A LayoutTests/platform/chromium-mac/fast/forms/form-in-malformed-markup-expected.checksum A LayoutTests/platform/chromium-mac/fast/forms/form-in-malformed-markup-expected.png A LayoutTests/platform/chromium-mac/fast/forms/formmove3-expected.checksum A LayoutTests/platform/chromium-mac/fast/forms/formmove3-expected.png A LayoutTests/platform/chromium-mac/fast/forms/isindex-placeholder-expected.checksum A LayoutTests/platform/chromium-mac/fast/forms/isindex-placeholder-expected.png A LayoutTests/platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum A LayoutTests/platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png A LayoutTests/platform/chromium-mac/fast/forms/text-style-color-expected.checksum A LayoutTests/platform/chromium-mac/fast/forms/text-style-color-expected.png A LayoutTests/platform/chromium-mac/fast/invalid/019-expected.checksum A LayoutTests/platform/chromium-mac/fast/invalid/019-expected.png A LayoutTests/platform/chromium-mac/fast/invalid/missing-address-end-tag-expected.checksum A LayoutTests/platform/chromium-mac/fast/invalid/missing-address-end-tag-expected.png M LayoutTests/platform/chromium-mac/fast/invalid/residual-style-expected.checksum M LayoutTests/platform/chromium-mac/fast/invalid/residual-style-expected.png A LayoutTests/platform/chromium-mac/fast/invalid/residual-style-expected.txt A LayoutTests/platform/chromium-mac/fast/invalid/table-inside-stray-table-content-expected.checksum A LayoutTests/platform/chromium-mac/fast/invalid/table-inside-stray-table-content-expected.png A LayoutTests/platform/chromium-mac/fast/parser/remove-block-in-residual-style-expected.checksum A LayoutTests/platform/chromium-mac/fast/parser/remove-block-in-residual-style-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug278385-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug278385-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug48028-1-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug48028-1-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png A LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum A LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png M LayoutTests/platform/chromium-win/fast/block/float/float-in-float-painting-expected.txt M LayoutTests/platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt M LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.txt M LayoutTests/platform/chromium-win/fast/forms/form-added-to-table-expected.txt M LayoutTests/platform/chromium-win/fast/forms/form-element-geometry-expected.txt M LayoutTests/platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.checksum M LayoutTests/platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png M LayoutTests/platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt M LayoutTests/platform/chromium-win/fast/forms/text-style-color-expected.checksum M LayoutTests/platform/chromium-win/fast/forms/text-style-color-expected.png M LayoutTests/platform/chromium-win/fast/forms/text-style-color-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/004-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/005-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/007-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/012-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/017-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/018-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/019-expected.checksum M LayoutTests/platform/chromium-win/fast/invalid/019-expected.png M LayoutTests/platform/chromium-win/fast/invalid/019-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/missing-address-end-tag-expected.checksum M LayoutTests/platform/chromium-win/fast/invalid/missing-address-end-tag-expected.png M LayoutTests/platform/chromium-win/fast/invalid/missing-address-end-tag-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/missing-font-end-tag-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/residual-style-expected.checksum M LayoutTests/platform/chromium-win/fast/invalid/residual-style-expected.png M LayoutTests/platform/chromium-win/fast/invalid/residual-style-expected.txt M LayoutTests/platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.checksum M LayoutTests/platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.png M LayoutTests/platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt M LayoutTests/platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt M LayoutTests/platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.checksum M LayoutTests/platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.png M LayoutTests/platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.txt M LayoutTests/platform/chromium-win/fast/parser/title-error-test-expected.txt M LayoutTests/platform/chromium-win/fast/table/fixed-table-non-cell-in-row-expected.txt M LayoutTests/platform/chromium-win/fast/table/inline-form-assert-expected.txt M LayoutTests/platform/chromium-win/fast/table/insert-cell-before-form-expected.txt M LayoutTests/platform/chromium-win/fast/table/insert-row-before-form-expected.txt M LayoutTests/platform/chromium-win/fast/text/large-text-composed-char-expected.txt M LayoutTests/platform/chromium-win/fonts/cursive-expected.txt M LayoutTests/platform/chromium-win/fonts/fantasy-expected.txt M LayoutTests/platform/chromium-win/fonts/monospace-expected.txt M LayoutTests/platform/chromium-win/fonts/sans-serif-expected.txt M LayoutTests/platform/chromium-win/fonts/serif-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug138725-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug2267-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug2516-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug2516-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug2757-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug278385-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug278385-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug278385-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug30559-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug30559-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug32447-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug32447-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug32447-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug34538-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug34538-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug34538-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug4527-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug53690-2-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug78162-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug96334-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug96343-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug96343-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug96343-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum M LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png M LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt M LayoutTests/platform/chromium/test_expectations.txt Committed r64728 260503 2 pfeldman 2010-08-05 03:55:39 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/platform/chromium-linux/fast/dom/isindex-001-expected.checksum A LayoutTests/platform/chromium-linux/fast/dom/isindex-001-expected.png M LayoutTests/platform/chromium-linux/fast/dom/isindex-002-expected.checksum M LayoutTests/platform/chromium-linux/fast/dom/isindex-002-expected.png M LayoutTests/platform/chromium-linux/fast/forms/form-in-malformed-markup-expected.checksum M LayoutTests/platform/chromium-linux/fast/forms/form-in-malformed-markup-expected.png M LayoutTests/platform/chromium-linux/fast/forms/formmove3-expected.checksum M LayoutTests/platform/chromium-linux/fast/forms/formmove3-expected.png M LayoutTests/platform/chromium-linux/fast/forms/formmove3-expected.txt M LayoutTests/platform/chromium-linux/fast/forms/isindex-placeholder-expected.checksum M LayoutTests/platform/chromium-linux/fast/forms/isindex-placeholder-expected.png M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt M LayoutTests/platform/chromium-win/fast/dom/isindex-001-expected.checksum M LayoutTests/platform/chromium-win/fast/dom/isindex-001-expected.png A LayoutTests/platform/chromium-win/fast/dom/isindex-001-expected.txt M LayoutTests/platform/chromium-win/fast/dom/isindex-002-expected.checksum M LayoutTests/platform/chromium-win/fast/dom/isindex-002-expected.png M LayoutTests/platform/chromium-win/fast/dom/isindex-002-expected.txt M LayoutTests/platform/chromium-win/fast/forms/form-in-malformed-markup-expected.checksum M LayoutTests/platform/chromium-win/fast/forms/form-in-malformed-markup-expected.png M LayoutTests/platform/chromium-win/fast/forms/form-in-malformed-markup-expected.txt M LayoutTests/platform/chromium-win/fast/forms/formmove3-expected.checksum M LayoutTests/platform/chromium-win/fast/forms/formmove3-expected.png M LayoutTests/platform/chromium-win/fast/forms/formmove3-expected.txt M LayoutTests/platform/chromium-win/fast/forms/isindex-placeholder-expected.checksum M LayoutTests/platform/chromium-win/fast/forms/isindex-placeholder-expected.png M LayoutTests/platform/chromium-win/fast/forms/isindex-placeholder-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/adforce_imgis_com-expected.txt Committed r64730 260677 3 abarth 2010-08-05 10:12:19 -0700 Generally speaking, these diffs look reasonable. We spent a week analyzing the changes to the expected diffs on Mac. You're changing the same test expectations in similar ways. If there were fewer of them, I would compare the diffs to the corresponding mac diffs, but I they generally look right. Unfortunately, there are too many of them to do a thorough job. :(