43543 2010-08-05 01:43:00 -0700 Chromium: isindex tests timeout after r64712 2010-08-08 00:33:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned abarth commit-queue eric mihaip oldest_to_newest 260464 0 pfeldman 2010-08-05 01:43:00 -0700 http/tests/misc/isindex-formdata.html = TIMEOUT http/tests/misc/isindex-with-no-form-base-href.html = TEXT TIMEOUT 260619 1 pfeldman 2010-08-05 08:17:31 -0700 More timeout suppressions: BUGWK43543 DEBUG : fast/parser/residual-style-dom.html = TIMEOUT BUGWK43543 LINUX MAC DEBUG : fast/parser/residual-style-hang.html = TIMEOUT Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/chromium/test_expectations.txt Committed r64751 261742 2 63821 mihaip 2010-08-07 11:33:45 -0700 Created attachment 63821 Faster failing isindex tests 261744 3 63821 abarth 2010-08-07 11:38:20 -0700 Comment on attachment 63821 Faster failing isindex tests Thanks. 261745 4 mihaip 2010-08-07 11:41:27 -0700 I happened to be running all the layout tests with --slowest, and I noticed that isindex-with-no-form-base-href.html and isindex-formdata.html both took 30 seconds, since they trigger a DRT timeout with the HTML5 builder. The attached patch still has them fail, but in <1 second (since it actually checks for the things that are no longer there with the HTML 5 parser). Is something like this worth committing as a stopgap? As for the tests themselves, isindex-formdata.html is definitely no longer valid with the HTML5 tree builder, since <isindex> elements inside <form> is supposed to be ignored (and is tested by LayoutTests/html5lib/resources/isindex.dat), so perhaps it could be deleted altogether. isindex-with-no-form-base-href.html seems tricker, since it has a naked <isindex> element, which per http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#isindex should generate a wrapping <form> (and does). However, that form has no action attribute, and I guess pre-HTML5 builder, the generated (empty string) form action was resolved against the <base href>, but that's no longer the case. I can't find anything in the HTML5 spec that defines the behavior either way, but Adam or Eric are probably more familiar with that. 261747 5 abarth 2010-08-07 11:51:32 -0700 I think it's worth landing. The results of these tests match Minefield and the spec, as far as I can tell. 261852 6 63821 eric 2010-08-08 00:33:45 -0700 Comment on attachment 63821 Faster failing isindex tests Clearing flags on attachment: 63821 Committed r64944: <http://trac.webkit.org/changeset/64944> 261853 7 eric 2010-08-08 00:33:51 -0700 All reviewed patches have been landed. Closing bug. 63821 2010-08-07 11:33:45 -0700 2010-08-08 00:33:45 -0700 Faster failing isindex tests bug-43543-20100807113343.patch text/plain 4748 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhOGFjMDllM2RjYTk4MTcyNjcwMWM4ZmI4ZWI3YzViNmExMTcxYjdmLi5lOTk4N2Fi ODYyYmZhY2VhYmE3YzBiYmIwYjllZTFiZTVlNjk5ZTk4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDgtMDcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW06IGlz aW5kZXggdGVzdHMgdGltZW91dCBhZnRlciByNjQ3MTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNTQzCisgICAgICAgIAorICAgICAgICBVcGRhdGUg aXNpbmRleCB0ZXN0cy9leHBlY3RhY3Rpb25zIGFmdGVyIHI2NDcxMiBzbyB0aGF0IGV2ZW4gdGhv dWdoIHRoZXkKKyAgICAgICAgc3RpbCBmYWlsLCB0aGV5IGZhaWwgaW1tZWRpYXRlbHkgaW5zdGVh ZCBvZiB0aW1pbmcgb3V0LgorCisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL2lzaW5kZXgtZm9y bWRhdGEtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9pc2luZGV4LWZv cm1kYXRhLmh0bWw6CisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL2lzaW5kZXgtd2l0aC1uby1m b3JtLWJhc2UtaHJlZi1leHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL3Jl c291cmNlcy9pc2luZGV4LXdpdGgtbm8tZm9ybS1iYXNlLWhyZWYuaHRtbDoKKwogMjAxMC0wOC0w NyAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtD aHJvbWl1bV06IEFkZGVkIHBvcnQtc3BlY2lmaWMgZXhwZWN0YXRpb25zIGFmdGVyIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY0OTAxLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9taXNjL2lzaW5kZXgtZm9ybWRhdGEtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9taXNjL2lzaW5kZXgtZm9ybWRhdGEtZXhwZWN0ZWQudHh0CmluZGV4IDQ1 YjI0YTg4OThiYmNiODlmYmE4OWFkMDZkODRiY2ExYjRmNTI0YjkuLjI4ODMzNDkxZWViZTg5YmJi MTg5OTA0NTY1YjU3M2EwZDI2Y2YzOWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbWlzYy9pc2luZGV4LWZvcm1kYXRhLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL21pc2MvaXNpbmRleC1mb3JtZGF0YS1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw0 IEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMTA6IFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJl c3Npb24gJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpc2luZGV4IiknIFtudWxsXSBpcyBub3Qg YW4gb2JqZWN0LgotRkFJTDogVGltZWQgb3V0IHdhaXRpbmcgZm9yIG5vdGlmeURvbmUgdG8gYmUg Y2FsbGVkCiBUaGlzIHBhZ2UgdGVzdHMgdGhhdCB3ZSBjb3JyZWN0bHkgcHV0IHRoZSB2YWx1ZSBv ZiBhbiA8aXNpbmRleD4gZWxlbWVudCBpbnRvIHRoZSBmb3JtIGRhdGEuCiAKK0ZBSUw6IGNvdWxk IG5vdCBmaW5kIGlzaW5kZXggZWxlbWVudAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL21pc2MvaXNpbmRleC1mb3JtZGF0YS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9taXNjL2lzaW5kZXgtZm9ybWRhdGEuaHRtbAppbmRleCBjNmRhOTQ4MjZiZGRmNzE2NWEwOTY4 YzM2MzhlOGJmNWNmZTdjODViLi5lOWVjYzViYmI3ODYwZTA1MmJjM2M2MzAyMjhlMjU0ZWExYzky YTgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvaXNpbmRleC1mb3Jt ZGF0YS5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9pc2luZGV4LWZvcm1k YXRhLmh0bWwKQEAgLTcsNiArNywxMiBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKICAgICAgICAgfQogCisgICAgICAg IGlmICghZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlzaW5kZXgiKSkgeworICAgICAgICAgICAg bG9nKCJGQUlMOiBjb3VsZCBub3QgZmluZCBpc2luZGV4IGVsZW1lbnQiKTsKKyAgICAgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CiAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpc2luZGV4IikudmFsdWUgPSAi VGhpcyBpcyBhIHRlc3QiOwogICAgICAgICBkb2N1bWVudC5mb3Jtc1swXS5zdWJtaXQoKTsKICAg ICB9IGVsc2UgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2lzaW5k ZXgtd2l0aC1uby1mb3JtLWJhc2UtaHJlZi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL21pc2MvaXNpbmRleC13aXRoLW5vLWZvcm0tYmFzZS1ocmVmLWV4cGVjdGVkLnR4dApp bmRleCBlMzkwY2EwNGI1Y2EyZWZkNDRiNmM4YjE0OTU0ZTNhMjU2ZmE1ZGY5Li40NTY2MzU1M2Y1 MGVmNGZiMTUzZGQzYWNiNjA5MWUwNWQ1ZTAxNzEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL21pc2MvaXNpbmRleC13aXRoLW5vLWZvcm0tYmFzZS1ocmVmLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvaXNpbmRleC13aXRoLW5vLWZvcm0t YmFzZS1ocmVmLWV4cGVjdGVkLnR4dApAQCAtMSw5ICsxLDkgQEAKLUZBSUw6IFRpbWVkIG91dCB3 YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAogCiAKIC0tLS0tLS0tCiBGcmFtZTog JzwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+JwogLS0tLS0tLS0KK0ZBSUw6IGNvdWxk IG5vdCBmaW5kIGZvcm0gd2l0aCBleHBlY3RlZCBhY3Rpb24KIFRoaXMgcGFnZSB0ZXN0cyB0aGF0 IHdlIGNvcnJlY3RseSBwdXQgdGhlIHZhbHVlIG9mIGFuIDxpc2luZGV4PiBlbGVtZW50IGludG8g dGhlIGZvcm0gZGF0YS4KIAogSWYgeW91IGFyZSBydW5uaW5nIHRoaXMgdGVzdCBieSBoYW5kLCBw cmVzcyB0aGUgZW50ZXIvcmV0dXJuIGtleSBvbiB5b3VyIGtleWJvYXJkIHRvIHN1Ym1pdC4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZXMvaXNpbmRleC13 aXRoLW5vLWZvcm0tYmFzZS1ocmVmLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mv cmVzb3VyY2VzL2lzaW5kZXgtd2l0aC1uby1mb3JtLWJhc2UtaHJlZi5odG1sCmluZGV4IDA2YmVk ZTgzYWI3NTJmOGFiNDE2OTg5NWIzNDI5NTZkNTY1N2FkOGYuLmMyZWMwOGQ1N2NkOTlhMzg3YTBm YmJlODg0ZDJiOTFmZmIzMzBiMzQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv bWlzYy9yZXNvdXJjZXMvaXNpbmRleC13aXRoLW5vLWZvcm0tYmFzZS1ocmVmLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3Jlc291cmNlcy9pc2luZGV4LXdpdGgtbm8tZm9y bS1iYXNlLWhyZWYuaHRtbApAQCAtMiw4ICsyLDIxIEBACiA8aGVhZD4KIDxiYXNlIGhyZWY9Imh0 dHA6Ly9sb2NhbGhvc3Q6ODAwMC9taXNjL3Jlc291cmNlcy9pc2luZGV4LXdpdGgtbm8tZm9ybS1i YXNlLWhyZWYtc3VibWl0Lmh0bWwiPgogPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtc2cpCit7Cisg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNy ZWF0ZVRleHROb2RlKG1zZyArICJcbiIpKTsKK30KKwogZnVuY3Rpb24gdGVzdCgpCiB7CisgICAg dmFyIGZvcm1zID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2Zvcm0nKTsKKyAgICBp ZiAoZm9ybXMubGVuZ3RoICE9IDEgfHwgZm9ybXNbMF0uYWN0aW9uICE9ICdodHRwOi8vbG9jYWxo b3N0OjgwMDAvbWlzYy9yZXNvdXJjZXMvaXNpbmRleC13aXRoLW5vLWZvcm0tYmFzZS1ocmVmLXN1 Ym1pdC5odG1sJykgeworICAgICAgICBsb2coJ0ZBSUw6IGNvdWxkIG5vdCBmaW5kIGZvcm0gd2l0 aCBleHBlY3RlZCBhY3Rpb24nKTsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAg ICB9CisKKwogICAgIHZhciBpc2luZGV4RWxtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlz aW5kZXgiKTsKICAgICBpc2luZGV4RWxtLnZhbHVlID0gIlRoaXMgaXMgYSB0ZXN0IjsKICAgICBp c2luZGV4RWxtLmZvY3VzKCk7CkBAIC0xNiw2ICsyOSw3IEBAIHdpbmRvdy5vbmxvYWQgPSB0ZXN0 OwogPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KKzxwcmUgaWQ9ImxvZyI+PC9wcmU+CiA8cD5U aGlzIHBhZ2UgdGVzdHMgdGhhdCB3ZSBjb3JyZWN0bHkgcHV0IHRoZSB2YWx1ZSBvZiBhbiA8dHQ+ Jmx0O2lzaW5kZXgmZ3Q7PC90dD4gZWxlbWVudCBpbnRvIHRoZSBmb3JtIGRhdGEuPC9wPgogPHA+ SWYgeW91IGFyZSBydW5uaW5nIHRoaXMgdGVzdCBieSBoYW5kLCBwcmVzcyB0aGUgZW50ZXIvcmV0 dXJuIGtleSBvbiB5b3VyIGtleWJvYXJkIHRvIHN1Ym1pdC48L3A+CiA8aXNpbmRleCBpZD0iaXNp bmRleCI+PC9pc2luZGV4Pgo=