43542 2010-08-05 00:16:04 -0700 [chromium] WidgetChromium does not need to notify the ChromeClient when it gets focused 2010-08-07 21:48:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned eric oldest_to_newest 260448 0 jcivelli 2010-08-05 00:16:04 -0700 WidgetChromium notifies the ChromeClient (via the ChromiumBridge) of every setFocus call. This is called every time a new node gets focused and is not used. (There is a ChromeClient::focusedNodeChange() that notifies every time a new node gets focused.) Calls to window.focus()/blur() are directly passed to the ChromeClient in WebCore/Chrome.cpp. For these reasons WidgetChromium::setFocus() should not do anything and the corresponding code in ChromiumBridge should be cleaned. 260450 1 63562 jcivelli 2010-08-05 00:23:13 -0700 Created attachment 63562 Initial patch 261485 2 63562 eric 2010-08-06 14:43:14 -0700 Comment on attachment 63562 Initial patch Yay! 261826 3 63562 eric 2010-08-07 21:48:06 -0700 Comment on attachment 63562 Initial patch Clearing flags on attachment: 63562 Committed r64935: <http://trac.webkit.org/changeset/64935> 261827 4 eric 2010-08-07 21:48:10 -0700 All reviewed patches have been landed. Closing bug. 63562 2010-08-05 00:23:13 -0700 2010-08-07 21:48:05 -0700 Initial patch focus_clean.patch text/plain 2758 jcivelli SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY0NzE3KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0wNSAgSmF5IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0Nocm9taXVtXSBSZW1vdmUgdW5lY2Vzc2FyeSBmb2N1cyBjb2RlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM1NDIKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmg6CisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vV2lkZ2V0Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpzZXRG b2N1cyk6CisKIDIwMTAtMDgtMDQgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmgNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmgJKHJldmlzaW9uIDY0NTI1 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bUJyaWRnZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNjAsNyArMjYwLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAg IC8vIFdpZGdldCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiAgICAgICAgIHN0YXRpYyB2b2lkIHdpZGdldFNldEN1cnNvcihXaWRn ZXQqLCBjb25zdCBDdXJzb3ImKTsKLSAgICAgICAgc3RhdGljIHZvaWQgd2lkZ2V0U2V0Rm9jdXMo V2lkZ2V0Kik7CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9XaWRnZXRDaHJvbWl1bS5jcHANCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1dpZGdldENocm9taXVtLmNwcAkocmV2aXNpb24gNjQ1 MjUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1dpZGdldENocm9taXVtLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjUsOCArNjUsNiBAQCB2b2lkIFdpZGdldDo6cGFpbnQoR3JhcGhpY3ND b250ZXh0KiwgY29uCiAKIHZvaWQgV2lkZ2V0OjpzZXRGb2N1cyhib29sIGZvY3VzZWQpCiB7Ci0g ICAgaWYgKGZvY3VzZWQpCi0gICAgICAgIENocm9taXVtQnJpZGdlOjp3aWRnZXRTZXRGb2N1cyh0 aGlzKTsKIH0KIAogdm9pZCBXaWRnZXQ6OnNldElzU2VsZWN0ZWQoYm9vbCkKSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCShyZXZpc2lvbiA2NDcxNykKKysrIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOC0wNSAgSmF5IENpdmVsbGkgIDxq Y2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZlZCB1bmVjZXNzYXJ5IGZvY3VzIGNvZGUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzU0MgorCisgICAgICAgICog c3JjL0Nocm9taXVtQnJpZGdlLmNwcDoKKwogMjAxMC0wOC0wMiAgS2VubmV0aCBSdXNzZWxsICA8 a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bUJyaWRnZS5jcHANCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcAkocmV2aXNpb24gNjQ1 MjUpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODYyLDEzICs4NjIsNiBAQCB2b2lkIENocm9taXVtQnJpZGdlOjp3aWRnZXRTZXRD dXJzb3IoV2lkCiAgICAgICAgIGNsaWVudC0+c2V0Q3Vyc29yKFdlYkN1cnNvckluZm8oY3Vyc29y KSk7CiB9CiAKLXZvaWQgQ2hyb21pdW1CcmlkZ2U6OndpZGdldFNldEZvY3VzKFdpZGdldCogd2lk Z2V0KQotewotICAgIENocm9tZUNsaWVudEltcGwqIGNsaWVudCA9IHRvQ2hyb21lQ2xpZW50SW1w bCh3aWRnZXQpOwotICAgIGlmIChjbGllbnQpCi0gICAgICAgIGNsaWVudC0+Zm9jdXMoKTsKLX0K LQogV29ya2VyQ29udGV4dFByb3h5KiBXb3JrZXJDb250ZXh0UHJveHk6OmNyZWF0ZShXb3JrZXIq IHdvcmtlcikKIHsKICAgICByZXR1cm4gV2ViV29ya2VyQ2xpZW50SW1wbDo6Y3JlYXRlV29ya2Vy Q29udGV4dFByb3h5KHdvcmtlcik7Cg==