43534 2010-08-04 19:50:18 -0700 Remove superfluous non-negative checks in HitTestResult:padding{Width|Height} 2010-08-24 02:50:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo hausmann hyatt steveblock oldest_to_newest 260348 0 tonikitoo 2010-08-04 19:50:18 -0700 As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 , the non-negative checks present in both paddingWidth and paddingHeight methods of HitTestResults class are superflous, after we changed the rect based hit testing logic of invalid padding from IntSize(-1, -1) to IntSize(0, 0). I missed updating these two method while addressing last hyatt's reviews. Patch coming. 260350 1 63536 tonikitoo 2010-08-04 19:55:25 -0700 Created attachment 63536 (committed with r64705, r=daniel bates) patch v1 260354 2 63536 dbates 2010-08-04 20:14:04 -0700 Comment on attachment 63536 (committed with r64705, r=daniel bates) patch v1 Looks sane to me. r=me. 260362 3 63536 tonikitoo 2010-08-04 20:29:33 -0700 Comment on attachment 63536 (committed with r64705, r=daniel bates) patch v1 Clearing flags on attachment: 63536 Committed r64705: <http://trac.webkit.org/changeset/64705> 268397 4 hausmann 2010-08-24 01:39:11 -0700 Revision r64705 cherry-picked into qtwebkit-2.1 with commit 40071b732cbe2fe02f738c04d01da6e35ba84bac 63536 2010-08-04 19:55:25 -0700 2010-08-04 20:29:33 -0700 (committed with r64705, r=daniel bates) patch v1 0001-2010-08-04-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 3041 tonikitoo RnJvbSA1MTFiYzViY2UzYzVjYTk4NTFhMmU0ZTkyZjk2ODMzMDJkMDIxOTM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCA0IEF1ZyAyMDEwIDIyOjUzOjA3IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAx MC0wOC0wNCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgoKICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUmVtb3ZlIHN1cGVyZmx1b3VzIG5v bi1uZWdhdGl2ZSBjaGVja3MgaW4gSGl0VGVzdFJlc3VsdDpwYWRkaW5ne1dpZHRofEhlaWdodH0K ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM1MzQKCiAg ICAgICAgQXMgcG9pbnRlZCBvdXQgYnkgU3RldmUgQmxvY2sgaW4gaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMTk3I2M1NCAsCiAgICAgICAgdGhlIG5vbi1uZWdhdGl2 ZSBjaGVja3MgcHJlc2VudCBpbiBib3RoIHBhZGRpbmdXaWR0aCBhbmQgcGFkZGluZ0hlaWdodCBt ZXRob2RzIG9mCiAgICAgICAgSGl0VGVzdFJlc3VsdHMgY2xhc3MgYXJlIHN1cGVyZmxvdXMsIGFm dGVyIHdlIGNoYW5nZWQgdGhlIHJlY3QgYmFzZWQgaGl0IHRlc3RpbmcgbG9naWMKICAgICAgICBv ZiBpbnZhbGlkIHBhZGRpbmcgZnJvbSBJbnRTaXplKC0xLCAtMSkgdG8gSW50U2l6ZSgwLCAwKS4g UGF0Y2ggYWRkcmVzc2VzIHRoaXMgaXNzdWUuCgogICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQu CgogICAgICAgICogcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuaDoKICAgICAgICAoV2ViQ29yZTo6 SGl0VGVzdFJlc3VsdDo6cGFkZGluZ1dpZHRoKToKICAgICAgICAoV2ViQ29yZTo6SGl0VGVzdFJl c3VsdDo6cGFkZGluZ0hlaWdodCk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIFdlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RS ZXN1bHQuaCB8ICAgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggMzY1NjYyYy4uZGI1ZGZiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOC0w NCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBzdXBlcmZsdW91cyBub24t bmVnYXRpdmUgY2hlY2tzIGluIEhpdFRlc3RSZXN1bHQ6cGFkZGluZ3tXaWR0aHxIZWlnaHR9Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzUzNAorCisg ICAgICAgIEFzIHBvaW50ZWQgb3V0IGJ5IFN0ZXZlIEJsb2NrIGluIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDE5NyNjNTQgLAorICAgICAgICB0aGUgbm9uLW5lZ2F0 aXZlIGNoZWNrcyBwcmVzZW50IGluIGJvdGggcGFkZGluZ1dpZHRoIGFuZCBwYWRkaW5nSGVpZ2h0 IG1ldGhvZHMgb2YKKyAgICAgICAgSGl0VGVzdFJlc3VsdHMgY2xhc3MgYXJlIHN1cGVyZmxvdXMs IGFmdGVyIHdlIGNoYW5nZWQgdGhlIHJlY3QgYmFzZWQgaGl0IHRlc3RpbmcgbG9naWMKKyAgICAg ICAgb2YgaW52YWxpZCBwYWRkaW5nIGZyb20gSW50U2l6ZSgtMSwgLTEpIHRvIEludFNpemUoMCwg MCkuIFBhdGNoIGFkZHJlc3NlcyB0aGlzIGlzc3VlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBu ZWVkZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5oOgorICAgICAgICAo V2ViQ29yZTo6SGl0VGVzdFJlc3VsdDo6cGFkZGluZ1dpZHRoKToKKyAgICAgICAgKFdlYkNvcmU6 OkhpdFRlc3RSZXN1bHQ6OnBhZGRpbmdIZWlnaHQpOgorCiAyMDEwLTA4LTA0ICBHYXZpbiBCYXJy YWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5o IGIvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5oCmluZGV4IGY0N2UyYTUuLmUwZmZl NTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuaAorKysgYi9X ZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmgKQEAgLTg2LDggKzg2LDggQEAgcHVibGlj OgogICAgIEludFJlY3QgcmVjdEZyb21Qb2ludChpbnQgeCwgaW50IHkpIGNvbnN0OwogICAgIElu dFJlY3QgcmVjdEZyb21Qb2ludChjb25zdCBJbnRQb2ludCYpIGNvbnN0OwogICAgIEludFNpemUg cGFkZGluZygpIGNvbnN0IHsgcmV0dXJuIG1fcGFkZGluZzsgfQotICAgIGludCBwYWRkaW5nV2lk dGgoKSBjb25zdCB7IHJldHVybiBtX3BhZGRpbmcud2lkdGgoKSA+PSAwID8gbV9wYWRkaW5nLndp ZHRoKCkgOiAwOyB9Ci0gICAgaW50IHBhZGRpbmdIZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX3Bh ZGRpbmcuaGVpZ2h0KCkgPj0gMCA/IG1fcGFkZGluZy5oZWlnaHQoKSA6IDA7IH0KKyAgICBpbnQg cGFkZGluZ1dpZHRoKCkgY29uc3QgeyByZXR1cm4gbV9wYWRkaW5nLndpZHRoKCk7IH0KKyAgICBp bnQgcGFkZGluZ0hlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFkZGluZy5oZWlnaHQoKTsgfQog ICAgIC8vIFJldHVybnMgdHJ1ZSBpZiBpdCBpcyByZWN0LWJhc2VkIGhpdCB0ZXN0IGFuZCBuZWVk cyB0byBjb250aW51ZSB1bnRpbCB0aGUgcmVjdCBpcyBmdWxseQogICAgIC8vIGVuY2xvc2VkIGJ5 IHRoZSBib3VuZGFyaWVzIG9mIGEgbm9kZS4KICAgICBib29sIGFkZE5vZGVUb1JlY3RCYXNlZFRl c3RSZXN1bHQoTm9kZSosIGludCB4LCBpbnQgeSwgY29uc3QgSW50UmVjdCYgcmVjdCA9IEludFJl Y3QoKSk7Ci0tIAoxLjcuMC40Cgo=