43530 2010-08-04 18:39:35 -0700 [Qt] Input mode states are not reset after entering a password field 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 david.leong webkit-unassigned david.leong hausmann laszlo.gombos oldest_to_newest 260322 0 david.leong 2010-08-04 18:39:35 -0700 In Qt's implementation of void EditorClientQt::setInputMethodState(bool active), the specific input type is updated based on the input element type attribute to specify vkb handling for number, password or other special input modes. There is a bug in this function where upon entering a password text field the input hit would be set correctly to 'hidden', but entering subsequent normal input elements the state would be stuck in the 'hidden' mode. There are other manifestations of the bug depending on the type of the text field previously entered. The fix is to reset the input method hints whenever EditorClientQt::setInputMethodState(). I will post up a patch as soon as possible. 260323 1 david.leong 2010-08-04 18:52:03 -0700 Made a small mistake with the description., the use case is clicking a <input type='password'> field, which sets the input mode to 'hidden'. Next click on a <textarea> and the text area input will be stuck in the password mode. 260330 2 63528 david.leong 2010-08-04 19:11:02 -0700 Created attachment 63528 proposed change to reset input modes The bug happens when the user clicks on a input field with a specific type then clicking on a text area. Because the input hints are never reset the text area inherits the wrong input hints. The fix is to reset the state and set all flags from scratch. 260358 3 laszlo.gombos 2010-08-04 20:21:12 -0700 Looks good to me. 260458 4 63528 hausmann 2010-08-05 01:03:10 -0700 Comment on attachment 63528 proposed change to reset input modes r=me. I'll land it manually together with a unit test. 260476 5 hausmann 2010-08-05 02:20:07 -0700 Committed r64725: <http://trac.webkit.org/changeset/64725> 260479 6 hausmann 2010-08-05 02:22:06 -0700 cherry-picked into qtwebkit-4.6 with commit bbff6182e525fcf58dbc7426a1fbbf8f31588214 260543 7 hausmann 2010-08-05 05:42:59 -0700 Revision r64725 cherry-picked into qtwebkit-2.1 with commit b0aea678e59f43c4fcc556d736da887452be5aad 260545 8 hausmann 2010-08-05 05:44:59 -0700 Revision r64725 cherry-picked into qtwebkit-2.0 with commit 31fc031c76110f1e7d8626d930559a8b5f6c8e1d 63528 2010-08-04 19:11:02 -0700 2010-08-05 01:03:10 -0700 proposed change to reset input modes 43530.patch text/plain 1811 david.leong SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjQ3MDMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMDQgIERhdmlkIExlb25nICA8ZGF2aWQubGVv bmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gSW5wdXQgbW9kZSBzdGF0ZXMgYXJlIG5vdCByZXNldCBhZnRlciBlbnRlcmlu ZyBhIHBhc3N3b3JkIGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MzUzMAorCisgICAgICAgIElucHV0IG1vZGUgaGludHMgYXJlIG5vdCByZXNl dCBpZiBjbGlja2luZyBvbiBwYXNzd29yZCA8aW5wdXQ+IGVsZW1lbnRzIHRoZW4gCisgICAgICAg IGNsaWNraW5nIG9uIDx0ZXh0YXJlYT4gZWxlbWVudHMKKyAgICAgICAgICAgICAgICAKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpFZGl0b3JDbGllbnRRdDo6c2V0SW5wdXRNZXRob2RTdGF0ZSk6CisKIDIwMTAtMDgtMDQgIFBp ZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQW50b25pbyBHb21lcy4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRv ckNsaWVudFF0LmNwcAkocmV2aXNpb24gNjQ2NTkpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRWRpdG9yQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OTYsNiArNTk2LDEzIEBA IHZvaWQgRWRpdG9yQ2xpZW50UXQ6OnNldElucHV0TWV0aG9kU3RhdGUKICAgICBRV2ViUGFnZUNs aWVudCogd2ViUGFnZUNsaWVudCA9IG1fcGFnZS0+ZC0+Y2xpZW50OwogICAgIGlmICh3ZWJQYWdl Q2xpZW50KSB7CiAjaWYgUVRfVkVSU0lPTiA+PSAweDA0MDYwMAorICAgICAgICAvLyBNYWtlIHN1 cmUgdG8gcmVzZXQgaW5wdXQgbWV0aG9kIGhpbnQKKyAgICAgICAgd2ViUGFnZUNsaWVudC0+c2V0 SW5wdXRNZXRob2RIaW50KFF0OjpJbWhEaWFsYWJsZUNoYXJhY3RlcnNPbmx5LCBmYWxzZSk7Cisg ICAgICAgIHdlYlBhZ2VDbGllbnQtPnNldElucHV0TWV0aG9kSGludChRdDo6SW1oRGlnaXRzT25s eSwgZmFsc2UpOworICAgICAgICB3ZWJQYWdlQ2xpZW50LT5zZXRJbnB1dE1ldGhvZEhpbnQoUXQ6 OkltaEVtYWlsQ2hhcmFjdGVyc09ubHksIGZhbHNlKTsKKyAgICAgICAgd2ViUGFnZUNsaWVudC0+ c2V0SW5wdXRNZXRob2RIaW50KFF0OjpJbWhVcmxDaGFyYWN0ZXJzT25seSwgZmFsc2UpOworICAg ICAgICB3ZWJQYWdlQ2xpZW50LT5zZXRJbnB1dE1ldGhvZEhpbnQoUXQ6OkltaEhpZGRlblRleHQs IGZhbHNlKTsKKwogICAgICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dEVsZW1lbnQgPSAwOwog ICAgICAgICBGcmFtZSogZnJhbWUgPSBtX3BhZ2UtPmQtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigp LT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKICAgICAgICAgaWYgKGZyYW1lICYmIGZyYW1lLT5kb2N1 bWVudCgpICYmIGZyYW1lLT5kb2N1bWVudCgpLT5mb2N1c2VkTm9kZSgpKQo=