43518 2010-08-04 16:15:52 -0700 [Qt][QtTestBrowser] Remove unneeded QAction class members 2010-08-04 17:27:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 tonikitoo tonikitoo oldest_to_newest 260263 0 tonikitoo 2010-08-04 16:15:52 -0700 LauncherWindow class has two totally unneeded class members: m_flopAnimated and m_flipYAnimated. Also, in initializeView method there are some dead code block trying to connect them at the wrong time, when they have not been instanciated. 260272 1 63511 tonikitoo 2010-08-04 16:38:53 -0700 Created attachment 63511 (committed with r64694, r=kenneth) patch This patch: - removes the two cited class members in favor of local variables in createChrome method; - removes the dead code block. 260293 2 63511 tonikitoo 2010-08-04 17:26:48 -0700 Comment on attachment 63511 (committed with r64694, r=kenneth) patch Clearing flags on attachment: 63511 Committed r64694: <http://trac.webkit.org/changeset/64694> 63511 2010-08-04 16:38:53 -0700 2010-08-04 17:26:48 -0700 (committed with r64694, r=kenneth) patch 0001-2010-08-04-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 5492 tonikitoo RnJvbSBjYjNlYzk3ZjNkODg1MjRkYzI3MTA1NTZhMmFhMWE0ZjBhYWU1M2I4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCA0IEF1ZyAyMDEwIDE3OjEwOjE0IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAx MC0wOC0wNCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgoKICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW1F0XSBbUXRUZXN0QnJvd3Nlcl0g UmVtb3ZlIHVubmVlZGVkIFFBY3Rpb24gY2xhc3MgbWVtYmVycwoKICAgICAgICBMYXVuY2hlcldp bmRvdyBjbGFzcyBoYXMgdHdvIHRvdGFsbHkgdW5uZWVkZWQgY2xhc3MgbWVtYmVyczogbV9mbG9w QW5pbWF0ZWQgYW5kCiAgICAgICAgbV9mbGlwWUFuaW1hdGVkLiBBbHNvLCBpbiBpbml0aWFsaXpl VmlldyBtZXRob2QgdGhlcmUgYXJlIHNvbWUgZGVhZCBjb2RlIGJsb2NrCiAgICAgICAgdHJ5aW5n IHRvIGNvbm5lY3QgdGhlbSBhdCB0aGUgd3JvbmcgdGltZSwgd2hlbiB0aGV5IGhhdmUgbm90IGJl ZW4gaW5zdGFuY2lhdGVkLgoKICAgICAgICBUaGlzIHBhdGNoOgoKICAgICAgICAtIHJlbW92ZXMg dGhlIHR3byBjaXRlZCBjbGFzcyBtZW1iZXJzIGluIGZhdm9yIG9mIGxvY2FsIHZhcmlhYmxlcyBp biBjcmVhdGVDaHJvbWUgbWV0aG9kOwogICAgICAgIC0gcmVtb3ZlcyB0aGUgZGVhZCBjb2RlIGJs b2NrLgoKICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwOgogICAgICAg IChMYXVuY2hlcldpbmRvdzo6TGF1bmNoZXJXaW5kb3cpOgogICAgICAgIChMYXVuY2hlcldpbmRv dzo6aW5pdGlhbGl6ZVZpZXcpOgogICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21l KToKICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaDoKLS0tCiBXZWJLaXRU b29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjEgKysrKysrKysrKysr KysrKysrKysrCiBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcCB8 ICAgMjQgKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiBXZWJLaXRUb29scy9RdFRlc3RCcm93c2Vy L2xhdW5jaGVyd2luZG93LmggICB8ICAgIDIgLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0 aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQwMGY4YzQuLmRmZDVhMTEgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cK QEAgLTEsNSArMSwyNiBAQAogMjAxMC0wOC0wNCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3 ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtRdF0gW1F0VGVzdEJyb3dzZXJdIFJlbW92ZSB1bm5lZWRlZCBRQWN0aW9uIGNsYXNzIG1l bWJlcnMKKworICAgICAgICBMYXVuY2hlcldpbmRvdyBjbGFzcyBoYXMgdHdvIHRvdGFsbHkgdW5u ZWVkZWQgY2xhc3MgbWVtYmVyczogbV9mbG9wQW5pbWF0ZWQgYW5kCisgICAgICAgIG1fZmxpcFlB bmltYXRlZC4gQWxzbywgaW4gaW5pdGlhbGl6ZVZpZXcgbWV0aG9kIHRoZXJlIGFyZSBzb21lIGRl YWQgY29kZSBibG9jaworICAgICAgICB0cnlpbmcgdG8gY29ubmVjdCB0aGVtIGF0IHRoZSB3cm9u ZyB0aW1lLCB3aGVuIHRoZXkgaGF2ZSBub3QgYmVlbiBpbnN0YW5jaWF0ZWQuCisKKyAgICAgICAg VGhpcyBwYXRjaDoKKworICAgICAgICAtIHJlbW92ZXMgdGhlIHR3byBjaXRlZCBjbGFzcyBtZW1i ZXJzIGluIGZhdm9yIG9mIGxvY2FsIHZhcmlhYmxlcyBpbiBjcmVhdGVDaHJvbWUgbWV0aG9kOwor ICAgICAgICAtIHJlbW92ZXMgdGhlIGRlYWQgY29kZSBibG9jay4KKworICAgICAgICAqIFF0VGVz dEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6Okxh dW5jaGVyV2luZG93KToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojppbml0aWFsaXplVmlldyk6 CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKToKKyAgICAgICAgKiBRdFRl c3RCcm93c2VyL2xhdW5jaGVyd2luZG93Lmg6CisKKzIwMTAtMDgtMDQgIEFudG9uaW8gR29tZXMg IDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVz bWFubiBhbmQgS2VubmV0aCBDaHJpc3RpYW5zZW4uCiAKICAgICAgICAgW1F0XSBbUXRUZXN0QnJv d3Nlcl0gQ2xlYW4gdXAgc3RhdGljIGFuZCBnbG9iYWwgbWVudSBzdGF0ZSBjb250cm9scwpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAgYi9X ZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAppbmRleCA0YWNmMmYw Li4xZDZjNzk5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVy d2luZG93LmNwcAorKysgYi9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93 LmNwcApAQCAtNDAsOCArNDAsNiBAQCBMYXVuY2hlcldpbmRvdzo6TGF1bmNoZXJXaW5kb3coV2lu ZG93T3B0aW9ucyogZGF0YSwgUUdyYXBoaWNzU2NlbmUqIHNoYXJlZFNjZW5lKQogICAgICwgbV92 aWV3KDApCiAgICAgLCBtX2luc3BlY3RvcigwKQogICAgICwgbV9mb3JtYXRNZW51QWN0aW9uKDAp Ci0gICAgLCBtX2ZsaXBBbmltYXRlZCgwKQotICAgICwgbV9mbGlwWUFuaW1hdGVkKDApCiAjaWYg UVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDQsIDYsIDApCiAgICAgLCBtX3pvb21Bbmlt YXRpb24oMCkKICNlbmRpZgpAQCAtMTE2LDEyICsxMTQsNiBAQCB2b2lkIExhdW5jaGVyV2luZG93 Ojppbml0aWFsaXplVmlldygpCiAgICAgICAgIFdlYlZpZXdHcmFwaGljc0Jhc2VkKiB2aWV3ID0g bmV3IFdlYlZpZXdHcmFwaGljc0Jhc2VkKHNwbGl0dGVyKTsKICAgICAgICAgdmlldy0+c2V0UGFn ZShwYWdlKCkpOwogCi0gICAgICAgIGlmIChtX2ZsaXBBbmltYXRlZCkKLSAgICAgICAgICAgIGNv bm5lY3QobV9mbGlwQW5pbWF0ZWQsIFNJR05BTCh0cmlnZ2VyZWQoKSksIHZpZXcsIFNMT1QoYW5p bWF0ZWRGbGlwKCkpKTsKLQotICAgICAgICBpZiAobV9mbGlwWUFuaW1hdGVkKQotICAgICAgICAg ICAgY29ubmVjdChtX2ZsaXBZQW5pbWF0ZWQsIFNJR05BTCh0cmlnZ2VyZWQoKSksIHZpZXcsIFNM T1QoYW5pbWF0ZWRZRmxpcCgpKSk7Ci0KICAgICAgICAgY29ubmVjdCh2aWV3LCBTSUdOQUwoY3Vy cmVudEZQU1VwZGF0ZWQoaW50KSksIHRoaXMsIFNMT1QodXBkYXRlRlBTKGludCkpKTsKIAogICAg ICAgICB2aWV3LT5pbnN0YWxsRXZlbnRGaWx0ZXIodGhpcyk7CkBAIC0zMjIsMTggKzMxNCwxOCBA QCB2b2lkIExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogCiAgICAgZ3JhcGhpY3NWaWV3 TWVudS0+YWRkU2VwYXJhdG9yKCk7CiAKLSAgICBtX2ZsaXBBbmltYXRlZCA9IGdyYXBoaWNzVmll d01lbnUtPmFkZEFjdGlvbigiQW5pbWF0ZWQgRmxpcCIpOwotICAgIG1fZmxpcEFuaW1hdGVkLT5j b25uZWN0KHRvZ2dsZUdyYXBoaWNzVmlldywgU0lHTkFMKHRvZ2dsZWQoYm9vbCkpLCBTTE9UKHNl dEVuYWJsZWQoYm9vbCkpKTsKLSAgICBtX2ZsaXBBbmltYXRlZC0+c2V0RW5hYmxlZChpc0dyYXBo aWNzQmFzZWQoKSk7CisgICAgUUFjdGlvbiogZmxpcEFuaW1hdGVkID0gZ3JhcGhpY3NWaWV3TWVu dS0+YWRkQWN0aW9uKCJBbmltYXRlZCBGbGlwIik7CisgICAgZmxpcEFuaW1hdGVkLT5jb25uZWN0 KHRvZ2dsZUdyYXBoaWNzVmlldywgU0lHTkFMKHRvZ2dsZWQoYm9vbCkpLCBTTE9UKHNldEVuYWJs ZWQoYm9vbCkpKTsKKyAgICBmbGlwQW5pbWF0ZWQtPnNldEVuYWJsZWQoaXNHcmFwaGljc0Jhc2Vk KCkpOwogCi0gICAgbV9mbGlwWUFuaW1hdGVkID0gZ3JhcGhpY3NWaWV3TWVudS0+YWRkQWN0aW9u KCJBbmltYXRlZCBZLUZsaXAiKTsKLSAgICBtX2ZsaXBZQW5pbWF0ZWQtPmNvbm5lY3QodG9nZ2xl R3JhcGhpY3NWaWV3LCBTSUdOQUwodG9nZ2xlZChib29sKSksIFNMT1Qoc2V0RW5hYmxlZChib29s KSkpOwotICAgIG1fZmxpcFlBbmltYXRlZC0+c2V0RW5hYmxlZChpc0dyYXBoaWNzQmFzZWQoKSk7 CisgICAgUUFjdGlvbiogZmxpcFlBbmltYXRlZCA9IGdyYXBoaWNzVmlld01lbnUtPmFkZEFjdGlv bigiQW5pbWF0ZWQgWS1GbGlwIik7CisgICAgZmxpcFlBbmltYXRlZC0+Y29ubmVjdCh0b2dnbGVH cmFwaGljc1ZpZXcsIFNJR05BTCh0b2dnbGVkKGJvb2wpKSwgU0xPVChzZXRFbmFibGVkKGJvb2wp KSk7CisgICAgZmxpcFlBbmltYXRlZC0+c2V0RW5hYmxlZChpc0dyYXBoaWNzQmFzZWQoKSk7CiAK ICAgICBpZiAoaXNHcmFwaGljc0Jhc2VkKCkpIHsKICAgICAgICAgV2ViVmlld0dyYXBoaWNzQmFz ZWQqIHZpZXcgPSBzdGF0aWNfY2FzdDxXZWJWaWV3R3JhcGhpY3NCYXNlZCo+KG1fdmlldyk7Ci0g ICAgICAgIGNvbm5lY3QobV9mbGlwQW5pbWF0ZWQsIFNJR05BTCh0cmlnZ2VyZWQoKSksIHZpZXcs IFNMT1QoYW5pbWF0ZWRGbGlwKCkpKTsKLSAgICAgICAgY29ubmVjdChtX2ZsaXBZQW5pbWF0ZWQs IFNJR05BTCh0cmlnZ2VyZWQoKSksIHZpZXcsIFNMT1QoYW5pbWF0ZWRZRmxpcCgpKSk7CisgICAg ICAgIGNvbm5lY3QoZmxpcEFuaW1hdGVkLCBTSUdOQUwodHJpZ2dlcmVkKCkpLCB2aWV3LCBTTE9U KGFuaW1hdGVkRmxpcCgpKSk7CisgICAgICAgIGNvbm5lY3QoZmxpcFlBbmltYXRlZCwgU0lHTkFM KHRyaWdnZXJlZCgpKSwgdmlldywgU0xPVChhbmltYXRlZFlGbGlwKCkpKTsKICAgICB9CiAKICAg ICBRQWN0aW9uKiBjbG9uZVdpbmRvdyA9IGdyYXBoaWNzVmlld01lbnUtPmFkZEFjdGlvbigiQ2xv bmUgV2luZG93IiwgdGhpcywgU0xPVChjbG9uZVdpbmRvdygpKSk7CmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmggYi9XZWJLaXRUb29scy9RdFRl c3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKaW5kZXggOTU5NTkwMS4uOWVmZWUxZSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCisrKyBiL1dl YktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaApAQCAtMTk1LDggKzE5NSw2 IEBAIHByaXZhdGU6CiAgICAgV2luZG93T3B0aW9ucyBtX3dpbmRvd09wdGlvbnM7CiAKICAgICBR QWN0aW9uKiBtX2Zvcm1hdE1lbnVBY3Rpb247Ci0gICAgUUFjdGlvbiogbV9mbGlwQW5pbWF0ZWQ7 Ci0gICAgUUFjdGlvbiogbV9mbGlwWUFuaW1hdGVkOwogCiAjaWYgUVRfVkVSU0lPTiA+PSBRVF9W RVJTSU9OX0NIRUNLKDQsIDYsIDApCiAgICAgUVByb3BlcnR5QW5pbWF0aW9uKiBtX3pvb21Bbmlt YXRpb247Ci0tIAoxLjcuMC40Cgo=