43514 2010-08-04 15:19:14 -0700 Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER for MIPS 2010-08-05 17:42:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 fu webkit-unassigned commit-queue oldest_to_newest 260237 0 fu 2010-08-04 15:19:14 -0700 Hi, MIPS needs to define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER, so that RenderArena::allocate() can return 8-byte aligned memory to avoid exceptions on sdc1/ldc1. This is similar to ARMv5 that requires double word alignment. I will post a patch soon. Thanks! Regards, Chao-ying 260243 1 63502 fu 2010-08-04 15:27:48 -0700 Created attachment 63502 Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER 260987 2 63502 commit-queue 2010-08-05 17:42:13 -0700 Comment on attachment 63502 Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER Clearing flags on attachment: 63502 Committed r64804: <http://trac.webkit.org/changeset/64804> 260989 3 commit-queue 2010-08-05 17:42:17 -0700 All reviewed patches have been landed. Closing bug. 63502 2010-08-04 15:27:48 -0700 2010-08-05 17:42:13 -0700 Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER mips-align.diff text/plain 1323 fu SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0Njg0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMDQgIENoYW8teWlu ZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERlZmluZSBXVEZfVVNFX0FSRU5BX0FMTE9DX0FMSUdOTUVOVF9JTlRFR0VS IGZvciBNSVBTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MzUxNAorCisgICAgICAgIE1JUFMgbmVlZHMgdG8gZGVmaW5lIFdURl9VU0VfQVJFTkFfQUxM T0NfQUxJR05NRU5UX0lOVEVHRVIsIHNvIHRoYXQKKyAgICAgICAgUmVuZGVyQXJlbmE6OmFsbG9j YXRlKCkgY2FuIHJldHVybiA4LWJ5dGUgYWxpZ25lZCBtZW1vcnkgdG8gYXZvaWQKKyAgICAgICAg ZXhjZXB0aW9ucyBvbiBzZGMxL2xkYzEuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwog MjAxMC0wOC0wNCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjY0NjU1LgpJbmRleDogSmF2YVNjcmlw dENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1Bs YXRmb3JtLmgJKHJldmlzaW9uIDY0NjA4KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3Jt LmgJKHdvcmtpbmcgY29weSkKQEAgLTE0Miw2ICsxNDIsOCBAQAogI2RlZmluZSBXVEZfTUlQU19B UkNIX1JFViBfX21pcHNfaXNhX3JldgogI2RlZmluZSBXVEZfTUlQU19JU0FfUkVWKHYpIChkZWZp bmVkIFdURl9NSVBTX0FSQ0hfUkVWICYmIFdURl9NSVBTX0FSQ0hfUkVWID09IHYpCiAjZGVmaW5l IFdURl9NSVBTX0RPVUJMRV9GTE9BVCAoZGVmaW5lZCBfX21pcHNfaGFyZF9mbG9hdCAmJiAhZGVm aW5lZCBfX21pcHNfc2luZ2xlX2Zsb2F0KQorLyogTUlQUyByZXF1aXJlcyBhbGxvY2F0b3JzIHRv IHVzZSBhbGlnbmVkIG1lbW9yeSAqLworI2RlZmluZSBXVEZfVVNFX0FSRU5BX0FMTE9DX0FMSUdO TUVOVF9JTlRFR0VSIDEKICNlbmRpZiAvKiBNSVBTICovCiAKIC8qIENQVShQUEMpIC0gUG93ZXJQ QyAzMi1iaXQgKi8K