43506 2010-08-04 13:36:58 -0700 foreign-iframe-main.html occasionally crashes (during the next test, idempotent-update.html) 2010-10-04 15:44:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P1 Normal --- 37812 1 joepeck ap abarth ap beidson ddkilzer dglazkov eric hclam joepeck mjs tkent webkit.review.bot oldest_to_newest 260191 0 joepeck 2010-08-04 13:36:58 -0700 Leopard Bot has intermittently crashed twice on this test: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r64645%20(18366)/results.html Most likely as a result of recent application cache changes in: <http://webkit.org/b/40627> Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 260214 1 ap 2010-08-04 14:27:15 -0700 I think it's actually foreign-iframe-main.html that crashes the next test. I could get it to assert with --repeat-each 10: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x00000001008be62d WebFrameLoaderClient::userAgent(WebCore::KURL const&) + 91 (WebFrameLoaderClient.mm:1281) 1 com.apple.WebCore 0x00000001011ce685 WebCore::FrameLoader::applyUserAgent(WebCore::ResourceRequest&) + 65 (FrameLoader.cpp:3117) 2 com.apple.WebCore 0x0000000100e55383 WebCore::ApplicationCacheGroup::createResourceHandle(WebCore::KURL const&, WebCore::ApplicationCacheResource*) + 109 (ApplicationCacheGroup.cpp:469) 3 com.apple.WebCore 0x0000000100e56975 WebCore::ApplicationCacheGroup::startLoadingEntry() + 487 (ApplicationCacheGroup.cpp:997) 4 com.apple.WebCore 0x0000000100e58e0c WebCore::ApplicationCacheGroup::didFinishLoading(WebCore::ResourceHandle*) + 672 (ApplicationCacheGroup.cpp:644) 5 com.apple.WebCore 0x00000001018791ad -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] + 270 (ResourceHandleMac.mm:915) ... This seems to mean that network loading didn't stop when a navigation happened, which may have far reaching consequences. I'm not sure if r40627 has anything to do with this. This particular assertion doesn't mean immediately crashing in release mode, as there is an early return, but further processing of a spurious didFinishLoading can cause much badness. 260223 2 joepeck 2010-08-04 14:49:49 -0700 (In reply to comment #1) > I think it's actually foreign-iframe-main.html that crashes the next test. > I could get it to assert with --repeat-each 10: Thanks for looking into this Alexey! I just came back from a meeting to see the same on my machine running a similar set of switches. Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x00000000bbadbeef 0x00000001008be2d9 in WebFrameLoaderClient::userAgent (this=0x105a24dd0, url=@0x7fff5fbfde18) at /Users/pecoraro/Code/webkit-open-source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1281 1281 ASSERT(webView); 262049 3 ap 2010-08-09 02:38:30 -0700 On this test, appcache updating doesn't stop in time - the process continues after the frame is detached from view. Normally, loading is stopped from ApplicationCacheGroup destructor, in a way that's anything but straightforward - even Inspector gets involved: #0 0x10344801f in WebCore::ResourceHandle::cancel at ResourceHandleMac.mm:342 #1 0x102a19dbc in WebCore::ApplicationCacheGroup::stopLoading at ApplicationCacheGroup.cpp:336 #2 0x102a1d707 in WebCore::ApplicationCacheGroup::~ApplicationCacheGroup at ApplicationCacheGroup.cpp:95 #3 0x102a18be3 in WebCore::ApplicationCacheGroup::disassociateDocumentLoader at ApplicationCacheGroup.cpp:361 #4 0x102a26de7 in WebCore::ApplicationCacheHost::~ApplicationCacheHost at ApplicationCacheHost.cpp:59 #5 0x102c43a85 in WTF::deleteOwnedPtr<WebCore::ApplicationCacheHost> at OwnPtrCommon.h:57 #6 0x102c43aa8 in WTF::OwnPtr<WebCore::ApplicationCacheHost>::~OwnPtr at OwnPtr.h:57 #7 0x102c3f3dd in WebCore::DocumentLoader::~DocumentLoader at DocumentLoader.cpp:104 #8 0x10246c5c0 in WebDocumentLoaderMac::~WebDocumentLoaderMac at WebDocumentLoaderMac.h:40 #9 0x102a1ff39 in WTF::RefCounted<WebCore::DocumentLoader>::deref at RefCounted.h:139 #10 0x102a2303f in WTF::derefIfNotNull<WebCore::DocumentLoader> at PassRefPtr.h:58 #11 0x102a2305a in WTF::RefPtr<WebCore::DocumentLoader>::~RefPtr at RefPtr.h:56 #12 0x102f691da in WebCore::InspectorResource::~InspectorResource at InspectorResource.cpp:74 #13 0x102f21b4d in WTF::RefCounted<WebCore::InspectorResource>::deref at RefCounted.h:139 #14 0x102f21b7d in WTF::derefIfNotNull<WebCore::InspectorResource> at PassRefPtr.h:58 #15 0x102f21b98 in WTF::RefPtr<WebCore::InspectorResource>::~RefPtr at RefPtr.h:56 #16 0x102f185f7 in WebCore::InspectorController::~InspectorController at InspectorController.cpp:194 #17 0x1032b8b58 in WTF::deleteOwnedPtr<WebCore::InspectorController> at OwnPtrCommon.h:57 #18 0x1032b8b7c in WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr at OwnPtr.h:57 #19 0x1032b35d4 in WebCore::Page::~Page at Page.cpp:224 It's possible that some subtle change in Inspector changed when ApplicationCacheGroup is destroyed (or maybe it's now leaked altogether). We need a more direct mechanism to stop updating. This is also related to a FIXME in ApplicationCacheGroup.h: // FIXME: An update started by a particular frame should not stop if it is destroyed, but there are other frames associated with the same cache group. Frame* m_frame; 262330 4 ddkilzer 2010-08-09 14:50:31 -0700 <rdar://problem/8289284> 280099 5 ap 2010-09-16 08:15:04 -0700 *** Bug 45876 has been marked as a duplicate of this bug. *** 289180 6 69694 ap 2010-10-04 15:03:00 -0700 Created attachment 69694 proposed fix 289182 7 69694 abarth 2010-10-04 15:05:38 -0700 Comment on attachment 69694 proposed fix ok. 289202 8 ap 2010-10-04 15:20:19 -0700 Committed <http://trac.webkit.org/changeset/69041>. 289212 9 webkit.review.bot 2010-10-04 15:25:59 -0700 http://trac.webkit.org/changeset/69041 might have broken Chromium Linux Release 289230 10 ap 2010-10-04 15:42:19 -0700 This is forked code that doesn't build, I think it's up to chromium maintainers to fix it. 289233 11 abarth 2010-10-04 15:44:13 -0700 (In reply to comment #10) > This is forked code that doesn't build, I think it's up to chromium maintainers to fix it. Adding Chromium gardener folks to the CC. 69694 2010-10-04 15:03:00 -0700 2010-10-04 15:05:37 -0700 proposed fix AppcacheStopLoading.txt text/plain 5229 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTAzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTAtMTAtMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNTA2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS84Mjg5Mjg0PiBmb3JlaWduLWlmcmFtZS1tYWluLmh0bWwgb2NjYXNpb25h bGx5IGNyYXNoZXMgKGR1cmluZyB0aGUgbmV4dCB0ZXN0LAorICAgICAgICBpZGVtcG90ZW50LXVw ZGF0ZS5odG1sKQorCisgICAgICAgIEFwcGxpY2F0aW9uIGNhY2hlIGRvZXNuJ3QgdXNlIFJlc291 cmNlTG9hZGVyIG1hY2hpbmVyeSAoZm9yIGJldHRlciBvciB3b3JzZSksIHNvIHdlIG5lZWQgdG8K KyAgICAgICAgYWJvcnQgdXBkYXRlIHByb2Nlc3MgZXhwbGljaXRseS4KKworICAgICAgICBOb3Rl IHRoYXQgaW4gcHJpbmNpcGxlLCB1cGRhdGUgY291bGQgcGlnZ3liYWNrIG9uIGFueSBvdGhlciBl eGlzdGluZyBmcmFtZSAtIG9yIGV2ZW4gcnVuCisgICAgICAgIGZyYW1lbGVzcyAtIGJ1dCBjdXJy ZW50bHksIGl0J3MgdGllZCB0byB0aGUgZmlyc3QgZnJhbWUgdGhhdCByZXF1ZXN0ZWQgdXBkYXRl LgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkRvY3VtZW50TG9hZGVyOjpzdG9wTG9hZGluZyk6CisgICAgICAgICogbG9hZGVyL2FwcGNh Y2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNh dGlvbkNhY2hlR3JvdXA6OnN0b3BMb2FkaW5nSW5GcmFtZSk6CisgICAgICAgICogbG9hZGVyL2Fw cGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5oOgorICAgICAgICAqIGxvYWRlci9hcHBjYWNo ZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlv bkNhY2hlSG9zdDo6fkFwcGxpY2F0aW9uQ2FjaGVIb3N0KToKKyAgICAgICAgKFdlYkNvcmU6OkFw cGxpY2F0aW9uQ2FjaGVIb3N0OjpzdG9wTG9hZGluZ0luRnJhbWUpOgorICAgICAgICAqIGxvYWRl ci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5oOgorCiAyMDEwLTEwLTA0ICBIdWFodWkg V3UgIDxtZWRpYWRlcGVuZGVudEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCShyZXZpc2lvbiA2ODkw OCkKKysrIFdlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjIwLDYgKzIyMCwxMSBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpzdG9wTG9hZGluZyhEYXRh YmFzCiAgICAgLy8gQWx3YXlzIGNhbmNlbCBtdWx0aXBhcnQgbG9hZGVycwogICAgIGNhbmNlbEFs bChtX211bHRpcGFydFN1YnJlc291cmNlTG9hZGVycyk7CiAKKyAgICAvLyBBcHBjYWNoZSB1c2Vz IFJlc291cmNlSGFuZGxlIGRpcmVjdGx5LCBEb2N1bWVudExvYWRlciBkb2Vzbid0IGNvdW50IHRo ZXNlIGxvYWRzLgorI2lmIEVOQUJMRShPRkZMSU5FX1dFQl9BUFBMSUNBVElPTlMpCisgICAgbV9h cHBsaWNhdGlvbkNhY2hlSG9zdC0+c3RvcExvYWRpbmdJbkZyYW1lKG1fZnJhbWUpOworI2VuZGlm CisKICAgICBpZiAoIWxvYWRpbmcpCiAgICAgICAgIHJldHVybjsKICAgICAKSW5kZXg6IFdlYkNv cmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmNwcAkocmV2 aXNpb24gNjg5MDgpCisrKyBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hl R3JvdXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODQsNiArMzg0LDE0IEBAIHZvaWQgQXBwbGlj YXRpb25DYWNoZUdyb3VwOjpjYWNoZURlc3Ryb3kKICAgICB9CiB9CiAKK3ZvaWQgQXBwbGljYXRp b25DYWNoZUdyb3VwOjpzdG9wTG9hZGluZ0luRnJhbWUoRnJhbWUqIGZyYW1lKQoreworICAgIGlm IChmcmFtZSAhPSBtX2ZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBzdG9wTG9hZGluZygp OworfQorCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKIHN0YXRpYyB2b2lkIGluc3BlY3RvclVwZGF0 ZUFwcGxpY2F0aW9uQ2FjaGVTdGF0dXMoRnJhbWUqIGZyYW1lKQogewpJbmRleDogV2ViQ29yZS9s b2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmgJKHJldmlzaW9uIDY4 OTA4KQorKysgV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmgJ KHdvcmtpbmcgY29weSkKQEAgLTgwLDYgKzgwLDggQEAgcHVibGljOgogCiAgICAgYm9vbCBjYWNo ZUlzQmVpbmdVcGRhdGVkKGNvbnN0IEFwcGxpY2F0aW9uQ2FjaGUqIGNhY2hlKSBjb25zdCB7IHJl dHVybiBjYWNoZSA9PSBtX2NhY2hlQmVpbmdVcGRhdGVkOyB9CiAKKyAgICB2b2lkIHN0b3BMb2Fk aW5nSW5GcmFtZShGcmFtZSopOworCiAgICAgQXBwbGljYXRpb25DYWNoZSogbmV3ZXN0Q2FjaGUo KSBjb25zdCB7IHJldHVybiBtX25ld2VzdENhY2hlLmdldCgpOyB9CiAgICAgdm9pZCBzZXROZXdl c3RDYWNoZShQYXNzUmVmUHRyPEFwcGxpY2F0aW9uQ2FjaGU+KTsKIApJbmRleDogV2ViQ29yZS9s b2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAkocmV2aXNpb24g Njg5MDgpCisrKyBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTU1LDYgKzU1LDggQEAgQXBwbGljYXRpb25DYWNoZUhvc3Q6 OkFwcGxpY2F0aW9uQ2FjaGVIbwogCiBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6fkFwcGxpY2F0aW9u Q2FjaGVIb3N0KCkKIHsKKyAgICBBU1NFUlQoIW1fYXBwbGljYXRpb25DYWNoZSB8fCAhbV9jYW5k aWRhdGVBcHBsaWNhdGlvbkNhY2hlR3JvdXAgfHwgbV9hcHBsaWNhdGlvbkNhY2hlLT5ncm91cCgp ID09IG1fY2FuZGlkYXRlQXBwbGljYXRpb25DYWNoZUdyb3VwKTsKKwogICAgIGlmIChtX2FwcGxp Y2F0aW9uQ2FjaGUpCiAgICAgICAgIG1fYXBwbGljYXRpb25DYWNoZS0+Z3JvdXAoKS0+ZGlzYXNz b2NpYXRlRG9jdW1lbnRMb2FkZXIobV9kb2N1bWVudExvYWRlcik7CiAgICAgZWxzZSBpZiAobV9j YW5kaWRhdGVBcHBsaWNhdGlvbkNhY2hlR3JvdXApCkBAIC0yMzksNiArMjQxLDE2IEBAIHZvaWQg QXBwbGljYXRpb25DYWNoZUhvc3Q6Om5vdGlmeURPTUFwcGwKICAgICBkaXNwYXRjaERPTUV2ZW50 KGlkLCB0b3RhbCwgZG9uZSk7CiB9CiAKK3ZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6OnN0b3BM b2FkaW5nSW5GcmFtZShGcmFtZSogZnJhbWUpCit7CisgICAgQVNTRVJUKCFtX2FwcGxpY2F0aW9u Q2FjaGUgfHwgIW1fY2FuZGlkYXRlQXBwbGljYXRpb25DYWNoZUdyb3VwIHx8IG1fYXBwbGljYXRp b25DYWNoZS0+Z3JvdXAoKSA9PSBtX2NhbmRpZGF0ZUFwcGxpY2F0aW9uQ2FjaGVHcm91cCk7CisK KyAgICBpZiAobV9jYW5kaWRhdGVBcHBsaWNhdGlvbkNhY2hlR3JvdXApCisgICAgICAgIG1fY2Fu ZGlkYXRlQXBwbGljYXRpb25DYWNoZUdyb3VwLT5zdG9wTG9hZGluZ0luRnJhbWUoZnJhbWUpOwor ICAgIGVsc2UgaWYgKG1fYXBwbGljYXRpb25DYWNoZSkKKyAgICAgICAgbV9hcHBsaWNhdGlvbkNh Y2hlLT5ncm91cCgpLT5zdG9wTG9hZGluZ0luRnJhbWUoZnJhbWUpOworfQorCiB2b2lkIEFwcGxp Y2F0aW9uQ2FjaGVIb3N0OjpzdG9wRGVmZXJyaW5nRXZlbnRzKCkKIHsKICAgICBSZWZQdHI8RG9j dW1lbnRMb2FkZXI+IHByb3RlY3QoZG9jdW1lbnRMb2FkZXIoKSk7CkluZGV4OiBXZWJDb3JlL2xv YWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmgJKHJldmlzaW9uIDY4OTA4 KQorKysgV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaAkod29y a2luZyBjb3B5KQpAQCAtNDMsNiArNDMsNyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNs YXNzIERPTUFwcGxpY2F0aW9uQ2FjaGU7CiAgICAgY2xhc3MgRG9jdW1lbnRMb2FkZXI7CisgICAg Y2xhc3MgRnJhbWU7CiAgICAgY2xhc3MgUmVzb3VyY2VMb2FkZXI7CiAgICAgY2xhc3MgUmVzb3Vy Y2VFcnJvcjsKICAgICBjbGFzcyBSZXNvdXJjZVJlcXVlc3Q7CkBAIC0xNDQsNiArMTQ1LDggQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIHNldERPTUFwcGxpY2F0aW9uQ2FjaGUo RE9NQXBwbGljYXRpb25DYWNoZSopOwogICAgICAgICB2b2lkIG5vdGlmeURPTUFwcGxpY2F0aW9u Q2FjaGUoRXZlbnRJRCwgaW50IHByb2dyZXNzVG90YWwsIGludCBwcm9ncmVzc0RvbmUpOwogCisg ICAgICAgIHZvaWQgc3RvcExvYWRpbmdJbkZyYW1lKEZyYW1lKik7CisKICAgICAgICAgdm9pZCBz dG9wRGVmZXJyaW5nRXZlbnRzKCk7IC8vIEFsc28gcmFpc2VzIHRoZSBldmVudHMgdGhhdCBoYXZl IGJlZW4gcXVldWVkIHVwLgogCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikK