43505 2010-08-04 13:26:31 -0700 Window title for image documents shows corrupted characters instead of multiplication sign when using WebKit2 2010-12-24 12:07:45 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 51598 1 aroben darin darin oldest_to_newest 260186 0 aroben 2010-08-04 13:26:31 -0700 To reproduce: 1. Go to http://webkit.org/images/download.png The window title has corrupted characters instead of a multiplication sign. This is because String::format doesn't correctly handle the UTF-8-encoded format string in WebPlatformStrategies::imageTitle on Windows. 260188 1 aroben 2010-08-04 13:27:05 -0700 <rdar://problem/8273249> 324054 2 76928 darin 2010-12-17 17:23:12 -0800 Created attachment 76928 Patch 324059 3 darin 2010-12-17 17:43:15 -0800 Committed r74306: <http://trac.webkit.org/changeset/74306> 76928 2010-12-17 17:23:12 -0800 2010-12-17 17:40:17 -0800 Patch bug-43505-20101217172311.patch text/plain 5437 darin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDMwNCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpbmRv dyB0aXRsZSBmb3IgaW1hZ2UgZG9jdW1lbnRzIHNob3dzIGNvcnJ1cHRlZCBjaGFyYWN0ZXJzIGlu c3RlYWQgb2YgbXVsdGlwbGljYXRpb24gc2lnbiB3aGVuIHVzaW5nIFdlYktpdDIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNTA1CisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHA6IENo YW5nZWQgVUlfU1RSSU5HIG1hY3JvcyB0byByZXR1cm4KKyAgICAgICAgV2ViQ29yZTo6U3RyaW5n IG9iamVjdHMgaW5zdGVhZCBvZiBDIHN0cmluZ3MuCisgICAgICAgIChXZWJLaXQ6OmZvcm1hdExv Y2FsaXplZFN0cmluZyk6IEFkZGVkLiBVc2VzIHRoZSBDb3JlIEZvdW5kYXRpb24gc3RyaW5nIGZv cm1hdHRpbmcgZnVuY3Rpb24gZm9yCisgICAgICAgIHJlYXNvbnMgZXhwbGFpbmVkIGluIHRoZSBj b21tZW50LgorICAgICAgICAoV2ViS2l0OjpXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6Om11bHRpcGxl RmlsZVVwbG9hZFRleHQpOiBVc2UgZm9ybWF0TG9jYWxpemVkU3RyaW5nIGluc3RlYWQgb2YKKyAg ICAgICAgU3RyaW5nOjpmb3JtYXQuCisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRl Z2llczo6aW1hZ2VUaXRsZSk6IERpdHRvLgorICAgICAgICAoV2ViS2l0OjpXZWJQbGF0Zm9ybVN0 cmF0ZWdpZXM6OmxvY2FsaXplZE1lZGlhVGltZURlc2NyaXB0aW9uKTogRGl0dG8uCisKIDIwMTAt MTItMTcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAJKHJldmlz aW9uIDc0MzAzKQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRm b3JtU3RyYXRlZ2llcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4LDEzICszOCwzMSBAQAogI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogLy8gRklYTUU6IEltcGxlbWVudCBsb2NhbGl6 YXRpb24uCi0jZGVmaW5lIFVJX1NUUklORyhzdHJpbmcsIGRlc2NyaXB0aW9uKSBzdHJpbmcKLSNk ZWZpbmUgVUlfU1RSSU5HX0tFWShzdHJpbmcsIGtleSwgZGVzY3JpcHRpb24pIHN0cmluZworI2Rl ZmluZSBVSV9TVFJJTkcoc3RyaW5nLCBkZXNjcmlwdGlvbikgU3RyaW5nOjpmcm9tVVRGOChzdHJp bmcsIHN0cmxlbihzdHJpbmcpKQorI2RlZmluZSBVSV9TVFJJTkdfS0VZKHN0cmluZywga2V5LCBk ZXNjcmlwdGlvbikgU3RyaW5nOjpmcm9tVVRGOChzdHJpbmcsIHN0cmxlbihzdHJpbmcpKQogCiB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKKy8vIFdlIGNh bid0IHVzZSBTdHJpbmc6OmZvcm1hdCBmb3IgdHdvIHJlYXNvbnM6CisvLyAgMSkgSXQgZG9lc24n dCBoYW5kbGUgbm9uLUFTQ0lJIGNoYXJhY3RlcnMgaW4gdGhlIGZvcm1hdCBzdHJpbmcuCisvLyAg MikgSXQgZG9lc24ndCBoYW5kbGUgdGhlICUyJGQgc3ludGF4Lgorc3RhdGljIFN0cmluZyBmb3Jt YXRMb2NhbGl6ZWRTdHJpbmcoY29uc3QgU3RyaW5nJiBmb3JtYXQsIC4uLikKK3sKKyNpZiBQTEFU Rk9STShDRikKKyAgICB2YV9saXN0IGFyZ3VtZW50czsKKyAgICB2YV9zdGFydChhcmd1bWVudHMs IGZvcm1hdCk7CisgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBmb3JtYXRDRlN0cmluZyhBZG9w dENGLCBmb3JtYXQuY3JlYXRlQ0ZTdHJpbmcoKSk7CisgICAgUmV0YWluUHRyPENGU3RyaW5nUmVm PiByZXN1bHQoQWRvcHRDRiwgQ0ZTdHJpbmdDcmVhdGVXaXRoRm9ybWF0QW5kQXJndW1lbnRzKDAs IDAsIGZvcm1hdENGU3RyaW5nLmdldCgpLCBhcmd1bWVudHMpKTsKKyAgICB2YV9lbmQoYXJndW1l bnRzKTsKKyAgICByZXR1cm4gcmVzdWx0LmdldCgpOworI2Vsc2UKKyAgICBub3RJbXBsZW1lbnRl ZCgpOworICAgIHJldHVybiBmb3JtYXQ7CisjZW5kaWYKK30KKwogdm9pZCBXZWJQbGF0Zm9ybVN0 cmF0ZWdpZXM6OmluaXRpYWxpemUoKQogewogICAgIERFRklORV9TVEFUSUNfTE9DQUwoV2ViUGxh dGZvcm1TdHJhdGVnaWVzLCBwbGF0Zm9ybVN0cmF0ZWdpZXMsICgpKTsKQEAgLTY3OSw3ICs2OTcs NyBAQCBTdHJpbmcgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpjcmFzaGVkUGx1CiAKIFN0cmluZyBX ZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6Om11bHRpcGxlRmlsZVVwbG9hZFRleHQodW5zaWduZWQgbnVt YmVyT2ZGaWxlcykKIHsKLSAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoVUlfU1RSSU5HKCIlZCBm aWxlcyIsICJMYWJlbCB0byBkZXNjcmliZSB0aGUgbnVtYmVyIG9mIGZpbGVzIHNlbGVjdGVkIGlu IGEgZmlsZSB1cGxvYWQgY29udHJvbCB0aGF0IGFsbG93cyBtdWx0aXBsZSBmaWxlcyIpLCBudW1i ZXJPZkZpbGVzKTsKKyAgICByZXR1cm4gZm9ybWF0TG9jYWxpemVkU3RyaW5nKFVJX1NUUklORygi JWQgZmlsZXMiLCAiTGFiZWwgdG8gZGVzY3JpYmUgdGhlIG51bWJlciBvZiBmaWxlcyBzZWxlY3Rl ZCBpbiBhIGZpbGUgdXBsb2FkIGNvbnRyb2wgdGhhdCBhbGxvd3MgbXVsdGlwbGUgZmlsZXMiKSwg bnVtYmVyT2ZGaWxlcyk7CiB9CiAKIFN0cmluZyBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OnVua25v d25GaWxlU2l6ZVRleHQoKQpAQCAtNzA1LDcgKzcyMyw4IEBAIFN0cmluZyBXZWJQbGF0Zm9ybVN0 cmF0ZWdpZXM6OmFsbEZpbGVzVGUKIAogU3RyaW5nIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6aW1h Z2VUaXRsZShjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBjb25zdCBJbnRTaXplJiBzaXplKQogewot ICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdChVSV9TVFJJTkcoIiVzICVkw5clZCBwaXhlbHMiLCAi d2luZG93IHRpdGxlIGZvciBhIHN0YW5kYWxvbmUgaW1hZ2UgKHVzZXMgbXVsdGlwbGljYXRpb24g c3ltYm9sLCBub3QgeCkiKSwgZmlsZW5hbWUudXRmOCgpLmRhdGEoKSwgc2l6ZS53aWR0aCgpLCBz aXplLmhlaWdodCgpKTsKKyAgICAvLyBGSVhNRTogSXQgd291bGQgYmUgbmljZSB0byBoYXZlIHRo ZSBmaWxlbmFtZSBpbnNpZGUgdGhlIGZvcm1hdCBzdHJpbmcsIGJ1dCBpdCdzIG5vdCBlYXN5IHRv IGRvIHRoYXQgaW4gYSB3YXkgdGhhdCB3b3JrcyB3aXRoIG5vbi1BU0NJSSBjaGFyYWN0ZXJzIGlu IHRoZSBmaWxlbmFtZS4KKyAgICByZXR1cm4gZmlsZW5hbWUgKyBmb3JtYXRMb2NhbGl6ZWRTdHJp bmcoVUlfU1RSSU5HKCIgJWTDlyVkIHBpeGVscyIsICJ3aW5kb3cgdGl0bGUgc3VmZml4IGZvciBh IHN0YW5kYWxvbmUgaW1hZ2UgKHVzZXMgbXVsdGlwbGljYXRpb24gc3ltYm9sLCBub3QgeCkiKSwg c2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKTsKIH0KIAogU3RyaW5nIFdlYlBsYXRmb3JtU3Ry YXRlZ2llczo6bWVkaWFFbGVtZW50TG9hZGluZ1N0YXRlVGV4dCgpCkBAIC04MjAsMTIgKzgzOSwx MiBAQCBTdHJpbmcgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpsb2NhbGl6ZWRNCiAgICAgc2Vjb25k cyAlPSA2MDsKIAogICAgIGlmIChkYXlzKQotICAgICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQo VUlfU1RSSU5HKCIlMSRkIGRheXMgJTIkZCBob3VycyAlMyRkIG1pbnV0ZXMgJTQkZCBzZWNvbmRz IiwgImFjY2Vzc2liaWxpdHkgaGVscCB0ZXh0IGZvciBtZWRpYSBjb250cm9sbGVyIHRpbWUgdmFs dWUgPj0gMSBkYXkiKSwgZGF5cywgaG91cnMsIG1pbnV0ZXMsIHNlY29uZHMpOworICAgICAgICBy ZXR1cm4gZm9ybWF0TG9jYWxpemVkU3RyaW5nKFVJX1NUUklORygiJTEkZCBkYXlzICUyJGQgaG91 cnMgJTMkZCBtaW51dGVzICU0JGQgc2Vjb25kcyIsICJhY2Nlc3NpYmlsaXR5IGhlbHAgdGV4dCBm b3IgbWVkaWEgY29udHJvbGxlciB0aW1lIHZhbHVlID49IDEgZGF5IiksIGRheXMsIGhvdXJzLCBt aW51dGVzLCBzZWNvbmRzKTsKICAgICBpZiAoaG91cnMpCi0gICAgICAgIHJldHVybiBTdHJpbmc6 OmZvcm1hdChVSV9TVFJJTkcoIiUxJGQgaG91cnMgJTIkZCBtaW51dGVzICUzJGQgc2Vjb25kcyIs ICJhY2Nlc3NpYmlsaXR5IGhlbHAgdGV4dCBmb3IgbWVkaWEgY29udHJvbGxlciB0aW1lIHZhbHVl ID49IDYwIG1pbnV0ZXMiKSwgaG91cnMsIG1pbnV0ZXMsIHNlY29uZHMpOworICAgICAgICByZXR1 cm4gZm9ybWF0TG9jYWxpemVkU3RyaW5nKFVJX1NUUklORygiJTEkZCBob3VycyAlMiRkIG1pbnV0 ZXMgJTMkZCBzZWNvbmRzIiwgImFjY2Vzc2liaWxpdHkgaGVscCB0ZXh0IGZvciBtZWRpYSBjb250 cm9sbGVyIHRpbWUgdmFsdWUgPj0gNjAgbWludXRlcyIpLCBob3VycywgbWludXRlcywgc2Vjb25k cyk7CiAgICAgaWYgKG1pbnV0ZXMpCi0gICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdChVSV9T VFJJTkcoIiUxJGQgbWludXRlcyAlMiRkIHNlY29uZHMiLCAiYWNjZXNzaWJpbGl0eSBoZWxwIHRl eHQgZm9yIG1lZGlhIGNvbnRyb2xsZXIgdGltZSB2YWx1ZSA+PSA2MCBzZWNvbmRzIiksIG1pbnV0 ZXMsIHNlY29uZHMpOwotICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdChVSV9TVFJJTkcoIiUxJGQg c2Vjb25kcyIsICJhY2Nlc3NpYmlsaXR5IGhlbHAgdGV4dCBmb3IgbWVkaWEgY29udHJvbGxlciB0 aW1lIHZhbHVlIDwgNjAgc2Vjb25kcyIpLCBzZWNvbmRzKTsKKyAgICAgICAgcmV0dXJuIGZvcm1h dExvY2FsaXplZFN0cmluZyhVSV9TVFJJTkcoIiUxJGQgbWludXRlcyAlMiRkIHNlY29uZHMiLCAi YWNjZXNzaWJpbGl0eSBoZWxwIHRleHQgZm9yIG1lZGlhIGNvbnRyb2xsZXIgdGltZSB2YWx1ZSA+ PSA2MCBzZWNvbmRzIiksIG1pbnV0ZXMsIHNlY29uZHMpOworICAgIHJldHVybiBmb3JtYXRMb2Nh bGl6ZWRTdHJpbmcoVUlfU1RSSU5HKCIlMSRkIHNlY29uZHMiLCAiYWNjZXNzaWJpbGl0eSBoZWxw IHRleHQgZm9yIG1lZGlhIGNvbnRyb2xsZXIgdGltZSB2YWx1ZSA8IDYwIHNlY29uZHMiKSwgc2Vj b25kcyk7CiB9CiAKIFN0cmluZyBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OnZhbGlkYXRpb25NZXNz YWdlVmFsdWVNaXNzaW5nVGV4dCgpCg==