43501 2010-08-04 12:14:46 -0700 Down-sampling doesn't work for some GIF files 2010-08-05 13:02:21 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 yong.li.webkit yong.li.webkit commit-queue staikos oldest_to_newest 260144 0 yong.li.webkit 2010-08-04 12:14:46 -0700 GIF reader can call "setSize()" multiple times. The current implementation doesn't clear the old down-sampling maps before adding new entries. Subsequent binary searches can give unexpected results. 260149 1 63479 yong.li.webkit 2010-08-04 12:24:52 -0700 Created attachment 63479 the patch 260792 2 63479 commit-queue 2010-08-05 13:02:15 -0700 Comment on attachment 63479 the patch Clearing flags on attachment: 63479 Committed r64777: <http://trac.webkit.org/changeset/64777> 260793 3 commit-queue 2010-08-05 13:02:21 -0700 All reviewed patches have been landed. Closing bug. 63479 2010-08-04 12:24:52 -0700 2010-08-05 13:02:15 -0700 the patch 43501.patch text/plain 2812 yong.li.webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTQ3NWFiNy4uODRhMzY0OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOC0wNCAgWW9uZyBMaSAgPHlv bGlAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggdGhlIHByb2JsZW0gdGhhdCBkb3duLXNhbXBsaW5nIGNvZGUgZG9lc24ndCB3b3Jr CisgICAgICAgIGZvciBzb21lIEdJRidzLiBHSUYgcmVhZGVyIGNhbiBjYWxsIHNldFNpemUoKSBt dWx0aXBsZSB0aW1lcy4KKyAgICAgICAgV2Ugc2hvdWxkIGNsZWFyIHRoZSBzY2FsaW5nIG1hcHMg YmVmb3JlIGFkZGluZyBuZXcgZW50cmllcy4KKyAgICAgICAgQWxzbyBhZGQgYSBmYXN0IHBhdGgg dG8gY2hlY2sgaWYgdGhlIHNpemUgaGFzIGNoYW5nZWQgc2luY2UgbGFzdCB0aW1lLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzUwMQorCisgICAg ICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkltYWdlRGVjb2Rlcjo6cHJlcGFyZVNjYWxlRGF0YUlmTmVjZXNzYXJ5KToKKyAg ICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VEZWNvZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkdJRkltYWdlRGVjb2Rlcjo6c2V0U2l6ZSk6CisKIDIwMTAtMDct MjMgIHJ5dWFuIGNob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL0ltYWdlRGVjb2Rlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL0ltYWdlRGVjb2Rlci5jcHAKaW5kZXggMTcyYmNjZi4uZmFkYjllMyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURlY29kZXIuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcApAQCAtMjE5LDE5 ICsyMTksMjAgQEAgdGVtcGxhdGUgPE1hdGNoVHlwZSB0eXBlPiBpbnQgZ2V0U2NhbGVkVmFsdWUo Y29uc3QgVmVjdG9yPGludD4mIHNjYWxlZFZhbHVlcywgaW4KIAogdm9pZCBJbWFnZURlY29kZXI6 OnByZXBhcmVTY2FsZURhdGFJZk5lY2Vzc2FyeSgpCiB7CisgICAgbV9zY2FsZWQgPSBmYWxzZTsK KyAgICBtX3NjYWxlZENvbHVtbnMuY2xlYXIoKTsKKyAgICBtX3NjYWxlZFJvd3MuY2xlYXIoKTsK KwogICAgIGludCB3aWR0aCA9IHNpemUoKS53aWR0aCgpOwogICAgIGludCBoZWlnaHQgPSBzaXpl KCkuaGVpZ2h0KCk7CiAgICAgaW50IG51bVBpeGVscyA9IGhlaWdodCAqIHdpZHRoOwotICAgIGlm IChtX21heE51bVBpeGVscyA+IDAgJiYgbnVtUGl4ZWxzID4gbV9tYXhOdW1QaXhlbHMpIHsKLSAg ICAgICAgbV9zY2FsZWQgPSB0cnVlOwotICAgICAgICBkb3VibGUgc2NhbGUgPSBzcXJ0KG1fbWF4 TnVtUGl4ZWxzIC8gKGRvdWJsZSludW1QaXhlbHMpOwotICAgICAgICBmaWxsU2NhbGVkVmFsdWVz KG1fc2NhbGVkQ29sdW1ucywgc2NhbGUsIHdpZHRoKTsKLSAgICAgICAgZmlsbFNjYWxlZFZhbHVl cyhtX3NjYWxlZFJvd3MsIHNjYWxlLCBoZWlnaHQpOwotICAgIH0gZWxzZSBpZiAobV9zY2FsZWQp IHsKLSAgICAgICAgbV9zY2FsZWQgPSBmYWxzZTsKLSAgICAgICAgbV9zY2FsZWRDb2x1bW5zLmNs ZWFyKCk7Ci0gICAgICAgIG1fc2NhbGVkUm93cy5jbGVhcigpOwotICAgIH0KKyAgICBpZiAobV9t YXhOdW1QaXhlbHMgPD0gMCB8fCBudW1QaXhlbHMgPD0gbV9tYXhOdW1QaXhlbHMpCisgICAgICAg IHJldHVybjsKKworICAgIG1fc2NhbGVkID0gdHJ1ZTsKKyAgICBkb3VibGUgc2NhbGUgPSBzcXJ0 KG1fbWF4TnVtUGl4ZWxzIC8gKGRvdWJsZSludW1QaXhlbHMpOworICAgIGZpbGxTY2FsZWRWYWx1 ZXMobV9zY2FsZWRDb2x1bW5zLCBzY2FsZSwgd2lkdGgpOworICAgIGZpbGxTY2FsZWRWYWx1ZXMo bV9zY2FsZWRSb3dzLCBzY2FsZSwgaGVpZ2h0KTsKIH0KIAogaW50IEltYWdlRGVjb2Rlcjo6dXBw ZXJCb3VuZFNjYWxlZFgoaW50IG9yaWdYLCBpbnQgc2VhcmNoU3RhcnQpCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VEZWNvZGVyLmNwcApp bmRleCBhNTkwYTZjLi5lYzE2ZGE3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rlci5jcHAKQEAgLTYxLDYgKzYxLDkgQEAg Ym9vbCBHSUZJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpCiAKIGJvb2wgR0lGSW1hZ2VE ZWNvZGVyOjpzZXRTaXplKHVuc2lnbmVkIHdpZHRoLCB1bnNpZ25lZCBoZWlnaHQpCiB7CisgICAg aWYgKEltYWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxhYmxlKCkgJiYgc2l6ZSgpLndpZHRoKCkgPT0g d2lkdGggJiYgc2l6ZSgpLmhlaWdodCgpID09IGhlaWdodCkKKyAgICAgICAgcmV0dXJuIHRydWU7 CisKICAgICBpZiAoIUltYWdlRGVjb2Rlcjo6c2V0U2l6ZSh3aWR0aCwgaGVpZ2h0KSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCg==