43498 2010-08-04 11:43:20 -0700 [Qt] add an API for QWebPage to get current focused element 2010-08-26 06:21:36 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED WONTFIX P2 Enhancement --- 0 max.hong.shen webkit-unassigned ariya.hidayat eric hausmann kenneth ojan ossy tonikitoo oldest_to_newest 260126 0 max.hong.shen 2010-08-04 11:43:20 -0700 The QWebPage has no API to retrieve current focused element, although you can use QWebFrame::findAllElement(":focus") to search for the focused element, which is not convenient enough and efficient to use (you have to find the focused frame first). So I am thinking about to add this API, which might be very useful in implementing tab navigation. 260127 1 63473 max.hong.shen 2010-08-04 11:44:29 -0700 Created attachment 63473 first try 263068 2 ariya.hidayat 2010-08-10 23:32:04 -0700 API addition needs to be discussed, might be too late for 4.7? In all cases, a new function will need \since tag. 263257 3 64115 max.hong.shen 2010-08-11 08:01:07 -0700 Created attachment 64115 add since tag 263259 4 max.hong.shen 2010-08-11 08:11:39 -0700 Thanks for your comments. I have added a \since tag for it. which can be changed if too late for 4.7. I would like to have this new Api for qwebpage because I think I am not the only people who has the problem to get the focused element. I have talked to several people to find out a way to get focused element, but had no luck. In stead of using CSS selector, why not just provides a straightforward and efficient way to help its developers like me :) 263786 5 64115 eric 2010-08-12 07:16:14 -0700 Comment on attachment 64115 add since tag There is already DOM API for this. Why would you want to expose new separate Qt API? 263787 6 eric 2010-08-12 07:17:41 -0700 https://developer.mozilla.org/en/DOM/selection 263792 7 ossy 2010-08-12 07:21:56 -0700 I cc-ed Simon and Kenneth, they are the competent persons for API changes. 263837 8 hausmann 2010-08-12 08:59:29 -0700 If at all then this method belongs into QWebFrame. Doesn't the following code work alternatively? QWebElement focusedElement = frame->findFirstElement("*:focus"); 263872 9 max.hong.shen 2010-08-12 10:47:31 -0700 Yes, I am sure that frame->findFirstElement("*:focus") can work. But to use this, we have to find the focused frame first, then call the findFisrtElement function to search the DOM tree, right? (Please correct me if I am wrong) So, the only reason I propose this API is to introduce a straightforward and efficient (no need to search DOM tree) way for qtwebkit developer to get the focused element. 263961 10 hausmann 2010-08-12 14:05:26 -0700 (In reply to comment #9) > Yes, I am sure that frame->findFirstElement("*:focus") can work. But to use this, we have to find the focused frame first, then call the findFisrtElement function to search the DOM tree, right? (Please correct me if I am wrong) > > So, the only reason I propose this API is to introduce a straightforward and efficient (no need to search DOM tree) way for qtwebkit developer to get the focused element. Is it that inconvenient? :) QWebFrame* frame = page->currentFrame(); QWebElement focusedElement = frame->... I agree about the efficiency though, that may be a good point for adding a method to QWebFrame. What are you doing with the focused element once you have retrieved it? 263988 11 ariya.hidayat 2010-08-12 14:36:24 -0700 > QWebFrame* frame = page->currentFrame(); Is this the same as 'focusedFrame'? 264097 12 tonikitoo 2010-08-12 17:26:16 -0700 (In reply to comment #11) > > QWebFrame* frame = page->currentFrame(); > > Is this the same as 'focusedFrame'? QWebFrame *QWebPage::currentFrame() const { d->createMainFrame(); return static_cast<WebCore::FrameLoaderClientQt *>(d->page->focusController()->focusedOrMainFrame()->loader()->client())->webFrame(); } looks like it'd work, yes. 264133 13 ariya.hidayat 2010-08-12 20:14:49 -0700 > QWebFrame *QWebPage::currentFrame() const > { > d->createMainFrame(); > return static_cast<WebCore::FrameLoaderClientQt *>(d->page->focusController()->focusedOrMainFrame()->loader()->client())->webFrame(); > } > > looks like it'd work, yes. Then this patch can't really be justified. 264151 14 tonikitoo 2010-08-12 21:06:20 -0700 > Then this patch can't really be justified. I tend to agree here too. I'd suggest: 1) If we decide to *not* go for it: 1.1) it could be a patch to the documentation in the sense of providing a snippet code for this possibly common task. 1.2) Maybe making it a helper method of your class, for convenience, would be enough. 2) To prove itself as needed: 2.1) Help us to understand your test case, in a broader context. For example, you might be needing to call this method so often that the performance of making it through a CSS selector really matter. 264304 15 ariya.hidayat 2010-08-13 05:33:04 -0700 If this is about performance, a use case where focused element needs to be fetched or detected so many times is probably a corner case. It's hard to imagine a type of application which does that :) 264385 16 max.hong.shen 2010-08-13 08:43:09 -0700 OK, one user case I can find is the Next button on VKB. Like android's browser does, when user clicks the next button, it scrolls user to the next input field (e.g. form field). In this case, we need to know the focused element to get its info. It would be better to get the focused element as fast as possible, then the app can start scrolling quickly (the user don't want to wait after click the next button). Also, I noticed that Mac's WebHTMLView.mm has a function to get accessibilityFocusedUIElement. Don't really know what it is but I think it would be friendly to developer to have this kind of Api, or just like Antonio Gomes says, added a snippet code example to the dev documentation. Thanks for all the comments and your time :) 264390 17 ariya.hidayat 2010-08-13 08:48:45 -0700 Android WebKit does this by caching navigation-able elements in a special tree, so as to avoid looking it up on the fly. In all cases, such a use case should be implemented using Antonio’s spatial navigation support, which has been there for a while (https://bugs.webkit.org/show_bug.cgi?id=18662). 269710 18 tonikitoo 2010-08-25 21:21:55 -0700 WONTFIX'ing this one. Please re-open if there is still stuff to be discussed here. (In reply to comment #16) > OK, one user case I can find is the Next button on VKB. Like android's browser does, when user clicks the next button, it scrolls user to the next input field (e.g. form field). In this case, we need to know the focused element to get its info. It would be better to get the focused element as fast as possible, then the app can start scrolling quickly (the user don't want to wait after click the next button). The snippet code Simon provide should run *really* fast, even on mobo devices, since it relies on a simple and well known/supported pseudo-selector (:focus). If it is not working as fast as you need, please file a bug about that. Providing profile data is even more helpful. As far as I know, there is no API for such scrolling-an-element-into-view action, but it'd be another bug. An important detail is that depending on how the window system handles the pop up and hiding of the virtual keyboard, scrolling an element into view might be simple or less-simple. Cases: 1) If when the vkb pops up, the windowing system resizes the application window, it is all fine. 2) Otherwise, the vkb needs to provide a way to get its bounding area, and it has to be considered when scrolling an element into view. > Also, I noticed that Mac's WebHTMLView.mm has a function to get accessibilityFocusedUIElement. Don't really know what it is but I think it would be friendly to developer to have this kind of Api, or just like Antonio Gomes says, added a snippet code example to the dev documentation. I vote for the later. 269848 19 max.hong.shen 2010-08-26 06:21:36 -0700 Thanks a lot for all your comments. I really appreciate it! 63473 2010-08-04 11:44:29 -0700 2010-08-11 08:01:07 -0700 first try 43498.patch text/plain 4038 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjQ2NTgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMDQgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhbiBBcGkgdG8gZ2V0IGN1cnJlbnQgZm9jdXNlZCBlbGVtZW50CisKKyAgICAgICAgKiBB cGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2U6OmZvY3VzZWRXZWJFbGVtZW50KToK KyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuaDoKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3Rf cXdlYnBhZ2UuY3BwOgorICAgICAgICAodHN0X1FXZWJQYWdlOjp0ZXN0Rm9jdXNlZFdlYkVsZW1l bnQpOgorCiAyMDEwLTA4LTAzICBOb2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K SW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9x dC9BcGkvcXdlYnBhZ2UuY3BwCShyZXZpc2lvbiA2NDY1NSkKKysrIFdlYktpdC9xdC9BcGkvcXdl YnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzExLDYgKzM3MTEsMjAgQEAgcXVpbnQ2NCBR V2ViUGFnZTo6Ynl0ZXNSZWNlaXZlZCgpIGNvbnN0CiB9CiAKIC8qIQorICAgIFJldHVybnMgZm9j dXNlZCB3ZWIgZWxlbWVudAorKi8KK1FXZWJFbGVtZW50IFFXZWJQYWdlOjpmb2N1c2VkV2ViRWxl bWVudCgpCit7CisgICAgRnJhbWUgKmZyYW1lID0gZC0+cGFnZS0+Zm9jdXNDb250cm9sbGVyKCkt PmZvY3VzZWRGcmFtZSgpOworICAgIGlmIChmcmFtZSkgeworICAgICAgICBEb2N1bWVudCAqZG9j dW1lbnQgPSBmcmFtZS0+ZG9jdW1lbnQoKTsKKyAgICAgICAgaWYgKGRvY3VtZW50KQorICAgICAg ICAgICAgcmV0dXJuIFFXZWJFbGVtZW50KGRvY3VtZW50LT5mb2N1c2VkTm9kZSgpKTsKKyAgICB9 CisgICAgcmV0dXJuIFFXZWJFbGVtZW50KCk7Cit9CisKKy8qIQogICAgIFxzaW5jZSA0LjcKICAg ICBcZm4gdm9pZCBRV2ViUGFnZTo6dmlld3BvcnRDaGFuZ2VSZXF1ZXN0ZWQoY29uc3QgUVdlYlBh Z2U6OlZpZXdwb3J0SGludHMmIGhpbnRzKQogCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5oCShyZXZpc2lvbiA2NDY1 NSkKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtMjc2LDYg KzI3Niw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBldmVudChRRXZlbnQqKTsKICAg ICBib29sIGZvY3VzTmV4dFByZXZDaGlsZChib29sIG5leHQpOworICAgIFFXZWJFbGVtZW50IGZv Y3VzZWRXZWJFbGVtZW50KCk7CiAKICAgICBRVmFyaWFudCBpbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJ bnB1dE1ldGhvZFF1ZXJ5IHByb3BlcnR5KSBjb25zdDsKIApJbmRleDogV2ViS2l0L3F0L3Rlc3Rz L3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3Rz L3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAJKHJldmlzaW9uIDY0NjU1KQorKysgV2ViS2l0L3F0 L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNSw2 ICsxMjUsNyBAQCBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgc2hvd01vZGFsRGlhbG9nKCk7CiAg ICAgdm9pZCB0ZXN0U3RvcFNjaGVkdWxlZFBhZ2VSZWZyZXNoKCk7CiAgICAgdm9pZCBmaW5kVGV4 dCgpOworICAgIHZvaWQgdGVzdEZvY3VzZWRXZWJFbGVtZW50KCk7CiAgICAgCiBwcml2YXRlOgog ICAgIFFXZWJWaWV3KiBtX3ZpZXc7CkBAIC0yMTczLDUgKzIxNzQsNDQgQEAgdm9pZCB0c3RfUVdl YlBhZ2U6OmZpbmRUZXh0KCkKICAgICB9CiB9CiAKK3ZvaWQgdHN0X1FXZWJQYWdlOjp0ZXN0Rm9j dXNlZFdlYkVsZW1lbnQoKQoreworICAgIFFTaWduYWxTcHkgc3B5TG9hZEZpbmlzaGVkKG1fdmll dywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpOworICAgIG1fdmlldy0+c2V0SHRtbChRU3Ry aW5nKCI8aHRtbD48Ym9keT4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGZvcm0+ IlwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlucHV0IHR5cGU9J3RleHQnIGlkPSdp bnB1dDEnLz4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlucHV0IHR5cGU9J3Bh c3N3b3JkJyBpZD0naW5wdXQyJy8+IiBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxp bnB1dCB0eXBlPSdzdWJtaXQnIGlkPSdpbnB1dDMnIHZhbHVlPSdzdWJtaXQnLz4iIFwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiPC9mb3JtPiJcCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIjxidXR0b24gdHlwZT0nYnV0dG9uJyBpZD0naW5wdXQ0JyA+Q2xpY2sgTWUhPC9idXR0 b24+IiBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjwvYm9keT48L2h0bWw+IikpOwor ICAgIFFUUllfQ09NUEFSRShzcHlMb2FkRmluaXNoZWQuY291bnQoKSwgMSk7CisgICAgbV9wYWdl LT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnaW5wdXQxJykuZm9jdXMoKSIpOworCisgICAgUVZFUklGWShtX3BhZ2UtPmZvY3VzTmV4dFBy ZXZDaGlsZCh0cnVlKSk7CisgICAgUVdlYkVsZW1lbnQgZm9jdXNlZEVsZW1lbnQgPSBtX3BhZ2Ut PmZvY3VzZWRXZWJFbGVtZW50KCk7CisgICAgUVZFUklGWShmb2N1c2VkRWxlbWVudC5hdHRyaWJ1 dGUoImlkIikgPT0gImlucHV0MiIpOworICAgIFFWRVJJRlkoZm9jdXNlZEVsZW1lbnQuYXR0cmli dXRlKCJ0eXBlIikgPT0gInBhc3N3b3JkIik7CisKKyAgICBRVkVSSUZZKG1fcGFnZS0+Zm9jdXNO ZXh0UHJldkNoaWxkKHRydWUpKTsKKyAgICBmb2N1c2VkRWxlbWVudCA9IG1fcGFnZS0+Zm9jdXNl ZFdlYkVsZW1lbnQoKTsKKyAgICBRVkVSSUZZKGZvY3VzZWRFbGVtZW50LmF0dHJpYnV0ZSgiaWQi KSA9PSAiaW5wdXQzIik7CisgICAgUVZFUklGWShmb2N1c2VkRWxlbWVudC5hdHRyaWJ1dGUoInR5 cGUiKSA9PSAic3VibWl0Iik7CisKKyAgICBRVkVSSUZZKG1fcGFnZS0+Zm9jdXNOZXh0UHJldkNo aWxkKHRydWUpKTsKKyAgICBmb2N1c2VkRWxlbWVudCA9IG1fcGFnZS0+Zm9jdXNlZFdlYkVsZW1l bnQoKTsKKyAgICBRVkVSSUZZKGZvY3VzZWRFbGVtZW50LmF0dHJpYnV0ZSgiaWQiKSA9PSAiaW5w dXQ0Iik7CisgICAgUVZFUklGWShmb2N1c2VkRWxlbWVudC5hdHRyaWJ1dGUoInR5cGUiKSA9PSAi YnV0dG9uIik7CisKKyAgICBRVkVSSUZZKG1fcGFnZS0+Zm9jdXNOZXh0UHJldkNoaWxkKGZhbHNl KSk7CisgICAgUVZFUklGWShtX3BhZ2UtPmZvY3VzTmV4dFByZXZDaGlsZChmYWxzZSkpOworICAg IFFWRVJJRlkobV9wYWdlLT5mb2N1c05leHRQcmV2Q2hpbGQoZmFsc2UpKTsKKyAgICBmb2N1c2Vk RWxlbWVudCA9IG1fcGFnZS0+Zm9jdXNlZFdlYkVsZW1lbnQoKTsKKyAgICBRVkVSSUZZKGZvY3Vz ZWRFbGVtZW50LmF0dHJpYnV0ZSgiaWQiKSA9PSAiaW5wdXQxIik7CisgICAgUVZFUklGWShmb2N1 c2VkRWxlbWVudC5hdHRyaWJ1dGUoInR5cGUiKSA9PSAidGV4dCIpOworfQorCisKKwogUVRFU1Rf TUFJTih0c3RfUVdlYlBhZ2UpCiAjaW5jbHVkZSAidHN0X3F3ZWJwYWdlLm1vYyIK 64115 2010-08-11 08:01:07 -0700 2010-08-12 07:16:13 -0700 add since tag 43498.patch text/plain 4146 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjUxNTMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMTEgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhbiBBcGkgdG8gZ2V0IGN1cnJlbnQgZm9jdXNlZCBlbGVtZW50CisKKyAgICAgICAgKiBB cGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2U6OmZvY3VzZWRXZWJFbGVtZW50KToK KyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuaDoKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3Rf cXdlYnBhZ2UuY3BwOgorICAgICAgICAodHN0X1FXZWJQYWdlOjp0ZXN0Rm9jdXNlZFdlYkVsZW1l bnQpOgorCiAyMDEwLTA4LTEwICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDog V2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAJKHJldmlzaW9uIDY1MTUzKQorKysgV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM3MTIsNiArMzcxMiwyMiBAQCBxdWludDY0IFFXZWJQYWdl OjpieXRlc1JlY2VpdmVkKCkgY29uc3QKIAogLyohCiAgICAgXHNpbmNlIDQuNworCisgICAgUmV0 dXJucyBmb2N1c2VkIHdlYiBlbGVtZW50CisqLworUVdlYkVsZW1lbnQgUVdlYlBhZ2U6OmZvY3Vz ZWRXZWJFbGVtZW50KCkKK3sKKyAgICBGcmFtZSAqZnJhbWUgPSBkLT5wYWdlLT5mb2N1c0NvbnRy b2xsZXIoKS0+Zm9jdXNlZEZyYW1lKCk7CisgICAgaWYgKGZyYW1lKSB7CisgICAgICAgIERvY3Vt ZW50ICpkb2N1bWVudCA9IGZyYW1lLT5kb2N1bWVudCgpOworICAgICAgICBpZiAoZG9jdW1lbnQp CisgICAgICAgICAgICByZXR1cm4gUVdlYkVsZW1lbnQoZG9jdW1lbnQtPmZvY3VzZWROb2RlKCkp OworICAgIH0KKyAgICByZXR1cm4gUVdlYkVsZW1lbnQoKTsKK30KKworLyohCisgICAgXHNpbmNl IDQuNwogICAgIFxmbiB2b2lkIFFXZWJQYWdlOjp2aWV3cG9ydENoYW5nZVJlcXVlc3RlZChjb25z dCBRV2ViUGFnZTo6Vmlld3BvcnRIaW50cyYgaGludHMpCiAKICAgICBUaGlzIHNpZ25hbCBpcyBl bWl0dGVkIGJlZm9yZSBhbnkgbGF5b3V0IG9mIHRoZSBjb250ZW50cywgZ2l2aW5nIHlvdSB0aGUg dmlld3BvcnQgXGEgYXJndW1lbnRzCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5oCShyZXZpc2lvbiA2NTE1MykKKysr IFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtMjc4LDYgKzI3OCw3 IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBldmVudChRRXZlbnQqKTsKICAgICBib29s IGZvY3VzTmV4dFByZXZDaGlsZChib29sIG5leHQpOworICAgIFFXZWJFbGVtZW50IGZvY3VzZWRX ZWJFbGVtZW50KCk7CiAKICAgICBRVmFyaWFudCBpbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJbnB1dE1l dGhvZFF1ZXJ5IHByb3BlcnR5KSBjb25zdDsKIApJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJw YWdlL3RzdF9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJw YWdlL3RzdF9xd2VicGFnZS5jcHAJKHJldmlzaW9uIDY1MTUzKQorKysgV2ViS2l0L3F0L3Rlc3Rz L3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNSw2ICsxMjUs NyBAQCBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgc2hvd01vZGFsRGlhbG9nKCk7CiAgICAgdm9p ZCB0ZXN0U3RvcFNjaGVkdWxlZFBhZ2VSZWZyZXNoKCk7CiAgICAgdm9pZCBmaW5kVGV4dCgpOwor ICAgIHZvaWQgdGVzdEZvY3VzZWRXZWJFbGVtZW50KCk7CiAgICAgCiBwcml2YXRlOgogICAgIFFX ZWJWaWV3KiBtX3ZpZXc7CkBAIC0yMTczLDUgKzIxNzQsNDQgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6 OmZpbmRUZXh0KCkKICAgICB9CiB9CiAKK3ZvaWQgdHN0X1FXZWJQYWdlOjp0ZXN0Rm9jdXNlZFdl YkVsZW1lbnQoKQoreworICAgIFFTaWduYWxTcHkgc3B5TG9hZEZpbmlzaGVkKG1fdmlldywgU0lH TkFMKGxvYWRGaW5pc2hlZChib29sKSkpOworICAgIG1fdmlldy0+c2V0SHRtbChRU3RyaW5nKCI8 aHRtbD48Ym9keT4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGZvcm0+IlwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlucHV0IHR5cGU9J3RleHQnIGlkPSdpbnB1dDEn Lz4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlucHV0IHR5cGU9J3Bhc3N3b3Jk JyBpZD0naW5wdXQyJy8+IiBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxpbnB1dCB0 eXBlPSdzdWJtaXQnIGlkPSdpbnB1dDMnIHZhbHVlPSdzdWJtaXQnLz4iIFwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiPC9mb3JtPiJcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg IjxidXR0b24gdHlwZT0nYnV0dG9uJyBpZD0naW5wdXQ0JyA+Q2xpY2sgTWUhPC9idXR0b24+IiBc CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjwvYm9keT48L2h0bWw+IikpOworICAgIFFU UllfQ09NUEFSRShzcHlMb2FkRmluaXNoZWQuY291bnQoKSwgMSk7CisgICAgbV9wYWdlLT5tYWlu RnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaW5w dXQxJykuZm9jdXMoKSIpOworCisgICAgUVZFUklGWShtX3BhZ2UtPmZvY3VzTmV4dFByZXZDaGls ZCh0cnVlKSk7CisgICAgUVdlYkVsZW1lbnQgZm9jdXNlZEVsZW1lbnQgPSBtX3BhZ2UtPmZvY3Vz ZWRXZWJFbGVtZW50KCk7CisgICAgUVZFUklGWShmb2N1c2VkRWxlbWVudC5hdHRyaWJ1dGUoImlk IikgPT0gImlucHV0MiIpOworICAgIFFWRVJJRlkoZm9jdXNlZEVsZW1lbnQuYXR0cmlidXRlKCJ0 eXBlIikgPT0gInBhc3N3b3JkIik7CisKKyAgICBRVkVSSUZZKG1fcGFnZS0+Zm9jdXNOZXh0UHJl dkNoaWxkKHRydWUpKTsKKyAgICBmb2N1c2VkRWxlbWVudCA9IG1fcGFnZS0+Zm9jdXNlZFdlYkVs ZW1lbnQoKTsKKyAgICBRVkVSSUZZKGZvY3VzZWRFbGVtZW50LmF0dHJpYnV0ZSgiaWQiKSA9PSAi aW5wdXQzIik7CisgICAgUVZFUklGWShmb2N1c2VkRWxlbWVudC5hdHRyaWJ1dGUoInR5cGUiKSA9 PSAic3VibWl0Iik7CisKKyAgICBRVkVSSUZZKG1fcGFnZS0+Zm9jdXNOZXh0UHJldkNoaWxkKHRy dWUpKTsKKyAgICBmb2N1c2VkRWxlbWVudCA9IG1fcGFnZS0+Zm9jdXNlZFdlYkVsZW1lbnQoKTsK KyAgICBRVkVSSUZZKGZvY3VzZWRFbGVtZW50LmF0dHJpYnV0ZSgiaWQiKSA9PSAiaW5wdXQ0Iik7 CisgICAgUVZFUklGWShmb2N1c2VkRWxlbWVudC5hdHRyaWJ1dGUoInR5cGUiKSA9PSAiYnV0dG9u Iik7CisKKyAgICBRVkVSSUZZKG1fcGFnZS0+Zm9jdXNOZXh0UHJldkNoaWxkKGZhbHNlKSk7Cisg ICAgUVZFUklGWShtX3BhZ2UtPmZvY3VzTmV4dFByZXZDaGlsZChmYWxzZSkpOworICAgIFFWRVJJ RlkobV9wYWdlLT5mb2N1c05leHRQcmV2Q2hpbGQoZmFsc2UpKTsKKyAgICBmb2N1c2VkRWxlbWVu dCA9IG1fcGFnZS0+Zm9jdXNlZFdlYkVsZW1lbnQoKTsKKyAgICBRVkVSSUZZKGZvY3VzZWRFbGVt ZW50LmF0dHJpYnV0ZSgiaWQiKSA9PSAiaW5wdXQxIik7CisgICAgUVZFUklGWShmb2N1c2VkRWxl bWVudC5hdHRyaWJ1dGUoInR5cGUiKSA9PSAidGV4dCIpOworfQorCisKKwogUVRFU1RfTUFJTih0 c3RfUVdlYlBhZ2UpCiAjaW5jbHVkZSAidHN0X3F3ZWJwYWdlLm1vYyIK