43469 2010-08-04 00:09:48 -0700 <noscript> works the other way around in some cases when xhtmlmp enabled 2010-08-05 06:20:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 charles.wei webkit-unassigned commit-queue staikos oldest_to_newest 259902 0 63422 charles.wei 2010-08-04 00:09:48 -0700 Created attachment 63422 html file that demos the bug <noscript> should be processed when the Javascript is DISABLED and should be ignored when javascript is ENABLED. But with WebKit, if you enable xhtmlmp , noscript works the other way around in some cases, that is, <noscript> is processed and rendered when javascript is ENABLED, and is ignored when Javascript is DISABLED. The attachment reveals it. Please note, you need to turn on xhtmlmp support to reproduce this. 259916 1 63426 charles.wei 2010-08-04 00:56:06 -0700 Created attachment 63426 The patch This patch fixes the problem. The logic was oppositely wrong in deciding if <noscript> should be processed. 260561 2 63426 commit-queue 2010-08-05 06:20:18 -0700 Comment on attachment 63426 The patch Clearing flags on attachment: 63426 Committed r64740: <http://trac.webkit.org/changeset/64740> 260562 3 commit-queue 2010-08-05 06:20:22 -0700 All reviewed patches have been landed. Closing bug. 63422 2010-08-04 00:09:48 -0700 2010-08-04 00:09:48 -0700 html file that demos the bug noscript.xhtml application/xhtml+xml 378 charles.wei PD94bWwgdmVyc2lvbj0iMS4wIj8+CjwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vV0FQRk9SVU0v L0RURCBYSFRNTCBNb2JpbGUgMS4xLy9FTiIgImh0dHA6Ly93d3cud2FwZm9ydW0ub3JnL0RURC94 aHRtbC1tb2JpbGUxMS5kdGQiPgoKPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkv eGh0bWwiPgo8Ym9keT4KPHA+IElmIHlvdSBzZWUgdGhpcyBsaW5lIG9ubHkgd2hlbiBqYXZhc2Ny aXB0IGVuYWJsZWQsIGl0IHN1Y2NlZWRzOyBvbmUgbGluZSBmb2xsb3dzIGlmIEphdmFzY3JpcHQg aXMgZGlzYWJsZWQ8L3A+Cjxub3NjcmlwdD48aDEgaWQ9Im5vc2NyaXB0Ij5pbnNpZGUgbm9zY3Jp cHQ8L2gxPjwvbm9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgoK 63426 2010-08-04 00:56:06 -0700 2010-08-05 06:20:18 -0700 The patch 43469.patch text/plain 2972 charles.wei SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDYzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMDQgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIDxub3NjcmlwdD4gaXMgd29ya2luZyB0aGUgb3RoZXIgd2F5IGFyb3VuZCBpbiBz b21lIGNhc2VzIHdpdGggeGh0bWxtcCBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzQ2OQorCisgICAgICAgIFRlc3Q6IGZhc3QveGh0bWxt cC9ub3NjcmlwdC1iYXNpYy54aHRtbAorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpEb2N1bWVudCk6CisKIDIwMTAtMDgtMDMgIERhcmlu IEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJu c3RlaW4uCkluZGV4OiBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA2NDYzMCkKKysrIFdlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDY1LDcgKzQ2NSw3IEBAIERvY3VtZW50OjpE b2N1bWVudChGcmFtZSogZnJhbWUsIGNvbnN0IEsKICAgICBzdGF0aWMgaW50IGRvY0lEID0gMDsK ICAgICBtX2RvY0lEID0gZG9jSUQrKzsKICNpZiBFTkFCTEUoWEhUTUxNUCkKLSAgICBtX3Nob3Vs ZFByb2Nlc3NOb1NjcmlwdEVsZW1lbnQgPSBtX2ZyYW1lICYmIG1fZnJhbWUtPnNjcmlwdCgpLT5j YW5FeGVjdXRlU2NyaXB0cyhOb3RBYm91dFRvRXhlY3V0ZVNjcmlwdCk7CisgICAgbV9zaG91bGRQ cm9jZXNzTm9TY3JpcHRFbGVtZW50ID0gIShtX2ZyYW1lICYmIG1fZnJhbWUtPnNjcmlwdCgpLT5j YW5FeGVjdXRlU2NyaXB0cyhOb3RBYm91dFRvRXhlY3V0ZVNjcmlwdCkpOwogI2VuZGlmCiB9CiAK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY0NjM0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMDQgIENoYXJsZXMgV2VpICA8Y2hh cmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MzQ2OQorICAgICAgICA8bm9zY3JpcHQ+IGlzIHdvcmtpbmcgd3JvbmcgaW4gc29tZSBj YXNlcyB3aGVuIHhodG1sbXAgaXMgZW5hYmxlZC4KKworICAgICAgICAqIGZhc3QveGh0bWxtcC9u b3NjcmlwdC1iYXNpYy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QveGh0bWxt cC9ub3NjcmlwdC1iYXNpYy54aHRtbDogQWRkZWQuCisKIDIwMTAtMDgtMDMgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5p Zy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QveGh0bWxtcC9ub3NjcmlwdC1iYXNpYy1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC94aHRtbG1wL25vc2NyaXB0LWJh c2ljLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QveGh0bWxt cC9ub3NjcmlwdC1iYXNpYy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBA QAorSWYgeW91IHNlZSB0aGlzIGxpbmUgb25seSB3aGVuIGphdmFzY3JpcHQgZW5hYmxlZCwgaXQg c3VjY2VlZHM7IG9uZSBsaW5lIGZvbGxvd3MgaWYgSmF2YXNjcmlwdCBpcyBkaXNhYmxlZAorCisK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QveGh0bWxtcC9ub3NjcmlwdC1iYXNpYy54aHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3hodG1sbXAvbm9zY3JpcHQtYmFzaWMueGh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3hodG1sbXAvbm9zY3JpcHQtYmFzaWMu eGh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTUgQEAKKzw/eG1sIHZlcnNpb249IjEuMCI/ PgorPCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XQVBGT1JVTS8vRFREIFhIVE1MIE1vYmlsZSAx LjEvL0VOIiAiaHR0cDovL3d3dy53YXBmb3J1bS5vcmcvRFREL3hodG1sLW1vYmlsZTExLmR0ZCI+ CisKKzxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKzxib2R5Pgor PHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+CisKKzxwPiBJZiB5b3Ugc2VlIHRo aXMgbGluZSBvbmx5IHdoZW4gamF2YXNjcmlwdCBlbmFibGVkLCBpdCBzdWNjZWVkczsgb25lIGxp bmUgZm9sbG93cyBpZiBKYXZhc2NyaXB0IGlzIGRpc2FibGVkPC9wPgorPG5vc2NyaXB0PjxoMSBp ZD0ibm9zY3JpcHQiPmluc2lkZSBub3NjcmlwdDwvaDE+PC9ub3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4KKwo=