43460 2010-08-03 19:42:19 -0700 prepare-ChangeLog fails mysteriously if curl doesn't support ssl 2010-08-04 10:13:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aa webkit-unassigned aroben cjerdonek darin dbates ddkilzer eric joepeck oldest_to_newest 259818 0 aa 2010-08-03 19:42:19 -0700 It ends up printing "Bug $bugNumber has no bug description. Maybe you set wrong bug ID?", which isn't really the problem. 259831 1 63408 aa 2010-08-03 20:05:20 -0700 Created attachment 63408 Patch 259836 2 joepeck 2010-08-03 20:17:28 -0700 This patch looks good to me, however the output might be confusing to users. I think it would be fine with an added line of output like: "Could not get the bug description for bug $bugNumber" Other than that I'm good with it. I'm CCing Eric, who has some more experience with Scripts (and he originally wrote the code above using curl) to see if he can sanity check it as well. Thanks for the quick improvement Aaron! 259837 3 63408 eric 2010-08-03 20:20:22 -0700 Comment on attachment 63408 Patch Looks FANTASTIC. Thank you. Maybe we should move to using some built in perl way of fetching the bug instead? I don't know what built-in perl SSL solutions there are. 259838 4 63408 eric 2010-08-03 20:21:28 -0700 Comment on attachment 63408 Patch I CC'd other folks who have perl experience in case they have bright ideas. But looks good to me. 259840 5 joepeck 2010-08-03 20:24:39 -0700 (In reply to comment #4) > (From update of attachment 63408 [details]) > I CC'd other folks who have perl experience in case they have > bright ideas. But looks good to me. Thanks for the quick reply! I CC'd someone as well. @Aaron, I still suggest adding the additional line out output to clarify what went wrong. It also hints at why curl was used in the first place. 260080 6 aa 2010-08-04 10:13:04 -0700 Committed r64654: <http://trac.webkit.org/changeset/64654> 63408 2010-08-03 20:05:20 -0700 2010-08-03 20:21:28 -0700 Patch bug-43460-20100803200518.patch text/plain 1912 aa ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyYzA1YWM1ZTczNzNiNmQ0YTgyMGUyNjc4Y2ZiYjE0OTE1MDZjNTY5Li45ZDAwZGY3 Zjk5Y2I4ZGY3MGUwNTZkMGM5MDYyNjkwYjY1M2NmNjljIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDgtMDMgIEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcHJlcGFyZS1DaGFuZ2VMb2cg ZmFpbHMgbXlzdGVyaW91c2x5IGlmIGN1cmwgZG9lc24ndCBzdXBwb3J0IHNzbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM0NjAKKworICAgICAgICAq IFNjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2c6CisKIDIwMTAtMDgtMDMgIEtlbnQgVGFtdXJhICA8 dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv di4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IDJlZjFlYjQ4MDUzNTQ4 NmViMDhlY2JmMWRjNmM3ZTUzNTc1YzMxNGMuLmJjODQwYzAzZDI1YmNmNjgxNzFjYWMxYWI5NmIw YjRiM2IzOGViNWQgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFu Z2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMjY0 LDggKzI2NCwxNSBAQCBpZiAoJGJ1Z051bWJlcikgewogICAgICMgY2FyZSBhYm91dCB2YWxpZGF0 aW5nIHRoYXQgYnVncy53ZWJraXQub3JnIGlzIHdobyBpdCBzYXlzIGl0IGlzIGhlcmUuCiAgICAg bXkgJGRlc2NyaXB0aW9uTGluZSA9IGBjdXJsIC0taW5zZWN1cmUgLS1zaWxlbnQgIiRidWdYTUxV UkwiIHwgZ3JlcCBzaG9ydF9kZXNjYDsKICAgICBpZiAoJGRlc2NyaXB0aW9uTGluZSAhfiAvPHNo b3J0X2Rlc2M+KC4qKTxcL3Nob3J0X2Rlc2M+LykgewotICAgICAgICBwcmludCBTVERFUlIgIiAg QnVnICRidWdOdW1iZXIgaGFzIG5vIGJ1ZyBkZXNjcmlwdGlvbi4gTWF5YmUgeW91IHNldCB3cm9u ZyBidWcgSUQ/XG4iOwotICAgICAgICBwcmludCBTVERFUlIgIiAgVGhlIGJ1ZyBVUkw6ICRidWdY TUxVUkxcbiI7CisgICAgICAgICMgTWF5YmUgdGhlIHJlYXNvbiB0aGUgYWJvdmUgZGlkIG5vdCB3 b3JrIGlzIGJlY2F1c2UgdGhlIGN1cmwgdGhhdCBpcyBpbnN0YWxsZWQgZG9lc24ndAorICAgICAg ICAjIHN1cHBvcnQgc3NsIGF0IGFsbC4KKyAgICAgICAgaWYgKGBjdXJsIC0tdmVyc2lvbiB8IGdy ZXAgXlByb3RvY29sc2AgIX4gL1xiaHR0cHNcYi8pIHsKKyAgICAgICAgICAgIHByaW50IFNUREVS UiAiICBJdCBsb29rcyBsaWtlIHlvdXIgdmVyc2lvbiBvZiBjdXJsIGRvZXMgbm90IHN1cHBvcnQg c3NsLlxuIjsKKyAgICAgICAgICAgIHByaW50IFNUREVSUiAiICBJZiB5b3UgYXJlIHVzaW5nIG1h Y3BvcnRzLCB0aGlzIGNhbiBiZSBmaXhlZCB3aXRoIHN1ZG8gcG9ydCBpbnN0YWxsIGN1cmwrc3Ns LlxuIjsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHByaW50IFNUREVSUiAiICBCdWcg JGJ1Z051bWJlciBoYXMgbm8gYnVnIGRlc2NyaXB0aW9uLiBNYXliZSB5b3Ugc2V0IHdyb25nIGJ1 ZyBJRD9cbiI7CisgICAgICAgICAgICBwcmludCBTVERFUlIgIiAgVGhlIGJ1ZyBVUkw6ICRidWdY TUxVUkxcbiI7CisgICAgICAgIH0KICAgICAgICAgZXhpdCAxOwogICAgIH0KICAgICAkYnVnRGVz Y3JpcHRpb24gPSBkZWNvZGVFbnRpdGllcygkMSk7Cg==