43444 2010-08-03 14:13:18 -0700 PLATFORM(CF) is false on Windows in JavaScriptCore 2010-08-03 15:04:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren webkit-unassigned aroben mrowe nlawrence oldest_to_newest 259682 0 ggaren 2010-08-03 14:13:18 -0700 PLATFORM(CF) is defined in WebCore/config.h, which means that JavaScriptCore is not in on the fun. We'd like JavaScriptCore to know about PLATFORM(CF) so it can use the CF GC activity callback. I'm not immediately sure what the best way is to distinguish Windows builds with CF from those without. WebCore uses the WIN_CAIRO #define, which is probably not right for JavaScriptCore, and is even a little weird for WebCore. 259700 1 63378 ggaren 2010-08-03 14:38:46 -0700 Created attachment 63378 Patch 259702 2 63378 mrowe 2010-08-03 14:42:57 -0700 Comment on attachment 63378 Patch The presence of #define WTF_USE_WININET 1 in Platform.h is very odd, since WebCore/config.h undefines that macro. Not really relevant to your patch, but it’s strange. Your changes to WebCore/WebCore.xcodeproj/project.pbxproj should be excluded from this patch since they’re not relevant. r=me 259718 3 ggaren 2010-08-03 15:04:41 -0700 Committed r64591: <http://trac.webkit.org/changeset/64591> 63378 2010-08-03 14:38:46 -0700 2010-08-03 14:42:57 -0700 Patch bug-43444-20100803143845.patch text/plain 6385 ggaren SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0NTg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMDMgIEdlb2ZmcmV5 IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDM0NDQKKyAgICAgICAgUExBVEZPUk0oQ0YpIGlzIGZhbHNlIG9uIFdpbmRvd3MgaW4gSmF2 YVNjcmlwdENvcmUKKworICAgICAgICBNb3ZlZCBzb21lIFBMQVRGT1JNKFdJTikgI2RlZmluZXMg ZG93biBpbnRvIEphdmFTY3JpcHRDb3JlLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisK IDIwMTAtMDgtMDMgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBUcnkgdG8gZml4IFdpbmRvd3MgYnVpbGQ6IERvbid0IHVzZSBHQ0FjdGl2aXR5Q2FsbGJhY2tD RiBvbiBXaW5kb3dzLCBzaW5jZQpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDY0 NTgzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAg LTY0OSw2ICs2NDksOCBAQAogCiAjaWYgUExBVEZPUk0oV0lOKQogI2RlZmluZSBXVEZfVVNFX1dJ TklORVQgMQorI2RlZmluZSBXVEZfUExBVEZPUk1fQ0YgMQorI2RlZmluZSBXVEZfVVNFX1BUSFJF QURTIDAKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oV1gpCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNjQ1ODcpCisrKyBX ZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA4 LTAzICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQzNDQ0CisgICAgICAgIFBMQVRGT1JNKENGKSBpcyBmYWxzZSBvbiBX aW5kb3dzIGluIEphdmFTY3JpcHRDb3JlCisKKyAgICAgICAgTW92ZWQgc29tZSBQTEFURk9STShX SU4pICNkZWZpbmVzIGRvd24gaW50byBKYXZhU2NyaXB0Q29yZS4KKworICAgICAgICAqIFdlYkNv cmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKyAgICAgICAgKiBjb25maWcuaDoKKwogMjAx MC0wNy0zMCAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDogV2ViQ29yZS9jb25maWcuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2NvbmZpZy5oCShyZXZpc2lvbiA2NDU4MykKKysrIFdlYkNvcmUv Y29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1Myw4ICsxNTMsNiBAQAogI3VuZGVmIFdURl9V U0VfQ1VSTAogI2VuZGlmCiAjdW5kZWYgV1RGX1VTRV9XSU5JTkVUCi0jZGVmaW5lIFdURl9QTEFU Rk9STV9DRiAxCi0jZGVmaW5lIFdURl9VU0VfUFRIUkVBRFMgMAogI2VuZGlmCiAKICNpZiBQTEFU Rk9STShNQUMpCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv ago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv agkocmV2aXNpb24gNjQ1ODMpCisrKyBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagkod29ya2luZyBjb3B5KQpAQCAtNDk3OCw5ICs0OTc4LDkgQEAKIAkJQzU4NUE2RUEx MUQ0RkIzRDAwNEMzRTRCIC8qIElEQktleVJhbmdlLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBDNTg1QTZCNjExRDRGQjNEMDA0QzNFNEIgLyogSURCS2V5 UmFuZ2UuaCAqLzsgfTsKIAkJQzU4NUE2RUMxMUQ0RkIzRDAwNEMzRTRCIC8qIElEQktleVRyZWUu aCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEM1ODVBNkI4 MTFENEZCM0QwMDRDM0U0QiAvKiBJREJLZXlUcmVlLmggKi87IH07CiAJCUM1ODVBNkVEMTFENEZC M0QwMDRDM0U0QiAvKiBJREJPYmplY3RTdG9yZS5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJY QnVpbGRGaWxlOyBmaWxlUmVmID0gQzU4NUE2QjkxMUQ0RkIzRDAwNEMzRTRCIC8qIElEQk9iamVj dFN0b3JlLmggKi87IH07Ci0JCUM1ODVBNkYwMTFENEZCM0QwMDRDM0U0QiAvKiBJREJPYmplY3RT dG9yZS5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBD NTg1QTZCQzExRDRGQjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmUuY3BwICovOyB9OwogCQlD NTg1QTZFRTExRDRGQjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmVCYWNrZW5kSW1wbC5jcHAg aW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBDNTg1QTZCQTEx RDRGQjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmVCYWNrZW5kSW1wbC5jcHAgKi87IH07CiAJ CUM1ODVBNkVGMTFENEZCM0QwMDRDM0U0QiAvKiBJREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsLmgg aW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBDNTg1QTZCQjEx RDRGQjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmVCYWNrZW5kSW1wbC5oICovOyB9OworCQlD NTg1QTZGMDExRDRGQjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmUuY3BwIGluIFNvdXJjZXMg Ki8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQzU4NUE2QkMxMUQ0RkIzRDAwNEMz RTRCIC8qIElEQk9iamVjdFN0b3JlLmNwcCAqLzsgfTsKIAkJQzU4NUE2RjExMUQ0RkIzRDAwNEMz RTRCIC8qIElEQk9iamVjdFN0b3JlQmFja2VuZEludGVyZmFjZS5oIGluIEhlYWRlcnMgKi8gPSB7 aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQzU4NUE2QkQxMUQ0RkIzRDAwNEMzRTRCIC8q IElEQk9iamVjdFN0b3JlQmFja2VuZEludGVyZmFjZS5oICovOyB9OwogCQlDNTg1QTZGMzExRDRG QjNEMDA0QzNFNEIgLyogSURCUmVxdWVzdC5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhC dWlsZEZpbGU7IGZpbGVSZWYgPSBDNTg1QTZCRjExRDRGQjNEMDA0QzNFNEIgLyogSURCUmVxdWVz dC5jcHAgKi87IH07CiAJCUM1ODVBNkY0MTFENEZCM0QwMDRDM0U0QiAvKiBJREJSZXF1ZXN0Lmgg aW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBDNTg1QTZDMDEx RDRGQjNEMDA0QzNFNEIgLyogSURCUmVxdWVzdC5oICovOyB9OwpAQCAtMTA2ODksMTIgKzEwNjg5 LDEyIEBACiAJCUM1ODVBNkI2MTFENEZCM0QwMDRDM0U0QiAvKiBJREJLZXlSYW5nZS5oICovID0g e2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVU eXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBJREJLZXlSYW5nZS5oOyBzb3VyY2VUcmVlID0g Ijxncm91cD4iOyB9OwogCQlDNTg1QTZCNzExRDRGQjNEMDA0QzNFNEIgLyogSURCS2V5UmFuZ2Uu aWRsICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RL bm93bkZpbGVUeXBlID0gdGV4dDsgcGF0aCA9IElEQktleVJhbmdlLmlkbDsgc291cmNlVHJlZSA9 ICI8Z3JvdXA+IjsgfTsKIAkJQzU4NUE2QjgxMUQ0RkIzRDAwNEMzRTRCIC8qIElEQktleVRyZWUu aCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25v d25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gSURCS2V5VHJlZS5oOyBzb3VyY2VU cmVlID0gIjxncm91cD4iOyB9OwotCQlDNTg1QTZCQzExRDRGQjNEMDA0QzNFNEIgLyogSURCT2Jq ZWN0U3RvcmUuY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9 IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gSURCT2Jq ZWN0U3RvcmUuY3BwOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlDNTg1QTZCOTExRDRG QjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmUuaCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJl bmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5o OyBwYXRoID0gSURCT2JqZWN0U3RvcmUuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKLQkJ QzU4NUE2QkUxMUQ0RkIzRDAwNEMzRTRCIC8qIElEQk9iamVjdFN0b3JlLmlkbCAqLyA9IHtpc2Eg PSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9 IHRleHQ7IHBhdGggPSBJREJPYmplY3RTdG9yZS5pZGw7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7 IH07CiAJCUM1ODVBNkJBMTFENEZCM0QwMDRDM0U0QiAvKiBJREJPYmplY3RTdG9yZUJhY2tlbmRJ bXBsLmNwcCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBs YXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0aCA9IElEQk9iamVjdFN0 b3JlQmFja2VuZEltcGwuY3BwOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlDNTg1QTZC QjExRDRGQjNEMDA0QzNFNEIgLyogSURCT2JqZWN0U3RvcmVCYWNrZW5kSW1wbC5oICovID0ge2lz YSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBl ID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBJREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsLmg7IHNv dXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCUM1ODVBNkJDMTFENEZCM0QwMDRDM0U0QiAvKiBJ REJPYmplY3RTdG9yZS5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29k aW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGggPSBJ REJPYmplY3RTdG9yZS5jcHA7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCUM1ODVBNkJE MTFENEZCM0QwMDRDM0U0QiAvKiBJREJPYmplY3RTdG9yZUJhY2tlbmRJbnRlcmZhY2UuaCAqLyA9 IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxl VHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gSURCT2JqZWN0U3RvcmVCYWNrZW5kSW50ZXJm YWNlLmg7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCUM1ODVBNkJFMTFENEZCM0QwMDRD M0U0QiAvKiBJREJPYmplY3RTdG9yZS5pZGwgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsg ZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSB0ZXh0OyBwYXRoID0gSURCT2Jq ZWN0U3RvcmUuaWRsOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlDNTg1QTZCRjExRDRG QjNEMDA0QzNFNEIgLyogSURCUmVxdWVzdC5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5j ZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5j cHA7IHBhdGggPSBJREJSZXF1ZXN0LmNwcDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJ QzU4NUE2QzAxMUQ0RkIzRDAwNEMzRTRCIC8qIElEQlJlcXVlc3QuaCAqLyA9IHtpc2EgPSBQQlhG aWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJj ZWNvZGUuYy5oOyBwYXRoID0gSURCUmVxdWVzdC5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9 OwogCQlDNTg1QTZDMTExRDRGQjNEMDA0QzNFNEIgLyogSURCUmVxdWVzdC5pZGwgKi8gPSB7aXNh ID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUg PSB0ZXh0OyBwYXRoID0gSURCUmVxdWVzdC5pZGw7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07 Cg==