<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43442</bug_id>
          
          <creation_ts>2010-08-03 13:35:49 -0700</creation_ts>
          <short_desc>[Qt] QtWebKit does not link on Windows CE 6 due to sqlite3 problem</short_desc>
          <delta_ts>2010-09-07 01:29:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Joerg Bornemann">joerg.bornemann</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>joerg.bornemann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>259667</commentid>
    <comment_count>0</comment_count>
    <who name="Joerg Bornemann">joerg.bornemann</who>
    <bug_when>2010-08-03 13:35:49 -0700</bug_when>
    <thetext>QtWebKit does not link on Windows CE 6 due to sqlite3 problem
This affects Qt 4.6.3 and above.

The exact linker error is:
sqlite3.obj : error LNK2019: unresolved external symbol localtime_s referenced in function localtimeOffset

The function localtime_s doesn&apos;t exist in the WinCE 6 MSVCRT.

To fix this, we could just add a
    wince*:DEFINES += HAVE_LOCALTIME_S=0
to WebKit.pro in the sqlite scope.

This is even ok for WinCE 5.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259668</commentid>
    <comment_count>1</comment_count>
    <who name="Joerg Bornemann">joerg.bornemann</who>
    <bug_when>2010-08-03 13:37:08 -0700</bug_when>
    <thetext>The corresponding Qt issue is http://bugreports.qt.nokia.com/browse/QTBUG-5120</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>261153</commentid>
    <comment_count>2</comment_count>
      <attachid>63705</attachid>
    <who name="Joerg Bornemann">joerg.bornemann</who>
    <bug_when>2010-08-06 01:44:24 -0700</bug_when>
    <thetext>Created attachment 63705
fix #1

fixes the linker error by defining HAVE_LOCALTIME_S=0 in WebCore.pro</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>261457</commentid>
    <comment_count>3</comment_count>
      <attachid>63705</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-08-06 14:13:23 -0700</bug_when>
    <thetext>Comment on attachment 63705
fix #1

Every patch requires a ChangeLog.  This one is also not made from a WebKit checkout.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>263192</commentid>
    <comment_count>4</comment_count>
      <attachid>64101</attachid>
    <who name="Joerg Bornemann">joerg.bornemann</who>
    <bug_when>2010-08-11 05:20:41 -0700</bug_when>
    <thetext>Created attachment 64101
fix #2

attempt #2. Now diffing from WebKit checkout and with ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>274886</commentid>
    <comment_count>5</comment_count>
      <attachid>64101</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2010-09-07 01:07:42 -0700</bug_when>
    <thetext>Comment on attachment 64101
fix #2

Asking the cq to land it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>274895</commentid>
    <comment_count>6</comment_count>
      <attachid>64101</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-07 01:29:16 -0700</bug_when>
    <thetext>Comment on attachment 64101
fix #2

Clearing flags on attachment: 64101

Committed r66865: &lt;http://trac.webkit.org/changeset/66865&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>274896</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-07 01:29:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>63705</attachid>
            <date>2010-08-06 01:44:24 -0700</date>
            <delta_ts>2010-08-11 05:20:41 -0700</delta_ts>
            <desc>fix #1</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>447</size>
            <attacher name="Joerg Bornemann">joerg.bornemann</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9XZWJDb3JlLnBybyBiL3Ny
Yy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCA3ZTU3Mzk0Li4wZTQ5
YzczIDEwMDY0NAotLS0gYS9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvV2ViQ29yZS5wcm8K
KysrIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0yNTk1LDYg
KzI1OTUsOCBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU1FMSVRFPTEpIHsKICAgICAgICAg
fQogICAgIH0KIAorICAgIHdpbmNlKjogREVGSU5FUyArPSBIQVZFX0xPQ0FMVElNRV9TPTAKKwog
ICAgIFNPVVJDRVMgKz0gXAogICAgICAgICBwbGF0Zm9ybS9zcWwvU1FMaXRlQXV0aG9yaXplci5j
cHAgXAogICAgICAgICBwbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwIFwK
</data>
<flag name="review"
          id="52110"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>64101</attachid>
            <date>2010-08-11 05:20:41 -0700</date>
            <delta_ts>2010-09-07 01:29:16 -0700</delta_ts>
            <desc>fix #2</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>871</size>
            <attacher name="Joerg Bornemann">joerg.bornemann</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZDZlOWZmNS4uN2ExZTIzMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0xMSAgSm9lcmcgQm9ybmVt
YW5uICA8am9lcmcuYm9ybmVtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggUXRXZWJLaXQgbGlua2VyIGVycm9yIG9uIFdp
bmRvd3MgQ0UgNi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTQzNDQyCisKKyAgICAgICAgRG9lc24ndCBhZmZlY3QgYW55IHRlc3RzLgorCisgICAgICAg
ICogV2ViQ29yZS5wcm86CisKIDIwMTAtMDgtMTAgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1n
aXQgYS9XZWJDb3JlL1dlYkNvcmUucHJvIGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCBlMTY3
NGUzLi5iNTY3Y2NmIDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNv
cmUvV2ViQ29yZS5wcm8KQEAgLTIzOTIsNiArMjM5Miw4IEBAIGNvbnRhaW5zKERFRklORVMsIEVO
QUJMRV9TUUxJVEU9MSkgewogICAgICAgICB9CiAgICAgfQogCisgICAgd2luY2UqOkRFRklORVMg
Kz0gSEFWRV9MT0NBTFRJTUVfUz0wCisKICAgICBTT1VSQ0VTICs9IFwKICAgICAgICAgcGxhdGZv
cm0vc3FsL1NRTGl0ZUF1dGhvcml6ZXIuY3BwIFwKICAgICAgICAgcGxhdGZvcm0vc3FsL1NRTGl0
ZURhdGFiYXNlLmNwcCBcCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>