43432 2010-08-03 09:55:31 -0700 MathML merror element style adjustments 2010-08-05 01:46:13 -0700 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 sausset webkit-unassigned commit-queue oldest_to_newest 259516 0 sausset 2010-08-03 09:55:31 -0700 The default style of merror should make it easily detectable when reading a MathML rendering. A patch that makes merror more clearly detectable and that roughly matches Mozilla behaviour will follow to have a consistent behaviour between different MathML implementations as the MathML3 specification let some freedom about merror style: http://www.w3.org/TR/MathML3/chapter3.html#presm.merror 259517 1 63344 sausset 2010-08-03 09:57:49 -0700 Created attachment 63344 Patch 259626 2 63344 darin 2010-08-03 12:34:26 -0700 Comment on attachment 63344 Patch Can we add a test case for this? We should be able to see this with getComputedStyle, so it could be tested with a dumpAsText-style test. 259652 3 63370 sausset 2010-08-03 13:07:01 -0700 Created attachment 63370 Test case Test case adapted from the MathML 3 test suite example. I don't understand what do you mean by "dumpAsText-style test". I'm quite new to WebKit development and I don't know all the subtleties. Should I include the test in LayoutTests by submitting a new patch with expected results? Or do you suggest something else? 260465 4 63344 commit-queue 2010-08-05 01:46:08 -0700 Comment on attachment 63344 Patch Clearing flags on attachment: 63344 Committed r64723: <http://trac.webkit.org/changeset/64723> 260466 5 commit-queue 2010-08-05 01:46:13 -0700 All reviewed patches have been landed. Closing bug. 63344 2010-08-03 09:57:49 -0700 2010-08-05 01:46:08 -0700 Patch MathML_merror.patch text/plain 973 sausset SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDU2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMDMgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU21hbGwgc3R5bGUgYWRqdXN0bWVudHMgZm9yIE1hdGhNTCBtZXJyb3IgZWxlbWVudC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNDMyCisKKyAg ICAgICAgKiBjc3MvbWF0aG1sLmNzczoKKyAgICAgICAgKG1lcnJvcik6CisKIDIwMTAtMDgtMDMg IFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJl dmlld2VkOiBzcGVjdWxhdGl2ZSBjaHJvbWl1bSB0ZXN0cyBmaXguCkluZGV4OiBXZWJDb3JlL2Nz cy9tYXRobWwuY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL21hdGhtbC5jc3MJKHJldmlz aW9uIDY0MzU3KQorKysgV2ViQ29yZS9jc3MvbWF0aG1sLmNzcwkod29ya2luZyBjb3B5KQpAQCAt MTEzLDggKzExMywxMiBAQCBhbm5vdGF0aW9uLCBhbm5vdGF0aW9uLXhtbCB7CiBtcGhhbnRvbSB7 CiAgICAgdmlzaWJpbGl0eTogaGlkZGVuOwogfQorCiBtZXJyb3IgewogICAgIG91dGxpbmU6IHNv bGlkIHRoaW4gcmVkOworICAgIGZvbnQtd2VpZ2h0OiBib2xkOworICAgIGZvbnQtZmFtaWx5OiBz YW5zLXNlcmlmOworICAgIGJhY2tncm91bmQtY29sb3I6IGxpZ2h0WWVsbG93OwogfQogCiBtc3Fy dCB7Cg== 63370 2010-08-03 13:07:01 -0700 2010-08-03 13:07:01 -0700 Test case error.xhtml application/xhtml+xml 371 sausset PGh0bWwgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgo8aGVhZD4KPHRpdGxl PkVycm9yPC90aXRsZT4KPHN0eWxlIHR5cGU9J3RleHQvY3NzJz4KPC9zdHlsZT4KPC9oZWFkPgo8 Ym9keT4KPHAgaWQ9J3QxJz5FcnJvciBpbmRpY2F0ZWQgYnkgdmlzdWFsIGhpbnRzOiAKPG1hdGgg eG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTgvTWF0aC9NYXRoTUwnPgogICAgPG1lcnJvcj4K ICAgICAgICA8bXJvdz4KICAgICAgICAgICAgPG1pPkE8L21pPgogICAgICAgICAgICA8bW8+Lzwv bW8+CiAgICAgICAgICAgIDxtbj4wPC9tbj4KICAgICAgICA8L21yb3c+CiAgICA8L21lcnJvcj4K PC9tYXRoPgo8L3A+CjwvYm9keT4KPC9odG1sPgo=