43429 2010-08-03 09:37:41 -0700 [GTK] Does not paint the node highlight used by the inspector 2010-08-03 11:10:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 259507 0 gustavo 2010-08-03 09:37:41 -0700 When using the "inspect" tool of the inspector, or when hovering the mouse over elements in the inspector, the nodes are not highlighted. 259508 1 63341 gustavo 2010-08-03 09:42:38 -0700 Created attachment 63341 proposed patch 259520 2 63341 xan.lopez 2010-08-03 10:02:38 -0700 Comment on attachment 63341 proposed patch >-void InspectorClient::highlight(Node* node) >+void InspectorClient::highlight(Node*) > { >- notImplemented(); >+ hideHighlight(); > } > > void InspectorClient::hideHighlight() > { >- notImplemented(); >+ // FIXME: we should be able to only invalidate the actual rects of >+ // the new and old nodes. We need to track the nodes, and take the >+ // actual highlight size into account when calculating the damage >+ // rect. >+ gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView)); > } There's some huge epic fail in naming going on here ;) >+ ctx.save(); >+ ctx.clip(static_cast<IntRect>(event->area)); >+ frame->page()->inspectorController()->drawNodeHighlight(ctx); >+ ctx.restore(); > } As discussed on jabber, the save/restore stuff is probably not needed. > > return FALSE; >-- >1.7.1 > 259561 3 63341 gustavo 2010-08-03 11:10:47 -0700 Comment on attachment 63341 proposed patch Landed as r64567. 63341 2010-08-03 09:42:38 -0700 2010-08-03 11:10:47 -0700 proposed patch 0001-Highlight-nodes-for-the-inspector.patch text/plain 2736 gustavo RnJvbSAyZjJlZTA5NGFjMTE5NDRlMTQwMTJlZDg4MzgxNjE1MDQwZTY5MDEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFR1ZSwgMyBBdWcgMjAxMCAxMzoyOTo0NSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEhp Z2hsaWdodCBub2RlcyBmb3IgdGhlIGluc3BlY3RvcgoKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRHdGsuY3BwIHwgICAxMCArKysr KysrLS0tCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCAgICAgICAgICAgICAg fCAgICA1ICsrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0No YW5nZUxvZwppbmRleCBiZjE3NzdkLi4xOWUyN2Y1IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0No YW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEw LTA4LTAzICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3Jh LmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHVEtdIERvZXMgbm90IHBhaW50IHRoZSBub2RlIGhpZ2hsaWdodCB1c2VkIGJ5IHRoZSBpbnNw ZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQz NDI5CisKKyAgICAgICAgSW1wbGVtZW50IGhpZ2hsaWdodGluZyB0aGUgbm9kZXMgd2hlbiB1c2lu ZyB0aGUgaW5zcGVjdG9yLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xp ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5zcGVjdG9yQ2xpZW50OjpoaWdobGlnaHQp OgorICAgICAgICAoV2ViS2l0OjpJbnNwZWN0b3JDbGllbnQ6OmhpZGVIaWdobGlnaHQpOgorICAg ICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmll d19leHBvc2VfZXZlbnQpOgorCiAyMDEwLTA3LTI2ICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tA Z29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEd0ay5jcHAgYi9X ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEd0ay5jcHAKaW5kZXggNjE2 ODM0Yi4uNzAzOWRkNiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9JbnNw ZWN0b3JDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvSW5zcGVj dG9yQ2xpZW50R3RrLmNwcApAQCAtMTAxLDE0ICsxMDEsMTggQEAgdm9pZCBJbnNwZWN0b3JDbGll bnQ6OnJlbGVhc2VGcm9udGVuZFBhZ2UoKQogICAgIG1fZnJvbnRlbmRQYWdlID0gMDsKIH0KIAot dm9pZCBJbnNwZWN0b3JDbGllbnQ6OmhpZ2hsaWdodChOb2RlKiBub2RlKQordm9pZCBJbnNwZWN0 b3JDbGllbnQ6OmhpZ2hsaWdodChOb2RlKikKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IGhpZGVIaWdobGlnaHQoKTsKIH0KIAogdm9pZCBJbnNwZWN0b3JDbGllbnQ6OmhpZGVIaWdobGln aHQoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgLy8gRklYTUU6IHdlIHNob3VsZCBi ZSBhYmxlIHRvIG9ubHkgaW52YWxpZGF0ZSB0aGUgYWN0dWFsIHJlY3RzIG9mCisgICAgLy8gdGhl IG5ldyBhbmQgb2xkIG5vZGVzLiBXZSBuZWVkIHRvIHRyYWNrIHRoZSBub2RlcywgYW5kIHRha2Ug dGhlCisgICAgLy8gYWN0dWFsIGhpZ2hsaWdodCBzaXplIGludG8gYWNjb3VudCB3aGVuIGNhbGN1 bGF0aW5nIHRoZSBkYW1hZ2UKKyAgICAvLyByZWN0LgorICAgIGd0a193aWRnZXRfcXVldWVfZHJh dyhHVEtfV0lER0VUKG1faW5zcGVjdGVkV2ViVmlldykpOwogfQogCiB2b2lkIEluc3BlY3RvckNs aWVudDo6cG9wdWxhdGVTZXR0aW5nKGNvbnN0IFN0cmluZyYga2V5LCBTdHJpbmcqIHZhbHVlKQpk aWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCBjZGU5MTQ4Li41MzhiMWI3IDEwMDY0 NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNTQ4LDYgKzU0OCwxMSBAQCBzdGF0aWMg Z2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2V4cG9zZV9ldmVudChHdGtXaWRnZXQqIHdpZGdldCwg R2RrRXZlbnRFeHBvc2UqCiAgICAgICAgICAgICAgICAgY3R4LnJlc3RvcmUoKTsKICAgICAgICAg ICAgIH0KICAgICAgICAgfQorCisgICAgICAgIGN0eC5zYXZlKCk7CisgICAgICAgIGN0eC5jbGlw KHN0YXRpY19jYXN0PEludFJlY3Q+KGV2ZW50LT5hcmVhKSk7CisgICAgICAgIGZyYW1lLT5wYWdl KCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+ZHJhd05vZGVIaWdobGlnaHQoY3R4KTsKKyAgICAg ICAgY3R4LnJlc3RvcmUoKTsKICAgICB9CiAKICAgICByZXR1cm4gRkFMU0U7Ci0tIAoxLjcuMQoK