43418 2010-08-03 06:19:46 -0700 [GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange 2010-08-05 00:56:00 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mario webkit-unassigned commit-queue xan.lopez oldest_to_newest 259416 0 mario 2010-08-03 06:19:46 -0700 It would be needed to make some extra checks at AccessibilityObject::visiblePositionRangeForRange to make sure toRenderText() function is called with valid parameters, that is, a RenderObject returning 'true when calling to its isText() method. This check is needed because current code doesn't do it and could be executed with RenderObjects other than instances of the RenderText subclass, resulting in failures such as the one in the following stack trace: http://webkit-bots.igalia.com/i386/svn_64534.core-when_1280823420-_-who_testatk-_-why_11.26739.trace.html I'm now building WK with a patch for this. Will attach it as soon as I tested it. 259427 1 mario 2010-08-03 06:46:16 -0700 Adding Xan to CC 259429 2 63331 mario 2010-08-03 06:50:28 -0700 Created attachment 63331 Patch proposal This patch just adds the needed checks that should have been added before, along with fix for bug 25677 (my fault) 259434 3 63331 xan.lopez 2010-08-03 07:09:27 -0700 Comment on attachment 63331 Patch proposal OK 260455 4 63331 commit-queue 2010-08-05 00:55:55 -0700 Comment on attachment 63331 Patch proposal Clearing flags on attachment: 63331 Committed r64721: <http://trac.webkit.org/changeset/64721> 260456 5 commit-queue 2010-08-05 00:56:00 -0700 All reviewed patches have been landed. Closing bug. 63331 2010-08-03 06:50:28 -0700 2010-08-05 00:55:55 -0700 Patch proposal 0001-2010-08-03-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3211 mario RnJvbSAxY2M2ZWMzNmJjMjgxNmU5ZmY5NDk4ZmI4MzljODQzYzQxMmUxYWE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUdWUsIDMgQXVnIDIwMTAgMTU6NDE6NTIgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA4LTAzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtHVEtdIEV4dHJh IGNoZWNrIG5lZWRlZCBhdCBBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp2aXNpYmxlUG9zaXRpb25SYW5n ZUZvclJhbmdlCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQzNDE4CgogICAgICAgIEVuc3VyZSB0aGUgcmVuZGVyZXIgaXMgYSBSZW5kZXJUZXh0IGJlZm9y ZSBjYWxsaW5nIHRvUmVuZGVyVGV4dCgpCgogICAgICAgIEFsc28sIHNpbXBsaWZpZWQgY29kZSBh IGJpdCB0byBhdm9pZCBzbyBtYW55IG5lc3RlZCBpZidzIGluIHRoYXQKICAgICAgICBwYXJ0IG9m IHRoZSBjb2RlLCB3aGlsZSBrZWVwaW5nIHRoZSBzYW1lIGxvZ2ljLgoKICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CiAgICAgICAgKFdlYkNvcmU6OkFjY2Vz c2liaWxpdHlPYmplY3Q6OnZpc2libGVQb3NpdGlvblJhbmdlRm9yUmFuZ2UpOgotLS0KIFdlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysr KysrKysrCiBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgfCAg IDE3ICsrKysrKysrLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBkNWUyMmVhLi40MDg4Y2I5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA4 LTAzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBFeHRyYSBjaGVj ayBuZWVkZWQgYXQgQWNjZXNzaWJpbGl0eU9iamVjdDo6dmlzaWJsZVBvc2l0aW9uUmFuZ2VGb3JS YW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM0 MTgKKworICAgICAgICBFbnN1cmUgdGhlIHJlbmRlcmVyIGlzIGEgUmVuZGVyVGV4dCBiZWZvcmUg Y2FsbGluZyB0b1JlbmRlclRleHQoKQorCisgICAgICAgIEFsc28sIHNpbXBsaWZpZWQgY29kZSBh IGJpdCB0byBhdm9pZCBzbyBtYW55IG5lc3RlZCBpZidzIGluIHRoYXQKKyAgICAgICAgcGFydCBv ZiB0aGUgY29kZSwgd2hpbGUga2VlcGluZyB0aGUgc2FtZSBsb2dpYy4KKworICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpB Y2Nlc3NpYmlsaXR5T2JqZWN0Ojp2aXNpYmxlUG9zaXRpb25SYW5nZUZvclJhbmdlKToKKwogMjAx MC0wNy0zMCAgQW5kcmVpIFBvcGVzY3UgIDxhbmRyZWlwQGRoY3AtMTcyLTE2LTE0LTEyLmxvbi5j b3JwLmdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCmluZGV4IGIwYWU4 NmIuLjMwZmJhMzEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5T2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9i amVjdC5jcHAKQEAgLTM3OCwxNiArMzc4LDE1IEBAIFZpc2libGVQb3NpdGlvblJhbmdlIEFjY2Vz c2liaWxpdHlPYmplY3Q6OnZpc2libGVQb3NpdGlvblJhbmdlRm9yUmFuZ2UoY29uc3QgUGxhCiAg ICAgLy8gR3RrIEFUcyBuZWVkIHRoaXMgZm9yIGFsbCB0ZXh0IG9iamVjdHM7IG5vdCBqdXN0IHRl eHQgY29udHJvbHMuCiAgICAgaWYgKCF0ZXh0TGVuZ3RoKSB7CiAgICAgICAgIE5vZGUqIG5vZGUg PSB0aGlzLT5ub2RlKCk7Ci0gICAgICAgIGlmIChub2RlKSB7Ci0gICAgICAgICAgICBSZW5kZXJU ZXh0KiByZW5kZXJUZXh0ID0gdG9SZW5kZXJUZXh0KG5vZGUtPnJlbmRlcmVyKCkpOwotICAgICAg ICAgICAgaWYgKHJlbmRlclRleHQpCi0gICAgICAgICAgICAgICAgdGV4dExlbmd0aCA9IHJlbmRl clRleHQtPnRleHRMZW5ndGgoKTsKLQotICAgICAgICAgICAgLy8gR2V0IHRoZSB0ZXh0IGxlbmd0 aCBmcm9tIHRoZSBlbGVtZW50cyB1bmRlciB0aGUKLSAgICAgICAgICAgIC8vIGFjY2Vzc2liaWxp dHkgb2JqZWN0IGlmIG5vdCBhIFJlbmRlclRleHQgb2JqZWN0LgotICAgICAgICAgICAgaWYgKCF0 ZXh0TGVuZ3RoICYmIGFsbG93c1RleHRSYW5nZXMoKSkKLSAgICAgICAgICAgICAgICB0ZXh0TGVu Z3RoID0gdGV4dFVuZGVyRWxlbWVudCgpLmxlbmd0aCgpOworICAgICAgICBSZW5kZXJPYmplY3Qq IHJlbmRlcmVyID0gbm9kZSA/IG5vZGUtPnJlbmRlcmVyKCkgOiAwOworICAgICAgICBpZiAocmVu ZGVyZXIgJiYgcmVuZGVyZXItPmlzVGV4dCgpKSB7CisgICAgICAgICAgICBSZW5kZXJUZXh0KiBy ZW5kZXJUZXh0ID0gdG9SZW5kZXJUZXh0KHJlbmRlcmVyKTsKKyAgICAgICAgICAgIHRleHRMZW5n dGggPSByZW5kZXJUZXh0ID8gcmVuZGVyVGV4dC0+dGV4dExlbmd0aCgpIDogMDsKICAgICAgICAg fQorICAgICAgICAvLyBHZXQgdGhlIHRleHQgbGVuZ3RoIGZyb20gdGhlIGVsZW1lbnRzIHVuZGVy IHRoZQorICAgICAgICAvLyBhY2Nlc3NpYmlsaXR5IG9iamVjdCBpZiB0aGUgdmFsdWUgaXMgc3Rp bGwgemVyby4KKyAgICAgICAgaWYgKCF0ZXh0TGVuZ3RoICYmIGFsbG93c1RleHRSYW5nZXMoKSkK KyAgICAgICAgICAgIHRleHRMZW5ndGggPSB0ZXh0VW5kZXJFbGVtZW50KCkubGVuZ3RoKCk7CiAg ICAgfQogI2VuZGlmCiAgICAgaWYgKHJhbmdlLnN0YXJ0ICsgcmFuZ2UubGVuZ3RoID4gdGV4dExl bmd0aCkKLS0gCjEuNy4wLjQKCg==