43413 2010-08-03 05:25:46 -0700 Fix warning in WebCore/plugins/win/PluginMessageThrottlerWin.cpp 2010-08-03 06:22:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 43191 1 ossy webkit-unassigned aroben sfalken oldest_to_newest 259385 0 ossy 2010-08-03 05:25:46 -0700 gcc warning: ..\..\..\WebCore\plugins\win\/PluginMessageThrottlerWin.h: In constructor 'WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin(WebCore::PluginView*)': ..\..\..\WebCore\plugins\win\/PluginMessageThrottlerWin.h:69:16: warning: 'WebCore::PluginMessageThrottlerWin::m_lastMessageTime' will be initialized after ..\..\..\WebCore\plugins\win\/PluginMessageThrottlerWin.h:68:42: warning: 'WebCore::Timer<WebCore::PluginMessageThrottlerWin> WebCore::PluginMessageThrottlerWin::m_messageThrottleTimer' ..\..\..\WebCore\plugins\win\PluginMessageThrottlerWin.cpp:47:1: warning: when initialized here This warning introduced in http://trac.webkit.org/changeset/57650 , which added m_lastMessageTime member to class PluginMessageThrottlerWin. 259386 1 63327 ossy 2010-08-03 05:27:46 -0700 Created attachment 63327 proposed fix 259395 2 63327 aroben 2010-08-03 05:34:27 -0700 Comment on attachment 63327 proposed fix r=me 259417 3 63327 ossy 2010-08-03 06:22:37 -0700 Comment on attachment 63327 proposed fix Clearing flags on attachment: 63327 Committed r64548: <http://trac.webkit.org/changeset/64548> 259418 4 ossy 2010-08-03 06:22:45 -0700 All reviewed patches have been landed. Closing bug. 63327 2010-08-03 05:27:46 -0700 2010-08-03 06:22:37 -0700 proposed fix 1.patch text/plain 1297 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzVjZmE0Ny4uNGE0MTUwZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0wMyAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB3YXJuaW5nIGluIFdlYkNvcmUvcGx1Z2lucy93aW4vUGx1 Z2luTWVzc2FnZVRocm90dGxlcldpbi5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQzNDEzCisKKyAgICAgICAgKiBwbHVnaW5zL3dpbi9QbHVnaW5N ZXNzYWdlVGhyb3R0bGVyV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpbk1lc3NhZ2VU aHJvdHRsZXJXaW46OlBsdWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW4pOiBNb2RpZnkgaW5pdGlhbGl6 YXRpb24gb3JkZXIuCisKIDIwMTAtMDgtMDMgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luTWVzc2FnZVRocm90dGxlcldpbi5jcHAgYi9XZWJDb3Jl L3BsdWdpbnMvd2luL1BsdWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW4uY3BwCmluZGV4IGRkMWYwNWIu LmM1ZjMwODEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luTWVzc2FnZVRo cm90dGxlcldpbi5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5NZXNzYWdlVGhy b3R0bGVyV2luLmNwcApAQCAtNDgsOCArNDgsOCBAQCBQbHVnaW5NZXNzYWdlVGhyb3R0bGVyV2lu OjpQbHVnaW5NZXNzYWdlVGhyb3R0bGVyV2luKFBsdWdpblZpZXcqIHBsdWdpblZpZXcpCiAgICAg OiBtX3BsdWdpblZpZXcocGx1Z2luVmlldykKICAgICAsIG1fYmFjaygwKQogICAgICwgbV9mcm9u dCgwKQotICAgICwgbV9sYXN0TWVzc2FnZVRpbWUoMCkKICAgICAsIG1fbWVzc2FnZVRocm90dGxl VGltZXIodGhpcywgJlBsdWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW46Om1lc3NhZ2VUaHJvdHRsZVRp bWVyRmlyZWQpCisgICAgLCBtX2xhc3RNZXNzYWdlVGltZSgwKQogewogICAgIC8vIEluaXRpYWxp emUgdGhlIGZyZWUgbGlzdCB3aXRoIG91ciBpbmxpbmUgbWVzc2FnZXMKICAgICBmb3IgKHVuc2ln bmVkIGkgPSAwOyBpIDwgTnVtSW5saW5lTWVzc2FnZXMgLSAxOyBpKyspCg==