43412 2010-08-03 04:40:08 -0700 Fix warning in WebCore/rendering/RenderBoxModelObject.cpp 2010-08-03 06:45:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 43191 1 ossy webkit-unassigned bdakin mitz oldest_to_newest 259374 0 ossy 2010-08-03 04:40:08 -0700 gcc warning: ..\..\..\WebCore\rendering\RenderBoxModelObject.cpp: In member function 'void WebCore::RenderBoxModelObject::clipBorderSidePolygon(WebCore::GraphicsContext*, const WebCore::IntRect&, const WebCore::IntSize&, const WebCore::IntSize&, const WebCore::IntSize&, const WebCore::IntSize&, WebCore::BoxSide, bool, bool, const WebCore::RenderStyle*)': ..\..\..\WebCore\rendering\RenderBoxModelObject.cpp:1529:62: warning: operation on 'firstQuad[2]' may be undefined This warning introduced in http://trac.webkit.org/changeset/63864 : 1528 firstQuad[2] = side == BSTop || side == BSBottom ? FloatPoint(quad[3].x(), quad[2].y()) 1529 : firstQuad[2] = FloatPoint(quad[2].x(), quad[3].y()); Assignment in the false case of ternary condition is useless, and evaluating of undefined firstQuad[2] cause this warning. 259375 1 63324 ossy 2010-08-03 04:41:24 -0700 Created attachment 63324 proposed fix 259405 2 63324 tonikitoo 2010-08-03 06:03:40 -0700 Comment on attachment 63324 proposed fix r=me 259425 3 63324 ossy 2010-08-03 06:45:04 -0700 Comment on attachment 63324 proposed fix Clearing flags on attachment: 63324 Committed r64553: <http://trac.webkit.org/changeset/64553> 259426 4 ossy 2010-08-03 06:45:12 -0700 All reviewed patches have been landed. Closing bug. 63324 2010-08-03 04:41:24 -0700 2010-08-03 06:45:04 -0700 proposed fix 1.patch text/plain 1288 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzVjZmE0Ny4uOWYxYzA5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0wMyAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB3YXJuaW5nIGluIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveE1vZGVsT2JqZWN0LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDM0MTIKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9i amVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y2xpcEJv cmRlclNpZGVQb2x5Z29uKTogUmVtb3ZlIHVzZWxlc3MgYXNzaWdubWVudC4KKwogMjAxMC0wOC0w MyAgQW5kcmVpIFBvcGVzY3UgIDxhbmRyZWlwQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 TW9kZWxPYmplY3QuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3Qu Y3BwCmluZGV4IDRkZGQ2NmIuLjkxMTdlZDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC b3hNb2RlbE9iamVjdC5jcHAKQEAgLTE1MjYsNyArMTUyNiw3IEBAIHZvaWQgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OmNsaXBCb3JkZXJTaWRlUG9seWdvbihHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNz Q29udGV4CiAgICAgZmlyc3RRdWFkWzBdID0gcXVhZFswXTsKICAgICBmaXJzdFF1YWRbMV0gPSBx dWFkWzFdOwogICAgIGZpcnN0UXVhZFsyXSA9IHNpZGUgPT0gQlNUb3AgfHwgc2lkZSA9PSBCU0Jv dHRvbSA/IEZsb2F0UG9pbnQocXVhZFszXS54KCksIHF1YWRbMl0ueSgpKQotICAgICAgICA6IGZp cnN0UXVhZFsyXSA9IEZsb2F0UG9pbnQocXVhZFsyXS54KCksIHF1YWRbM10ueSgpKTsKKyAgICAg ICAgOiBGbG9hdFBvaW50KHF1YWRbMl0ueCgpLCBxdWFkWzNdLnkoKSk7CiAgICAgZmlyc3RRdWFk WzNdID0gcXVhZFszXTsKICAgICBncmFwaGljc0NvbnRleHQtPmNsaXBDb252ZXhQb2x5Z29uKDQs IGZpcnN0UXVhZCwgIWZpcnN0RWRnZU1hdGNoZXMpOwogCg==