<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43410</bug_id>
          
          <creation_ts>2010-08-03 04:22:24 -0700</creation_ts>
          <short_desc>Enable JSValue32_64 on ARM by default</short_desc>
          <delta_ts>2010-08-04 00:45:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gabor Loki">loki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>259370</commentid>
    <comment_count>0</comment_count>
    <who name="Gabor Loki">loki</who>
    <bug_when>2010-08-03 04:22:24 -0700</bug_when>
    <thetext>The ARM_TRADITIONAL back-end should also follow the direction of JSValue development.

Here is some performance numbers:

SunSpider:
  sunspider-results-jsc-v7-jsvalue32_64.js : 2134.3
  sunspider-results-jsc-v7-jsvalue32.js    : 3886.1 (1.821x as slow)

V8:
  sunspider-results-jsc-v7-jsvalue32.js    : 14600.2
  sunspider-results-jsc-v7-jsvalue32_64.js : 15961.8 (1.093x as slow)

WindScorpion:
  sunspider-results-jsc-v7-jsv32_64.js : 9548.5
  sunspider-results-jsc-v7-jsv32.js    : 9662.75 (1.012x as slow)

So, 2 of the 3 benchmark say the JSValue32_64 is faster. Although the r64319 or r64320 causes 10% performance regression in JSValue32 on ARM (see at http://webkit.sed.hu/benchmark/query/advanced/63695;64541;linux-arm-qt;jit;ss;speed ). So the overall picture is not so clear. ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259372</commentid>
    <comment_count>1</comment_count>
      <attachid>63323</attachid>
    <who name="Gabor Loki">loki</who>
    <bug_when>2010-08-03 04:30:32 -0700</bug_when>
    <thetext>Created attachment 63323
Enable JSValue32_64 on ARM by default</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259430</commentid>
    <comment_count>2</comment_count>
      <attachid>63332</attachid>
    <who name="Gabor Loki">loki</who>
    <bug_when>2010-08-03 06:56:39 -0700</bug_when>
    <thetext>Created attachment 63332
Enable JSValue32_64 for GCC on ARM by default

Enable JSValue32_64 only for GCC on ARM.
JSValue32_64 will be enabled for RVCT in another patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259555</commentid>
    <comment_count>3</comment_count>
      <attachid>63332</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2010-08-03 11:05:29 -0700</bug_when>
    <thetext>Comment on attachment 63332
Enable JSValue32_64 for GCC on ARM by default

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259914</commentid>
    <comment_count>4</comment_count>
    <who name="Gabor Loki">loki</who>
    <bug_when>2010-08-04 00:45:00 -0700</bug_when>
    <thetext>Committed revision 64632.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>63323</attachid>
            <date>2010-08-03 04:30:32 -0700</date>
            <delta_ts>2010-08-03 06:56:39 -0700</delta_ts>
            <desc>Enable JSValue32_64 on ARM by default</desc>
            <filename>0001-Enable-JSValue32_64-on-ARM-by-default.patch</filename>
            <type>text/plain</type>
            <size>1437</size>
            <attacher name="Gabor Loki">loki</attacher>
            
              <data encoding="base64">RnJvbSA0M2VhNzg2MjY1OWJhMzdiZTA2NDViZjQxZWY3NmRhNWZiNDllNTIwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0
ZTogVHVlLCAzIEF1ZyAyMDEwIDEzOjI4OjA1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRW5hYmxl
IEpTVmFsdWUzMl82NCBvbiBBUk0gYnkgZGVmYXVsdAoKU2lnbmVkLW9mZi1ieTogR2Fib3IgTG9r
aSA8bG9raUBpbmYudS1zemVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAg
ICAgfCAgICA5ICsrKysrKysrKwogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggfCAgICAy
ICstCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hh
bmdlTG9nCmluZGV4IDE4NmJmODYuLmY0OWQ2NjYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl
L0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBA
QAorMjAxMC0wOC0wMyAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0Lm9yZz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgSlNWYWx1ZTMyXzY0
IG9uIEFSTSBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD00MzQxMAorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTAtMDgt
MDIgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAg
W3d4XSBCdWlsZCBmaXggYWZ0ZXIgcmVtb3ZhbCBvZiBuZWVkIHRvIGNvbXBpbGUgRXhlY3V0YWJs
ZUFsbG9jYXRvclBvc2l4LmNwcApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm
b3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA1MWJmOTJkLi42YWE0
ZmJmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9KYXZh
U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtOTAwLDcgKzkwMCw3IEBACiAgICAgfHwgQ1BV
KEFMUEhBKSBcCiAgICAgfHwgQ1BVKFNQQVJDNjQpCiAjZGVmaW5lIFdURl9VU0VfSlNWQUxVRTY0
IDEKLSNlbGlmIENQVShBUk1fVFJBRElUSU9OQUwpIHx8IENQVShQUEM2NCkgfHwgQ1BVKE1JUFMp
CisjZWxpZiBDUFUoUFBDNjQpIHx8IENQVShNSVBTKQogI2RlZmluZSBXVEZfVVNFX0pTVkFMVUUz
MiAxCiAjZWxpZiBPUyhXSU5ET1dTKSAmJiBDT01QSUxFUihNSU5HVykKIC8qIFVzaW5nIEpTVkFM
VUUzMl82NCBjYXVzZXMgcGFkZGluZy9hbGlnbmVtZW50IGlzc3VlcyBmb3IgSklUU3R1YkFyZwot
LSAKMS43LjAuNAoK
</data>
<flag name="commit-queue"
          id="51650"
          type_id="3"
          status="-"
          setter="loki"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>63332</attachid>
            <date>2010-08-03 06:56:39 -0700</date>
            <delta_ts>2010-08-03 11:05:29 -0700</delta_ts>
            <desc>Enable JSValue32_64 for GCC on ARM by default</desc>
            <filename>0001-Enable-JSValue32_64-on-ARM-with-GCC-by-default.patch</filename>
            <type>text/plain</type>
            <size>1498</size>
            <attacher name="Gabor Loki">loki</attacher>
            
              <data encoding="base64">RnJvbSAyZmZiZmEyZWQ3NDMyZDE3MjQ4MDExZTA1M2Y0NGZlYmVlMzU5N2UyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0
ZTogVHVlLCAzIEF1ZyAyMDEwIDE1OjQ4OjM3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRW5hYmxl
IEpTVmFsdWUzMl82NCBvbiBBUk0gd2l0aCBHQ0MgYnkgZGVmYXVsdAoKU2lnbmVkLW9mZi1ieTog
R2Fib3IgTG9raSA8bG9raUBpbmYudS1zemVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUvQ2hh
bmdlTG9nICAgICAgfCAgICA5ICsrKysrKysrKwogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3Jt
LmggfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEgZGVsZXRp
b25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nCmluZGV4IDE4NmJmODYuLmYxMDYwMDkgMTAwNjQ0Ci0tLSBhL0phdmFT
Y3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMiBAQAorMjAxMC0wOC0wMyAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0Lm9yZz4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgSlNW
YWx1ZTMyXzY0IGZvciBHQ0Mgb24gQVJNIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNDEwCisKKyAgICAgICAgKiB3dGYvUGxhdGZv
cm0uaDoKKwogMjAxMC0wOC0wMiAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJz
LmNvbT4KIAogICAgICAgICBbd3hdIEJ1aWxkIGZpeCBhZnRlciByZW1vdmFsIG9mIG5lZWQgdG8g
Y29tcGlsZSBFeGVjdXRhYmxlQWxsb2NhdG9yUG9zaXguY3BwCmRpZmYgLS1naXQgYS9KYXZhU2Ny
aXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmlu
ZGV4IDUxYmY5MmQuLjI5YjMxOTEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0
Zm9ybS5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC05MDAsNyArOTAw
LDcgQEAKICAgICB8fCBDUFUoQUxQSEEpIFwKICAgICB8fCBDUFUoU1BBUkM2NCkKICNkZWZpbmUg
V1RGX1VTRV9KU1ZBTFVFNjQgMQotI2VsaWYgQ1BVKEFSTV9UUkFESVRJT05BTCkgfHwgQ1BVKFBQ
QzY0KSB8fCBDUFUoTUlQUykKKyNlbGlmIENQVShQUEM2NCkgfHwgQ1BVKE1JUFMpIHx8IChDUFUo
QVJNX1RSQURJVElPTkFMKSAmJiAhQ09NUElMRVIoR0NDKSkKICNkZWZpbmUgV1RGX1VTRV9KU1ZB
TFVFMzIgMQogI2VsaWYgT1MoV0lORE9XUykgJiYgQ09NUElMRVIoTUlOR1cpCiAvKiBVc2luZyBK
U1ZBTFVFMzJfNjQgY2F1c2VzIHBhZGRpbmcvYWxpZ25lbWVudCBpc3N1ZXMgZm9yIEpJVFN0dWJB
cmcKLS0gCjEuNy4wLjQKCg==
</data>
<flag name="review"
          id="51660"
          type_id="1"
          status="+"
          setter="ggaren"
    />
    <flag name="commit-queue"
          id="51661"
          type_id="3"
          status="-"
          setter="loki"
    />
          </attachment>
      

    </bug>

</bugzilla>