43385 2010-08-02 15:33:49 -0700 Range::create should not be calling deprecatedEditingOffset and node on start and end 2010-08-02 18:00:11 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin enrica eric ojan tony oldest_to_newest 259150 0 rniwa 2010-08-02 15:33:49 -0700 The version of Range::create that takes two positions calls deprecatedEditingOffset() and node() on start and end to create a range object. Since these two methods are deprecated and have side-effects, we should be calling containerNode() and computeOffsetInContainerNode() instead. A simple patch coming with the following change: @@ -94,8 +94,7 @@ PassRefPtr<Range> Range::create(PassRefPtr<Document> ownerDocument, const Position& start, const Position& end) { - // FIXME: we shouldn't be using deprecatedEditingOffset here - return adoptRef(new Range(ownerDocument, start.node(), start.deprecatedEditingOffset(), end.node(), end.deprecatedEditingOffset())); + return adoptRef(new Range(ownerDocument, start.containerNode(), start.computeOffsetInContainerNode(), end.containerNode(), end.computeOffsetInContainerNode())); } 259152 1 63270 rniwa 2010-08-02 15:40:50 -0700 Created attachment 63270 fixes the bug 259155 2 63270 eric 2010-08-02 15:42:41 -0700 Comment on attachment 63270 fixes the bug I wonder if this is tesable. It's obviously wrong, but I wonder how we would trigger it. This should make it so we don't need to call rangeCompliantPosition on positions before passing them to this function. :) So we could remove that in a later patch. 259230 3 rniwa 2010-08-02 18:00:11 -0700 Committed r64516: <http://trac.webkit.org/changeset/64516> 63270 2010-08-02 15:40:50 -0700 2010-08-02 15:42:41 -0700 fixes the bug bug-43385-20100802154049.patch text/plain 1507 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDQ5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmFu Z2U6OmNyZWF0ZSBzaG91bGQgbm8gYmUgY2FsbGluZyBkZXByZWNhdGVkRWRpdGluZ09mZnNldCBh bmQgbm9kZSBvbiBzdGFydCBhbmQgZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MzM4NQorCisgICAgICAgIFJlcGxhY2VkIG5vZGUoKSBhbmQgZGVw cmVjYXRlZEVkaXRpbmdPZmZzZXQoKSBieSBjb250YWluZXJOb2RlKCkgYW5kIGNvbXB1dGVPZmZz ZXRJbkNvbnRhaW5lck5vZGUoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYWRkZWQgc2luY2Ug dGhpcyBkb2VzIG5vdCBjaGFuZ2UgdGhlIGJlaGF2aW9yLgorCisgICAgICAgICogZG9tL1Jhbmdl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJhbmdlOjpjcmVhdGUpOgorCiAyMDEwLTA4LTAyICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bmRlcnMgQ2FybHNzb24uCkluZGV4OiBXZWJDb3JlL2RvbS9SYW5nZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9kb20vUmFuZ2UuY3BwCShyZXZpc2lvbiA2NDQ3NykKKysrIFdlYkNvcmUvZG9t L1JhbmdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTQsOCArOTQsNyBAQCBQYXNzUmVmUHRyPFJh bmdlPiBSYW5nZTo6Y3JlYXRlKFBhc3NSZWZQCiAKIFBhc3NSZWZQdHI8UmFuZ2U+IFJhbmdlOjpj cmVhdGUoUGFzc1JlZlB0cjxEb2N1bWVudD4gb3duZXJEb2N1bWVudCwgY29uc3QgUG9zaXRpb24m IHN0YXJ0LCBjb25zdCBQb3NpdGlvbiYgZW5kKQogewotICAgIC8vIEZJWE1FOiB3ZSBzaG91bGRu J3QgYmUgdXNpbmcgZGVwcmVjYXRlZEVkaXRpbmdPZmZzZXQgaGVyZQotICAgIHJldHVybiBhZG9w dFJlZihuZXcgUmFuZ2Uob3duZXJEb2N1bWVudCwgc3RhcnQubm9kZSgpLCBzdGFydC5kZXByZWNh dGVkRWRpdGluZ09mZnNldCgpLCBlbmQubm9kZSgpLCBlbmQuZGVwcmVjYXRlZEVkaXRpbmdPZmZz ZXQoKSkpOworICAgIHJldHVybiBhZG9wdFJlZihuZXcgUmFuZ2Uob3duZXJEb2N1bWVudCwgc3Rh cnQuY29udGFpbmVyTm9kZSgpLCBzdGFydC5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2RlKCks IGVuZC5jb250YWluZXJOb2RlKCksIGVuZC5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2RlKCkp KTsKIH0KIAogUmFuZ2U6On5SYW5nZSgpCg==