43381 2010-08-02 14:25:50 -0700 re-enable WebGL on Leopard for now 2010-08-04 16:03:24 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 42118 1 zmo zmo cmarrin dglazkov kbr oliver sam oldest_to_newest 259121 0 zmo 2010-08-02 14:25:50 -0700 Per discussion on https://bugs.webkit.org/show_bug.cgi?id=42118, whether a Leopard is capable of running WebGL depends on the GL extensions it supports. Therefore, re-enable WebGL on Leopard for now. (My Mac is a Leopard, so disabling WebGL on Leopard is blocking my progress.) 259125 1 63262 zmo 2010-08-02 14:31:26 -0700 Created attachment 63262 patch This patch reverses the changes made in http://trac.webkit.org/changeset/63688. Let's do this for now until Chris Marrin's more complicated logic is in. 259134 2 kbr 2010-08-02 14:53:31 -0700 This issue is making it difficult for Mo to develop, and since he's been doing a great deal of WebGL work and bug fixing recently I would like to address it now. The patch looks okay to me. CC'ing Sam Weinig in case checking this in is going to break one of the bots right now (I believe that test cases failing while bringing up a new bot was the motivation behind https://bugs.webkit.org/show_bug.cgi?id=42118 ). A quick targeted patch for that issue would be to disable WebGL at run time if the graphics card on Mac OS X is a GeForce 7300 (or 7000 series more generally). 259149 3 63262 levin 2010-08-02 15:31:39 -0700 Comment on attachment 63262 patch From cmarrin:"I need to complete the implementation for https://bugs.webkit.org/show_bug.cgi?id=42118 or this will break the build bots." 259157 4 zmo 2010-08-02 15:44:32 -0700 OK, I am upgrading my machine to Snow Leopard. Good luck to others who's still using Leopard! 63262 2010-08-02 14:31:26 -0700 2010-08-02 15:31:39 -0700 patch leopard.patch text/plain 4945 zmo SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0NDkyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDgtMDIgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICByZS1lbmFibGUgV2ViR0wgb24gTGVvcGFyZCBmb3Igbm93CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzM4MQorCisgICAgICAg ICogQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWc6IEVuYWJsZSBXZWJHTCBv biBMZW9wYXJkLgorCiAyMDEwLTA4LTAyICBNYWhlc2ggS3Vsa2FybmkgIDxtYWhlc2gua3Vsa2Fy bmlAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRl eDogSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmlu ZXMueGNjb25maWcJKHJldmlzaW9uIDY0NDg3KQorKysgSmF2YVNjcmlwdENvcmUvQ29uZmlndXJh dGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1 LDcgQEAgRU5BQkxFX0xJTktfUFJFRkVUQ0ggPSA7CiAKIEVOQUJMRV8zRF9DQU5WQVMgPSAkKEVO QUJMRV8zRF9DQU5WQVNfJChSRUFMX1BMQVRGT1JNX05BTUUpKTsKIEVOQUJMRV8zRF9DQU5WQVNf bWFjb3N4ID0gJChFTkFCTEVfM0RfQ0FOVkFTX21hY29zeF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJT SU9OX01BSk9SKSk7CitFTkFCTEVfM0RfQ0FOVkFTX21hY29zeF8xMDUwID0gRU5BQkxFXzNEX0NB TlZBUzsKIEVOQUJMRV8zRF9DQU5WQVNfbWFjb3N4XzEwNjAgPSBFTkFCTEVfM0RfQ0FOVkFTOwog RU5BQkxFXzNEX0NBTlZBU19tYWNvc3hfMTA3MCA9IEVOQUJMRV8zRF9DQU5WQVM7CiAKSW5kZXg6 IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiA2NDQ5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTAtMDgtMDIgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZS1lbmFibGUgV2Vi R0wgb24gTGVvcGFyZCBmb3Igbm93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MzM4MQorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvRmVhdHVyZURl ZmluZXMueGNjb25maWc6IEVuYWJsZSBXZWJHTCBvbiBMZW9wYXJkLgorCiAyMDEwLTA4LTAyICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bmRlcnMgQ2FybHNzb24uCkluZGV4OiBXZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZp bmVzLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ29uZmlndXJhdGlvbnMvRmVhdHVy ZURlZmluZXMueGNjb25maWcJKHJldmlzaW9uIDY0NDg3KQorKysgV2ViQ29yZS9Db25maWd1cmF0 aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUs NyBAQCBFTkFCTEVfTElOS19QUkVGRVRDSCA9IDsKIAogRU5BQkxFXzNEX0NBTlZBUyA9ICQoRU5B QkxFXzNEX0NBTlZBU18kKFJFQUxfUExBVEZPUk1fTkFNRSkpOwogRU5BQkxFXzNEX0NBTlZBU19t YWNvc3ggPSAkKEVOQUJMRV8zRF9DQU5WQVNfbWFjb3N4XyQoVEFSR0VUX01BQ19PU19YX1ZFUlNJ T05fTUFKT1IpKTsKK0VOQUJMRV8zRF9DQU5WQVNfbWFjb3N4XzEwNTAgPSBFTkFCTEVfM0RfQ0FO VkFTOwogRU5BQkxFXzNEX0NBTlZBU19tYWNvc3hfMTA2MCA9IEVOQUJMRV8zRF9DQU5WQVM7CiBF TkFCTEVfM0RfQ0FOVkFTX21hY29zeF8xMDcwID0gRU5BQkxFXzNEX0NBTlZBUzsKIApJbmRleDog V2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDY0NDkyKQorKysgV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOC0wMiAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlLWVu YWJsZSBXZWJHTCBvbiBMZW9wYXJkIGZvciBub3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMzgxCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZzogRW5hYmxlIFdlYkdMIG9uIExlb3BhcmQuCisKIDIwMTAt MDgtMDIgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3Bl Y3VsYXRpdmUgcmV2ZXJ0IG9mIDY0NDI1IGR1ZSB0byBDaHJvbWl1bSBpbnN0YWJpbGl0eQpJbmRl eDogV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29u ZmlnCShyZXZpc2lvbiA2NDQ4NykKKysrIFdlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvRmVhdHVy ZURlZmluZXMueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAgRU5BQkxF X0xJTktfUFJFRkVUQ0ggPSA7CiAKIEVOQUJMRV8zRF9DQU5WQVMgPSAkKEVOQUJMRV8zRF9DQU5W QVNfJChSRUFMX1BMQVRGT1JNX05BTUUpKTsKIEVOQUJMRV8zRF9DQU5WQVNfbWFjb3N4ID0gJChF TkFCTEVfM0RfQ0FOVkFTX21hY29zeF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7 CitFTkFCTEVfM0RfQ0FOVkFTX21hY29zeF8xMDUwID0gRU5BQkxFXzNEX0NBTlZBUzsKIEVOQUJM RV8zRF9DQU5WQVNfbWFjb3N4XzEwNjAgPSBFTkFCTEVfM0RfQ0FOVkFTOwogRU5BQkxFXzNEX0NB TlZBU19tYWNvc3hfMTA3MCA9IEVOQUJMRV8zRF9DQU5WQVM7CiAKSW5kZXg6IFdlYktpdFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9u IDY0NDkyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTAtMDgtMDIgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZS1lbmFibGUgV2Vi R0wgb24gTGVvcGFyZCBmb3Igbm93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MzM4MQorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6IEVu YWJsZSBXZWJHTCBvbiBMZW9wYXJkLgorCiAyMDEwLTA3LTI5ICBKb24gSG9uZXljdXR0ICA8amhv bmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgU2tpcHBlZCBsaXN0IG9uIFdpbmRv d3MsIGFuZCBoYXZlIHJ1bi13ZWJraXQtdGVzdHMgcmVzcGVjdCBpdC4KSW5kZXg6IFdlYktpdFRv b2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0CShyZXZpc2lvbiA2NDQ2MikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0CSh3b3JraW5nIGNvcHkpCkBAIC02OCw3ICs2OCw3IEBAIG15IEBmZWF0dXJl cyA9ICgKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0xJTktfUFJFRkVUQ0giLCBkZWZhdWx0ID0+ IDAsIHZhbHVlID0+IFwkbGlua1ByZWZldGNoU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4g IjNkLWNhbnZhcyIsIGRlc2MgPT4gIlRvZ2dsZSAzRCBjYW52YXMgc3VwcG9ydCIsCi0gICAgICBk ZWZpbmUgPT4gIkVOQUJMRV8zRF9DQU5WQVMiLCBkZWZhdWx0ID0+IChpc0FwcGxlTWFjV2ViS2l0 KCkgJiYgIWlzVGlnZXIoKSAmJiAhaXNMZW9wYXJkKCkpLCB2YWx1ZSA9PiBcJHRocmVlRENhbnZh c1N1cHBvcnQgfSwKKyAgICAgIGRlZmluZSA9PiAiRU5BQkxFXzNEX0NBTlZBUyIsIGRlZmF1bHQg PT4gKGlzQXBwbGVNYWNXZWJLaXQoKSAmJiAhaXNUaWdlcigpKSwgdmFsdWUgPT4gXCR0aHJlZURD YW52YXNTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAiM2QtcmVuZGVyaW5nIiwgZGVzYyA9 PiAiVG9nZ2xlIDNEIHJlbmRlcmluZyBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxF XzNEX1JFTkRFUklORyIsIGRlZmF1bHQgPT4gKGlzQXBwbGVNYWNXZWJLaXQoKSAmJiAhaXNUaWdl cigpKSwgdmFsdWUgPT4gXCR0aHJlZURSZW5kZXJpbmdTdXBwb3J0IH0sCg==