43372 2010-08-02 13:20:34 -0700 [wx] Crash during HitTest call 2010-08-03 11:46:47 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 mmacleod webkit-unassigned kevino oldest_to_newest 259064 0 mmacleod 2010-08-02 13:20:34 -0700 Calling HitTest on a wxWebView results in a crash due to a) destruction of an uninitialized variable and b) (after a is fixed) deletion of a variable that has already been freed, presumably due to some kind of smart pointer. This patch fixes both of these issues so that HitTest can be used ina functional manner again. 259069 1 63249 mmacleod 2010-08-02 13:31:08 -0700 Created attachment 63249 Patch to fix initialisation crash 259446 2 63249 ap 2010-08-03 07:34:32 -0700 Comment on attachment 63249 Patch to fix initialisation crash Would you be willing to submit a patch for review, as described in <http://webkit.org/coding/contributing.html>? Please don't comment out code - just delete it if it's wrong. 259591 3 kevino 2010-08-03 11:44:58 -0700 Thanks! Landed in r64568. A couple remarks for future patches. One, there is a 'patch' checkbox which lets the system know the attachment is a patch, and setting ? on the review queue marks it as needing review. (It also actually initiates try-bots which attempt to compile the patch.) Also, typically patches are supposed to contain a ChangeLog entry, which can be auto-generated using WebKitTools/Scripts/prepare-ChangeLog. Typically patches missing a ChangeLog entry are supposed to be given a bad review and sent back for reworking, but as this was fixing a crash, I felt it was best to be expedient and land this ASAP, adding the ChangeLog entry myself. 259593 4 kevino 2010-08-03 11:46:47 -0700 (In reply to comment #3) > Thanks! Landed in r64568. > > A couple remarks for future patches. One, there is a 'patch' checkbox which lets the system know the attachment is a patch, and setting ? on the review queue marks it as needing review. (It also actually initiates try-bots which attempt to compile the patch.) > > Also, typically patches are supposed to contain a ChangeLog entry, which can be auto-generated using WebKitTools/Scripts/prepare-ChangeLog. Typically patches missing a ChangeLog entry are supposed to be given a bad review and sent back for reworking, but as this was fixing a crash, I felt it was best to be expedient and land this ASAP, adding the ChangeLog entry myself. Err, bad review is a poor choice of words. :) I mean an r-, which means it isn't ready to land. 63249 2010-08-02 13:31:08 -0700 2010-08-03 11:40:29 -0700 Patch to fix initialisation crash wxwebkit.patch text/plain 1114 mmacleod SW5kZXg6IFdlYkZyYW1lLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkZyYW1lLmNwcAkocmV2aXNp b24gNjQ0MzkpDQorKysgV2ViRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtNDU4LDcgKzQ1 OCw3IEBADQogICAgIGlmIChtX2ltcGwtPmZyYW1lLT52aWV3KCkpIHsNCiAgICAgICAgIFdlYkNv cmU6OkhpdFRlc3RSZXN1bHQgcmVzdWx0ID0gbV9pbXBsLT5mcmFtZS0+ZXZlbnRIYW5kbGVyKCkt PmhpdFRlc3RSZXN1bHRBdFBvaW50KG1faW1wbC0+ZnJhbWUtPnZpZXcoKS0+d2luZG93VG9Db250 ZW50cyhwb3MpLCBmYWxzZSk7DQogICAgICAgICBpZiAocmVzdWx0LmlubmVyTm9kZSgpKSB7DQot ICAgICAgICAgICAgZG9tSW5mby5TZXRJbm5lck5vZGUobmV3IFdlYkRPTU5vZGUocmVzdWx0Lmlu bmVyTm9kZSgpKSk7DQorICAgICAgICAgICAgLy9kb21JbmZvLlNldElubmVyTm9kZShuZXcgV2Vi RE9NTm9kZShyZXN1bHQuaW5uZXJOb2RlKCkpKTsNCiAgICAgICAgICAgICBkb21JbmZvLlNldExp bmsocmVzdWx0LmFic29sdXRlTGlua1VSTCgpLnN0cmluZygpKTsNCiAgICAgICAgICAgICBkb21J bmZvLlNldFRleHQocmVzdWx0LnRleHRDb250ZW50KCkpOw0KICAgICAgICAgICAgIGRvbUluZm8u U2V0SW1hZ2VTcmMocmVzdWx0LmFic29sdXRlSW1hZ2VVUkwoKS5zdHJpbmcoKSk7DQpJbmRleDog V2ViVmlldy5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJWaWV3LmNwcAkocmV2aXNpb24gNjQ0Mzkp DQorKysgV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkNCkBAIC0yMzUsNyArMjM1LDkgQEANCiAg ICAgbV9pc1NlbGVjdGVkKGZhbHNlKSwNCiAgICAgbV90ZXh0KHd4RW1wdHlTdHJpbmcpLA0KICAg ICBtX2ltYWdlU3JjKHd4RW1wdHlTdHJpbmcpLA0KLSAgICBtX2xpbmsod3hFbXB0eVN0cmluZykN CisgICAgbV9saW5rKHd4RW1wdHlTdHJpbmcpLA0KKyAgICBtX3VybEVsZW1lbnQoTlVMTCksDQor ICAgIG1faW5uZXJOb2RlKE5VTEwpDQogew0KIH0NCg==