43365 2010-08-02 10:24:53 -0700 [Qt] DOM listeners get wrong keycodes for some keys 2010-09-13 08:25:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 258960 0 mrobinson 2010-08-02 10:24:53 -0700 http://trac.webkit.org/changeset/64470 fixed some bugs and introduced tests related to invalid keyCodes sent for Print Screen and keypad insert/delete keys. WebKitQt seems to have this same issue as well. 258963 1 mrobinson 2010-08-02 10:28:39 -0700 Committed r64473: <http://trac.webkit.org/changeset/64473> 258966 2 63233 mrobinson 2010-08-02 10:38:46 -0700 Created attachment 63233 Blind patch 258967 3 mrobinson 2010-08-02 10:39:46 -0700 I've uploaded a patch which I'm fairly certain fixes this issue, but I'm unable to test it right now as my version of Qt is not fully up-to-date. When I can test this / get someone to test it for me, I'll r? it. 277818 4 67323 mrobinson 2010-09-11 18:56:11 -0700 Created attachment 67323 Tested patch for this issue 277851 5 67323 kling 2010-09-12 03:39:22 -0700 Comment on attachment 67323 Tested patch for this issue Thanks for fixing this! r=me 278226 6 mrobinson 2010-09-13 08:25:54 -0700 Committed r67389: <http://trac.webkit.org/changeset/67389> 63233 2010-08-02 10:38:46 -0700 2010-09-11 18:56:07 -0700 Blind patch bug-43365-20100802103845.patch text/plain 3511 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNmMxMGZiYzVhODUzOWYyM2VkODE0Y2E1NjJmNGRmZmVkNGE5NjMwLi5iYzA0NzQ4 MGZiNDgxNTI1YTlkYjg1Y2RhMDM0ZmQ3YTJjZDBhZjMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTAtMDgtMDIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRE9NIGxp c3RlbmVycyBnZXQgd3Jvbmcga2V5Y29kZXMgZm9yIHNvbWUga2V5cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMzNjUKKworICAgICAgICAqIHBsYXRm b3JtL3F0L1NraXBwZWQ6IFVuc2tpcCB0ZXN0cyB0aGF0IGFyZSBub3cgcGFzc2luZy4KKworMjAx MC0wOC0wMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKICAgICAg ICAgW1F0XSBET00gbGlzdGVuZXJzIGdldCB3cm9uZyBrZXljb2RlcyBmb3Igc29tZSBrZXlzCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzM2NQogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA4MGU1NGQwOWExOTJjOWI2ODgxNjkxZDAwMmI0MTNl ZjdiMGNiMWVmLi4zMzYzOGUzN2YyM2I0OGI0MWY4Y2ZkOTIzODFlZDI1M2VmNDNiNTFlIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTU0ODAsOCArNTQ4MCwzIEBAIGZhc3QvZXZlbnRzL3Nw YXRpYWwtbmF2aWdhdGlvbi9zbmF2LWNsaXBwZWQtb3ZlcmZsb3dlZC1jb250ZW50Lmh0bWwKICMg QXNzdW1lcyBzcGVzaWZpYyBtZXRyaWNzCiAjIFNlZSBodHRwOi8vY29kZS5nb29nbGUuY29tL3Av Y2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0xOTg5Nwogc3ZnL2N1c3RvbS9nZXRzY3JlZW5jdG0t aW4tbWl4ZWQtY29udGVudDIueGh0bWwKLQotIyBbUXRdIERPTSBsaXN0ZW5lcnMgZ2V0IHdyb25n IGtleWNvZGVzIGZvciBzb21lIGtleXMKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQzMzY1Ci1mYXN0L2V2ZW50cy9rZXlkb3duLW51bXBhZC1rZXlzLmh0bWwKLWZh c3QvZXZlbnRzL3NwZWNpYWwta2V5LWV2ZW50cy1pbi1pbnB1dC10ZXh0Lmh0bWwKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTVmNjVhZGU4 YTJiMTgyYTc0OGQ1NTQ4YWI5Nzk5OGFlMjIxODk0YS4uNTQ3ZDJhMGEwNjQwNGI0MDNiYmVhODYw MzgwZDM5NTFmYjY2Mzk3YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0wMiAgTWFydGluIFJvYmlu c29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1F0XSBET00gbGlzdGVuZXJzIGdldCB3cm9uZyBrZXljb2Rl cyBmb3Igc29tZSBrZXlzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MzM2NQorCisgICAgICAgIFByb2R1Y2UgdGhlIHByb3BlciBrZXljb2RlcyBmb3Ig dGhlIHByaW50IHNjcmVlbiBrZXkgYXMgd2VsbCBhcyB0aGV5CisgICAgICAgIGtleXBhZCBpbnNl cnQgYW5kIGRlbGV0ZSBrZXlzLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXli b2FyZEV2ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6d2luZG93c0tleUNvZGVGb3JLZXlF dmVudCk6IEZpeCBrZXljb2RlIHRyYW5zbGF0aW9uIGZvciB0aGUgbWVudGlvbmVkIGtleXMuCisK IDIwMTAtMDgtMDIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBBWDogU3VwcG9ydCBtZXRob2RzIGZvciB3ZWIgYXBwcyB0byBpbnRlcmFjdCB3aXRoIHRo ZSBuYXRpdmUgYWNjZXNzaWJpbGl0eSBBUElzCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxh dGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwCmluZGV4IDZkZGU5YzQ2Mzg0NDI5MDk0OWUzYzZlMjcw NWQ0N2Y5N2M0ZGI0NzguLjYwMDJkODYyM2Q3YjJjMGY4OGZjYTEwNDdjYTM1OTI5MWRkMWFmNmUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3Bw CkBAIC0xODgsNiArMTg4LDEwIEBAIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2ln bmVkIGludCBrZXljb2RlLCBib29sIGlzS2V5cGFkKQogICAgICAgICAgICAgcmV0dXJuIFZLX1JJ R0hUOyAvLyAoMjcpIFJJR0hUIEFSUk9XIGtleQogICAgICAgICBjYXNlIFF0OjpLZXlfRG93bjoK ICAgICAgICAgICAgIHJldHVybiBWS19ET1dOOyAvLyAoMjgpIERPV04gQVJST1cga2V5CisgICAg ICAgIGNhc2UgUXQ6OktleV9JbnNlcnQ6CisgICAgICAgICAgICByZXR1cm4gVktfSU5TRVJUOyAv LyAoMkQpIElOUyBrZXkKKyAgICAgICAgY2FzZSBRdDo6S2V5X0RlbGV0ZToKKyAgICAgICAgICAg IHJldHVybiBWS19ERUxFVEU7IC8vICgyRSkgREVMIGtleQogICAgICAgICBkZWZhdWx0OgogICAg ICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KQEAgLTMwNCwxMiArMzA4LDkgQEAgaW50IHdp bmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQgaW50IGtleWNvZGUsIGJvb2wgaXNLZXlw YWQpCiAgICAgY2FzZSBRdDo6S2V5X1NlbGVjdDoKICAgICAgICAgcmV0dXJuIFZLX1NFTEVDVDsg Ly8gKDI5KSBTRUxFQ1Qga2V5CiAgICAgY2FzZSBRdDo6S2V5X1ByaW50OgotICAgICAgICByZXR1 cm4gVktfUFJJTlQ7IC8vICgyQSkgUFJJTlQga2V5CisgICAgICAgIHJldHVybiBWS19TTkFQU0hP VDsgLy8gKDJDKSBQUklOVCBTQ1JFRU4ga2V5CiAgICAgY2FzZSBRdDo6S2V5X0V4ZWN1dGU6CiAg ICAgICAgIHJldHVybiBWS19FWEVDVVRFOyAvLyAoMkIpIEVYRUNVVEUga2V5Ci0gICAgICAgIC8v IGR1bm5vIG9uIHRoaXMKLSAgICAgICAgLy8gY2FzZSBRdDo6S2V5X1ByaW50U2NyZWVuOgotICAg ICAgICAvLyByZXR1cm4gVktfU05BUFNIT1Q7IC8vICgyQykgUFJJTlQgU0NSRUVOIGtleQogICAg IGNhc2UgUXQ6OktleV9JbnNlcnQ6CiAgICAgICAgIHJldHVybiBWS19JTlNFUlQ7IC8vICgyRCkg SU5TIGtleQogICAgIGNhc2UgUXQ6OktleV9EZWxldGU6Cg== 67323 2010-09-11 18:56:11 -0700 2010-09-12 03:39:22 -0700 Tested patch for this issue bug-43365-20100911185609.patch text/plain 3554 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MjFlYWE2Nzg3NjllMGM3ODczZGY4NGM4MWYxMzE1YmIyYzE2OGM3Li45ZWQ4YzU3 ZjFjNTQwMmY5YTA3Njc4ZDEzNTZkYjY5Mjg5YmZkOWM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTAtMDktMTEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRE9NIGxp c3RlbmVycyBnZXQgd3Jvbmcga2V5Y29kZXMgZm9yIHNvbWUga2V5cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMzNjUKKworICAgICAgICAqIHBsYXRm b3JtL3F0L1NraXBwZWQ6IFVuc2tpcCB0ZXN0cyB0aGF0IGFyZSBub3cgcGFzc2luZy4KKworMjAx MC0wOS0xMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKICAgICAg ICAgQWRkIGEgcGxhdGZvcm0tc3BlY2lmaWMgcmVzdWx0IGFmdGVyIHI2NzI4MS4KIAogICAgICAg ICAqIHBsYXRmb3JtL2d0ay9mYXN0L2R5bmFtaWMvZmlyc3QtbGV0dGVyLWRpc3BsYXktY2hhbmdl LWV4cGVjdGVkLnR4dDogQWRkZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCAzOGM2MjM2 NjE1NDhmMmU4ZmY0NTNmOWU3NjgwZGU1Yzk3ZjlkMDgzLi5hYjE4OTYxOWFlZTQxNGUxZDc3MGFj ZDkwNjAzN2U1NmIzNzBkZTZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTU0MjIsMTEg KzU0MjIsNiBAQCBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jbGlwcGVkLW92 ZXJmbG93ZWQtY29udGVudC5odG1sCiAjIFNlZSBodHRwOi8vY29kZS5nb29nbGUuY29tL3AvY2hy b21pdW0vaXNzdWVzL2RldGFpbD9pZD0xOTg5Nwogc3ZnL2N1c3RvbS9nZXRzY3JlZW5jdG0taW4t bWl4ZWQtY29udGVudDIueGh0bWwKIAotIyBbUXRdIERPTSBsaXN0ZW5lcnMgZ2V0IHdyb25nIGtl eWNvZGVzIGZvciBzb21lIGtleXMKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQzMzY1Ci1mYXN0L2V2ZW50cy9rZXlkb3duLW51bXBhZC1rZXlzLmh0bWwKLWZhc3Qv ZXZlbnRzL3NwZWNpYWwta2V5LWV2ZW50cy1pbi1pbnB1dC10ZXh0Lmh0bWwKLQogIyBTdGlsbCB3 b3JraW5nIG91dCBmbGFraW5lc3MgaXNzdWVzIHdpdGggdGhlIHBlcmYgdGVzdHMuCiAjIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE5OQogcGVyZi8KZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFjZGYzNjhh NTE2ZGIyMzBjMDQwYjcwOTI4ZTM4YTQ5NTM5ZTNlMC4uZTlhZTBlNDMzMjhkNzc5NDhkMjQ1NTEz NTRkZjZhNTFmMjlkZTVkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0xMSAgTWFydGluIFJvYmlu c29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1F0XSBET00gbGlzdGVuZXJzIGdldCB3cm9uZyBrZXljb2Rl cyBmb3Igc29tZSBrZXlzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MzM2NQorCisgICAgICAgIFByb2R1Y2UgdGhlIHByb3BlciBrZXljb2RlcyBmb3Ig dGhlIHByaW50IHNjcmVlbiBrZXkgYXMgd2VsbCBhcyB0aGUKKyAgICAgICAga2V5cGFkIGluc2Vy dCBhbmQgZGVsZXRlIGtleXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJv YXJkRXZlbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3aW5kb3dzS2V5Q29kZUZvcktleUV2 ZW50KTogRml4IGtleWNvZGUgdHJhbnNsYXRpb24gZm9yIHRoZSBtZW50aW9uZWQga2V5cy4KKwog MjAxMC0wOS0xMSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxh dGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtl eWJvYXJkRXZlbnRRdC5jcHAKaW5kZXggNmRkZTljNDYzODQ0MjkwOTQ5ZTNjNmUyNzA1ZDQ3Zjk3 YzRkYjQ3OC4uZDBlZGIxNjE2MDNlNmRjMWYwMjQ1NTc1ZDlhZjAzYTUzMTFmNDljNiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAKQEAgLTE4 OCw2ICsxODgsMTAgQEAgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQgaW50 IGtleWNvZGUsIGJvb2wgaXNLZXlwYWQpCiAgICAgICAgICAgICByZXR1cm4gVktfUklHSFQ7IC8v ICgyNykgUklHSFQgQVJST1cga2V5CiAgICAgICAgIGNhc2UgUXQ6OktleV9Eb3duOgogICAgICAg ICAgICAgcmV0dXJuIFZLX0RPV047IC8vICgyOCkgRE9XTiBBUlJPVyBrZXkKKyAgICAgICAgY2Fz ZSBRdDo6S2V5X0luc2VydDoKKyAgICAgICAgICAgIHJldHVybiBWS19JTlNFUlQ7IC8vICgyRCkg SU5TIGtleQorICAgICAgICBjYXNlIFF0OjpLZXlfRGVsZXRlOgorICAgICAgICAgICAgcmV0dXJu IFZLX0RFTEVURTsgLy8gKDJFKSBERUwga2V5CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAg ICByZXR1cm4gMDsKICAgICAgICAgfQpAQCAtMzA0LDEyICszMDgsOSBAQCBpbnQgd2luZG93c0tl eUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQga2V5Y29kZSwgYm9vbCBpc0tleXBhZCkKICAg ICBjYXNlIFF0OjpLZXlfU2VsZWN0OgogICAgICAgICByZXR1cm4gVktfU0VMRUNUOyAvLyAoMjkp IFNFTEVDVCBrZXkKICAgICBjYXNlIFF0OjpLZXlfUHJpbnQ6Ci0gICAgICAgIHJldHVybiBWS19Q UklOVDsgLy8gKDJBKSBQUklOVCBrZXkKKyAgICAgICAgcmV0dXJuIFZLX1NOQVBTSE9UOyAvLyAo MkEpIFBSSU5UIGtleQogICAgIGNhc2UgUXQ6OktleV9FeGVjdXRlOgogICAgICAgICByZXR1cm4g VktfRVhFQ1VURTsgLy8gKDJCKSBFWEVDVVRFIGtleQotICAgICAgICAvLyBkdW5ubyBvbiB0aGlz Ci0gICAgICAgIC8vIGNhc2UgUXQ6OktleV9QcmludFNjcmVlbjoKLSAgICAgICAgLy8gcmV0dXJu IFZLX1NOQVBTSE9UOyAvLyAoMkMpIFBSSU5UIFNDUkVFTiBrZXkKICAgICBjYXNlIFF0OjpLZXlf SW5zZXJ0OgogICAgICAgICByZXR1cm4gVktfSU5TRVJUOyAvLyAoMkQpIElOUyBrZXkKICAgICBj YXNlIFF0OjpLZXlfRGVsZXRlOgo=