43360 2010-08-02 09:42:15 -0700 [Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h 2010-08-08 15:27:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows XP RESOLVED FIXED Qt, QtTriaged P3 Normal --- 43191 1 ossy webkit-unassigned aroben lkcl tonikitoo oldest_to_newest 258930 0 ossy 2010-08-02 09:42:15 -0700 In file included from ..\..\..\WebCore\platform\qt\PlatformKeyboardEventQt.cpp:32:0: ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:37:0: warning: "VK_BACK" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1869:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:38:0: warning: "VK_TAB" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1870:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:39:0: warning: "VK_CLEAR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1871:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:40:0: warning: "VK_RETURN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1872:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:41:0: warning: "VK_SHIFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1873:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:42:0: warning: "VK_CONTROL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1874:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:43:0: warning: "VK_MENU" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1875:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:44:0: warning: "VK_PAUSE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1876:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:45:0: warning: "VK_CAPITAL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1877:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:57:0: warning: "VK_SPACE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1890:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:58:0: warning: "VK_PRIOR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1891:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:59:0: warning: "VK_NEXT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1892:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:60:0: warning: "VK_END" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1893:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:61:0: warning: "VK_HOME" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1894:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:62:0: warning: "VK_LEFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1895:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:63:0: warning: "VK_UP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1896:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:64:0: warning: "VK_RIGHT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1897:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:65:0: warning: "VK_DOWN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1898:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:66:0: warning: "VK_SELECT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1899:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:67:0: warning: "VK_PRINT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1900:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:68:0: warning: "VK_EXECUTE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1901:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:69:0: warning: "VK_SNAPSHOT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1902:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:70:0: warning: "VK_INSERT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1903:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:71:0: warning: "VK_DELETE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1904:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:72:0: warning: "VK_HELP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1905:0: note: this is the location of the previous definition In file included from ..\..\..\WebKit\qt\WebCoreSupport\EditorClientQt.cpp:49:0: ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:37:0: warning: "VK_BACK" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1869:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:38:0: warning: "VK_TAB" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1870:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:39:0: warning: "VK_CLEAR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1871:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:40:0: warning: "VK_RETURN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1872:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:41:0: warning: "VK_SHIFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1873:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:42:0: warning: "VK_CONTROL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1874:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:43:0: warning: "VK_MENU" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1875:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:44:0: warning: "VK_PAUSE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1876:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:45:0: warning: "VK_CAPITAL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1877:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:57:0: warning: "VK_SPACE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1890:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:58:0: warning: "VK_PRIOR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1891:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:59:0: warning: "VK_NEXT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1892:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:60:0: warning: "VK_END" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1893:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:61:0: warning: "VK_HOME" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1894:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:62:0: warning: "VK_LEFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1895:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:63:0: warning: "VK_UP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1896:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:64:0: warning: "VK_RIGHT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1897:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:65:0: warning: "VK_DOWN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1898:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:66:0: warning: "VK_SELECT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1899:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:67:0: warning: "VK_PRINT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1900:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:68:0: warning: "VK_EXECUTE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1901:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:69:0: warning: "VK_SNAPSHOT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1902:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:70:0: warning: "VK_INSERT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1903:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:71:0: warning: "VK_DELETE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1904:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:72:0: warning: "VK_HELP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1905:0: note: this is the location of the previous definition VK_xxx macros also defined in mingw/include/winuser.h. We should use these defines when we use MinGW, or #undef macros before defining them in WindowsKeyboardCodes.h 258935 1 ossy 2010-08-02 09:56:28 -0700 *** This bug has been marked as a duplicate of bug 20721 *** 259364 2 ossy 2010-08-03 04:14:20 -0700 Reopened, because https://bugs.webkit.org/show_bug.cgi?id=20721 is obsolete, defining VK_XXX macros changed. 259365 3 63319 ossy 2010-08-03 04:15:11 -0700 Created attachment 63319 proposed fix 259367 4 ossy 2010-08-03 04:15:58 -0700 *** Bug 20721 has been marked as a duplicate of this bug. *** 261939 5 63319 ossy 2010-08-08 15:27:31 -0700 Comment on attachment 63319 proposed fix Clearing flags on attachment: 63319 Committed r64957: <http://trac.webkit.org/changeset/64957> 261940 6 ossy 2010-08-08 15:27:40 -0700 All reviewed patches have been landed. Closing bug. 63319 2010-08-03 04:15:11 -0700 2010-08-08 15:27:31 -0700 proposed fix 1.patch text/plain 1555 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzlmNzc0MC4uM2Q1MTgwMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOC0wMyAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IHdhcm5pbmdzIGluIFdlYkNvcmUvcGxhdGZvcm0v V2luZG93c0tleWJvYXJkQ29kZXMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDMzNjAKKworICAgICAgICAqIHBsYXRmb3JtL1dpbmRvd3NLZXlib2Fy ZENvZGVzLmg6IFVuZGVmIG1hY3JvcyB3aGljaCBhcmUgYWxzbyBkZWZpbmVkIGluIE1pbkdXL2lu Y2x1ZGUvd2ludXNlci5oIHRvIGF2aW9kIGdjYyByZWRlZmluaXRpb24gd2FybmluZworCiAyMDEw LTA4LTAzICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vV2lu ZG93c0tleWJvYXJkQ29kZXMuaCBiL1dlYkNvcmUvcGxhdGZvcm0vV2luZG93c0tleWJvYXJkQ29k ZXMuaAppbmRleCA4NmM3N2VhLi4yZDI4N2MyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L1dpbmRvd3NLZXlib2FyZENvZGVzLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9XaW5kb3dzS2V5 Ym9hcmRDb2Rlcy5oCkBAIC0yNyw2ICsyNywzNiBAQAogCiAjZGVmaW5lIFZLX1VOS05PV04gMAog CisvLyBVbmRlZiBtYWNyb3Mgd2hpY2ggYXJlIGFsc28gZGVmaW5lZCBpbiBNaW5HVy9pbmNsdWRl L3dpbnVzZXIuaCB0byBhdmlvZCBnY2MgcmVkZWZpbml0aW9uIHdhcm5pbmcKKy8vIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzM2MAorI2lmIENPTVBJTEVSKE1JTkdX KQorI3VuZGVmIFZLX0JBQ0sKKyN1bmRlZiBWS19UQUIKKyN1bmRlZiBWS19DTEVBUgorI3VuZGVm IFZLX1JFVFVSTgorI3VuZGVmIFZLX1NISUZUCisjdW5kZWYgVktfQ09OVFJPTAorI3VuZGVmIFZL X01FTlUKKyN1bmRlZiBWS19QQVVTRQorI3VuZGVmIFZLX0NBUElUQUwKKyN1bmRlZiBWS19TUEFD RQorI3VuZGVmIFZLX1BSSU9SCisjdW5kZWYgVktfTkVYVAorI3VuZGVmIFZLX0VORAorI3VuZGVm IFZLX0hPTUUKKyN1bmRlZiBWS19MRUZUCisjdW5kZWYgVktfVVAKKyN1bmRlZiBWS19SSUdIVAor I3VuZGVmIFZLX0RPV04KKyN1bmRlZiBWS19TRUxFQ1QKKyN1bmRlZiBWS19QUklOVAorI3VuZGVm IFZLX0VYRUNVVEUKKyN1bmRlZiBWS19TTkFQU0hPVAorI3VuZGVmIFZLX0lOU0VSVAorI3VuZGVm IFZLX0RFTEVURQorI3VuZGVmIFZLX0hFTFAKKyNlbmRpZiAvLyBDT01QSUxFUihNSU5HVykKKwog Ly8gTGVmdCBtb3VzZSBidXR0b24KIC8vIFJpZ2h0IG1vdXNlIGJ1dHRvbgogLy8gQ29udHJvbC1i cmVhayBwcm9jZXNzaW5nCg==