43359 2010-08-02 09:33:44 -0700 [Qt] Fix warnings: unknown conversion type character 'l' in format 2014-01-29 07:46:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows XP RESOLVED INVALID Qt, QtTriaged P3 Normal --- 43191 1 ossy ossy abarth andersca aroben eric webkit.review.bot oldest_to_newest 258926 0 ossy 2010-08-02 09:33:44 -0700 Build QtWebKit on Windows with MinGW, there are some "warning: unknown conversion type character 'l' in format": ..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:404:36: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:404:36: warning: too many arguments for format ..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:413:36: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:413:36: warning: too many arguments for format ..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: too many arguments for format ..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:76:84: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:76:84: warning: too many arguments for format ..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:79:44: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:79:44: warning: too many arguments for format We should use SCN... and PRI... macros from inttypes.h to avoid using %lli, %llu, ... 263277 1 64122 ossy 2010-08-11 09:20:02 -0700 Created attachment 64122 proposed fix #1 Fix 4 warnings: JavaScriptCore\wtf\text\WTFString.cpp:404: return String::format("%lli", n); JavaScriptCore\wtf\text\WTFString.cpp:413: return String::format("%llu", n); WebCore\platform\sql\SQLiteFileSystem.cpp:76: fileName = pathByAppendingComponent(dbDir, String::format("%016llx.db", seq)); WebCore\platform\sql\SQLiteFileSystem.cpp:79: return String::format("%016llx.db", seq); 263319 2 64132 ossy 2010-08-11 10:13:38 -0700 Created attachment 64132 proposed fix #2 Fix this warning: ..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: too many arguments for format I prefer PRI and SCN macros defined in inttypes.h, but I can't find any occurance of them in WebKit trunk. Accordingly I propose a fix similar to String::number(...). JavaScriptCore/wtf/text/WTFString.cpp: ... String String::number(long long n) { #if OS(WINDOWS) && !PLATFORM(QT) return String::format("%I64i", n); #else return String::format("%lli", n); #endif } ... 263781 3 64218 ossy 2010-08-12 06:52:09 -0700 Created attachment 64218 proposed fix #3 Fix 6 warnings (Windows - debug mode): ..\..\..\WebCore\platform\sql\SQLiteDatabase.cpp:159: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\platform\sql\SQLiteDatabase.cpp:159: warning: too many arguments for format ..\..\..\WebCore\storage\DatabaseTracker.cpp:689: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\storage\DatabaseTracker.cpp:689: warning: format '%s' expects type 'char*', but argument 5 has type 'long long unsigned int' ..\..\..\WebCore\storage\DatabaseTracker.cpp:689: warning: too many arguments for format ..\..\..\WebCore\loader\icon\IconDatabase.cpp:1313: warning: unknown conversion type character 'z' in format ..\..\..\WebCore\loader\icon\IconDatabase.cpp:1313: warning: too many arguments for format ..\..\..\WebCore\loader\icon\IconDatabase.cpp:1637: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\loader\icon\IconDatabase.cpp:1637: warning: too many arguments for format ..\..\..\WebCore\loader\icon\IconDatabase.cpp:1641: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\loader\icon\IconDatabase.cpp:1641: warning: too many arguments for format ..\..\..\WebCore\platform\graphics\qt\MediaPlayerPrivatePhonon.cpp:537: warning: unknown conversion type character 'l' in format ..\..\..\WebCore\platform\graphics\qt\MediaPlayerPrivatePhonon.cpp:537: warning: too many arguments for format 263923 4 64122 tonikitoo 2010-08-12 12:57:06 -0700 Comment on attachment 64122 proposed fix #1 > @@ -1,3 +1,20 @@ > +2010-08-11 Csaba Osztrogonác <ossy@webkit.org> maybe you could fix you name spell :) 263928 5 ossy 2010-08-12 13:12:09 -0700 (In reply to comment #4) > (From update of attachment 64122 [details]) > > > @@ -1,3 +1,20 @@ > > +2010-08-11 Csaba Osztrogonác <ossy@webkit.org> > > maybe you could fix you name spell :) Bugzilla doesn't like me, but trac would be happy. ;) 263929 6 ossy 2010-08-12 13:13:50 -0700 Adam, could you review "proposed fix #2" and "proposed fix #3" Windows related patches, please? 263941 7 64122 ossy 2010-08-12 13:28:28 -0700 Comment on attachment 64122 proposed fix #1 Clearing flags on attachment: 64122 Committed r65264: <http://trac.webkit.org/changeset/65264> 263980 8 webkit.review.bot 2010-08-12 14:30:45 -0700 http://trac.webkit.org/changeset/65264 might have broken SnowLeopard Intel Release (Tests) 263984 9 ossy 2010-08-12 14:33:31 -0700 (In reply to comment #8) > http://trac.webkit.org/changeset/65264 might have broken SnowLeopard Intel Release (Tests) It must be a false positive alarm. 265106 10 64132 ossy 2010-08-16 08:04:30 -0700 Comment on attachment 64132 proposed fix #2 Landed in http://trac.webkit.org/changeset/65426. 265117 11 64218 ossy 2010-08-16 08:31:25 -0700 Comment on attachment 64218 proposed fix #3 Landed in http://trac.webkit.org/changeset/65427. 283683 12 ossy 2010-09-23 09:13:53 -0700 Reopen, because there are more 5 warnings in JavaScriptCore\interpreter\Interpreter.cpp revealed by enabling JSVALUE32_64 on Windows: ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:426: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:426: warning: too many arguments for format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:438: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:438: warning: too many arguments for format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:447: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:447: warning: too many arguments for format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:470: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:470: warning: too many arguments for format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:485: warning: unknown conversion type character 'l' in format ..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:485: warning: too many arguments for format Fix is coming soon. 64122 2010-08-11 09:20:02 -0700 2010-08-12 13:28:28 -0700 proposed fix #1 1.patch text/plain 1605 ossy ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA2MTYwYjMxLi5kZGYyYTg1IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTAtMDgtMTEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCB3 YXJuaW5nczogdW5rbm93biBjb252ZXJzaW9uIHR5cGUgY2hhcmFjdGVyICdsJyBpbiBmb3JtYXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMzU5CisK KyAgICAgICAgUXQgcG9ydCBkb2Vzbid0IGNhbGwgYW55IHByaW50ZiBpbiBTdHJpbmc6OmZvcm1h dCguLi4pLCBjb25zZXF1ZW50bHkKKyAgICAgICAgdXNpbmcgX19hdHRyaWJ1dGVfXygoZm9ybWF0 KHByaW50ZixtLG4pKSkgaXMgaW5jb3JyZWN0IGFuZCBjYXVzZXMKKyAgICAgICAgZmFsc2UgcG9z aXRpdmUgd2FybmluZ3Mgb24gV2luZG93cyBpZiB5b3UgYnVpbGQgd2l0aCBNaW5HVy4KKworICAg ICAgICBRdCBwb3J0IGNhbGxzIFFTdHJpbmc6OnZzcHJpbnRmKC4uLikgLCB3aGljaCBpcyBwbGF0 Zm9ybQorICAgICAgICBpbmRlcGVuZGVudCwgYW5kIGhhbmRsZXMgJWxsaSwgJWxsdSBhbmQgJWxs eCBvbiBhbGwgcGxhdGZvcm1zLgorICAgICAgICAoaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvMzU3MTIpCisKKyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKwogMjAxMC0w OC0xMSAgTmF0aGFuIExhd3JlbmNlICA8bmxhd3JlbmNlQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0 Zi90ZXh0L1dURlN0cmluZy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgK aW5kZXggNmFmNTE5Yy4uNDkyMWQxOCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL3Rl eHQvV1RGU3RyaW5nLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgK QEAgLTIwMSw4ICsyMDEsMTIgQEAgcHVibGljOgogICAgIHN0YXRpYyBTdHJpbmcgbnVtYmVyKGxv bmcgbG9uZyk7CiAgICAgc3RhdGljIFN0cmluZyBudW1iZXIodW5zaWduZWQgbG9uZyBsb25nKTsK ICAgICBzdGF0aWMgU3RyaW5nIG51bWJlcihkb3VibGUpOwotICAgIAorCisjaWYgIVBMQVRGT1JN KFFUKQogICAgIHN0YXRpYyBTdHJpbmcgZm9ybWF0KGNvbnN0IGNoYXIgKiwgLi4uKSBXVEZfQVRU UklCVVRFX1BSSU5URigxLCAyKTsKKyNlbHNlCisgICAgc3RhdGljIFN0cmluZyBmb3JtYXQoY29u c3QgY2hhciAqLCAuLi4pOworI2VuZGlmCiAKICAgICAvLyBSZXR1cm5zIGFuIHVuaW5pdGlhbGl6 ZWQgc3RyaW5nLiBUaGUgY2hhcmFjdGVycyBuZWVkcyB0byBiZSB3cml0dGVuCiAgICAgLy8gaW50 byB0aGUgYnVmZmVyIHJldHVybmVkIGluIGRhdGEgYmVmb3JlIHRoZSByZXR1cm5lZCBzdHJpbmcg aXMgdXNlZC4K 64132 2010-08-11 10:13:38 -0700 2010-08-16 08:04:30 -0700 proposed fix #2 1.patch text/plain 1400 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2RmNWRiMC4uYTQwNWMxMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0xMSAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB3YXJuaW5nczogdW5rbm93biBjb252ZXJzaW9uIHR5cGUg Y2hhcmFjdGVyICdsJyBpbiBmb3JtYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQzMzU5CisKKyAgICAgICAgKiBsb2FkZXIvRlRQRGlyZWN0b3J5UGFy c2VyLmNwcDogVXNlICVJNjR1IGZvcm1hdCBzcGVjaWZpZXIgaW5zdGVhZCBvZiAlbGx1IG9uIFdp bmRvd3MuCisgICAgICAgIChXZWJDb3JlOjpwYXJzZU9uZUZUUExpbmUpOgorCiAyMDEwLTA4LTEx ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9GVFBEaXJl Y3RvcnlQYXJzZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRlRQRGlyZWN0b3J5UGFyc2VyLmNwcApp bmRleCAxNDJmMmEzLi5mNmE3NGRlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GVFBEaXJl Y3RvcnlQYXJzZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZUUERpcmVjdG9yeVBhcnNlci5j cHAKQEAgLTE4OCw5ICsxODgsMTMgQEAgRlRQRW50cnlUeXBlIHBhcnNlT25lRlRQTGluZShjb25z dCBjaGFyKiBsaW5lLCBMaXN0U3RhdGUmIHN0YXRlLCBMaXN0UmVzdWx0JiByZXMKICAgICAgICAg ICAgICAgaWYgKHBvcyA8IGxpbmVsZW4gJiYgbGluZVtwb3NdID09ICcsJykKICAgICAgICAgICAg ICAgewogICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbG9uZyBzZWNvbmRzID0gMDsKKyNp ZiBPUyhXSU5ET1dTKQorICAgICAgICAgICAgICAgIHNzY2FuZihwICsgMSwgIiVJNjR1IiwgJnNl Y29uZHMpOworI2Vsc2UKICAgICAgICAgICAgICAgICBzc2NhbmYocCArIDEsICIlbGx1IiwgJnNl Y29uZHMpOworI2VuZGlmCiAgICAgICAgICAgICAgICAgdGltZV90IHQgPSBzdGF0aWNfY2FzdDx0 aW1lX3Q+KHNlY29uZHMpOwotICAgICAgICAgICAgICAgIAorCiAgICAgICAgICAgICAgICAgLy8g RklYTUU6IFRoaXMgY29kZSBoYXMgdGhlIHllYXIgMjAzOCBidWcKICAgICAgICAgICAgICAgICBn bXRpbWVfcigmdCwgJnJlc3VsdC5tb2RpZmllZFRpbWUpOwogICAgICAgICAgICAgICAgIHJlc3Vs dC5tb2RpZmllZFRpbWUudG1feWVhciArPSAxOTAwOwo= 64218 2010-08-12 06:52:09 -0700 2010-08-16 08:31:25 -0700 proposed fix #3 1.patch text/plain 5159 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmYwM2JjOC4uNmE1NGZkYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOC0xMiAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB3YXJuaW5nczogdW5rbm93biBjb252ZXJzaW9uIHR5cGUg Y2hhcmFjdGVyICdsJyBpbiBmb3JtYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQzMzU5CisKKyAgICAgICAgKiBsb2FkZXIvaWNvbi9JY29uRGF0YWJh c2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SWNvbkRhdGFiYXNlOjpwZXJmb3JtVVJMSW1wb3J0 KTogUmVwbGFjZSAlenUgd2l0aCAlbHUsIGJlY2F1c2UgV2luZG93cyBkb2Vzbid0IHVuZGVyc3Rh bmQgeiBtb2RpZmllci4KKyAgICAgICAgKFdlYkNvcmU6Okljb25EYXRhYmFzZTo6cHJ1bmVVbnJl dGFpbmVkSWNvbnMpOiBVc2UgJUk2NGkgaW50c2VhZCBvZiAlbGxpIG9uIFdpbmRvd3MuCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dG90YWxUaW1lQ2hhbmdlZCk6 IFVzZSAlSTY0ZCBpbnRzZWFkIG9mICVsbGQgb24gV2luZG93cy4KKyAgICAgICAgKiBwbGF0Zm9y bS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRGF0YWJh c2U6OnNldE1heGltdW1TaXplKTogVXNlICVJNjRpIGludHNlYWQgb2YgJWxsaSBvbiBXaW5kb3dz LgorICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkRhdGFiYXNlVHJhY2tlcjo6c2V0UXVvdGEpOiBVc2UgJUk2NHUgaW50c2VhZCBvZiAlbGx1 IG9uIFdpbmRvd3MuCisKIDIwMTAtMDgtMTIgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2ZXJ0IGZvciBub3cKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9h ZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcCBiL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFi YXNlLmNwcAppbmRleCA1NWU5ZjZjLi41MGE3MjI4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRl ci9pY29uL0ljb25EYXRhYmFzZS5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0 YWJhc2UuY3BwCkBAIC0xMzEwLDcgKzEzMTAsNyBAQCB2b2lkIEljb25EYXRhYmFzZTo6cGVyZm9y bVVSTEltcG9ydCgpCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBMT0coSWNvbkRhdGFiYXNlLCAi Tm90aWZ5aW5nICV6dSBpbnRlcmVzdGVkIHBhZ2UgVVJMcyB0aGF0IHRoZWlyIGljb24gVVJMIGlz IGtub3duIGR1ZSB0byB0aGUgaW1wb3J0IiwgdXJsc1RvTm90aWZ5LnNpemUoKSk7CisgICAgTE9H KEljb25EYXRhYmFzZSwgIk5vdGlmeWluZyAlbHUgaW50ZXJlc3RlZCBwYWdlIFVSTHMgdGhhdCB0 aGVpciBpY29uIFVSTCBpcyBrbm93biBkdWUgdG8gdGhlIGltcG9ydCIsIHN0YXRpY19jYXN0PHVu c2lnbmVkIGxvbmc+KHVybHNUb05vdGlmeS5zaXplKCkpKTsKICAgICAvLyBOb3cgdGhhdCB3ZSBk b24ndCBob2xkIGFueSBsb2NrcywgcGVyZm9ybSB0aGUgYWN0dWFsIG5vdGlmaWNhdGlvbnMKICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdXJsc1RvTm90aWZ5LnNpemUoKTsgKytpKSB7CiAg ICAgICAgIExPRyhJY29uRGF0YWJhc2UsICJOb3RpZnlpbmcgaWNvbiBpbmZvIGtub3duIGZvciBw YWdlVVJMICVzIiwgdXJsc1RvTm90aWZ5W2ldLmFzY2lpKCkuZGF0YSgpKTsKQEAgLTE2MzQsMTEg KzE2MzQsMTkgQEAgdm9pZCBJY29uRGF0YWJhc2U6OnBydW5lVW5yZXRhaW5lZEljb25zKCkKICAg ICAgICAgU1FMaXRlU3RhdGVtZW50IHBhZ2VEZWxldGVTUUwobV9zeW5jREIsICJERUxFVEUgRlJP TSBQYWdlVVJMIFdIRVJFIHJvd2lkID0gKD8pOyIpOwogICAgICAgICBwYWdlRGVsZXRlU1FMLnBy ZXBhcmUoKTsKICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBudW1Ub0RlbGV0ZTsgKytp KSB7CisjaWYgT1MoV0lORE9XUykKKyAgICAgICAgICAgIExPRyhJY29uRGF0YWJhc2UsICJQcnVu aW5nIHBhZ2Ugd2l0aCByb3dpZCAlSTY0aSBmcm9tIGRpc2siLCBzdGF0aWNfY2FzdDxsb25nIGxv bmc+KHBhZ2VJRHNUb0RlbGV0ZVtpXSkpOworI2Vsc2UKICAgICAgICAgICAgIExPRyhJY29uRGF0 YWJhc2UsICJQcnVuaW5nIHBhZ2Ugd2l0aCByb3dpZCAlbGxpIGZyb20gZGlzayIsIHN0YXRpY19j YXN0PGxvbmcgbG9uZz4ocGFnZUlEc1RvRGVsZXRlW2ldKSk7CisjZW5kaWYKICAgICAgICAgICAg IHBhZ2VEZWxldGVTUUwuYmluZEludDY0KDEsIHBhZ2VJRHNUb0RlbGV0ZVtpXSk7CiAgICAgICAg ICAgICBpbnQgcmVzdWx0ID0gcGFnZURlbGV0ZVNRTC5zdGVwKCk7CiAgICAgICAgICAgICBpZiAo cmVzdWx0ICE9IFNRTFJlc3VsdERvbmUpCisjaWYgT1MoV0lORE9XUykKKyAgICAgICAgICAgICAg ICBMT0dfRVJST1IoIlVuYWJsZWQgdG8gZGVsZXRlIHBhZ2Ugd2l0aCBpZCAlSTY0aSBmcm9tIGRp c2siLCBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHBhZ2VJRHNUb0RlbGV0ZVtpXSkpOworI2Vsc2UK ICAgICAgICAgICAgICAgICBMT0dfRVJST1IoIlVuYWJsZWQgdG8gZGVsZXRlIHBhZ2Ugd2l0aCBp ZCAlbGxpIGZyb20gZGlzayIsIHN0YXRpY19jYXN0PGxvbmcgbG9uZz4ocGFnZUlEc1RvRGVsZXRl W2ldKSk7CisjZW5kaWYKICAgICAgICAgICAgIHBhZ2VEZWxldGVTUUwucmVzZXQoKTsKICAgICAg ICAgICAgIAogICAgICAgICAgICAgLy8gSWYgdGhlIHRocmVhZCB3YXMgYXNrZWQgdG8gdGVybWlu YXRlLCB3ZSBzaG91bGQgY29tbWl0IHdoYXQgcHJ1bmluZyB3ZSd2ZSBkb25lIHNvIGZhciwgZmln dXJpbmcgd2UgY2FuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01l ZGlhUGxheWVyUHJpdmF0ZVBob25vbi5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L01lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5jcHAKaW5kZXggM2M2YzVhYS4uMDhlYjgxNiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVQ aG9ub24uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQ cml2YXRlUGhvbm9uLmNwcApAQCAtNTM0LDcgKzUzNCwxMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJp dmF0ZTo6YWJvdXRUb0ZpbmlzaCgpCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjp0b3RhbFRp bWVDaGFuZ2VkKHFpbnQ2NCB0b3RhbFRpbWUpCiB7CisjaWYgT1MoV0lORE9XUykKKyAgICBMT0co TWVkaWEsICJNZWRpYVBsYXllclByaXZhdGVQaG9ub246OnRvdGFsVGltZUNoYW5nZWQoJUk2NGQp IiwgdG90YWxUaW1lKTsKKyNlbHNlCiAgICAgTE9HKE1lZGlhLCAiTWVkaWFQbGF5ZXJQcml2YXRl UGhvbm9uOjp0b3RhbFRpbWVDaGFuZ2VkKCVsbGQpIiwgdG90YWxUaW1lKTsKKyNlbmRpZgogICAg IExPR19NRURJQU9CSkVDVCgpOwogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3Nx bC9TUUxpdGVEYXRhYmFzZS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFz ZS5jcHAKaW5kZXggMDVhMmEyMi4uMTczNjMyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0 ZURhdGFiYXNlLmNwcApAQCAtMTU2LDcgKzE1NiwxMSBAQCB2b2lkIFNRTGl0ZURhdGFiYXNlOjpz ZXRNYXhpbXVtU2l6ZShpbnQ2NF90IHNpemUpCiAgICAgU1FMaXRlU3RhdGVtZW50IHN0YXRlbWVu dCgqdGhpcywgIlBSQUdNQSBtYXhfcGFnZV9jb3VudCA9ICIgKyBTdHJpbmc6Om51bWJlcihuZXdN YXhQYWdlQ291bnQpKTsKICAgICBzdGF0ZW1lbnQucHJlcGFyZSgpOwogICAgIGlmIChzdGF0ZW1l bnQuc3RlcCgpICE9IFNRTFJlc3VsdFJvdykKKyNpZiBPUyhXSU5ET1dTKQorICAgICAgICBMT0df RVJST1IoIkZhaWxlZCB0byBzZXQgbWF4aW11bSBzaXplIG9mIGRhdGFiYXNlIHRvICVJNjRpIGJ5 dGVzIiwgc3RhdGljX2Nhc3Q8bG9uZyBsb25nPihzaXplKSk7CisjZWxzZQogICAgICAgICBMT0df RVJST1IoIkZhaWxlZCB0byBzZXQgbWF4aW11bSBzaXplIG9mIGRhdGFiYXNlIHRvICVsbGkgYnl0 ZXMiLCBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHNpemUpKTsKKyNlbmRpZgogCiAgICAgZW5hYmxl QXV0aG9yaXplcih0cnVlKTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNl VHJhY2tlci5jcHAgYi9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmNwcAppbmRleCAw NzY0ZGIwLi5lMGJhNDIyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VUcmFj a2VyLmNwcAorKysgYi9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmNwcApAQCAtNjg2 LDcgKzY4NiwxMSBAQCB2b2lkIERhdGFiYXNlVHJhY2tlcjo6c2V0UXVvdGEoU2VjdXJpdHlPcmln aW4qIG9yaWdpbiwgdW5zaWduZWQgbG9uZyBsb25nIHF1b3RhKQogICAgICAgICB9CiAKICAgICAg ICAgaWYgKGVycm9yKQorI2lmIE9TKFdJTkRPV1MpCisgICAgICAgICAgICBMT0dfRVJST1IoIkZh aWxlZCB0byBzZXQgcXVvdGEgJUk2NHUgaW4gdHJhY2tlciBkYXRhYmFzZSBmb3Igb3JpZ2luICVz IiwgcXVvdGEsIG9yaWdpbi0+ZGF0YWJhc2VJZGVudGlmaWVyKCkuYXNjaWkoKS5kYXRhKCkpOwor I2Vsc2UKICAgICAgICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIHNldCBxdW90YSAlbGx1IGlu IHRyYWNrZXIgZGF0YWJhc2UgZm9yIG9yaWdpbiAlcyIsIHF1b3RhLCBvcmlnaW4tPmRhdGFiYXNl SWRlbnRpZmllcigpLmFzY2lpKCkuZGF0YSgpKTsKKyNlbmRpZgogICAgIH0KIAogICAgIC8vIEZJ WE1FOiBJcyBpdCByZWFsbHkgT0sgdG8gdXBkYXRlIHRoZSBxdW90YSBpbiBtZW1vcnkgaWYgd2Ug ZmFpbGVkIHRvIHVwZGF0ZSBpdCBvbiBkaXNrPwo=