43353 2010-08-02 08:39:58 -0700 generate-bindings.pl should generate warning free code 2010-08-12 14:56:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned andersca commit-queue darin eric tonikitoo oldest_to_newest 258886 0 ossy 2010-08-02 08:39:58 -0700 WebCore/generated/JSBlobBuilder.cpp is generated by WebCore/bindings/scripts/generate-bindings.pl, and gcc-4.3.2 reports this warning: generated/JSBlobBuilder.cpp: In function ‘JSC::EncodedJSValue WebCore::jsBlobBuilderPrototypeFunctionAppend(JSC::ExecState*)’: generated/JSBlobBuilder.cpp:255: warning: suggest parentheses around && within || generated/JSBlobBuilder.cpp:255: if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info)))) generate-bindings.pl should generate this line: if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || (exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info))))) 263842 1 ossy 2010-08-12 09:29:36 -0700 I cc-ed Darin, Eric and Anders, you may help to solve this bug, because you know generate-bindings.pl from the beginning: https://bugs.webkit.org/show_bug.cgi?id=5975 263843 2 ossy 2010-08-12 09:31:08 -0700 I think I found it, patch is coming soon. 263849 3 64230 ossy 2010-08-12 09:43:23 -0700 Created attachment 64230 proposed fix 264002 4 64230 commit-queue 2010-08-12 14:56:09 -0700 Comment on attachment 64230 proposed fix Clearing flags on attachment: 64230 Committed r65269: <http://trac.webkit.org/changeset/65269> 264003 5 commit-queue 2010-08-12 14:56:14 -0700 All reviewed patches have been landed. Closing bug. 64230 2010-08-12 09:43:23 -0700 2010-08-12 14:56:09 -0700 proposed fix 1.patch text/plain 1489 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDE5MjhhZS4uNGJlMWE0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOC0xMiAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGdlbmVyYXRlLWJpbmRpbmdzLnBsIHNob3VsZCBnZW5lcmF0ZSB3 YXJuaW5nIGZyZWUgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDMzNTMKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckpTLnBtOiBTdWdnZXN0ZWQgcGFyZW50aGVzZXMgYWRkZWQgYXJvdW5kICYmIHdpdGhpbiB8fAor CiAyMDEwLTA4LTExICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggY2I3YzMzMy4uZjQ4MTU5YiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0xMTM1LDcgKzExMzUs NyBAQCBzdWIgR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2tFeHByZXNzaW9uCiAgICAgICAgICMgdGhl c2UgYXJlIGFjY2VwdGFibGUgdmFsdWVzIGZvciBhIERPTVN0cmluZyBhcmd1bWVudCAoYW55IE9i amVjdCBjYW4KICAgICAgICAgIyBiZSBjb252ZXJ0ZWQgdG8gYSBzdHJpbmcgdmlhIC50b1N0cmlu ZykuCiAgICAgICAgIHB1c2goQGFuZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNOdWxsKCkgfHwg JHt2YWx1ZX0uaXNVbmRlZmluZWQoKSB8fCAke3ZhbHVlfS5pc1N0cmluZygpIHx8ICR7dmFsdWV9 LmlzT2JqZWN0KCkpIikgaWYgJGNvZGVHZW5lcmF0b3ItPklzU3RyaW5nVHlwZSgkdHlwZSk7Ci0g ICAgICAgIHB1c2goQGFuZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNOdWxsKCkgfHwgJHt2YWx1 ZX0uaXNPYmplY3QoKSAmJiBhc09iamVjdCgke3ZhbHVlfSktPmluaGVyaXRzKCZKUyR7dHlwZX06 OnNfaW5mbykpIikgdW5sZXNzIElzTmF0aXZlVHlwZSgkdHlwZSk7CisgICAgICAgIHB1c2goQGFu ZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNOdWxsKCkgfHwgKCR7dmFsdWV9LmlzT2JqZWN0KCkg JiYgYXNPYmplY3QoJHt2YWx1ZX0pLT5pbmhlcml0cygmSlMke3R5cGV9OjpzX2luZm8pKSkiKSB1 bmxlc3MgSXNOYXRpdmVUeXBlKCR0eXBlKTsKIAogICAgICAgICAkcGFyYW1ldGVySW5kZXgrKzsK ICAgICB9Cg==