43352 2010-08-02 08:35:01 -0700 Initiate speech input requests on click event 2010-08-03 04:52:12 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned abarth eric tkent webkit.review.bot oldest_to_newest 258883 0 satish 2010-08-02 08:35:01 -0700 Instead of initiating speech input requests on mouseup, do it on click event similar to how some other elements do (for e.g. spin button). This introduces no change in functionality from a user perspective while allowing clean automation for test purposes. 258887 1 63221 satish 2010-08-02 08:41:37 -0700 Created attachment 63221 Patch 259194 2 63221 tkent 2010-08-02 16:48:23 -0700 Comment on attachment 63221 Patch ok 259342 3 63221 tkent 2010-08-03 03:10:17 -0700 Comment on attachment 63221 Patch I'll commit this. 259343 4 63221 tkent 2010-08-03 03:12:47 -0700 Comment on attachment 63221 Patch Clearing flags on attachment: 63221 Committed r64542: <http://trac.webkit.org/changeset/64542> 259344 5 tkent 2010-08-03 03:12:55 -0700 All reviewed patches have been landed. Closing bug. 259377 6 webkit.review.bot 2010-08-03 04:52:12 -0700 http://trac.webkit.org/changeset/64542 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/64541 http://trac.webkit.org/changeset/64542 http://trac.webkit.org/changeset/64543 63221 2010-08-02 08:41:37 -0700 2010-08-03 03:12:47 -0700 Patch bug-43352-20100802164136.patch text/plain 2025 satish ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmZmNjMyYTNjNDUxMDZlM2YxMTMwMWU0YjQ2MDhmNmNjNGI4MTg4My4uNDI4OWE2YzFkNzVmMWIx ZDlhM2I3Nzg1YmEyMWJiM2FjZTBjMTZiYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0wMiAgU2F0 aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluaXRpYXRlIHNwZWVjaCBpbnB1dCByZXF1ZXN0 cyBvbiBjbGljayBldmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDMzNTIKKworICAgICAgICAqIHJlbmRlcmluZy9UZXh0Q29udHJvbElubmVyRWxl bWVudHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorCiAyMDEwLTA4LTAyICBKZXJlbXkgT3Jsb3cgIDxq b3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNwZWN1bGF0aXZlIHJldmVydCBvZiA2NDQy NSBkdWUgdG8gQ2hyb21pdW0gaW5zdGFiaWxpdHkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVy aW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9UZXh0 Q29udHJvbElubmVyRWxlbWVudHMuY3BwCmluZGV4IGIyOTg3NmFmMGViZGNlOGVkNzg0YTc4Yjlh ZGE1MDQwYTg3Y2RmN2IuLjM4NDZmMDM1NTRjNjE5MDI5ZGUwNWNhM2ZmNDg1Y2VmNDFjYmZhMGMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5j cHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcApA QCAtMzcyLDIwICszNzIsMjEgQEAgdm9pZCBJbnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxlbWVudDo6 ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiAgICAgICAgIGlucHV0LT5zZWxlY3Qo KTsKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiAgICAgfQotICAgIC8vIE9u IG1vdXNlIHVwLCBzdGFydCBzcGVlY2ggcmVjb2duaXRpb24uCisgICAgLy8gT24gbW91c2UgdXAs IHJlbGVhc2UgY2FwdHVyZSBjbGVhbmx5LgogICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50 TmFtZXMoKS5tb3VzZXVwRXZlbnQgJiYgZXZlbnQtPmlzTW91c2VFdmVudCgpICYmIHN0YXRpY19j YXN0PE1vdXNlRXZlbnQqPihldmVudCktPmJ1dHRvbigpID09IExlZnRCdXR0b24pIHsKICAgICAg ICAgaWYgKG1fY2FwdHVyaW5nICYmIHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+dmlzaWJsZVRv SGl0VGVzdGluZygpKSB7CiAgICAgICAgICAgICBpZiAoRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQo KS0+ZnJhbWUoKSkgewogICAgICAgICAgICAgICAgIGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+c2V0 Q2FwdHVyaW5nTW91c2VFdmVudHNOb2RlKDApOwogICAgICAgICAgICAgICAgIG1fY2FwdHVyaW5n ID0gZmFsc2U7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAoaG92ZXJlZCgpKSB7Ci0g ICAgICAgICAgICAgICAgc3BlZWNoSW5wdXQoKS0+c3RhcnRSZWNvZ25pdGlvbih0aGlzKTsKLSAg ICAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKLSAgICAgICAgICAgIH0K ICAgICAgICAgfQogICAgIH0KIAorICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMo KS5jbGlja0V2ZW50KSB7CisgICAgICAgIHNwZWVjaElucHV0KCktPnN0YXJ0UmVjb2duaXRpb24o dGhpcyk7CisgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOworICAgIH0KKwogICAg IGlmICghZXZlbnQtPmRlZmF1bHRIYW5kbGVkKCkpCiAgICAgICAgIEhUTUxEaXZFbGVtZW50Ojpk ZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKIH0K