43345 2010-08-02 06:41:52 -0700 Compile fix for Android, add missing guards 2010-08-02 09:05:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 kristianm webkit-unassigned commit-queue steveblock yurys oldest_to_newest 258835 0 kristianm 2010-08-02 06:41:52 -0700 INSPECTOR is not enabled on Android, some code was added to ScriptValue.cpp without guards. 258836 1 63211 kristianm 2010-08-02 06:45:06 -0700 Created attachment 63211 Proposed patch. 258838 2 63212 kristianm 2010-08-02 06:51:31 -0700 Created attachment 63212 Proposed patch (Updated Changelog description). 258846 3 steveblock 2010-08-02 07:06:12 -0700 Why is an equivalent fix not required for JSC. Also, it looks like you need to rebase and update your patch. 258875 4 kristianm 2010-08-02 08:03:23 -0700 The JSC version is actually guarded in the same way. 258880 5 63220 kristianm 2010-08-02 08:16:24 -0700 Created attachment 63220 Updated patch (rebase) 258889 6 63220 steveblock 2010-08-02 08:45:03 -0700 Comment on attachment 63220 Updated patch (rebase) r=me 258908 7 63220 commit-queue 2010-08-02 09:05:28 -0700 Comment on attachment 63220 Updated patch (rebase) Clearing flags on attachment: 63220 Committed r64464: <http://trac.webkit.org/changeset/64464> 258909 8 commit-queue 2010-08-02 09:05:32 -0700 All reviewed patches have been landed. Closing bug. 63211 2010-08-02 06:45:06 -0700 2010-08-02 06:51:31 -0700 Proposed patch. patch.txt text/plain 1293 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDQ1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzAgQEAKKzIwMTAtMDgtMDIgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbXBpbGUgZml4IGZvciBBbmRyb2lkLCBndWFyZCBpbnNwZWN0b3IgY29kZSB3aXRoIEVO QUJMRShJTlNQRUNUT1IpLgorICAgICAgICAKKyAgICAgICAgQ29kZSBpbnRyb2R1Y2VkIGluIHRo aXMgQ0w6CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzYzODkxCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb21waWxlIGZpeC4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1NjcmlwdFZhbHVlLmNwcDoKKwogMjAxMC0wOC0wMiAgSWx5YSBUaWtob25vdnNreSAgPGxv aXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNr eS4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCShyZXZpc2lvbiA2NDQ1MykK KysrIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02Nyw2ICs2Nyw3IEBAIFN0cmluZyBTY3JpcHRWYWx1ZTo6dG9TdHJpbmcoU2NyaXB0U3RhdGUK ICAgICByZXR1cm4gdG9XZWJDb3JlU3RyaW5nKG1fdmFsdWUpOwogfQogCisjaWYgRU5BQkxFKElO U1BFQ1RPUikKIHN0YXRpYyBQYXNzUmVmUHRyPEluc3BlY3RvclZhbHVlPiB2OFRvSW5zcGVjdG9y VmFsdWUodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQogewogICAgIGlmICh2YWx1ZS5Jc0Vt cHR5KCkpIHsKQEAgLTEyMiw1ICsxMjMsNiBAQCBQYXNzUmVmUHRyPEluc3BlY3RvclZhbHVlPiBT Y3JpcHRWYWx1ZTo6CiAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZShzY3JpcHRT dGF0ZS0+Y29udGV4dCgpKTsKICAgICByZXR1cm4gdjhUb0luc3BlY3RvclZhbHVlKG1fdmFsdWUp OwogfQorI2VuZGlmCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 63212 2010-08-02 06:51:31 -0700 2010-08-02 08:16:24 -0700 Proposed patch (Updated Changelog description). patch.txt text/plain 1338 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDQ1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzAgQEAKKzIwMTAtMDgtMDIgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbXBpbGUgZml4IGZvciBBbmRyb2lkLCBndWFyZCBpbnNwZWN0b3IgY29kZSB3aXRoIEVO QUJMRShJTlNQRUNUT1IpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDMzNDUKKyAgICAgICAgQ29kZSBpbnRyb2R1Y2VkIGluIHRoaXMgQ0w6CisgICAg ICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzYzODkxCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBjb21waWxlIGZpeC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFZh bHVlLmNwcDoKKwogMjAxMC0wOC0wMiAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KSW5kZXg6IFdl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCShyZXZpc2lvbiA2NDQ1MykKKysrIFdlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2Nyw3 IEBAIFN0cmluZyBTY3JpcHRWYWx1ZTo6dG9TdHJpbmcoU2NyaXB0U3RhdGUKICAgICByZXR1cm4g dG9XZWJDb3JlU3RyaW5nKG1fdmFsdWUpOwogfQogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKIHN0 YXRpYyBQYXNzUmVmUHRyPEluc3BlY3RvclZhbHVlPiB2OFRvSW5zcGVjdG9yVmFsdWUodjg6Okhh bmRsZTx2ODo6VmFsdWU+IHZhbHVlKQogewogICAgIGlmICh2YWx1ZS5Jc0VtcHR5KCkpIHsKQEAg LTEyMiw1ICsxMjMsNiBAQCBQYXNzUmVmUHRyPEluc3BlY3RvclZhbHVlPiBTY3JpcHRWYWx1ZTo6 CiAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZShzY3JpcHRTdGF0ZS0+Y29udGV4 dCgpKTsKICAgICByZXR1cm4gdjhUb0luc3BlY3RvclZhbHVlKG1fdmFsdWUpOwogfQorI2VuZGlm CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 63220 2010-08-02 08:16:24 -0700 2010-08-02 09:05:28 -0700 Updated patch (rebase) patch.txt text/plain 1367 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDQ2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMDIgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbXBpbGUgZml4IGZvciBBbmRyb2lkLCBndWFyZCBpbnNwZWN0b3IgY29kZSB3aXRoIEVO QUJMRShJTlNQRUNUT1IpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDMzNDUKKyAgICAgICAgQ29kZSBpbnRyb2R1Y2VkIGluIHRoaXMgQ0w6CisgICAg ICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzYzODkxCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBqdXN0IGEgY29tcGlsZSBmaXguCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9T Y3JpcHRWYWx1ZS5jcHA6CisKIDIwMTAtMDgtMDIgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgU3BlY3VsYXRpdmUgcmV2ZXJ0IG9mIDY0NDI1IGR1ZSB0byBD aHJvbWl1bSBpbnN0YWJpbGl0eQpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRWYWx1 ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRWYWx1ZS5jcHAJ KHJldmlzaW9uIDY0NDYyKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRWYWx1ZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTY3LDYgKzY3LDcgQEAgU3RyaW5nIFNjcmlwdFZhbHVlOjp0b1N0 cmluZyhTY3JpcHRTdGF0ZQogICAgIHJldHVybiB0b1dlYkNvcmVTdHJpbmcobV92YWx1ZSk7CiB9 CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogc3RhdGljIFBhc3NSZWZQdHI8SW5zcGVjdG9yVmFs dWU+IHY4VG9JbnNwZWN0b3JWYWx1ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUpCiB7CiAg ICAgaWYgKHZhbHVlLklzRW1wdHkoKSkgewpAQCAtMTIyLDUgKzEyMyw2IEBAIFBhc3NSZWZQdHI8 SW5zcGVjdG9yVmFsdWU+IFNjcmlwdFZhbHVlOjoKICAgICB2ODo6Q29udGV4dDo6U2NvcGUgY29u dGV4dFNjb3BlKHNjcmlwdFN0YXRlLT5jb250ZXh0KCkpOwogICAgIHJldHVybiB2OFRvSW5zcGVj dG9yVmFsdWUobV92YWx1ZSk7CiB9CisjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=