43338 2010-08-02 05:17:10 -0700 Compile fix for android, missing guards in SVGResourcesCycleSolver.cpp 2010-08-02 09:18:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 kristianm webkit-unassigned commit-queue steveblock oldest_to_newest 258793 0 kristianm 2010-08-02 05:17:10 -0700 Android does not have FILTERS enabled and does not compile without this fix. 258799 1 63193 kristianm 2010-08-02 05:22:35 -0700 Created attachment 63193 Proposed patch. 258804 2 63193 steveblock 2010-08-02 05:27:55 -0700 Comment on attachment 63193 Proposed patch. Code looks fine, but this can't be landed with an OOPS in the tests line. Just say this is a build fix only. Also, it would be good to link to the change that added this from the bug. 258818 3 63204 kristianm 2010-08-02 05:51:58 -0700 Created attachment 63204 Proposed patch (Updated Changelog description). 258823 4 63204 steveblock 2010-08-02 05:58:34 -0700 Comment on attachment 63204 Proposed patch (Updated Changelog description). r=me 258919 5 63204 commit-queue 2010-08-02 09:18:06 -0700 Comment on attachment 63204 Proposed patch (Updated Changelog description). Clearing flags on attachment: 63204 Committed r64465: <http://trac.webkit.org/changeset/64465> 258920 6 commit-queue 2010-08-02 09:18:10 -0700 All reviewed patches have been landed. Closing bug. 63193 2010-08-02 05:22:35 -0700 2010-08-02 05:51:58 -0700 Proposed patch. patch.txt text/plain 1296 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDQ1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMDIgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbXBpbGUgZml4IGZvciBBbmRyb2lkLCBhZGRpbmcgZ3VhcmRzIGFyb3VuZCBmaWx0ZXIg c3BlY2lmaWMgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQzMzM4CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAg KiByZW5kZXJpbmcvU1ZHUmVzb3VyY2VzQ3ljbGVTb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U1ZHUmVzb3VyY2VzQ3ljbGVTb2x2ZXI6OmJyZWFrQ3ljbGUpOgorCiAyMDEwLTA4LTAxICBO aWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpcmsgU2NodWx6ZS4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1NWR1Jlc291cmNl c0N5Y2xlU29sdmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9TVkdSZXNv dXJjZXNDeWNsZVNvbHZlci5jcHAJKHJldmlzaW9uIDY0NDUzKQorKysgV2ViQ29yZS9yZW5kZXJp bmcvU1ZHUmVzb3VyY2VzQ3ljbGVTb2x2ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTMsOCAr MTkzLDEwIEBAIHZvaWQgU1ZHUmVzb3VyY2VzQ3ljbGVTb2x2ZXI6OmJyZWFrQ3ljbGUKICAgICAg ICAgICAgIG1fcmVzb3VyY2VzLT5yZXNldFN0cm9rZSgpOwogICAgICAgICBicmVhazsKICAgICBj YXNlIEZpbHRlclJlc291cmNlVHlwZToKKyNpZiBFTkFCTEUoRklMVEVSUykKICAgICAgICAgQVNT RVJUKHJlc291cmNlTGVhZGluZ1RvQ3ljbGUgPT0gbV9yZXNvdXJjZXMtPmZpbHRlcigpKTsKICAg ICAgICAgbV9yZXNvdXJjZXMtPnJlc2V0RmlsdGVyKCk7CisjZW5kaWYKICAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBDbGlwcGVyUmVzb3VyY2VUeXBlOgogICAgICAgICBBU1NFUlQocmVzb3VyY2VM ZWFkaW5nVG9DeWNsZSA9PSBtX3Jlc291cmNlcy0+Y2xpcHBlcigpKTsK 63204 2010-08-02 05:51:58 -0700 2010-08-02 09:18:06 -0700 Proposed patch (Updated Changelog description). patch.txt text/plain 1392 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDQ1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMDIgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbXBpbGUgZml4IGZvciBBbmRyb2lkLCBhZGRpbmcgZ3VhcmRzIGFyb3VuZCBmaWx0ZXIg c3BlY2lmaWMgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQzMzM4CisgICAgICAgIFRoaXMgQ0wgaW50cm9kdWNlZCB0aGUgY29kZToKKyAgICAg ICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNjQxOTYKKworICAgICAgICBDb21w aWxlIGZpeCBvbmx5LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvU1ZHUmVz b3VyY2VzQ3ljbGVTb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUmVzb3VyY2VzQ3lj bGVTb2x2ZXI6OmJyZWFrQ3ljbGUpOgorCiAyMDEwLTA4LTAxICBOaWtvbGFzIFppbW1lcm1hbm4g IDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6 ZS4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1NWR1Jlc291cmNlc0N5Y2xlU29sdmVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9TVkdSZXNvdXJjZXNDeWNsZVNvbHZlci5j cHAJKHJldmlzaW9uIDY0NDUzKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUmVzb3VyY2VzQ3lj bGVTb2x2ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTMsOCArMTkzLDEwIEBAIHZvaWQgU1ZH UmVzb3VyY2VzQ3ljbGVTb2x2ZXI6OmJyZWFrQ3ljbGUKICAgICAgICAgICAgIG1fcmVzb3VyY2Vz LT5yZXNldFN0cm9rZSgpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIEZpbHRlclJlc291cmNl VHlwZToKKyNpZiBFTkFCTEUoRklMVEVSUykKICAgICAgICAgQVNTRVJUKHJlc291cmNlTGVhZGlu Z1RvQ3ljbGUgPT0gbV9yZXNvdXJjZXMtPmZpbHRlcigpKTsKICAgICAgICAgbV9yZXNvdXJjZXMt PnJlc2V0RmlsdGVyKCk7CisjZW5kaWYKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDbGlwcGVy UmVzb3VyY2VUeXBlOgogICAgICAgICBBU1NFUlQocmVzb3VyY2VMZWFkaW5nVG9DeWNsZSA9PSBt X3Jlc291cmNlcy0+Y2xpcHBlcigpKTsK