<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43329</bug_id>
          
          <creation_ts>2010-08-02 01:15:26 -0700</creation_ts>
          <short_desc>WebSocket server should start with SO_REUSEADDR</short_desc>
          <delta_ts>2010-08-02 03:13:53 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fumitoshi Ukai">ukai</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>258745</commentid>
    <comment_count>0</comment_count>
    <who name="Fumitoshi Ukai">ukai</who>
    <bug_when>2010-08-02 01:15:26 -0700</bug_when>
    <thetext>DumpRenderTee buildbots for Windows and Mac sometimes has a failure on websocket_server startup. 
Probably, WebSocket server should start with SO_REUSEADDR.

Example:
Mac build 950: http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/950/steps/layout-test/logs/stdio
100728 03:10:07 websocket_server.py:179  DEBUG Using handler_map_file: /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/LayoutTests/websocket/tests/handler_map.txt
100728 03:10:07 websocket_server.py:194  DEBUG Starting PyWebSocket server on 8880.
100728 03:10:07 websocket_server.py:195  DEBUG cmdline: /System/Library/Frameworks/Python.framework/Versions/2.5/Resources/Python.app/Contents/MacOS/Python /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/pywebsocket/mod_pywebsocket/standalone.py --server-host 127.0.0.1 --port 8880 --document-root /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/LayoutTests --scan-dir /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/LayoutTests/websocket/tests --cgi-paths /websocket/tests --log-file /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKit/chromium/webkit/Release/layout-test-results/pywebsocket.ws.log-28Jul2010-031007-err.txt --websock-handlers-map-file /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/LayoutTests/websocket/tests/handler_map.txt
Traceback (most recent call last):
  File &quot;./WebKitTools/Scripts/new-run-webkit-tests&quot;, line 38, in &lt;module&gt;
    sys.exit(run_webkit_tests.main())
  File &quot;/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py&quot;, line 1677, in main
    return run(port_obj, options, args)
  File &quot;/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py&quot;, line 1441, in run
    num_unexpected_results = test_runner.run(result_summary)
  File &quot;/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py&quot;, line 754, in run
    self._port.start_websocket_server()
  File &quot;/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py&quot;, line 467, in start_websocket_server
    self._websocket_server.start()
  File &quot;/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave2/chromium-mac-release-tests/build/WebKitTools/Scripts/webkitpy/layout_tests/port/websocket_server.py&quot;, line 219, in start
    (self._server_name, self._port))
webkitpy.layout_tests.port.websocket_server.PyWebSocketNotStarted: Failed to start PyWebSocket server on port 8880.

Mac build 949 had no problem on websocket_server shtudown. http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/949/steps/layout-test/logs/stdio
100728 02:37:41 websocket_server.py:244  DEBUG Shutting down PyWebSocket server 73855.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>258747</commentid>
    <comment_count>1</comment_count>
      <attachid>63184</attachid>
    <who name="Fumitoshi Ukai">ukai</who>
    <bug_when>2010-08-02 01:20:59 -0700</bug_when>
    <thetext>Created attachment 63184
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>258748</commentid>
    <comment_count>2</comment_count>
      <attachid>63184</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2010-08-02 01:21:49 -0700</bug_when>
    <thetext>Comment on attachment 63184
Patch

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>258763</commentid>
    <comment_count>3</comment_count>
    <who name="Fumitoshi Ukai">ukai</who>
    <bug_when>2010-08-02 03:13:53 -0700</bug_when>
    <thetext>Committed r64453: &lt;http://trac.webkit.org/changeset/64453&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>63184</attachid>
            <date>2010-08-02 01:20:59 -0700</date>
            <delta_ts>2010-08-02 01:21:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-43329-20100802012057.patch</filename>
            <type>text/plain</type>
            <size>1770</size>
            <attacher name="Fumitoshi Ukai">ukai</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBiZjc4ZWE1MjgzZDlmOTBkZDk4MzI4MDgwNDlkNThjYTM5MWMwOGY3Li4zZTI0NDhh
ZjhkMGM1YWVjNGU1ZmQ4NzdlZjhjOWJlMGNmZThkYjgzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK
KzIwMTAtMDgtMDIgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViU29ja2V0IHNlcnZl
ciBzaG91bGQgc3RhcnQgd2l0aCBTT19SRVVTRUFERFIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMzI5CisKKyAgICAgICAgUHVsbHMgaW4gcHl3ZWJz
b2NrZXQtMC41LjIuCisgICAgICAgIHB5d2Vic29ja2V0LTAuNS4yIGluY2x1ZGVzIGEgc21hbGwg
Zml4IHRvIHN0YXJ0IHNlcnZlciB3aXRoIFNPX1JFVVNFX0FERFIuCisgICAgICAgIGh0dHA6Ly9j
b2RlLmdvb2dsZS5jb20vcC9weXdlYnNvY2tldC9zb3VyY2UvZGV0YWlsP3I9MjczCisKKyAgICAg
ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHk6IEJ1bXAgcHl3ZWJz
b2NrZXQgdmVyc2lvbgorCiAyMDEwLTA4LTAxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQg
YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkgYi9X
ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkKaW5kZXgg
NTAxMDI4ZTk0NmVlMjBkOWE0NzI0ZmMxYmEzYzE5YWZkM2ZkM2YwYi4uNzA0OTcwZGY3ZTZhNWVj
N2I3Mzk5MjgyYzg5ZmUyMDdlNTNmYzVjMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0
cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQpAQCAtOTMsOCArOTMsOCBAQCBpbnN0
YWxsZXIuaW5zdGFsbCh1cmw9Imh0dHA6Ly9kb3dubG9hZHMuc291cmNlZm9yZ2UubmV0L3Byb2pl
Y3QvcHl0aG9uLWlyY2xpYi9weQogCiBweXdlYnNvY2tldF9kaXIgPSBvcy5wYXRoLmpvaW4oYXV0
b2luc3RhbGxlZF9kaXIsICJweXdlYnNvY2tldCIpCiBpbnN0YWxsZXIgPSBBdXRvSW5zdGFsbGVy
KHRhcmdldF9kaXI9cHl3ZWJzb2NrZXRfZGlyKQotaW5zdGFsbGVyLmluc3RhbGwodXJsPSJodHRw
Oi8vcHl3ZWJzb2NrZXQuZ29vZ2xlY29kZS5jb20vZmlsZXMvbW9kX3B5d2Vic29ja2V0LTAuNS4x
LnRhci5neiIsCi0gICAgICAgICAgICAgICAgICB1cmxfc3VicGF0aD0icHl3ZWJzb2NrZXQtMC41
LjEvc3JjL21vZF9weXdlYnNvY2tldCIpCitpbnN0YWxsZXIuaW5zdGFsbCh1cmw9Imh0dHA6Ly9w
eXdlYnNvY2tldC5nb29nbGVjb2RlLmNvbS9maWxlcy9tb2RfcHl3ZWJzb2NrZXQtMC41LjIudGFy
Lmd6IiwKKyAgICAgICAgICAgICAgICAgIHVybF9zdWJwYXRoPSJweXdlYnNvY2tldC0wLjUuMi9z
cmMvbW9kX3B5d2Vic29ja2V0IikKIAogcmVhZG1lX3BhdGggPSBvcy5wYXRoLmpvaW4oYXV0b2lu
c3RhbGxlZF9kaXIsICJSRUFETUUiKQogaWYgbm90IG9zLnBhdGguZXhpc3RzKHJlYWRtZV9wYXRo
KToK
</data>
<flag name="review"
          id="51493"
          type_id="1"
          status="+"
          setter="tkent"
    />
          </attachment>
      

    </bug>

</bugzilla>