43296 2010-07-31 03:42:45 -0700 fast/text/hyphen* tests have different results on Leopard 2010-11-13 20:36:41 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zimmermann webkit-unassigned mitz zimmermann oldest_to_newest 258590 0 zimmermann 2010-07-31 03:42:45 -0700 I'm going to rebaseline these tests to stop the bots from failing. Someone should look into, wheter these results are correct or not. 258591 1 zimmermann 2010-07-31 03:53:21 -0700 Erm, I meant I'm going to skip them. 261194 2 zimmermann 2010-08-06 04:40:00 -0700 Also affects fast/text/hyphens-locale.html. Skipping to turn leopard green again. Dan, can you have a look? 261236 3 mitz 2010-08-06 07:12:11 -0700 Like I mentioned in another bug, I think this is a result of the AppleLanguages user default not being set to (en) on the machine running the tests. 261242 4 zimmermann 2010-08-06 07:21:56 -0700 (In reply to comment #3) > Like I mentioned in another bug, I think this is a result of the AppleLanguages user default not being set to (en) on the machine running the tests. Really? I thought the bots run al in language=en? 261243 5 mitz 2010-08-06 07:23:43 -0700 See bug 41093. 266560 6 mitz 2010-08-18 23:00:09 -0700 Partially addressed in <http://trac.webkit.org/projects/webkit/changeset/65652>. fast/text/hyphens-locale.html tests the default hyphenation locale and therefore still depends on user defaults. This can probably be addressed by changing WebCore to read from the application domain instead of the global domain. 309030 7 73838 mitz 2010-11-13 19:29:04 -0800 Created attachment 73838 Look up the value of the AppleLanguages default through the normal NSUserDefaults search order 309036 8 73838 hyatt 2010-11-13 20:03:07 -0800 Comment on attachment 73838 Look up the value of the AppleLanguages default through the normal NSUserDefaults search order r=me 309040 9 mitz 2010-11-13 20:36:41 -0800 Fixed in <http://trac.webkit.org/projects/webkit/changeset/71977>. 73838 2010-11-13 19:29:04 -0800 2010-11-13 20:03:07 -0800 Look up the value of the AppleLanguages default through the normal NSUserDefaults search order 43296_r1.diff text/plain 2332 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTk3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMTMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmYXN0 L3RleHQvaHlwaGVuKiB0ZXN0cyBoYXZlIGRpZmZlcmVudCByZXN1bHRzIG9uIExlb3BhcmQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjk2CisKKyAg ICAgICAgKiBwbGF0Zm9ybS90ZXh0L21hYy9UZXh0QnJlYWtJdGVyYXRvckludGVybmFsSUNVTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6dG9wTGFuZ3VhZ2VQcmVmZXJlbmNlKTogQ2hhbmdlZCB0 byBsb29rIHVwIHRoZSB2YWx1ZSBvZiB0aGUgQXBwbGVMYW5ndWFnZXMgZGVmYXVsdAorICAgICAg ICB0aHJvdWdoIHRoZSBub3JtYWwgTlNVc2VyRGVmYXVsdHMgc2VhcmNoIG9yZGVyIHJhdGhlciB0 aGFuIHNraXBwaW5nIHRoZSBhcHBsaWNhdGlvbiBkb21haW4uCisgICAgICAgIFRoaXMgbWFrZXMg dGhpcyBmdW5jdGlvbiByZXNwZWN0IER1bXBSZW5kZXJUcmVl4oCZcyBzZXR0aW5nIG9mIHRoZSBk ZWZhdWx0IGluIHRoZSBhcHBsaWNhdGlvbgorICAgICAgICBkb21haW4uCisKIDIwMTAtMTEtMTMg IERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTQ5NgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS90 ZXh0L21hYy9UZXh0QnJlYWtJdGVyYXRvckludGVybmFsSUNVTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVU1h Yy5tbQkocmV2aXNpb24gNzE5NjApCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvbWFjL1RleHRC cmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1VNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTM4LDE3ICsz OCwxNSBAQCBzdGF0aWMgaW5saW5lIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gdGV4CiAKIHN0YXRp YyBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHRvcExhbmd1YWdlUHJlZmVyZW5jZSgpCiB7Ci0gICAg UmV0YWluUHRyPENGUHJvcGVydHlMaXN0UmVmPiBsYW5ndWFnZXMoQWRvcHRDRiwgQ0ZQcmVmZXJl bmNlc0NvcHlWYWx1ZShDRlNUUigiQXBwbGVMYW5ndWFnZXMiKSwKLSAgICAgICAga0NGUHJlZmVy ZW5jZXNBbnlBcHBsaWNhdGlvbiwga0NGUHJlZmVyZW5jZXNDdXJyZW50VXNlciwga0NGUHJlZmVy ZW5jZXNBbnlIb3N0KSk7Ci0gICAgaWYgKCFsYW5ndWFnZXMgfHwgQ0ZHZXRUeXBlSUQobGFuZ3Vh Z2VzLmdldCgpKSAhPSBDRkFycmF5R2V0VHlwZUlEKCkpCisgICAgTlNBcnJheSAqbGFuZ3VhZ2Vz QXJyYXkgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBhcnJheUZvcktl eTpAIkFwcGxlTGFuZ3VhZ2VzIl07CisgICAgaWYgKCFsYW5ndWFnZXNBcnJheSkKICAgICAgICAg cmV0dXJuIDA7Ci0gICAgQ0ZBcnJheVJlZiBsYW5ndWFnZXNBcnJheSA9IHN0YXRpY19jYXN0PENG QXJyYXlSZWY+KGxhbmd1YWdlcy5nZXQoKSk7Ci0gICAgaWYgKENGQXJyYXlHZXRDb3VudChsYW5n dWFnZXNBcnJheSkgPCAxKQorICAgIGlmIChbbGFuZ3VhZ2VzQXJyYXkgY291bnRdIDwgMSkKICAg ICAgICAgcmV0dXJuIDA7Ci0gICAgY29uc3Qgdm9pZCogdmFsdWUgPSBDRkFycmF5R2V0VmFsdWVB dEluZGV4KGxhbmd1YWdlc0FycmF5LCAwKTsKLSAgICBpZiAoIXZhbHVlIHx8IENGR2V0VHlwZUlE KHZhbHVlKSAhPSBDRlN0cmluZ0dldFR5cGVJRCgpKQorICAgIE5TU3RyaW5nICp2YWx1ZSA9IFts YW5ndWFnZXNBcnJheSBvYmplY3RBdEluZGV4OjBdOworICAgIGlmICghW3ZhbHVlIGlzS2luZE9m Q2xhc3M6W05TU3RyaW5nIGNsYXNzXV0pCiAgICAgICAgIHJldHVybiAwOwotICAgIHJldHVybiBz dGF0aWNfY2FzdDxDRlN0cmluZ1JlZj4odmFsdWUpOworICAgIHJldHVybiByZWludGVycHJldF9j YXN0PENGU3RyaW5nUmVmPih2YWx1ZSk7CiB9CiAKIHN0YXRpYyBSZXRhaW5QdHI8Q0ZTdHJpbmdS ZWY+IGNhbm9uaWNhbExhbmd1YWdlSWRlbnRpZmllcihDRlN0cmluZ1JlZiBsb2NhbGUpCg==