43275 2010-07-30 15:41:48 -0700 Make WKArrayRef more usable 2010-07-30 15:49:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 258427 0 sam 2010-07-30 15:41:48 -0700 In order to make WKArrayRef usable, we need to be able to create them. 258428 1 63112 sam 2010-07-30 15:42:54 -0700 Created attachment 63112 Patch 258432 2 sam 2010-07-30 15:49:43 -0700 Landed in 64382. 63112 2010-07-30 15:42:54 -0700 2010-07-30 15:43:58 -0700 Patch patcher.diff text/plain 4953 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDM4MSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDctMzAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjc1CisgICAgICAg IE1ha2UgV0tBcnJheVJlZiBtb3JlIHVzYWJsZS4KKworICAgICAgICAtIEFkZCBDcmVhdGUgZnVu Y3Rpb25zLgorICAgICAgICAtIE1ha2UgV0tBcnJheUdldEl0ZW1BdEluZGV4IHJldHVybiBhIFdL VHlwZVJlZi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0FycmF5LmNwcDoKKyAgICAg ICAgKFdLQXJyYXlDcmVhdGUpOgorICAgICAgICAoV0tBcnJheUNyZWF0ZUFkb3B0aW5nVmFsdWVz KToKKyAgICAgICAgKFdLQXJyYXlHZXRJdGVtQXRJbmRleCk6CisgICAgICAgICogVUlQcm9jZXNz L0FQSS9DL1dLQXJyYXkuaDoKKwogMjAxMC0wNy0zMCAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tBcnJheS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0MvV0tBcnJheS5jcHAJKHJldmlzaW9uIDY0Mzc5KQorKysgV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0MvV0tBcnJheS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDE5IEBA IFdLVHlwZUlEIFdLQXJyYXlHZXRUeXBlSUQoKQogICAgIHJldHVybiB0b1JlZihBUElPYmplY3Q6 OlR5cGVBcnJheSk7CiB9CiAKLWNvbnN0IHZvaWQqIFdLQXJyYXlHZXRJdGVtQXRJbmRleChXS0Fy cmF5UmVmIGFycmF5UmVmLCBzaXplX3QgaW5kZXgpCitXS0FycmF5UmVmIFdLQXJyYXlDcmVhdGUo V0tUeXBlUmVmKiB2YWx1ZXMsIHNpemVfdCBudW1iZXJPZlZhbHVlcykKK3sKKyAgICBSZWZQdHI8 SW1tdXRhYmxlQXJyYXk+IGFycmF5ID0gSW1tdXRhYmxlQXJyYXk6OmNyZWF0ZShyZWludGVycHJl dF9jYXN0PEFQSU9iamVjdCoqPih2YWx1ZXMpLCBudW1iZXJPZlZhbHVlcyk7CisgICAgcmV0dXJu IHRvUmVmKGFycmF5LnJlbGVhc2UoKS5yZWxlYXNlUmVmKCkpOworfQorCitXS0FycmF5UmVmIFdL QXJyYXlDcmVhdGVBZG9wdGluZ1ZhbHVlcyhXS1R5cGVSZWYqIHZhbHVlcywgc2l6ZV90IG51bWJl ck9mVmFsdWVzKQoreworICAgIFJlZlB0cjxJbW11dGFibGVBcnJheT4gYXJyYXkgPSBJbW11dGFi bGVBcnJheTo6YWRvcHQocmVpbnRlcnByZXRfY2FzdDxBUElPYmplY3QqKj4odmFsdWVzKSwgbnVt YmVyT2ZWYWx1ZXMpOworICAgIHJldHVybiB0b1JlZihhcnJheS5yZWxlYXNlKCkucmVsZWFzZVJl ZigpKTsKK30KKworV0tUeXBlUmVmIFdLQXJyYXlHZXRJdGVtQXRJbmRleChXS0FycmF5UmVmIGFy cmF5UmVmLCBzaXplX3QgaW5kZXgpCiB7CiAgICAgcmV0dXJuIHRvV0soYXJyYXlSZWYpLT5hdChp bmRleCk7CiB9CkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0FycmF5LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tBcnJheS5oCShyZXZpc2lvbiA2NDM3 OSkKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQXJyYXkuaAkod29ya2luZyBjb3B5KQpA QCAtMzQsNyArMzQsMTAgQEAgZXh0ZXJuICJDIiB7CiAKIFdLX0VYUE9SVCBXS1R5cGVJRCBXS0Fy cmF5R2V0VHlwZUlEKCk7CiAKLVdLX0VYUE9SVCBjb25zdCB2b2lkKiBXS0FycmF5R2V0SXRlbUF0 SW5kZXgoV0tBcnJheVJlZiBhcnJheSwgc2l6ZV90IGluZGV4KTsKK1dLX0VYUE9SVCBXS0FycmF5 UmVmIFdLQXJyYXlDcmVhdGUoV0tUeXBlUmVmKiB2YWx1ZXMsIHNpemVfdCBudW1iZXJPZlZhbHVl cyk7CitXS19FWFBPUlQgV0tBcnJheVJlZiBXS0FycmF5Q3JlYXRlQWRvcHRpbmdWYWx1ZXMoV0tU eXBlUmVmKiB2YWx1ZXMsIHNpemVfdCBudW1iZXJPZlZhbHVlcyk7CisKK1dLX0VYUE9SVCBXS1R5 cGVSZWYgV0tBcnJheUdldEl0ZW1BdEluZGV4KFdLQXJyYXlSZWYgYXJyYXksIHNpemVfdCBpbmRl eCk7CiBXS19FWFBPUlQgc2l6ZV90IFdLQXJyYXlHZXRTaXplKFdLQXJyYXlSZWYgYXJyYXkpOwog CiBXS19FWFBPUlQgV0tBcnJheVJlZiBXS0FycmF5UmV0YWluKFdLQXJyYXlSZWYgYXJyYXkpOwpJ bmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0No YW5nZUxvZwkocmV2aXNpb24gNjQzODEpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0zMCAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhdGNoIGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMy NzUKKyAgICAgICAgTWFrZSBXS0FycmF5UmVmIG1vcmUgdXNhYmxlLgorCisgICAgICAgIFJlbW92 ZSBub3cgdW5uZWNlc3NhcnkgY29uc3RfY2FzdHMuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVu bmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHA6CisgICAgICAgIChXVFI6 OmR1bXBEZXNjZW5kYW50RnJhbWVTY3JvbGxQb3NpdGlvbnMpOgorICAgICAgICAoV1RSOjpkdW1w RGVzY2VuZGFudEZyYW1lc1RleHQpOgorCiAyMDEwLTA3LTMwICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDog V2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRs ZVBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcAkocmV2aXNpb24gNjQzNjQpCisrKyBX ZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxl UGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4NSw4ICsyODUsNyBAQCBzdGF0aWMgdm9pZCBk dW1wRGVzY2VuZGFudEZyYW1lU2Nyb2xsUG9zCiAgICAgV0tSZXRhaW5QdHI8V0tBcnJheVJlZj4g Y2hpbGRGcmFtZXMoQWRvcHRXSywgV0tCdW5kbGVGcmFtZUNvcHlDaGlsZEZyYW1lcyhmcmFtZSkp OwogICAgIHNpemVfdCBzaXplID0gV0tBcnJheUdldFNpemUoY2hpbGRGcmFtZXMuZ2V0KCkpOwog ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgc2l6ZTsgKytpKSB7Ci0gICAgICAgIC8vIEZJWE1F OiBJIGRvbid0IGxpa2UgdGhhdCB3ZSBoYXZlIHRvIGNvbnN0X2Nhc3QgaGVyZS4gQ2FuIHdlIGNo YW5nZSBXS0FycmF5PwotICAgICAgICBXS0J1bmRsZUZyYW1lUmVmIHN1YmZyYW1lID0gc3RhdGlj X2Nhc3Q8V0tCdW5kbGVGcmFtZVJlZj4oY29uc3RfY2FzdDx2b2lkKj4oV0tBcnJheUdldEl0ZW1B dEluZGV4KGNoaWxkRnJhbWVzLmdldCgpLCBpKSkpOworICAgICAgICBXS0J1bmRsZUZyYW1lUmVm IHN1YmZyYW1lID0gc3RhdGljX2Nhc3Q8V0tCdW5kbGVGcmFtZVJlZj4oV0tBcnJheUdldEl0ZW1B dEluZGV4KGNoaWxkRnJhbWVzLmdldCgpLCBpKSk7CiAgICAgICAgIGR1bXBGcmFtZVNjcm9sbFBv c2l0aW9uKHN1YmZyYW1lLCBTaG91bGRJbmNsdWRlRnJhbWVOYW1lKTsKICAgICAgICAgZHVtcERl c2NlbmRhbnRGcmFtZVNjcm9sbFBvc2l0aW9ucyhzdWJmcmFtZSk7CiAgICAgfQpAQCAtMzEyLDgg KzMxMSw3IEBAIHN0YXRpYyB2b2lkIGR1bXBEZXNjZW5kYW50RnJhbWVzVGV4dChXS0IKICAgICBX S1JldGFpblB0cjxXS0FycmF5UmVmPiBjaGlsZEZyYW1lcyhBZG9wdFdLLCBXS0J1bmRsZUZyYW1l Q29weUNoaWxkRnJhbWVzKGZyYW1lKSk7CiAgICAgc2l6ZV90IHNpemUgPSBXS0FycmF5R2V0U2l6 ZShjaGlsZEZyYW1lcy5nZXQoKSk7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplOyAr K2kpIHsKLSAgICAgICAgLy8gRklYTUU6IEkgZG9uJ3QgbGlrZSB0aGF0IHdlIGhhdmUgdG8gY29u c3RfY2FzdCBoZXJlLiBDYW4gd2UgY2hhbmdlIFdLQXJyYXk/Ci0gICAgICAgIFdLQnVuZGxlRnJh bWVSZWYgc3ViZnJhbWUgPSBzdGF0aWNfY2FzdDxXS0J1bmRsZUZyYW1lUmVmPihjb25zdF9jYXN0 PHZvaWQqPihXS0FycmF5R2V0SXRlbUF0SW5kZXgoY2hpbGRGcmFtZXMuZ2V0KCksIGkpKSk7Cisg ICAgICAgIFdLQnVuZGxlRnJhbWVSZWYgc3ViZnJhbWUgPSBzdGF0aWNfY2FzdDxXS0J1bmRsZUZy YW1lUmVmPihXS0FycmF5R2V0SXRlbUF0SW5kZXgoY2hpbGRGcmFtZXMuZ2V0KCksIGkpKTsKICAg ICAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHN1YmZyYW1lTmFtZShBZG9wdFdLLCBXS0J1 bmRsZUZyYW1lQ29weU5hbWUoc3ViZnJhbWUpKTsKICAgICAgICAgSW5qZWN0ZWRCdW5kbGU6OnNo YXJlZCgpLm9zKCkgPDwgIlxuLS0tLS0tLS1cbkZyYW1lOiAnIiA8PCBzdWJmcmFtZU5hbWUgPDwg Iidcbi0tLS0tLS0tXG4iOwogICAgICAgICBkdW1wRnJhbWVUZXh0KHN1YmZyYW1lKTsK