43267 2010-07-30 11:54:06 -0700 SVGScriptElement doesn't execute when ENABLE(XHTMLMP) is on 2010-07-30 14:15:32 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 yong.li.webkit yong.li.webkit commit-queue staikos zimmermann oldest_to_newest 258318 0 yong.li.webkit 2010-07-30 11:54:06 -0700 When ENABLE(XHTMLMP) is on, the code patch is triggered. #if ENABLE(XHTMLMP) if (!scriptElement->shouldExecuteAsJavaScript()) m_doc->setShouldProcessNoscriptElement(true); else #endif but SVGScriptElement::shouldExecuteAsJavaScript() just return false. It should return m_data.shouldExecuteAsJavaScript() as HTMLScriptElement does. 258336 1 63093 yong.li.webkit 2010-07-30 12:40:46 -0700 Created attachment 63093 the patch 258377 2 63093 commit-queue 2010-07-30 14:15:26 -0700 Comment on attachment 63093 the patch Clearing flags on attachment: 63093 Committed r64373: <http://trac.webkit.org/changeset/64373> 258378 3 commit-queue 2010-07-30 14:15:32 -0700 All reviewed patches have been landed. Closing bug. 63093 2010-07-30 12:40:46 -0700 2010-07-30 14:15:26 -0700 the patch 43267.patch text/plain 1708 yong.li.webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTQ3NWFiNy4uNTBmNTI1OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0zMCAgWW9uZyBMaSAgPHlv bGlAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbXBsZW1lbnQgU1ZHU2NyaXB0RWxlbWVudDo6c2hvdWxkRXhlY3V0ZUFzSmF2YVNjcmlw dCgpIG90aGVyd2lzZQorICAgICAgICBTVkdTY3JpcHRFbGVtZW50IGNhbm5vdCBydW4gd2hlbiBY SFRNTE1QIGlzIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MzI2NworCisgICAgICAgIE5vIHRlc3QgbmVlZGVkLCBiZWNhdXNlIGl0IGZh aWxzIGFsbCBTVkcgPHNjcmlwdD4gdGVzdHMgd2hlbiBYSFRNTE1QIGlzIG9uLgorCisgICAgICAg ICogc3ZnL1NWR1NjcmlwdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHU2NyaXB0 RWxlbWVudDo6c2hvdWxkRXhlY3V0ZUFzSmF2YVNjcmlwdCk6CisgICAgICAgICogc3ZnL1NWR1Nj cmlwdEVsZW1lbnQuaDoKKwogMjAxMC0wNy0yMyAgcnl1YW4gY2hvaSAgPHJ5dWFuLmNob2lAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvc3ZnL1NWR1NjcmlwdEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9zdmcvU1ZHU2Ny aXB0RWxlbWVudC5jcHAKaW5kZXggYWJlNzdhOS4uZWE0YWMxZiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9zdmcvU1ZHU2NyaXB0RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9zdmcvU1ZHU2NyaXB0RWxl bWVudC5jcHAKQEAgLTI0Miw2ICsyNDIsMTEgQEAgdm9pZCBTVkdTY3JpcHRFbGVtZW50OjpkaXNw YXRjaEVycm9yRXZlbnQoKQogICAgIGRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0ZShldmVudE5h bWVzKCkuZXJyb3JFdmVudCwgdHJ1ZSwgZmFsc2UpKTsKIH0KIAorYm9vbCBTVkdTY3JpcHRFbGVt ZW50OjpzaG91bGRFeGVjdXRlQXNKYXZhU2NyaXB0KCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9k YXRhLnNob3VsZEV4ZWN1dGVBc0phdmFTY3JpcHQoKTsKK30KKwogfQogCiAjZW5kaWYgLy8gRU5B QkxFKFNWRykKZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL1NWR1NjcmlwdEVsZW1lbnQuaCBiL1dl YkNvcmUvc3ZnL1NWR1NjcmlwdEVsZW1lbnQuaAppbmRleCA3NzBkYzg5Li4yZDljYWU4IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3N2Zy9TVkdTY3JpcHRFbGVtZW50LmgKKysrIGIvV2ViQ29yZS9zdmcv U1ZHU2NyaXB0RWxlbWVudC5oCkBAIC01Niw3ICs1Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogICAgICAgICB2aXJ0dWFsIHZvaWQgYWRkU3VicmVzb3VyY2VBdHRyaWJ1dGVVUkxzKExpc3RI YXNoU2V0PEtVUkw+JikgY29uc3Q7CiAKLSAgICAgICAgdmlydHVhbCBib29sIHNob3VsZEV4ZWN1 dGVBc0phdmFTY3JpcHQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorICAgICAgICB2aXJ0dWFs IGJvb2wgc2hvdWxkRXhlY3V0ZUFzSmF2YVNjcmlwdCgpIGNvbnN0OwogCiAgICAgcHJvdGVjdGVk OgogICAgICAgICB2aXJ0dWFsIGJvb2wgaGF2ZUxvYWRlZFJlcXVpcmVkUmVzb3VyY2VzKCk7Cg==