43262 2010-07-30 10:11:25 -0700 style errors in Navigator.h 2010-07-30 14:14:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 258255 0 cfleizach 2010-07-30 10:11:25 -0700 I want to modify Navigator.h but there are style errors. i'd like to resolve the style errors so my commit won't have them the style error is bad class identation 258261 1 63073 cfleizach 2010-07-30 10:16:22 -0700 Created attachment 63073 Patch 258331 2 63073 darin 2010-07-30 12:31:08 -0700 Comment on attachment 63073 Patch Seems fine to chagne the indentation. > + ~Navigator(); This should be explicitly marked virtual. We prefer to do that explicitly even when we derive from a class where the destructor is already virtual. 258376 3 cfleizach 2010-07-30 14:14:25 -0700 http://trac.webkit.org/changeset/64371 63073 2010-07-30 10:16:22 -0700 2010-07-30 12:31:08 -0700 Patch bug-43262-20100730101621.patch text/plain 3243 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDM1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMzAgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTdHlsZSBlcnJvcnMgaW4gTmF2aWdhdG9yLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjYyCisKKyAgICAgICAgRml4aW5nIHN0eWxlIGNoYW5n ZXMuIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2UvTmF2aWdhdG9yLmg6CisgICAgICAg IChXZWJDb3JlOjpOYXZpZ2F0b3I6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpOYXZpZ2F0 b3I6OmZyYW1lKToKKyAgICAgICAgKFdlYkNvcmU6Ok5hdmlnYXRvcjo6b3B0aW9uYWxHZW9sb2Nh dGlvbik6CisKIDIwMTAtMDctMjkgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxvY2suCkluZGV4OiBXZWJDb3JlL3BhZ2Uv TmF2aWdhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL05hdmlnYXRvci5oCShyZXZp c2lvbiA2NDM1OCkKKysrIFdlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuaAkod29ya2luZyBjb3B5KQpA QCAtMjcsNDYgKzI3LDQ2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotICAgIGNsYXNzIERP TU1pbWVUeXBlQXJyYXk7Ci0gICAgY2xhc3MgRE9NUGx1Z2luQXJyYXk7Ci0gICAgY2xhc3MgRnJh bWU7Ci0gICAgY2xhc3MgR2VvbG9jYXRpb247Ci0gICAgY2xhc3MgUGx1Z2luRGF0YTsKLSAgICBj bGFzcyBTdHJpbmc7Ci0KLSAgICBjbGFzcyBOYXZpZ2F0b3IgOiBwdWJsaWMgTmF2aWdhdG9yQmFz ZSwgcHVibGljIFJlZkNvdW50ZWQ8TmF2aWdhdG9yPiB7Ci0gICAgcHVibGljOgotICAgICAgICBz dGF0aWMgUGFzc1JlZlB0cjxOYXZpZ2F0b3I+IGNyZWF0ZShGcmFtZSogZnJhbWUpIHsgcmV0dXJu IGFkb3B0UmVmKG5ldyBOYXZpZ2F0b3IoZnJhbWUpKTsgfQotICAgICAgICB+TmF2aWdhdG9yKCk7 Ci0KLSAgICAgICAgdm9pZCBkaXNjb25uZWN0RnJhbWUoKTsKLSAgICAgICAgRnJhbWUqIGZyYW1l KCkgY29uc3QgeyByZXR1cm4gbV9mcmFtZTsgfQotCi0gICAgICAgIFN0cmluZyBhcHBWZXJzaW9u KCkgY29uc3Q7Ci0gICAgICAgIFN0cmluZyBsYW5ndWFnZSgpIGNvbnN0OwotICAgICAgICBET01Q bHVnaW5BcnJheSogcGx1Z2lucygpIGNvbnN0OwotICAgICAgICBET01NaW1lVHlwZUFycmF5KiBt aW1lVHlwZXMoKSBjb25zdDsKLSAgICAgICAgYm9vbCBjb29raWVFbmFibGVkKCkgY29uc3Q7Ci0g ICAgICAgIGJvb2wgamF2YUVuYWJsZWQoKSBjb25zdDsKLQotICAgICAgICB2aXJ0dWFsIFN0cmlu ZyB1c2VyQWdlbnQoKSBjb25zdDsKLQotICAgICAgICBHZW9sb2NhdGlvbiogZ2VvbG9jYXRpb24o KSBjb25zdDsKLSAgICAgICAgLy8gVGhpcyBpcyB1c2VkIGZvciBHQyBtYXJraW5nLgotICAgICAg ICBHZW9sb2NhdGlvbiogb3B0aW9uYWxHZW9sb2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fZ2Vv bG9jYXRpb24uZ2V0KCk7IH0KK2NsYXNzIERPTU1pbWVUeXBlQXJyYXk7CitjbGFzcyBET01QbHVn aW5BcnJheTsKK2NsYXNzIEZyYW1lOworY2xhc3MgR2VvbG9jYXRpb247CitjbGFzcyBQbHVnaW5E YXRhOworY2xhc3MgU3RyaW5nOworCitjbGFzcyBOYXZpZ2F0b3IgOiBwdWJsaWMgTmF2aWdhdG9y QmFzZSwgcHVibGljIFJlZkNvdW50ZWQ8TmF2aWdhdG9yPiB7CitwdWJsaWM6CisgICAgc3RhdGlj IFBhc3NSZWZQdHI8TmF2aWdhdG9yPiBjcmVhdGUoRnJhbWUqIGZyYW1lKSB7IHJldHVybiBhZG9w dFJlZihuZXcgTmF2aWdhdG9yKGZyYW1lKSk7IH0KKyAgICB+TmF2aWdhdG9yKCk7CisKKyAgICB2 b2lkIGRpc2Nvbm5lY3RGcmFtZSgpOworICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0IHsgcmV0dXJu IG1fZnJhbWU7IH0KKworICAgIFN0cmluZyBhcHBWZXJzaW9uKCkgY29uc3Q7CisgICAgU3RyaW5n IGxhbmd1YWdlKCkgY29uc3Q7CisgICAgRE9NUGx1Z2luQXJyYXkqIHBsdWdpbnMoKSBjb25zdDsK KyAgICBET01NaW1lVHlwZUFycmF5KiBtaW1lVHlwZXMoKSBjb25zdDsKKyAgICBib29sIGNvb2tp ZUVuYWJsZWQoKSBjb25zdDsKKyAgICBib29sIGphdmFFbmFibGVkKCkgY29uc3Q7CisKKyAgICB2 aXJ0dWFsIFN0cmluZyB1c2VyQWdlbnQoKSBjb25zdDsKKworICAgIEdlb2xvY2F0aW9uKiBnZW9s b2NhdGlvbigpIGNvbnN0OworICAgIC8vIFRoaXMgaXMgdXNlZCBmb3IgR0MgbWFya2luZy4KKyAg ICBHZW9sb2NhdGlvbiogb3B0aW9uYWxHZW9sb2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fZ2Vv bG9jYXRpb24uZ2V0KCk7IH0KIAogI2lmIEVOQUJMRShET01fU1RPUkFHRSkKLSAgICAgICAgLy8g UmVsaW5xdWlzaGVzIHRoZSBzdG9yYWdlIGxvY2ssIGlmIG9uZSBleGlzdHMuCi0gICAgICAgIHZv aWQgZ2V0U3RvcmFnZVVwZGF0ZXMoKTsKKyAgICAvLyBSZWxpbnF1aXNoZXMgdGhlIHN0b3JhZ2Ug bG9jaywgaWYgb25lIGV4aXN0cy4KKyAgICB2b2lkIGdldFN0b3JhZ2VVcGRhdGVzKCk7CiAjZW5k aWYKIAotICAgIHByaXZhdGU6Ci0gICAgICAgIE5hdmlnYXRvcihGcmFtZSopOwotICAgICAgICBG cmFtZSogbV9mcmFtZTsKLSAgICAgICAgbXV0YWJsZSBSZWZQdHI8RE9NUGx1Z2luQXJyYXk+IG1f cGx1Z2luczsKLSAgICAgICAgbXV0YWJsZSBSZWZQdHI8RE9NTWltZVR5cGVBcnJheT4gbV9taW1l VHlwZXM7Ci0gICAgICAgIG11dGFibGUgUmVmUHRyPEdlb2xvY2F0aW9uPiBtX2dlb2xvY2F0aW9u OwotICAgIH07Citwcml2YXRlOgorICAgIE5hdmlnYXRvcihGcmFtZSopOworICAgIEZyYW1lKiBt X2ZyYW1lOworICAgIG11dGFibGUgUmVmUHRyPERPTVBsdWdpbkFycmF5PiBtX3BsdWdpbnM7Cisg ICAgbXV0YWJsZSBSZWZQdHI8RE9NTWltZVR5cGVBcnJheT4gbV9taW1lVHlwZXM7CisgICAgbXV0 YWJsZSBSZWZQdHI8R2VvbG9jYXRpb24+IG1fZ2VvbG9jYXRpb247Cit9OwogCiB9CiAK