43246 2010-07-30 06:24:58 -0700 Web Inspector: incorrect absolute protocol-less URLs in tooltips of links in the ElementsTreeOutline 2010-08-03 10:54:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 258173 0 apavlov 2010-07-30 06:24:58 -0700 In a page loaded from http://example.com, <a href="//example.org/foo">...</a> is given the following tooltip in the ElementsTreeOutline: "http://example.com//example.org/foo", which should be "http://example.org/foo" instead. 259432 1 63333 apavlov 2010-08-03 06:57:17 -0700 Created attachment 63333 [PATCH] Suggested solution 259513 2 joepeck 2010-08-03 09:51:04 -0700 Hmm, I didn't even know about this style of link. Is it specified somewhere? I took a look at the HTML5 spec and nothing popped out at me. I'd appreciate a link if have one. Also, I notice a number of calls to completeURL (in frames) just use the documentURL. Does that respect a <base> element if there is one? Meaning, does the documentURL property update if there is a <base href="..."> or xml:base attribute, or must those be determined dynamically? 259523 3 apavlov 2010-08-03 10:15:15 -0700 (In reply to comment #2) > Hmm, I didn't even know about this style of link. Is it specified somewhere? > I took a look at the HTML5 spec and nothing popped out at me. I'd appreciate > a link if have one. Please see http://www.faqs.org/rfcs/rfc1808.html (2.4.3) for the reference. > Also, I notice a number of calls to completeURL (in frames) just use the > documentURL. Does that respect a <base> element if there is one? Meaning, > does the documentURL property update if there is a <base href="..."> or > xml:base attribute, or must those be determined dynamically? I'm not entitled to answer this question :) The only thing I've done in this direction was the introduction of the documentURL property which is determined in InspectorDOMAgent as document->url(). I do not know whether the parser takes <base href...> into account when computing document->url() but anyway, I believe it is the right point where this should be done. 259535 4 63333 joepeck 2010-08-03 10:39:05 -0700 Comment on attachment 63333 [PATCH] Suggested solution > (use the baseURL protocol). NIT: might be better if it was "(use the baseURL's protocol).". > Please see http://www.faqs.org/rfcs/rfc1808.html (2.4.3) for the reference. Thanks, this is great =). I see this format under Relative URLs. > > Also, I notice a number of calls to completeURL (in frames) just use the > > documentURL. Does that respect a <base> element if there is one? Meaning, > > does the documentURL property update if there is a <base href="..."> or > > xml:base attribute, or must those be determined dynamically? > > I'm not entitled to answer this question :) I think "entitled" is the wrong word. But I understand what you mean =). > The only thing I've done in this direction was the introduction of the documentURL property > which is determined in InspectorDOMAgent as document->url(). I do not know whether the > parser takes <base href...> into account when computing document->url() but anyway, I > believe it is the right point where this should be done. I just whipped up a quick test, and the Inspector's tooltips do not work correctly with <base>. I just filed the following: Web Inspector: Relative URL Link Tooltips do not respect <base> https://bugs.webkit.org/show_bug.cgi?id=43434 Let me know if its something you are interested in working on. The thing is so few people use <base> that it might not be a good use of time. Still, it is a bug. r=me for this fix. Thanks! 259547 5 apavlov 2010-08-03 10:54:45 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r64565 63333 2010-08-03 06:57:17 -0700 2010-08-03 10:39:05 -0700 [PATCH] Suggested solution tooltip.patch text/plain 1394 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDVlMjJlYS4uYzg3OGMxMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0wMyAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGluY29ycmVjdCBhYnNvbHV0ZSBw cm90b2NvbC1sZXNzIFVSTHMgaW4gdG9vbHRpcHMgb2YgbGlua3MgaW4gdGhlIEVsZW1lbnRzVHJl ZU91dGxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQzMjQ2CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5jb21wbGV0ZVVSTCk6CisKIDIwMTAtMDctMzAgIEFuZHJlaSBQ b3Blc2N1ICA8YW5kcmVpcEBkaGNwLTE3Mi0xNi0xNC0xMi5sb24uY29ycC5nb29nbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IDRiYjMwYzcuLjAzZGZlYjcgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtMTc4Nyw2ICsxNzg3LDkgQEAgV2ViSW5z cGVjdG9yLmNvbXBsZXRlVVJMID0gZnVuY3Rpb24oYmFzZVVSTCwgaHJlZikKICAgICAgICAgaWYg KHBhdGguY2hhckF0KDApICE9PSAiLyIpIHsKICAgICAgICAgICAgIHZhciBiYXNlUGF0aCA9IG1h dGNoWzRdIHx8ICIvIjsKICAgICAgICAgICAgIHBhdGggPSBiYXNlUGF0aC5zdWJzdHJpbmcoMCwg YmFzZVBhdGgubGFzdEluZGV4T2YoIi8iKSkgKyAiLyIgKyBwYXRoOworICAgICAgICB9IGVsc2Ug aWYgKHBhdGgubGVuZ3RoID4gMSAmJiBwYXRoLmNoYXJBdCgxKSA9PT0gIi8iKSB7CisgICAgICAg ICAgICAvLyBocmVmIHN0YXJ0cyB3aXRoICIvLyIgd2hpY2ggaXMgYSBmdWxsIFVSTCB3aXRoIHRo ZSBwcm90b2NvbCBkcm9wcGVkICh1c2UgdGhlIGJhc2VVUkwgcHJvdG9jb2wpLgorICAgICAgICAg ICAgcmV0dXJuIG1hdGNoWzFdICsgIjoiICsgcGF0aDsKICAgICAgICAgfQogICAgICAgICByZXR1 cm4gbWF0Y2hbMV0gKyAiOi8vIiArIG1hdGNoWzJdICsgKG1hdGNoWzNdID8gKCI6IiArIG1hdGNo WzNdKSA6ICIiKSArIHBhdGg7CiAgICAgfQo=