43242 2010-07-30 05:45:01 -0700 [Qt] Do not link to SharedBufferCF.cpp 2010-08-02 07:48:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 markus markus commit-queue hausmann oldest_to_newest 258158 0 markus 2010-07-30 05:45:01 -0700 [Qt] Do not link to SharedBufferCF.cpp 258163 1 markus 2010-07-30 05:53:58 -0700 Patch coming soon.. 258216 2 63064 markus 2010-07-30 08:59:59 -0700 Created attachment 63064 Patch 258218 3 63064 commit-queue 2010-07-30 09:02:02 -0700 Comment on attachment 63064 Patch Rejecting patch 63064 from commit-queue. markus.goetz@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 258219 4 63064 vestbo 2010-07-30 09:06:00 -0700 Comment on attachment 63064 Patch Let's look at this on monday. > + No new tests. (OOPS!) Also, this oops has to go 258220 5 63064 markus 2010-07-30 09:07:57 -0700 Comment on attachment 63064 Patch have to speak with Tor Arne first.. 258839 6 63213 markus 2010-08-02 06:57:15 -0700 Created attachment 63213 Patch 258841 7 63213 kenneth 2010-08-02 07:01:39 -0700 Comment on attachment 63213 Patch LGTM 258843 8 63213 kenneth 2010-08-02 07:02:20 -0700 Comment on attachment 63213 Patch Oh, sorry I see that you want to talk to Tor Arne first. Removing cq+ 258857 9 markus 2010-08-02 07:31:19 -0700 Thanks kenneth. The TorArne thing was about the previous patch, the current one should be fine. So cq+ is great with me. 258869 10 63213 commit-queue 2010-08-02 07:48:21 -0700 Comment on attachment 63213 Patch Clearing flags on attachment: 63213 Committed r64461: <http://trac.webkit.org/changeset/64461> 258870 11 commit-queue 2010-08-02 07:48:26 -0700 All reviewed patches have been landed. Closing bug. 63064 2010-07-30 08:59:59 -0700 2010-08-02 06:57:10 -0700 Patch bug-43242-20100730175954.patch text/plain 1129 markus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YThjZWFlOWYzMzMzYjM5MWE1ZTlkYTBjNTg1MjdlY2RlOTU1ZmI1ZS4uZTg2MDM2ZmQxYmJkODkx MmMyYjFmZmVkNGNhMTMxMDllZjQwZDczMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0zMCAgTWFy a3VzIEdvZXR6ICA8TWFya3VzLkdvZXR6QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERvIG5vdCBsaW5rIHRvIFNoYXJlZEJ1 ZmZlckNGLmNwcAorICAgICAgICBUaGUgUXQgcG9ydCBkb2VzIG5vdCBuZWVkIHRoaXMgZmlsZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjQyCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBXZWJDb3JlLnBybzoK KwogMjAxMC0wNy0yOSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3Jl L1dlYkNvcmUucHJvIGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCBiN2YxNTJlMmUzMzk4N2Y0 MzU0MTBjOWZhZDJiZWZhNDRjYWYwNTc4Li4wNDY1Mjc1N2E5ZGVlYTZlNzNmMDhmZTFlMjVlMGM5 OTRmMjQ5YTNjIDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNvcmUv V2ViQ29yZS5wcm8KQEAgLTIyNjgsOCArMjI2OCw3IEBAIG1hZW1vNSB7CiAgICAgbWFjIHsKICAg ICAgICAgU09VUkNFUyArPSBcCiAgICAgICAgICAgICBwbGF0Zm9ybS90ZXh0L2NmL1N0cmluZ0NG LmNwcCBcCi0gICAgICAgICAgICBwbGF0Zm9ybS90ZXh0L2NmL1N0cmluZ0ltcGxDRi5jcHAgXAot ICAgICAgICAgICAgcGxhdGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwCisgICAgICAgICAgICBw bGF0Zm9ybS90ZXh0L2NmL1N0cmluZ0ltcGxDRi5jcHAKICAgICAgICAgTElCU19QUklWQVRFICs9 IC1mcmFtZXdvcmsgQ2FyYm9uIC1mcmFtZXdvcmsgQXBwS2l0CiAgICAgfQogCg== 63213 2010-08-02 06:57:15 -0700 2010-08-02 07:48:21 -0700 Patch bug-43242-20100802155714.patch text/plain 1798 markus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YThjZWFlOWYzMzMzYjM5MWE1ZTlkYTBjNTg1MjdlY2RlOTU1ZmI1ZS4uOTRmYmU0YzdmMzA0ZmNi MDQ5M2E1MTU0ZTFmYmMyYmRkMjg5ZjU1ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0zMCAgTWFy a3VzIEdvZXR6ICA8TWFya3VzLkdvZXR6QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERvIG5vdCBsaW5rIHRvIFNoYXJlZEJ1 ZmZlckNGLmNwcAorICAgICAgICBUaGUgUXQgcG9ydCBkb2VzIG5vdCBuZWVkIHRoaXMgZmlsZS4K KyAgICAgICAgV2UgcGxhbiB0byBpbXBsZW1lbnQgdGhlIHBsYXRmb3JtRGF0YSgpCisgICAgICAg IGZvciBTaGFyZWRCdWZmZXIgYXQgc29tZSBwb2ludCBzb29uLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMyNDIKKworICAgICAgICAqIFdlYkNvcmUu cHJvOgorICAgICAgICAqIHBsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHA6CisKIDIwMTAtMDctMjkg IEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBi L1dlYkNvcmUvV2ViQ29yZS5wcm8KaW5kZXggYjdmMTUyZTJlMzM5ODdmNDM1NDEwYzlmYWQyYmVm YTQ0Y2FmMDU3OC4uMDQ2NTI3NTdhOWRlZWE2ZTczZjA4ZmUxZTI1ZTBjOTk0ZjI0OWEzYyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBybworKysgYi9XZWJDb3JlL1dlYkNvcmUucHJvCkBA IC0yMjY4LDggKzIyNjgsNyBAQCBtYWVtbzUgewogICAgIG1hYyB7CiAgICAgICAgIFNPVVJDRVMg Kz0gXAogICAgICAgICAgICAgcGxhdGZvcm0vdGV4dC9jZi9TdHJpbmdDRi5jcHAgXAotICAgICAg ICAgICAgcGxhdGZvcm0vdGV4dC9jZi9TdHJpbmdJbXBsQ0YuY3BwIFwKLSAgICAgICAgICAgIHBs YXRmb3JtL2NmL1NoYXJlZEJ1ZmZlckNGLmNwcAorICAgICAgICAgICAgcGxhdGZvcm0vdGV4dC9j Zi9TdHJpbmdJbXBsQ0YuY3BwCiAgICAgICAgIExJQlNfUFJJVkFURSArPSAtZnJhbWV3b3JrIENh cmJvbiAtZnJhbWV3b3JrIEFwcEtpdAogICAgIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9TaGFyZWRCdWZmZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3Bw CmluZGV4IDZjZjExMzE2NzlhZGJhNmM2OTA1YmVmZmE5ZjExMGFmNjliN2QwYjYuLjM1YTdiN2M0 MjZlNjIyNzdlNzdhMTExNmUxODI5ZDU1YmUxZDM0MDMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vU2hhcmVkQnVmZmVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZl ci5jcHAKQEAgLTIzOSw3ICsyMzksNyBAQCB1bnNpZ25lZCBTaGFyZWRCdWZmZXI6OmdldFNvbWVE YXRhKGNvbnN0IGNoYXIqJiBzb21lRGF0YSwgdW5zaWduZWQgcG9zaXRpb24pIGNvbgogICAgIHJl dHVybiBzZWdtZW50ID09IHNlZ21lbnRzIC0gMSA/IHNlZ21lbnRlZFNpemUgLSBwb3NpdGlvbiA6 IHNlZ21lbnRTaXplIC0gcG9zaXRpb25JblNlZ21lbnQ7CiB9CiAKLSNpZiAhUExBVEZPUk0oQ0Yp CisjaWYgIVBMQVRGT1JNKENGKSB8fCBQTEFURk9STShRVCkKIAogaW5saW5lIHZvaWQgU2hhcmVk QnVmZmVyOjpjbGVhclBsYXRmb3JtRGF0YSgpCiB7Cg==